feat: add Security & Password tab by NidhiKJha · Pull Request #40959 · MetaMask/metamask-extension

NidhiKJha · 2026-03-17T11:59:51Z

Add a new "Security & Password" settings page to Settings V2 with:

Manage wallet recovery item (links to SRP reveal, shows "Back up incomplete" tag)
Password item (links to password change)
Auto-lock item with sub-page for selecting lock duration from presets
Phishing detection toggle

Description

Changelog

CHANGELOG entry: Added Security & Password page to the redesigned settings

Related issues

Fixes:

Manual testing steps

Enable Settings V2 menu item in the hamburger menu
Open Settings (V2) and click "Security & Password"
Verify all 4 items render correctly
Test the "Back up incomplete" tag visibility
Test auto-lock sub-page selection and navigation
Test phishing detection toggle

Screenshots/Recordings

Before

After

Screen.Recording.2026-03-17.at.11.58.47.AM.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Adds new Settings V2 navigation and UI that updates security-related preferences (notably auto-lock timer) via Redux actions; incorrect routing or value handling could impact locking behavior and user security expectations.

Overview
Adds a new Settings V2 tab, Security and password, with menu/route registry entries and i18n strings for its labels.

The tab introduces items to manage wallet recovery (links to SRP reveal and shows a Back up incomplete tag when SRP isn’t backed up), change password, toggle phishing detection, and view/edit auto-lock. Auto-lock now has a dedicated sub-page with preset durations (including Never), a formatter for preset/custom labels (rounding long decimals), and new route wiring in settings-v2.tsx.

Updates/extends Jest console baselines and adds unit tests covering the new tab, auto-lock formatting/selection flow, and wallet recovery tag behavior.

^{Written by Cursor Bugbot for commit 9301ced. This will update automatically on new commits. Configure here.}

Add a new "Security & Password" settings page to Settings V2 with: - Manage wallet recovery item (links to SRP reveal, shows "Back up incomplete" tag) - Password item (links to password change) - Auto-lock item with sub-page for selecting lock duration from presets - Phishing detection toggle Includes route constants, settings registry entry, lazy-loaded routing, i18n keys (en/en_GB), and comprehensive unit tests (23 tests across 5 files). Made-with: Cursor

ui/pages/settings-v2/security-and-password-tab/security-and-password-tab.tsx

ui/pages/settings-v2/security-and-password-tab/password-item.tsx

ui/pages/settings-v2/security-and-password-tab/auto-lock-item.test.tsx

ui/pages/settings-v2/security-and-password-tab/auto-lock-sub-page.tsx

ui/pages/settings-v2/settings-registry.ts

ui/pages/settings-v2/security-and-password-tab/auto-lock-utils.ts

ui/pages/settings-v2/security-and-password-tab/password-item.tsx

ui/pages/settings-v2/security-and-password-tab/auto-lock-item.tsx

ui/pages/settings-v2/security-and-password-tab/manage-wallet-recovery-item.tsx

app/_locales/en/messages.json

ui/pages/settings-v2/security-and-password-tab/security-and-password-tab.tsx

ui/pages/settings-v2/security-and-password-tab/auto-lock-sub-page.tsx

metamaskbotv2 · 2026-03-18T11:45:22Z

Builds ready [5a2c9d6]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 286 272 315 17 279 315
total 286 272 315 17 279 315
Confirm Tx confirm_tx 6046 6010 6073 22 6062 6073
total 6046 6010 6073 22 6062 6073
Bridge User Actions bridge_load_page 306 259 330 26 324 330
bridge_load_asset_picker 236 207 273 29 270 273
bridge_search_token 733 697 775 31 748 775
total 1294 1280 1312 13 1312 1312

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1456 1235 1796 110 1495 1658
load 1204 1008 1496 103 1237 1399
domContentLoaded 1197 1002 1489 100 1233 1393
domInteractive 29 17 103 18 25 78
firstPaint 166 71 1223 132 210 312
backgroundConnect 216 194 263 14 221 248
firstReactRender 20 14 39 4 21 29
initialActions 1 0 7 1 2 4
loadScripts 996 816 1295 98 1025 1189
setupStore 14 6 50 6 15 23
numNetworkReqs 39 31 80 15 38 76
Power User Home uiStartup 6240 2372 18112 3442 6644 14864
load 1314 1152 2091 147 1334 1603
domContentLoaded 1293 1146 2016 139 1310 1589
domInteractive 40 19 241 41 33 134
firstPaint 230 89 1717 179 284 365
backgroundConnect 2668 310 14418 3253 3499 11566
firstReactRender 25 17 53 6 27 35
initialActions 1 0 3 1 1 2
loadScripts 1063 925 1686 127 1077 1336
setupStore 16 7 48 8 18 32
numNetworkReqs 217 93 355 63 253 325

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 219 220 0 219 220
srpButtonToSrpForm 96 95 97 1 97 97
confirmSrpToPwForm 23 22 24 1 23 24
pwFormToMetricsScreen 16 15 16 0 16 16
metricsToWalletReadyScreen 19 15 27 5 22 27
doneButtonToHomeScreen 604 596 615 7 603 615
openAccountMenuToAccountListLoaded 2916 2905 2930 9 2916 2930
total 3920 3892 3968 32 3949 3968
Onboarding New Wallet createWalletToSocialScreen 223 222 224 1 223 224
srpButtonToPwForm 119 114 124 3 121 124
createPwToRecoveryScreen 10 10 10 0 10 10
skipBackupToMetricsScreen 45 44 48 2 46 48
agreeButtonToOnboardingSuccess 19 19 21 1 20 21
doneButtonToAssetList 514 512 516 1 516 516
total 931 923 935 5 935 935
Asset Details assetClickToPriceChart 81 46 118 24 91 118
total 81 46 118 24 91 118
Solana Asset Details assetClickToPriceChart 105 99 111 4 107 111
total 105 99 111 4 107 111
Import Srp Home loginToHomeScreen 2320 2275 2353 30 2341 2353
openAccountMenuAfterLogin 84 55 113 24 101 113
homeAfterImportWithNewWallet 1628 580 2319 838 2315 2319
total 4052 2985 4822 853 4773 4822
Send Transactions openSendPageFromHome 29 25 35 4 28 35
selectTokenToSendFormLoaded 46 25 76 19 61 76
reviewTransactionToConfirmationPage 831 669 943 108 915 943
total 909 720 1046 122 979 1046
Swap openSwapPageFromHome 97 56 122 25 114 122
fetchAndDisplaySwapQuotes 2679 2677 2681 1 2679 2681
total 2784 2759 2801 15 2793 2801

🌐 Dapp Page Load Benchmarks

Current Commit: 5a2c9d6 | Date: 3/18/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±49ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 730ms (±69ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 87ms (±42ms) 🟢 | historical mean value: 84ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	49ms	1.01s	1.39s	1.11s	1.39s
domContentLoaded	730ms	69ms	693ms	1.34s	769ms	1.34s
firstPaint	87ms	42ms	68ms	504ms	92ms	504ms
firstContentfulPaint	87ms	42ms	68ms	504ms	92ms	504ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 8.34 KiB (0.1%)
common: 673 Bytes (0.01%)

metamaskbotv2 · 2026-03-18T14:48:41Z

Builds ready [1129887]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 284 279 288 3 285 288
total 284 279 288 3 285 288
Confirm Tx confirm_tx 6063 6037 6082 16 6076 6082
total 6063 6037 6082 16 6076 6082
Bridge User Actions bridge_load_page 295 281 313 12 298 313
bridge_load_asset_picker 276 235 328 35 305 328
bridge_search_token 745 742 748 3 747 748
total 1294 1264 1314 19 1304 1314

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1500 1237 1824 113 1550 1700
load 1237 1032 1512 97 1282 1399
domContentLoaded 1231 1025 1506 96 1278 1393
domInteractive 31 17 111 22 27 94
firstPaint 164 70 1207 125 212 255
backgroundConnect 219 199 278 14 223 243
firstReactRender 21 14 55 7 22 35
initialActions 2 0 11 2 2 5
loadScripts 1027 825 1252 92 1069 1184
setupStore 14 7 37 6 18 24
numNetworkReqs 39 31 86 16 37 80
Power User Home uiStartup 5361 2327 15092 2336 6521 9204
load 1355 1138 2183 165 1385 1711
domContentLoaded 1331 1127 2176 159 1360 1675
domInteractive 41 21 213 40 35 135
firstPaint 221 86 1657 170 276 356
backgroundConnect 1935 285 11637 2101 2894 5038
firstReactRender 24 17 50 5 26 36
initialActions 1 0 5 1 1 3
loadScripts 1103 925 1926 154 1136 1432
setupStore 16 7 33 6 19 28
numNetworkReqs 225 127 362 51 259 318

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 221 216 225 3 222 225
srpButtonToSrpForm 94 92 97 2 93 97
confirmSrpToPwForm 23 21 28 2 24 28
pwFormToMetricsScreen 15 15 16 0 15 16
metricsToWalletReadyScreen 16 15 18 1 16 18
doneButtonToHomeScreen 611 586 626 18 626 626
openAccountMenuToAccountListLoaded 2910 2894 2935 18 2935 2935
total 3895 3859 3943 31 3918 3943
Onboarding New Wallet createWalletToSocialScreen 219 218 219 0 219 219
srpButtonToPwForm 111 110 113 1 113 113
createPwToRecoveryScreen 9 9 9 0 9 9
skipBackupToMetricsScreen 41 39 43 2 43 43
agreeButtonToOnboardingSuccess 17 17 18 0 17 18
doneButtonToAssetList 524 490 556 26 551 556
total 922 894 956 25 948 956
Asset Details assetClickToPriceChart 58 51 66 6 56 66
total 58 51 66 6 56 66
Solana Asset Details assetClickToPriceChart 82 50 121 25 99 121
total 82 50 121 25 99 121
Import Srp Home loginToHomeScreen 2399 2283 2500 75 2436 2500
openAccountMenuAfterLogin 84 62 96 13 95 96
homeAfterImportWithNewWallet 590 494 649 56 637 649
total 3031 2965 3085 44 3052 3085
Send Transactions openSendPageFromHome 37 25 58 12 42 58
selectTokenToSendFormLoaded 36 34 39 2 38 39
reviewTransactionToConfirmationPage 1038 707 1380 251 1279 1380
total 1110 788 1475 255 1338 1475
Swap openSwapPageFromHome 122 29 189 56 151 189
fetchAndDisplaySwapQuotes 2691 2686 2695 4 2695 2695
total 2812 2718 2884 57 2846 2884

🌐 Dapp Page Load Benchmarks

Current Commit: 1129887 | Date: 3/18/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.08s (±47ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 761ms (±63ms) 🟢 | historical mean value: 731ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 97ms (±133ms) 🟢 | historical mean value: 84ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.08s	47ms	1.04s	1.45s	1.13s	1.45s
domContentLoaded	761ms	63ms	729ms	1.34s	789ms	1.34s
firstPaint	97ms	133ms	68ms	1.42s	96ms	1.42s
firstContentfulPaint	97ms	133ms	68ms	1.42s	96ms	1.42s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 8.33 KiB (0.1%)
common: 673 Bytes (0.01%)

ui/pages/settings-v2/settings-registry.ts

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

ui/pages/settings-v2/security-and-password-tab/security-and-password-tab.tsx

ui/pages/settings-v2/security-and-password-tab/manage-wallet-recovery-item.tsx

sonarqubecloud · 2026-03-19T10:14:52Z

Quality Gate failed

Failed conditions
4.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

NidhiKJha temporarily deployed to pr-comment March 17, 2026 11:59 — with GitHub Actions Inactive

metamaskbot added the team-core-extension-ux Core Extension UX team label Mar 17, 2026

github-actions bot added the size-L label Mar 17, 2026

cursor bot reviewed Mar 17, 2026

View reviewed changes

ui/pages/settings-v2/security-and-password-tab/security-and-password-tab.tsx Show resolved Hide resolved

ui/pages/settings-v2/security-and-password-tab/password-item.tsx Outdated Show resolved Hide resolved

jest update

505834a

NidhiKJha temporarily deployed to pr-comment March 17, 2026 12:16 — with GitHub Actions Inactive

cursor bot reviewed Mar 17, 2026

View reviewed changes

ui/pages/settings-v2/security-and-password-tab/auto-lock-item.test.tsx Outdated Show resolved Hide resolved

NidhiKJha had a problem deploying to pr-comment March 17, 2026 12:48 — with GitHub Actions Error

lint fix

542925b

NidhiKJha temporarily deployed to pr-comment March 17, 2026 12:51 — with GitHub Actions Inactive

lint fix

fe69c71

NidhiKJha temporarily deployed to pr-comment March 17, 2026 12:58 — with GitHub Actions Inactive

cursor bot reviewed Mar 17, 2026

View reviewed changes

ui/pages/settings-v2/security-and-password-tab/auto-lock-sub-page.tsx Show resolved Hide resolved

NidhiKJha temporarily deployed to pr-comment March 17, 2026 13:31 — with GitHub Actions Inactive

ameliejyc reviewed Mar 17, 2026

View reviewed changes

ui/pages/settings-v2/security-and-password-tab/manage-wallet-recovery-item.tsx Outdated Show resolved Hide resolved

nit fix

8aa76a2

NidhiKJha temporarily deployed to pr-comment March 18, 2026 10:59 — with GitHub Actions Inactive

NidhiKJha requested a review from ameliejyc March 18, 2026 11:00

cursor bot reviewed Mar 18, 2026

View reviewed changes

app/_locales/en/messages.json Outdated Show resolved Hide resolved

Merge branch 'main' into CEUX-910-add-security-and-password

1ecbf97

NidhiKJha temporarily deployed to pr-comment March 18, 2026 11:07 — with GitHub Actions Inactive

lint fix

5a2c9d6

NidhiKJha temporarily deployed to pr-comment March 18, 2026 11:09 — with GitHub Actions Inactive

cursor bot reviewed Mar 18, 2026

View reviewed changes

ui/pages/settings-v2/security-and-password-tab/security-and-password-tab.tsx Show resolved Hide resolved

ui/pages/settings-v2/security-and-password-tab/auto-lock-sub-page.tsx Show resolved Hide resolved

NidhiKJha temporarily deployed to pr-comment March 18, 2026 11:40 — with GitHub Actions Inactive

Merge branch 'main' into CEUX-910-add-security-and-password

476165a

NidhiKJha temporarily deployed to pr-comment March 18, 2026 12:36 — with GitHub Actions Inactive

ameliejyc previously approved these changes Mar 18, 2026

View reviewed changes

NidhiKJha enabled auto-merge March 18, 2026 15:17

sahar-fehri reviewed Mar 18, 2026

View reviewed changes

ui/pages/settings-v2/settings-registry.ts Show resolved Hide resolved

sahar-fehri previously approved these changes Mar 18, 2026

View reviewed changes

NidhiKJha added this pull request to the merge queue Mar 18, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 18, 2026

NidhiKJha added this pull request to the merge queue Mar 18, 2026

github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Mar 18, 2026

Merge branch 'main' into CEUX-910-add-security-and-password

7bffb93

NidhiKJha dismissed stale reviews from sahar-fehri and ameliejyc via 7bffb93 March 19, 2026 09:28

NidhiKJha temporarily deployed to pr-comment March 19, 2026 09:28 — with GitHub Actions Inactive

NidhiKJha enabled auto-merge March 19, 2026 09:30

NidhiKJha requested review from ameliejyc and sahar-fehri March 19, 2026 09:31

cursor bot reviewed Mar 19, 2026

View reviewed changes

ui/pages/settings-v2/security-and-password-tab/security-and-password-tab.tsx Show resolved Hide resolved

ui/pages/settings-v2/security-and-password-tab/manage-wallet-recovery-item.tsx Show resolved Hide resolved

AndyMBridges approved these changes Mar 19, 2026

View reviewed changes

ameliejyc approved these changes Mar 19, 2026

View reviewed changes

NidhiKJha had a problem deploying to pr-comment March 19, 2026 09:59 — with GitHub Actions Error

Merge branch 'main' into CEUX-910-add-security-and-password

9301ced

NidhiKJha temporarily deployed to pr-comment March 19, 2026 10:01 — with GitHub Actions Inactive

NidhiKJha temporarily deployed to pr-comment March 19, 2026 10:32 — with GitHub Actions Inactive

NidhiKJha added this pull request to the merge queue Mar 19, 2026

Merged via the queue into main with commit 5e49246 Mar 19, 2026
203 of 205 checks passed

NidhiKJha deleted the CEUX-910-add-security-and-password branch March 19, 2026 10:33

github-actions bot locked and limited conversation to collaborators Mar 19, 2026

metamaskbot added the release-13.24.0 Issue or pull request that will be included in release 13.24.0 label Mar 19, 2026

Conversation

NidhiKJha commented Mar 17, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metamaskbotv2 bot commented Mar 18, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Mar 18, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Mar 19, 2026

Quality Gate failed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

NidhiKJha commented Mar 17, 2026 •

edited by cursor bot

Loading