fix: updated utils to handle corrupted account state by NidhiKJha · Pull Request #40955 · MetaMask/metamask-extension

NidhiKJha · 2026-03-17T10:36:36Z

Description

The contacts list page (ContactsListPage) and the add/edit contact forms crash when an internal account has corrupted state — specifically when account.metadata or account.metadata.name is undefined. This can happen due to state corruption or migration edge cases.

This PR adds defensive handling in the contact list utility functions (buildDuplicateContactMap, hasDuplicateContacts, isDuplicateContact) via a getAccountName helper that safely accesses account?.metadata?.name, falling back to an empty string. Accounts with missing names are filtered out of duplicate detection rather than causing a runtime crash.

A component-level test is added to ContactsListPage to verify the page renders without crashing when an account has missing metadata

Changelog

CHANGELOG entry: Fixed a crash on the contacts page when an internal account had corrupted or missing metadata.

Related issues

Fixes: #39699

Manual testing steps

Open MetaMask and navigate to the Contacts page via the global menu
Verify the contacts page loads and existing contacts are displayed
Add a new contact and verify it saves successfully

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: adds defensive null/undefined handling around InternalAccount.metadata.name in duplicate-contact utilities and a regression test to prevent crashes from corrupted account state.

Overview
Prevents the Contacts UI from crashing when an InternalAccount is missing metadata/metadata.name by introducing a safe getAccountName helper and skipping unnamed accounts in duplicate-name detection (buildDuplicateContactMap, hasDuplicateContacts, isDuplicateContact).

Adds a ContactsListPage test that renders the page with a deliberately malformed internal account to verify the page still loads and shows contacts.

^{Written by Cursor Bugbot for commit 0e43dc2. This will update automatically on new commits. Configure here.}

sonarqubecloud · 2026-03-17T10:50:38Z

Quality Gate failed

Failed conditions
68.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-03-17T11:14:23Z

Builds ready [0e43dc2]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 379 274 574 126 485 574
total 379 274 574 126 485 574
Confirm Tx confirm_tx 6033 6031 6034 1 6034 6034
total 6033 6031 6034 1 6034 6034
Bridge User Actions bridge_load_page 223 188 255 24 241 255
bridge_load_asset_picker 253 243 261 6 255 261
bridge_search_token 759 758 759 0 759 759
total 1245 1204 1285 29 1260 1285

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1460 1233 1783 118 1508 1700
load 1204 1008 1458 100 1250 1403
domContentLoaded 1198 1003 1419 98 1245 1394
domInteractive 30 16 114 22 25 93
firstPaint 151 70 317 67 215 249
backgroundConnect 214 196 278 14 216 245
firstReactRender 21 11 46 6 22 33
initialActions 1 0 4 1 1 3
loadScripts 1000 814 1217 96 1037 1192
setupStore 14 7 61 7 17 23
numNetworkReqs 39 31 85 16 40 78
Power User Home uiStartup 5828 2201 18110 3155 6501 11633
load 1321 1137 1769 137 1387 1642
domContentLoaded 1302 1131 1757 130 1349 1595
domInteractive 39 21 234 38 32 109
firstPaint 212 86 1392 154 268 372
backgroundConnect 2526 335 14834 3071 3182 9254
firstReactRender 25 18 43 4 27 33
initialActions 1 0 5 1 1 3
loadScripts 1073 925 1512 123 1103 1367
setupStore 16 6 38 6 18 28
numNetworkReqs 155 78 294 46 173 256

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 218 218 218 0 218 218
srpButtonToSrpForm 93 91 95 2 95 95
confirmSrpToPwForm 22 22 22 0 22 22
pwFormToMetricsScreen 15 15 15 0 15 15
metricsToWalletReadyScreen 15 15 16 0 15 16
doneButtonToHomeScreen 648 643 654 4 654 654
openAccountMenuToAccountListLoaded 2916 2892 2931 17 2931 2931
total 3923 3876 3963 36 3951 3963
Onboarding New Wallet createWalletToSocialScreen 220 219 221 1 221 221
srpButtonToPwForm 119 111 130 7 123 130
createPwToRecoveryScreen 9 9 11 1 9 11
skipBackupToMetricsScreen 43 39 51 4 45 51
agreeButtonToOnboardingSuccess 18 16 19 1 18 19
doneButtonToAssetList 648 371 913 196 764 913
total 1060 776 1355 206 1163 1355
Asset Details assetClickToPriceChart 68 52 89 14 77 89
total 68 52 89 14 77 89
Solana Asset Details assetClickToPriceChart 131 40 197 58 189 197
total 131 40 197 58 189 197
Import Srp Home loginToHomeScreen 2352 2336 2367 11 2356 2367
openAccountMenuAfterLogin 75 49 110 21 83 110
homeAfterImportWithNewWallet 1685 504 2710 923 2292 2710
total 4146 2943 5187 892 4702 5187
Send Transactions openSendPageFromHome 24 22 29 3 24 29
selectTokenToSendFormLoaded 34 24 39 5 38 39
reviewTransactionToConfirmationPage 914 858 967 39 923 967
total 977 936 1027 33 983 1027
Swap openSwapPageFromHome 96 80 108 12 107 108
fetchAndDisplaySwapQuotes 2688 2685 2690 2 2690 2690
total 2784 2771 2798 11 2792 2798

🌐 Dapp Page Load Benchmarks

Current Commit: 0e43dc2 | Date: 3/17/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±40ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 728ms (±37ms) 🟢 | historical mean value: 726ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 80ms (±11ms) 🟢 | historical mean value: 89ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	40ms	1.01s	1.33s	1.07s	1.33s
domContentLoaded	728ms	37ms	707ms	1.01s	760ms	1.01s
firstPaint	80ms	11ms	60ms	164ms	88ms	164ms
firstContentfulPaint	80ms	11ms	60ms	164ms	88ms	164ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 5.59 KiB (0.07%)
common: 46 Bytes (0%)

updated utils to handle corrupted account state

0e43dc2

NidhiKJha temporarily deployed to pr-comment March 17, 2026 10:36 — with GitHub Actions Inactive

metamaskbot added the team-core-extension-ux Core Extension UX team label Mar 17, 2026

NidhiKJha changed the title ~~updated utils to handle corrupted account state~~ fix: updated utils to handle corrupted account state Mar 17, 2026

github-actions bot added the size-S label Mar 17, 2026

NidhiKJha temporarily deployed to pr-comment March 17, 2026 11:09 — with GitHub Actions Inactive

ameliejyc approved these changes Mar 17, 2026

View reviewed changes

AndyMBridges approved these changes Mar 17, 2026

View reviewed changes

NidhiKJha added this pull request to the merge queue Mar 17, 2026

Merged via the queue into main with commit ea7121b Mar 17, 2026
195 of 200 checks passed

NidhiKJha deleted the fix-39699 branch March 17, 2026 12:54

github-actions bot locked and limited conversation to collaborators Mar 17, 2026

metamaskbot added the release-13.24.0 Issue or pull request that will be included in release 13.24.0 label Mar 17, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: updated utils to handle corrupted account state#40955

fix: updated utils to handle corrupted account state#40955
NidhiKJha merged 1 commit intomainfrom
fix-39699

NidhiKJha commented Mar 17, 2026 •

edited by cursor bot

Loading

Uh oh!

sonarqubecloud bot commented Mar 17, 2026

Uh oh!

metamaskbotv2 bot commented Mar 17, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

NidhiKJha commented Mar 17, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

sonarqubecloud bot commented Mar 17, 2026

Quality Gate failed

Uh oh!

metamaskbotv2 bot commented Mar 17, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NidhiKJha commented Mar 17, 2026 •

edited by cursor bot

Loading