chore: update basic functionality modal components and wording by ameliejyc · Pull Request #40954 · MetaMask/metamask-extension

ameliejyc · 2026-03-17T10:24:57Z

Description

Brings the Basic functionality modal up to date using the design system components, alters wording slightly and updates e2e tests accordingly.

Changelog

CHANGELOG entry: updates wording and styles in basic functionality modal

Related issues

Fixes:

Manual testing steps

On Settings > Security & Privacy toggle Basic Functionality off
See the modal with updated styles and wording
Check that the functionality (checkbox, enabled button) works the same

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Refactors a settings-critical modal that toggles external services and metrics flags; while behavior appears equivalent, UI/component API changes and i18n key changes could cause regressions in enabling/disabling flows and tests.

Overview
Updates the “Basic functionality” disable/enable modal UI and copy. The modal is refactored to use @metamask/design-system-react components (new Checkbox/Text/button props), extracting toggle/checkbox handlers and switching the “turn off” disclaimer text to new i18n keys (basicConfigurationModalDisclaimerOffPart1/Part2).

Aligns tests and selectors with the new UI. E2E page objects now target data-testid selectors for the agreement checkbox and modal toggle button, and the modal unit test asserts via role-based checkbox querying and simplified click behavior.

^{Written by Cursor Bugbot for commit 8939e4a. This will update automatically on new commits. Configure here.}

github-actions · 2026-03-17T10:25:09Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-03-17T11:01:48Z

Builds ready [3de9328]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 295 278 318 17 302 318
total 295 278 318 17 302 318
Confirm Tx confirm_tx 6018 5970 6041 27 6039 6041
total 6018 5970 6041 27 6039 6041
Bridge User Actions bridge_load_page 222 200 249 20 245 249
bridge_load_asset_picker 266 193 322 49 306 322
bridge_search_token 754 743 765 8 758 765
total 1265 1235 1283 19 1278 1283

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1443 1197 1784 127 1493 1698
load 1195 981 1557 106 1255 1373
domContentLoaded 1188 973 1506 103 1248 1362
domInteractive 29 17 104 20 25 84
firstPaint 156 68 508 79 205 288
backgroundConnect 210 193 277 14 211 245
firstReactRender 20 12 66 7 21 30
initialActions 1 0 7 1 2 4
loadScripts 994 790 1293 101 1054 1171
setupStore 13 7 52 6 15 22
numNetworkReqs 39 31 88 16 40 79
Power User Home uiStartup 6186 2294 17904 3022 6668 12705
load 1308 1123 2009 142 1346 1612
domContentLoaded 1286 1120 1954 130 1316 1545
domInteractive 39 20 222 33 35 118
firstPaint 221 93 1260 137 274 359
backgroundConnect 2759 320 14264 2946 3453 9794
firstReactRender 24 16 41 5 26 39
initialActions 1 0 4 1 1 3
loadScripts 1064 906 1717 123 1093 1307
setupStore 16 7 53 7 17 30
numNetworkReqs 210 123 353 49 229 309

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 217 221 2 220 221
srpButtonToSrpForm 92 89 95 2 93 95
confirmSrpToPwForm 22 22 22 0 22 22
pwFormToMetricsScreen 15 15 15 0 15 15
metricsToWalletReadyScreen 16 15 17 0 16 17
doneButtonToHomeScreen 628 575 674 40 659 674
openAccountMenuToAccountListLoaded 2935 2896 2964 28 2959 2964
total 3789 3520 3945 178 3928 3945
Onboarding New Wallet createWalletToSocialScreen 220 219 221 1 220 221
srpButtonToPwForm 108 105 114 3 107 114
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 39 37 42 2 40 42
agreeButtonToOnboardingSuccess 16 16 17 0 16 17
doneButtonToAssetList 488 483 495 5 491 495
total 887 872 909 14 890 909
Asset Details assetClickToPriceChart 56 45 78 13 55 78
total 56 45 78 13 55 78
Solana Asset Details assetClickToPriceChart 149 68 217 61 191 217
total 149 68 217 61 191 217
Import Srp Home loginToHomeScreen 2344 2333 2352 7 2350 2352
openAccountMenuAfterLogin 64 32 91 25 88 91
homeAfterImportWithNewWallet 2343 2215 2507 108 2359 2507
total 4752 4599 4888 105 4793 4888
Send Transactions openSendPageFromHome 41 27 65 17 59 65
selectTokenToSendFormLoaded 31 28 34 3 34 34
reviewTransactionToConfirmationPage 1066 684 1429 265 1190 1429
total 1138 743 1522 277 1269 1522
Swap openSwapPageFromHome 132 123 140 7 137 140
fetchAndDisplaySwapQuotes 2696 2687 2705 7 2700 2705
total 2830 2821 2842 7 2830 2842

🌐 Dapp Page Load Benchmarks

Current Commit: 3de9328 | Date: 3/17/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±42ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 734ms (±60ms) 🟢 | historical mean value: 726ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 92ms (±126ms) 🟢 | historical mean value: 89ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	42ms	1.01s	1.38s	1.05s	1.38s
domContentLoaded	734ms	60ms	708ms	1.28s	739ms	1.28s
firstPaint	92ms	126ms	64ms	1.35s	88ms	1.35s
firstContentfulPaint	92ms	126ms	64ms	1.35s	88ms	1.35s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 19.75 KiB (0.23%)
common: 1.3 KiB (0.01%)

metamaskbotv2 · 2026-03-17T11:39:05Z

✨ Files requiring CODEOWNER review ✨

🧪 @MetaMask/qa (1 files, +3 -5)

📁 test/
- 📁 e2e/
  - 📁 page-objects/
    - 📁 pages/
      - 📁 onboarding/
        
        📄 onboarding-privacy-settings-page.ts +3 -5

sonarqubecloud · 2026-03-17T11:54:46Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-03-17T12:15:57Z

Builds ready [8939e4a]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 295 271 329 21 292 329
total 295 271 329 21 292 329
Confirm Tx confirm_tx 6002 5982 6017 13 6016 6017
total 6002 5982 6017 13 6016 6017
Bridge User Actions bridge_load_page 212 194 228 14 222 228
bridge_load_asset_picker 251 225 277 18 266 277
bridge_search_token 749 728 778 17 756 778
total 1225 1202 1249 18 1242 1249

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1492 1230 1802 113 1569 1688
load 1228 1022 1442 98 1281 1413
domContentLoaded 1221 1017 1435 95 1275 1391
domInteractive 30 18 101 19 26 82
firstPaint 175 70 1211 166 213 344
backgroundConnect 220 197 287 15 225 252
firstReactRender 20 14 46 6 21 33
initialActions 4 0 244 24 2 5
loadScripts 1019 817 1237 93 1069 1188
setupStore 14 6 51 6 17 23
numNetworkReqs 39 31 84 15 40 77
Power User Home uiStartup 5954 2261 18140 2817 6605 11349
load 1348 1172 1988 143 1379 1685
domContentLoaded 1328 1165 1935 137 1351 1673
domInteractive 43 22 415 49 34 128
firstPaint 235 96 1618 171 291 386
backgroundConnect 2400 311 14027 2544 3258 6263
firstReactRender 25 16 39 4 27 32
initialActions 1 0 4 1 1 2
loadScripts 1104 948 1638 129 1130 1431
setupStore 16 6 48 8 18 32
numNetworkReqs 242 106 357 64 296 341

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 217 215 218 1 218 218
srpButtonToSrpForm 93 92 93 1 93 93
confirmSrpToPwForm 21 21 21 0 21 21
pwFormToMetricsScreen 15 15 15 0 15 15
metricsToWalletReadyScreen 17 15 19 1 17 19
doneButtonToHomeScreen 639 588 763 67 661 763
openAccountMenuToAccountListLoaded 2910 2886 2927 15 2920 2927
total 3954 3863 4151 113 4010 4151
Onboarding New Wallet createWalletToSocialScreen 220 219 223 2 221 223
srpButtonToPwForm 113 109 120 4 115 120
createPwToRecoveryScreen 9 8 9 0 9 9
skipBackupToMetricsScreen 41 38 44 2 42 44
agreeButtonToOnboardingSuccess 17 17 17 0 17 17
doneButtonToAssetList 505 490 517 10 508 517
total 906 890 929 14 907 929
Asset Details assetClickToPriceChart 75 56 86 11 86 86
total 75 56 86 11 86 86
Solana Asset Details assetClickToPriceChart 90 35 162 47 120 162
total 90 35 162 47 120 162
Import Srp Home loginToHomeScreen 2348 2284 2390 37 2369 2390
openAccountMenuAfterLogin 85 59 136 28 95 136
homeAfterImportWithNewWallet 1696 459 2798 969 2316 2798
total 4129 2893 5229 962 4745 5229
Send Transactions openSendPageFromHome 48 17 78 22 67 78
selectTokenToSendFormLoaded 23 19 28 3 26 28
reviewTransactionToConfirmationPage 1350 1304 1401 41 1380 1401
total 1385 1240 1500 93 1470 1500
Swap openSwapPageFromHome 101 88 108 9 108 108
fetchAndDisplaySwapQuotes 2705 2688 2722 13 2716 2722
total 2810 2797 2823 11 2823 2823

🌐 Dapp Page Load Benchmarks

Current Commit: 8939e4a | Date: 3/17/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±43ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 743ms (±41ms) 🟢 | historical mean value: 730ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 82ms (±11ms) 🟢 | historical mean value: 88ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	43ms	1.03s	1.38s	1.08s	1.38s
domContentLoaded	743ms	41ms	714ms	1.05s	764ms	1.05s
firstPaint	82ms	11ms	68ms	172ms	92ms	172ms
firstContentfulPaint	82ms	11ms	68ms	172ms	92ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 255 Bytes (0%)
ui: 25.27 KiB (0.3%)
common: 1.81 KiB (0.02%)

seaona

e2e LGTM

ameliejyc added 2 commits March 16, 2026 16:41

chore: refactor basic configuration modal to use new components

7e835e1

chore: replace string on basic functionality modal

3de9328

ameliejyc temporarily deployed to pr-comment March 17, 2026 10:25 — with GitHub Actions Inactive

metamaskbot added the team-core-extension-ux Core Extension UX team label Mar 17, 2026

github-actions bot added the size-M label Mar 17, 2026

ameliejyc temporarily deployed to pr-comment March 17, 2026 10:56 — with GitHub Actions Inactive

chore: fix onboarding e2e tests

8939e4a

ameliejyc temporarily deployed to pr-comment March 17, 2026 11:38 — with GitHub Actions Inactive

ameliejyc changed the title ~~chore: update basic functionality modal~~ chore: update basic functionality modal components and wording Mar 17, 2026

ameliejyc marked this pull request as ready for review March 17, 2026 12:09

ameliejyc requested a review from a team as a code owner March 17, 2026 12:09

ameliejyc temporarily deployed to pr-comment March 17, 2026 12:09 — with GitHub Actions Inactive

ameliejyc temporarily deployed to pr-comment March 17, 2026 12:11 — with GitHub Actions Inactive

seaona approved these changes Mar 18, 2026

View reviewed changes

ameliejyc enabled auto-merge March 18, 2026 13:08

NidhiKJha approved these changes Mar 18, 2026

View reviewed changes

ameliejyc added this pull request to the merge queue Mar 18, 2026

Merged via the queue into main with commit 7f02641 Mar 18, 2026
194 of 196 checks passed

ameliejyc deleted the update-basic-functionality-modal branch March 18, 2026 15:34

github-actions bot locked and limited conversation to collaborators Mar 18, 2026

metamaskbot added the release-13.24.0 Issue or pull request that will be included in release 13.24.0 label Mar 18, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update basic functionality modal components and wording#40954

chore: update basic functionality modal components and wording#40954
ameliejyc merged 3 commits intomainfrom
update-basic-functionality-modal

ameliejyc commented Mar 17, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

metamaskbotv2 bot commented Mar 17, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Mar 17, 2026

Uh oh!

sonarqubecloud bot commented Mar 17, 2026

Uh oh!

metamaskbotv2 bot commented Mar 17, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

seaona left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ameliejyc commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

metamaskbotv2 bot commented Mar 17, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Mar 17, 2026

✨ Files requiring CODEOWNER review ✨

Uh oh!

sonarqubecloud bot commented Mar 17, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 bot commented Mar 17, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

seaona left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ameliejyc commented Mar 17, 2026 •

edited

Loading