fix: Correct name for useSnapNavigation return value#40950
Merged
FrederikBolding merged 1 commit intomainfrom Mar 17, 2026
Merged
fix: Correct name for useSnapNavigation return value#40950FrederikBolding merged 1 commit intomainfrom
useSnapNavigation return value#40950FrederikBolding merged 1 commit intomainfrom
Conversation
FrederikBolding
commented
Mar 17, 2026
|
|
||
| const isMetaMaskUrl = href.startsWith('metamask:'); | ||
| const { navigate } = useSnapNavigation(); | ||
| const { handleSnapNavigate } = useSnapNavigation(); |
Contributor
✨ Files requiring CODEOWNER review ✨🫰 @MetaMask/core-platform (2 files, +4 -4)
|
GuillaumeRx
approved these changes
Mar 17, 2026
|
cryptodev-2s
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where defining
metamask://URLs in Snaps would not work because the return value foruseSnapNavigationwas updated without changing all the usages.Changelog
CHANGELOG entry: Fixed an issue with Snaps links
Note
Low Risk
Low risk rename-alignment change limited to Snap UI link handling; main risk is regressions in
metamask:link click behavior if any callers still expect the oldnavigatereturn shape.Overview
Fixes Snap UI
metamask:link handling by updatingSnapUILinkandSnapUIMarkdownto calluseSnapNavigation()’s renamedhandleSnapNavigatefunction instead of the previously-referencednavigate.This restores in-app navigation for
metamask:URLs originating from Snap-rendered links and markdown.Written by Cursor Bugbot for commit 53a71e4. This will update automatically on new commits. Configure here.