Skip to content

fix: missing local in hw wallet errors#40923

Merged
HowardBraham merged 1 commit intomainfrom
fix/hw-error-locale
Mar 17, 2026
Merged

fix: missing local in hw wallet errors#40923
HowardBraham merged 1 commit intomainfrom
fix/hw-error-locale

Conversation

@montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Mar 16, 2026

Description

This pr fixes the issue where 2 locale content were missing in the hardware wallet error flow.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: fix missing locale.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: adds missing en/en_GB translation keys only, with no logic or behavior changes.

Overview
Fixes missing localization strings in the hardware wallet error flow by adding the hardwareWalletErrorTitleBlindSignNotSupported and hardwareWalletTitleEthAppNotOpen messages to app/_locales/en and app/_locales/en_GB.

Written by Cursor Bugbot for commit 42045a2. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@montelaidev montelaidev added this pull request to the merge queue Mar 16, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 16, 2026
@HowardBraham HowardBraham added this pull request to the merge queue Mar 17, 2026
Merged via the queue into main with commit 6cc8eee Mar 17, 2026
68 of 69 checks passed
@HowardBraham HowardBraham deleted the fix/hw-error-locale branch March 17, 2026 01:47
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2026
@metamaskbot metamaskbot added the release-13.24.0 Issue or pull request that will be included in release 13.24.0 label Mar 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.24.0 Issue or pull request that will be included in release 13.24.0 size-S team-accounts-framework Accounts team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants