Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (1 files, +9 -0)
👨🔧 @MetaMask/core-extension-ux (7 files, +179 -11)
👨🔧 @MetaMask/metamask-earn (1 files, +2 -0)
|
Contributor
Builds ready [bd61dcd]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Contributor
Builds ready [69b618b]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
shane-t
previously approved these changes
Mar 12, 2026
nickewansmith
requested changes
Mar 12, 2026
nickewansmith
previously approved these changes
Mar 12, 2026
matthewwalsh0
requested changes
Mar 12, 2026
...es/confirmations/components/activity/transaction-details-modal/transaction-details-modal.tsx
Outdated
Show resolved
Hide resolved
...onfirmations/components/activity/transaction-details-summary/transaction-details-summary.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
nickewansmith
approved these changes
Mar 12, 2026
matthewwalsh0
approved these changes
Mar 12, 2026
ameliejyc
approved these changes
Mar 12, 2026
|
n3ps
approved these changes
Mar 12, 2026
Contributor
Builds ready [4e797cf]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Shows the correct transaction type for MUSD reward claims after navigating or refreshing.
Changelog
CHANGELOG entry: fix 'claim bonus' transactions being displayed as 'contract interaction' after reload
Related issues
Fixes: MUSD-502
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk: adds a narrow transaction-type override (Merkl distributor address + claim method selector) and updates titles/tests; misclassification risk is limited to transactions matching that exact address+method.
Overview
Fixes Merkl mUSD reward claims being shown as generic
contractInteractionafter refresh/navigation by introducingresolveTransactionTypethat re-detects claims via the Merkl distributor address and claim method selector.Updates legacy and multichain activity UIs to use the resolved type for categorization, Pay details modal selection, and titles (standardizing on
musdClaimTitle), and adds targeted unit tests; removes the unusedmusdClaimActivityTitlei18n string.Written by Cursor Bugbot for commit 4e797cf. This will update automatically on new commits. Configure here.