Skip to content

fix: show correct TXN name for merkl claims#40834

Merged
Jwhiles merged 8 commits intomainfrom
MUSD-502
Mar 12, 2026
Merged

fix: show correct TXN name for merkl claims#40834
Jwhiles merged 8 commits intomainfrom
MUSD-502

Conversation

@Jwhiles
Copy link
Copy Markdown
Contributor

@Jwhiles Jwhiles commented Mar 12, 2026

Description

Shows the correct transaction type for MUSD reward claims after navigating or refreshing.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: fix 'claim bonus' transactions being displayed as 'contract interaction' after reload

Related issues

Fixes: MUSD-502

Manual testing steps

  1. Go to an account that has a musd claim
  2. Make the claim, verify that it shows the correct title
  3. Refresh the app - verify that activity view still shows the correct title for the claim

Screenshots/Recordings

Before

image image

After

image image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: adds a narrow transaction-type override (Merkl distributor address + claim method selector) and updates titles/tests; misclassification risk is limited to transactions matching that exact address+method.

Overview
Fixes Merkl mUSD reward claims being shown as generic contractInteraction after refresh/navigation by introducing resolveTransactionType that re-detects claims via the Merkl distributor address and claim method selector.

Updates legacy and multichain activity UIs to use the resolved type for categorization, Pay details modal selection, and titles (standardizing on musdClaimTitle), and adds targeted unit tests; removes the unused musdClaimActivityTitle i18n string.

Written by Cursor Bugbot for commit 4e797cf. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Mar 12, 2026

✨ Files requiring CODEOWNER review ✨

@MetaMask/confirmations (1 files, +9 -0)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 components/
          • 📁 activity/
            • 📁 transaction-details-modal/
              • 📄 transaction-details-modal.test.tsx +9 -0

👨‍🔧 @MetaMask/core-extension-ux (7 files, +179 -11)
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 transaction-list-item/
          • 📄 helpers.test.ts +52 -1
          • 📄 helpers.ts +36 -2
          • 📄 transaction-list-item.component.js +10 -5
      • 📁 multichain/
        • 📁 activity-v2/
          • 📄 activity-details-modal-adapter.tsx +1 -1
          • 📄 helpers.test.ts +60 -0
          • 📄 helpers.ts +10 -1
          • 📄 hooks.ts +10 -1

👨‍🔧 @MetaMask/metamask-earn (1 files, +2 -0)
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 musd/
          • 📄 constants.ts +2 -0

@Jwhiles Jwhiles marked this pull request as ready for review March 12, 2026 09:40
@Jwhiles Jwhiles requested review from a team as code owners March 12, 2026 09:40
@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Mar 12, 2026

Builds ready [bd61dcd]
⚡ Performance Benchmarks
👆 Interaction Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account29126132826316328
total29126132826316328
Confirm Txconfirm_tx6012598660341660196034
total6012598660341660196034
Bridge User Actionsbridge_load_page2602502708270270
bridge_load_asset_picker17715422427191224
bridge_search_token71969875019723750
total1155110012445611921244
🔌 Startup Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Standard HomeuiStartup15201299205111315521721
load12601078167210213061426
domContentLoaded12541062166410212991419
domInteractive3117136222688
firstPaint175721571194222289
backgroundConnect22920927613233257
firstReactRender21136572133
initialActions105124
loadScripts1041843145110110921206
setupStore1472541622
numNetworkReqs362787173679
Power User HomeuiStartup64372134183323229686414453
load14091207286720014421755
domContentLoaded13861201282319514201727
domInteractive43203285033123
firstPaint25393632121325513
backgroundConnect268031314903309737099495
firstReactRender27204353037
initialActions104123
loadScripts1147980252618611781454
setupStore1675781727
numNetworkReqs2096635948225303
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2202192200220220
srpButtonToSrpForm92919319393
confirmSrpToPwForm22212312223
pwFormToMetricsScreen15151601516
metricsToWalletReadyScreen16151711717
doneButtonToHomeScreen67161974445696744
openAccountMenuToAccountListLoaded2921290129391529312939
total3962392540113639974011
Onboarding New WalletcreateWalletToSocialScreen2212202221221222
srpButtonToPwForm1131091183114118
createPwToRecoveryScreen889099
skipBackupToMetricsScreen39364124041
agreeButtonToOnboardingSuccess17161711717
doneButtonToAssetList58551067662605676
total9848991075649991075
Asset DetailsassetClickToPriceChart745697179397
total745697179397
Solana Asset DetailsassetClickToPriceChart1223919959177199
total1223919959177199
Import Srp HomeloginToHomeScreen2241214423698122312369
openAccountMenuAfterLogin56555715757
homeAfterImportWithNewWallet1600466234785622912347
total39822890456671245554566
Send TransactionsopenSendPageFromHome462572196672
selectTokenToSendFormLoaded33274053840
reviewTransactionToConfirmationPage980793117414211081174
total1059863124914512021249
SwapopenSwapPageFromHome1093019055136190
fetchAndDisplaySwapQuotes268326822683026832683
total2792271928735328182873
🌐 Dapp Page Load Benchmarks

Current Commit: bd61dcd | Date: 3/12/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±81ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 741ms (±93ms) 🟢 | historical mean value: 742ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 81ms (±45ms) 🟢 | historical mean value: 84ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 81ms 992ms 1.39s 1.28s 1.39s
domContentLoaded 741ms 93ms 692ms 1.34s 968ms 1.34s
firstPaint 81ms 45ms 64ms 520ms 88ms 520ms
firstContentfulPaint 81ms 45ms 64ms 520ms 88ms 520ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 53 Bytes (0%)
  • ui: -1.36 KiB (-0.02%)
  • common: 20 Bytes (0%)

@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Mar 12, 2026

Builds ready [69b618b]
⚡ Performance Benchmarks
👆 Interaction Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account2622602641263264
total2622602641263264
Confirm Txconfirm_tx6040602660531060496053
total6040602660531060496053
Bridge User Actionsbridge_load_page24422425913249259
bridge_load_asset_picker20015924435230244
bridge_search_token73972476516749765
total1192114112584312241258
🔌 Startup Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Standard HomeuiStartup15331271183511816121723
load12851031155011113631477
domContentLoaded12771028154511113571468
domInteractive2917120212581
firstPaint194741271172238344
backgroundConnect23020927714236261
firstReactRender19125662027
initialActions109113
loadScripts1066826132410811361248
setupStore1372651621
numNetworkReqs362795173680
Power User HomeuiStartup5597224017252262565539889
load12851082269319812991617
domContentLoaded12651074268119412801580
domInteractive36181822933113
firstPaint216801666168255334
backgroundConnect229031214026251435345431
firstReactRender3118376353143
initialActions105112
loadScripts1037886154411810591335
setupStore1566881828
numNetworkReqs1364827343142238
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2202182232221223
srpButtonToSrpForm96949719797
confirmSrpToPwForm22222302323
pwFormToMetricsScreen16161601616
metricsToWalletReadyScreen17161701717
doneButtonToHomeScreen61457366535625665
openAccountMenuToAccountListLoaded2922290329391629372939
total3991386240828540794082
Onboarding New WalletcreateWalletToSocialScreen2222212241223224
srpButtonToPwForm1121081215115121
createPwToRecoveryScreen989099
skipBackupToMetricsScreen38383803838
agreeButtonToOnboardingSuccess16151811718
doneButtonToAssetList52350653513535535
total92290593513935935
Asset DetailsassetClickToPriceChart815199189699
total815199189699
Solana Asset DetailsassetClickToPriceChart844111734117117
total844111734117117
Import Srp HomeloginToHomeScreen2270218823204723022320
openAccountMenuAfterLogin483477174277
homeAfterImportWithNewWallet2355223124167424012416
total4667463746862146864686
Send TransactionsopenSendPageFromHome462980195180
selectTokenToSendFormLoaded482989235589
reviewTransactionToConfirmationPage1171923140519113821405
total12641031148818314701488
SwapopenSwapPageFromHome1102915647155156
fetchAndDisplaySwapQuotes2708269227261427222726
total2841281028813028612881
🌐 Dapp Page Load Benchmarks

Current Commit: 69b618b | Date: 3/12/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±41ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 740ms (±39ms) 🟢 | historical mean value: 738ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 82ms (±11ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 41ms 1.03s 1.36s 1.09s 1.36s
domContentLoaded 740ms 39ms 718ms 1.03s 760ms 1.03s
firstPaint 82ms 11ms 68ms 180ms 88ms 180ms
firstContentfulPaint 82ms 11ms 68ms 180ms 88ms 180ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 1.86 KiB (0.04%)
  • ui: -948 Bytes (-0.01%)
  • common: -5.57 KiB (-0.05%)

@nickewansmith nickewansmith self-requested a review March 12, 2026 13:25
shane-t
shane-t previously approved these changes Mar 12, 2026
@nickewansmith nickewansmith self-requested a review March 12, 2026 16:51
nickewansmith
nickewansmith previously approved these changes Mar 12, 2026
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@Jwhiles Jwhiles enabled auto-merge March 12, 2026 17:30
@sonarqubecloud
Copy link
Copy Markdown

@Jwhiles Jwhiles added this pull request to the merge queue Mar 12, 2026
@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Mar 12, 2026

Builds ready [4e797cf]
⚡ Performance Benchmarks
👆 Interaction Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account29326433228322332
total29326433228322332
Confirm Txconfirm_tx6012598460452260126045
total6012598460452260126045
Bridge User Actionsbridge_load_page23821526618246266
bridge_load_asset_picker25621729132285291
bridge_search_token7577467658762765
total125312481259512591259
🔌 Startup Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Standard HomeuiStartup14891261197111715471680
load12371029157910212961428
domContentLoaded12281023157310212911402
domInteractive3017115202685
firstPaint172731274169212326
backgroundConnect21819939621221244
firstReactRender20134862229
initialActions105124
loadScripts1027823136410110901206
setupStore166261251624
numNetworkReqs362786173478
Power User HomeuiStartup58222425172342495673410095
load13691185197714514101656
domContentLoaded13481179191113213801636
domInteractive3722218283479
firstPaint225891735204280374
backgroundConnect197232414109229528236815
firstReactRender28205363040
initialActions104113
loadScripts1116969165512311471380
setupStore1664971832
numNetworkReqs1829438950201289
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2212192242222224
srpButtonToSrpForm100951095102109
confirmSrpToPwForm24232612526
pwFormToMetricsScreen16161601616
metricsToWalletReadyScreen18171801718
doneButtonToHomeScreen63859967428649674
openAccountMenuToAccountListLoaded30122904313910131313139
total3938391739521539513952
Onboarding New WalletcreateWalletToSocialScreen2212192221221222
srpButtonToPwForm1141111203116120
createPwToRecoveryScreen999099
skipBackupToMetricsScreen38383913839
agreeButtonToOnboardingSuccess17161701717
doneButtonToAssetList52349557229513572
total92589399038913990
Asset DetailsassetClickToPriceChart86829038890
total86829038890
Solana Asset DetailsassetClickToPriceChart944816041110160
total944816041110160
Import Srp HomeloginToHomeScreen2308221823575323322357
openAccountMenuAfterLogin794610224101102
homeAfterImportWithNewWallet1915521242680623922426
total43022980481876547564818
Send TransactionsopenSendPageFromHome361461175161
selectTokenToSendFormLoaded31303313033
reviewTransactionToConfirmationPage1156744140027013921400
total1230800149128214371491
SwapopenSwapPageFromHome13811817220147172
fetchAndDisplaySwapQuotes269826902703527002703
total2833281628621728282862
🌐 Dapp Page Load Benchmarks

Current Commit: 4e797cf | Date: 3/12/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±42ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 733ms (±39ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 80ms (±13ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 42ms 1.02s 1.37s 1.08s 1.37s
domContentLoaded 733ms 39ms 711ms 1.02s 762ms 1.02s
firstPaint 80ms 13ms 64ms 188ms 88ms 188ms
firstContentfulPaint 80ms 13ms 64ms 188ms 88ms 188ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -13.71 KiB (-0.26%)
  • ui: 3.53 KiB (0.04%)
  • common: -64.35 KiB (-0.57%)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 12, 2026
@Jwhiles Jwhiles added this pull request to the merge queue Mar 12, 2026
Merged via the queue into main with commit d2b4f7a Mar 12, 2026
183 checks passed
@Jwhiles Jwhiles deleted the MUSD-502 branch March 12, 2026 19:29
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2026
@metamaskbot metamaskbot added the release-13.23.0 Issue or pull request that will be included in release 13.23.0 label Mar 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.23.0 Issue or pull request that will be included in release 13.23.0 size-M team-earn

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants