chore: Enable token permissions in production build by jeffsmale90 · Pull Request #40813 · MetaMask/metamask-extension

jeffsmale90 · 2026-03-11T17:40:49Z

Description

Enables the following token permissions in production build:

erc20-token-stream
native-token-stream
erc20-token-periodic
native-token-periodic

Bumps the Advanced Permissions dependencies:

@metmask/gator-permissions-snap from ^1.1.1 to 1.2.0
@metamask/permissions-kernel-snap from ^1.0.0 to ^1.1.0
@metamask/gator-permissions-controller from ^2.0.0 to ^2.1.0

Changelog

CHANGELOG entry: Enables token permissions via EIP-7715

Related issues

Fixes:

Manual testing steps

Go to site in https://github.com/MetaMask/snap-7715-permissions/tree/main/packages/site
Request each permission type

Expect the permission requesting flow to work as expected

After granting permissions go to Dapp Permissions
Expect granted permissions to appear

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Enables additional EIP-7715 permission types in the default build and upgrades the related snap/controller packages, which could affect permission-request flows at runtime. Risk is limited to the Advanced Permissions feature area but impacts production builds.

Overview
Enables EIP-7715 token streaming and periodic permission types in production by expanding GATOR_ENABLED_PERMISSION_TYPES beyond just ERC20 revocation.

Bumps Advanced Permissions dependencies to newer versions (@metamask/gator-permissions-controller ^2.1.0, @metamask/gator-permissions-snap ^1.2.0, @metamask/permissions-kernel-snap ^1.1.0) and updates yarn.lock accordingly.

^{Written by Cursor Bugbot for commit 3ab8169. This will update automatically on new commits. Configure here.}

github-actions · 2026-03-11T17:40:59Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2026-03-11T17:42:38Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	Quality	Maintenance
@metamask/permissions-kernel-snap@1.0.0 ⏵ 1.1.0	⁺¹		⁺¹
@metamask/gator-permissions-snap@1.1.1 ⏵ 1.2.0
@metamask/gator-permissions-controller@2.0.0 ⏵ 2.1.0		⁺¹

View full report

- @metamask/gator-permissions-snap from ^1.1.1 to ^1.2.0 - @metamask/permissions-kernel-snap from ^1.0.0 to ^1.1.0

metamaskbotv2 · 2026-03-11T18:34:44Z

Builds ready [5cac273]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 294 269 336 29 324 336
total 294 269 336 29 324 336
Confirm Tx confirm_tx 6029 6020 6042 8 6030 6042
total 6029 6020 6042 8 6030 6042
Bridge User Actions bridge_load_page 226 194 259 22 232 259
bridge_load_asset_picker 244 205 289 29 258 289
bridge_search_token 758 752 762 4 762 762
total 1225 1214 1242 12 1242 1242

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1444 1195 1857 112 1481 1655
load 1197 994 1435 94 1237 1379
domContentLoaded 1191 989 1422 93 1232 1375
domInteractive 29 16 101 19 25 83
firstPaint 140 72 385 71 193 261
backgroundConnect 215 195 258 12 220 240
firstReactRender 19 13 30 3 20 26
initialActions 1 0 6 1 2 5
loadScripts 991 796 1216 91 1023 1166
setupStore 13 6 45 5 15 19
numNetworkReqs 36 27 94 18 36 81
Power User Home uiStartup 6153 2006 18020 3362 7394 13659
load 1313 1139 2021 137 1347 1577
domContentLoaded 1296 1132 1993 131 1319 1546
domInteractive 35 20 142 23 34 81
firstPaint 201 95 524 87 262 357
backgroundConnect 2368 318 14515 3213 2564 10647
firstReactRender 28 19 103 9 30 38
initialActions 1 0 5 1 1 3
loadScripts 1069 924 1709 122 1089 1294
setupStore 17 7 55 9 19 37
numNetworkReqs 139 75 273 42 147 246

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 224 219 232 5 223 232
srpButtonToSrpForm 100 96 107 4 102 107
confirmSrpToPwForm 23 22 24 1 24 24
pwFormToMetricsScreen 16 16 17 1 16 17
metricsToWalletReadyScreen 18 17 21 2 19 21
doneButtonToHomeScreen 664 608 771 64 651 771
openAccountMenuToAccountListLoaded 2928 2919 2936 7 2936 2936
total 4014 3913 4124 81 4085 4124
Onboarding New Wallet createWalletToSocialScreen 221 218 226 3 223 226
srpButtonToPwForm 108 105 110 2 108 110
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 37 36 38 1 37 38
agreeButtonToOnboardingSuccess 16 16 16 0 16 16
doneButtonToAssetList 488 477 506 11 488 506
total 888 885 893 3 893 893
Asset Details assetClickToPriceChart 119 95 155 20 127 155
total 119 95 155 20 127 155
Solana Asset Details assetClickToPriceChart 81 78 84 2 81 84
total 81 78 84 2 81 84
Import Srp Home loginToHomeScreen 2288 2254 2317 23 2295 2317
openAccountMenuAfterLogin 67 54 77 9 72 77
homeAfterImportWithNewWallet 2367 2202 2562 140 2453 2562
total 4747 4573 4922 120 4800 4922
Send Transactions openSendPageFromHome 28 23 37 6 29 37
selectTokenToSendFormLoaded 33 32 34 1 34 34
reviewTransactionToConfirmationPage 1332 850 1797 334 1479 1797
total 1400 900 1900 351 1540 1900
Swap openSwapPageFromHome 22 22 23 0 23 23
fetchAndDisplaySwapQuotes 2688 2684 2690 2 2689 2690
total 2710 2707 2712 2 2711 2712

🌐 Dapp Page Load Benchmarks

Current Commit: 5cac273 | Date: 3/11/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±78ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 752ms (±87ms) 🟢 | historical mean value: 740ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 92ms (±129ms) 🟢 | historical mean value: 82ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	78ms	1.01s	1.40s	1.29s	1.40s
domContentLoaded	752ms	87ms	707ms	1.30s	965ms	1.30s
firstPaint	92ms	129ms	64ms	1.37s	88ms	1.37s
firstContentfulPaint	92ms	129ms	64ms	1.37s	88ms	1.37s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 8.24 KiB (0.16%)
ui: 3 Bytes (0%)
common: 104 Bytes (0%)

sonarqubecloud · 2026-03-11T19:25:52Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-03-11T19:48:06Z

Builds ready [3ab8169]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 271 262 280 8 277 280
total 271 262 280 8 277 280
Confirm Tx confirm_tx 6020 6006 6029 9 6027 6029
total 6020 6006 6029 9 6027 6029
Bridge User Actions bridge_load_page 235 194 292 35 245 292
bridge_load_asset_picker 236 153 291 49 281 291
bridge_search_token 739 730 751 8 741 751
total 1204 1102 1318 75 1236 1318

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1443 1209 1786 112 1485 1629
load 1204 1007 1536 99 1262 1375
domContentLoaded 1196 1004 1532 99 1256 1370
domInteractive 29 17 101 18 25 81
firstPaint 139 69 404 70 174 259
backgroundConnect 217 197 288 14 223 237
firstReactRender 20 13 43 5 21 30
initialActions 2 0 7 1 2 5
loadScripts 995 788 1327 98 1039 1163
setupStore 13 6 31 5 16 22
numNetworkReqs 36 27 87 17 30 79
Power User Home uiStartup 5842 1922 17849 2953 6841 8934
load 1323 1143 1656 119 1376 1561
domContentLoaded 1305 1137 1634 111 1362 1525
domInteractive 37 21 290 32 34 81
firstPaint 206 81 1202 131 275 339
backgroundConnect 2267 314 14752 2750 3153 5276
firstReactRender 30 20 296 27 30 39
initialActions 1 0 5 1 1 2
loadScripts 1070 912 1365 103 1120 1282
setupStore 17 6 87 10 20 32
numNetworkReqs 138 75 275 40 146 229

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 219 220 0 219 220
srpButtonToSrpForm 93 92 94 1 93 94
confirmSrpToPwForm 21 21 22 0 22 22
pwFormToMetricsScreen 15 15 15 0 15 15
metricsToWalletReadyScreen 16 15 16 0 16 16
doneButtonToHomeScreen 599 590 615 9 598 615
openAccountMenuToAccountListLoaded 2918 2904 2936 12 2926 2936
total 3880 3862 3900 14 3884 3900
Onboarding New Wallet createWalletToSocialScreen 219 219 219 0 219 219
srpButtonToPwForm 109 106 111 2 111 111
createPwToRecoveryScreen 8 8 9 0 8 9
skipBackupToMetricsScreen 35 34 36 1 35 36
agreeButtonToOnboardingSuccess 16 16 16 0 16 16
doneButtonToAssetList 578 484 781 113 623 781
total 968 865 1170 112 1007 1170
Asset Details assetClickToPriceChart 71 52 91 15 81 91
total 71 52 91 15 81 91
Solana Asset Details assetClickToPriceChart 79 71 87 6 84 87
total 79 71 87 6 84 87
Import Srp Home loginToHomeScreen 2340 2223 2422 73 2375 2422
openAccountMenuAfterLogin 80 54 103 17 94 103
homeAfterImportWithNewWallet 2537 2421 2593 68 2573 2593
total 4951 4860 5049 78 5006 5049
Send Transactions openSendPageFromHome 47 21 70 20 65 70
selectTokenToSendFormLoaded 31 17 46 12 42 46
reviewTransactionToConfirmationPage 1241 845 1795 374 1518 1795
total 1319 883 1890 396 1613 1890
Swap openSwapPageFromHome 23 22 25 1 23 25
fetchAndDisplaySwapQuotes 2684 2675 2692 6 2685 2692
total 2721 2698 2746 20 2742 2746

🌐 Dapp Page Load Benchmarks

Current Commit: 3ab8169 | Date: 3/11/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.01s (±73ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 708ms (±70ms) 🟢 | historical mean value: 740ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 80ms (±13ms) 🟢 | historical mean value: 84ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.01s	73ms	964ms	1.30s	1.24s	1.30s
domContentLoaded	708ms	70ms	671ms	981ms	923ms	981ms
firstPaint	80ms	13ms	68ms	196ms	96ms	196ms
firstContentfulPaint	80ms	13ms	68ms	196ms	96ms	196ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 8.24 KiB (0.16%)
ui: 26.28 KiB (0.31%)
common: 635 Bytes (0.01%)

jeffsmale90 temporarily deployed to pr-comment March 11, 2026 17:40 — with GitHub Actions Inactive

metamaskbot added the team-delegation MetaMask Delegation Team label Mar 11, 2026

jeffsmale90 changed the title ~~Chore/enable token permissions~~ chore: Enable token permissions in production build Mar 11, 2026

github-actions bot added the size-XS label Mar 11, 2026

jeffsmale90 added 3 commits March 12, 2026 06:51

Set enabled permissions

d512f56

Upgrade gator-permissions-controller

19fa07e

Bump Advanced Permissions snaps

5cac273

- @metamask/gator-permissions-snap from ^1.1.1 to ^1.2.0 - @metamask/permissions-kernel-snap from ^1.0.0 to ^1.1.0

jeffsmale90 force-pushed the chore/enable_token_permissions branch from 739d07f to 5cac273 Compare March 11, 2026 17:53

jeffsmale90 temporarily deployed to pr-comment March 11, 2026 17:53 — with GitHub Actions Inactive

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 11, 2026

jeffsmale90 temporarily deployed to pr-comment March 11, 2026 18:30 — with GitHub Actions Inactive

Dedupe deps

3ab8169

jeffsmale90 temporarily deployed to pr-comment March 11, 2026 19:10 — with GitHub Actions Inactive

jeffsmale90 marked this pull request as ready for review March 11, 2026 19:40

jeffsmale90 temporarily deployed to pr-comment March 11, 2026 19:40 — with GitHub Actions Inactive

jeffsmale90 temporarily deployed to pr-comment March 11, 2026 19:43 — with GitHub Actions Inactive

mj-kiwi approved these changes Mar 11, 2026

View reviewed changes

jeffsmale90 enabled auto-merge March 11, 2026 21:46

McOso approved these changes Mar 12, 2026

View reviewed changes

jeffsmale90 added this pull request to the merge queue Mar 12, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 12, 2026

MoMannn added this pull request to the merge queue Mar 12, 2026

Merged via the queue into main with commit f107536 Mar 12, 2026
189 checks passed

MoMannn deleted the chore/enable_token_permissions branch March 12, 2026 08:13

github-actions bot locked and limited conversation to collaborators Mar 12, 2026

metamaskbot added the release-13.23.0 Issue or pull request that will be included in release 13.23.0 label Mar 12, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Enable token permissions in production build#40813

chore: Enable token permissions in production build#40813
MoMannn merged 4 commits intomainfrom
chore/enable_token_permissions

jeffsmale90 commented Mar 11, 2026 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Mar 11, 2026

Uh oh!

socket-security bot commented Mar 11, 2026 •

edited

Loading

Uh oh!

metamaskbotv2 bot commented Mar 11, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud bot commented Mar 11, 2026

Uh oh!

metamaskbotv2 bot commented Mar 11, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

jeffsmale90 commented Mar 11, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Mar 11, 2026

Uh oh!

socket-security bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbotv2 bot commented Mar 11, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud bot commented Mar 11, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 bot commented Mar 11, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jeffsmale90 commented Mar 11, 2026 •

edited by cursor bot

Loading

socket-security bot commented Mar 11, 2026 •

edited

Loading