fix: disable closing price impact modal while submitting a trade by micaelae · Pull Request #40811 · MetaMask/metamask-extension

micaelae · 2026-03-11T17:22:30Z

Description

Fixes a bug in which the priceImpact modal automatically closes after tx submission, which allows re-submitting the same trade. This change disables closing the modal when the modal overlay is clicked and also removes onClose call after the transaction is submitted

Changelog

CHANGELOG entry: fix: disable closing price impact modal while submitting a trade

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-4256

Manual testing steps

Get a swap quote with high price impact (small amount of ETH to MUSD usually has a PancakeSwap route)
Submit the trade
Try to close the modal while submission is in progress
After submission, the wallet should navigate to the activity log

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes the bridge submission UX/control flow by keeping the price impact modal open and adjusting post-submit navigation, which could affect error handling and prevent/allow unintended resubmissions.

Overview
Prevents the BridgePriceImpactWarningModal (submit CTA variant) from being dismissed via outside click/escape during submission and removes the automatic onClose() after clicking Proceed, keeping the modal open until explicitly cancelled.

Adjusts bridge submission error handling in useSubmitBridgeTransaction by no longer immediately navigating to the Activity page from the catch block (only hardware-wallet rejections redirect back to the bridge page), and updates the modal test expectations accordingly.

^{Written by Cursor Bugbot for commit d434b80. This will update automatically on new commits. Configure here.}

metamaskbotv2 · 2026-03-11T17:23:32Z

✨ Files requiring CODEOWNER review ✨

🔄 @MetaMask/swaps-engineers (3 files, +3 -6)

📁 ui/
- 📁 pages/
  - 📁 bridge/
    - 📁 hooks/
      - 📄 useSubmitBridgeTransaction.ts +0 -2
    - 📁 prepare/
      - 📄 bridge-price-impact-modal.test.tsx +1 -1
      - 📄 bridge-price-impact-modal.tsx +2 -3

sonarqubecloud · 2026-03-11T17:35:50Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-03-11T17:56:34Z

Builds ready [d434b80]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 270 256 289 12 279 289
total 270 256 289 12 279 289
Confirm Tx confirm_tx 6020 5999 6037 15 6030 6037
total 6020 5999 6037 15 6030 6037
Bridge User Actions bridge_load_page 261 250 270 8 267 270
bridge_load_asset_picker 170 143 200 22 181 200
bridge_search_token 711 691 725 14 723 725
total 1132 1081 1193 42 1163 1193

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1433 1163 1701 115 1481 1664
load 1184 962 1433 101 1230 1366
domContentLoaded 1177 957 1424 100 1224 1355
domInteractive 29 16 100 19 26 78
firstPaint 173 66 1206 130 204 333
backgroundConnect 211 183 253 13 217 239
firstReactRender 19 12 44 4 20 25
initialActions 1 0 5 1 2 3
loadScripts 983 769 1226 98 1030 1157
setupStore 14 7 45 6 16 25
numNetworkReqs 35 27 91 18 27 85
Power User Home uiStartup 5538 2185 17869 2706 6534 8968
load 1286 1131 1744 121 1323 1542
domContentLoaded 1268 1125 1713 111 1295 1501
domInteractive 37 19 315 36 33 88
firstPaint 198 80 426 89 267 361
backgroundConnect 2074 290 14596 2448 2715 6155
firstReactRender 26 18 51 6 28 34
initialActions 1 0 4 1 1 2
loadScripts 1047 922 1490 103 1086 1280
setupStore 15 5 60 8 19 30
numNetworkReqs 134 48 258 44 145 248

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 218 218 219 0 219 219
srpButtonToSrpForm 93 92 93 0 93 93
confirmSrpToPwForm 21 21 21 0 21 21
pwFormToMetricsScreen 16 15 17 1 17 17
metricsToWalletReadyScreen 16 15 17 1 16 17
doneButtonToHomeScreen 615 584 666 35 648 666
openAccountMenuToAccountListLoaded 2758 2499 2942 207 2930 2942
total 3740 3455 3932 201 3892 3932
Onboarding New Wallet createWalletToSocialScreen 222 218 225 3 225 225
srpButtonToPwForm 113 108 118 4 115 118
createPwToRecoveryScreen 9 9 10 0 9 10
skipBackupToMetricsScreen 39 38 41 1 41 41
agreeButtonToOnboardingSuccess 17 16 19 1 18 19
doneButtonToAssetList 562 510 659 55 584 659
total 940 906 991 31 931 991
Asset Details assetClickToPriceChart 142 98 196 38 165 196
total 142 98 196 38 165 196
Solana Asset Details assetClickToPriceChart 81 51 101 18 90 101
total 81 51 101 18 90 101
Import Srp Home loginToHomeScreen 2423 2244 2699 161 2452 2699
openAccountMenuAfterLogin 55 41 67 10 62 67
homeAfterImportWithNewWallet 2317 2241 2394 61 2380 2394
total 4795 4649 5029 138 4864 5029
Send Transactions openSendPageFromHome 27 17 46 11 36 46
selectTokenToSendFormLoaded 19 16 21 2 19 21
reviewTransactionToConfirmationPage 904 844 1064 93 855 1064
total 948 884 1129 104 890 1129
Swap openSwapPageFromHome 32 24 47 9 39 47
fetchAndDisplaySwapQuotes 2680 2679 2681 1 2681 2681
total 2713 2703 2728 11 2723 2728

🌐 Dapp Page Load Benchmarks

Current Commit: d434b80 | Date: 3/11/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±42ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 736ms (±40ms) 🟢 | historical mean value: 740ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 81ms (±10ms) 🟢 | historical mean value: 82ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	42ms	1.02s	1.37s	1.10s	1.37s
domContentLoaded	736ms	40ms	712ms	1.04s	786ms	1.04s
firstPaint	81ms	10ms	68ms	168ms	88ms	168ms
firstContentfulPaint	81ms	10ms	68ms	168ms	88ms	168ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: -156 Bytes (0%)
ui: -678 Bytes (-0.01%)
common: 20 Bytes (0%)

fix: disable closing price impact modal while submitting a trade

d434b80

micaelae temporarily deployed to pr-comment March 11, 2026 17:22 — with GitHub Actions Inactive

metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Mar 11, 2026

github-actions bot added the size-XS label Mar 11, 2026

micaelae marked this pull request as ready for review March 11, 2026 17:32

micaelae requested a review from a team as a code owner March 11, 2026 17:32

micaelae temporarily deployed to pr-comment March 11, 2026 17:32 — with GitHub Actions Inactive

micaelae enabled auto-merge March 11, 2026 17:43

micaelae temporarily deployed to pr-comment March 11, 2026 17:51 — with GitHub Actions Inactive

SteP-n-s approved these changes Mar 11, 2026

View reviewed changes

ghgoodreau approved these changes Mar 11, 2026

View reviewed changes

micaelae added this pull request to the merge queue Mar 11, 2026

Merged via the queue into main with commit be0650d Mar 11, 2026
201 of 202 checks passed

micaelae deleted the swaps4256-disable-close-on-submit branch March 11, 2026 19:55

github-actions bot locked and limited conversation to collaborators Mar 11, 2026

metamaskbot added the release-13.23.0 Issue or pull request that will be included in release 13.23.0 label Mar 11, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: disable closing price impact modal while submitting a trade#40811

fix: disable closing price impact modal while submitting a trade#40811
micaelae merged 1 commit intomainfrom
swaps4256-disable-close-on-submit

micaelae commented Mar 11, 2026 •

edited by cursor bot

Loading

Uh oh!

metamaskbotv2 bot commented Mar 11, 2026

Uh oh!

sonarqubecloud bot commented Mar 11, 2026

Uh oh!

metamaskbotv2 bot commented Mar 11, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

micaelae commented Mar 11, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbotv2 bot commented Mar 11, 2026

✨ Files requiring CODEOWNER review ✨

Uh oh!

sonarqubecloud bot commented Mar 11, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 bot commented Mar 11, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

micaelae commented Mar 11, 2026 •

edited by cursor bot

Loading