feat: Hide Cancel and Speed up when gas is paid with alternate token by vinistevam · Pull Request #40804 · MetaMask/metamask-extension

vinistevam · 2026-03-11T14:27:56Z

Description

Cancel and Speed up in the activity list should not be shown when the user has chosen a non‑native token to pay for gas, because those flows are not supported for gas‑fee‑token transactions.

Changelog

CHANGELOG entry: Added check for hiding Cancel and Speed up in the activity list when the user has selected another token to pay for gas

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/7073

Manual testing steps

Create a transaction and, in the gas/token selector, choose a different token (not native) to pay for gas.
Submit the transaction (it will be pending).
Open the activity list and locate that pending transaction.
Expected: Speed up and Cancel buttons do not appear for that transaction.
Optional: Create another pending transaction without selecting a different token for gas. Expected: Speed up and Cancel buttons do appear for that one.

Screenshots/Recordings

7702.webm

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes the conditions for showing Speed Up/Cancel actions on pending transactions, which could impact users’ ability to manage transactions if the selectedGasFeeToken flag is set incorrectly. Scope is limited to UI gating and is covered by added unit tests.

Overview
Updates TransactionListItem to hide the Cancel and Speed Up buttons when a transaction’s primaryTransaction.selectedGasFeeToken is set (i.e., gas is paid with a non-native token), since those flows aren’t supported for gas-fee-token transactions.

Adds unit tests that mock useShouldShowSpeedUp and verify the buttons are hidden when selectedGasFeeToken is present and still shown when it is absent and other conditions allow.

^{Written by Cursor Bugbot for commit 8c3bbbe. This will update automatically on new commits. Configure here.}

…ionListItem

…TransactionListItem test: add tests for useHasGasFeeTokenSelected and remove tests for useIs7702Transaction

github-actions · 2026-03-11T14:28:09Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-03-11T14:36:25Z

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (2 files, +66 -4)

📁 ui/
- 📁 components/
  - 📁 app/
    - 📁 transaction-list-item/
      - 📄 transaction-list-item.component.js +15 -4
      - 📄 transaction-list-item.component.test.js +51 -0

ui/pages/confirmations/hooks/useHasGasFeeTokenSelected.ts

metamaskbotv2 · 2026-03-11T15:10:53Z

Builds ready [d288466]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 293 290 297 3 297 297
total 293 290 297 3 297 297
Confirm Tx confirm_tx 6108 6065 6180 42 6125 6180
total 6108 6065 6180 42 6125 6180
Bridge User Actions bridge_load_page 240 203 298 40 277 298
bridge_load_asset_picker 192 190 195 2 195 195
bridge_search_token 723 707 743 13 731 743
total 1130 1109 1175 26 1119 1175

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1466 1229 1859 115 1538 1659
load 1221 1018 1654 109 1289 1401
domContentLoaded 1213 1015 1590 105 1284 1393
domInteractive 31 18 157 21 26 82
firstPaint 175 67 1272 173 206 375
backgroundConnect 215 198 313 15 217 245
firstReactRender 20 14 40 5 22 31
initialActions 1 0 6 1 2 4
loadScripts 1015 822 1388 104 1090 1193
setupStore 14 6 35 6 16 26
numNetworkReqs 36 27 92 19 28 85
Power User Home uiStartup 6396 2136 18068 3500 6802 16840
load 1351 1172 1791 122 1404 1597
domContentLoaded 1332 1165 1780 115 1380 1550
domInteractive 35 19 168 21 36 68
firstPaint 221 93 492 91 293 358
backgroundConnect 2638 321 14684 3486 3149 13920
firstReactRender 27 19 66 6 30 36
initialActions 1 0 8 1 1 3
loadScripts 1095 947 1507 107 1145 1308
setupStore 17 6 68 9 18 33
numNetworkReqs 148 87 259 38 155 238

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 216 222 2 221 222
srpButtonToSrpForm 97 92 103 4 101 103
confirmSrpToPwForm 21 21 22 1 21 22
pwFormToMetricsScreen 15 15 15 0 15 15
metricsToWalletReadyScreen 16 14 18 1 16 18
doneButtonToHomeScreen 644 586 731 51 655 731
openAccountMenuToAccountListLoaded 2929 2921 2935 6 2935 2935
total 3915 3883 3955 28 3926 3955
Onboarding New Wallet createWalletToSocialScreen 220 218 223 1 221 223
srpButtonToPwForm 108 107 109 1 109 109
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 35 34 36 1 35 36
agreeButtonToOnboardingSuccess 16 15 17 1 17 17
doneButtonToAssetList 555 492 623 55 614 623
total 943 879 1007 54 1005 1007
Asset Details assetClickToPriceChart 132 109 145 13 144 145
total 132 109 145 13 144 145
Solana Asset Details assetClickToPriceChart 92 85 96 4 95 96
total 92 85 96 4 95 96
Import Srp Home loginToHomeScreen 2285 2252 2326 30 2302 2326
openAccountMenuAfterLogin 78 47 106 22 99 106
homeAfterImportWithNewWallet 2553 2415 2735 144 2721 2735
total 4983 4743 5105 144 5093 5105
Send Transactions openSendPageFromHome 22 19 27 3 24 27
selectTokenToSendFormLoaded 27 17 43 10 34 43
reviewTransactionToConfirmationPage 883 845 975 53 865 975
total 929 889 1016 51 907 1016
Swap openSwapPageFromHome 37 20 57 16 55 57
fetchAndDisplaySwapQuotes 2696 2693 2698 2 2698 2698
total 2733 2704 2764 22 2753 2764

🌐 Dapp Page Load Benchmarks

Current Commit: d288466 | Date: 3/11/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±41ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 736ms (±38ms) 🟢 | historical mean value: 738ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 81ms (±13ms) 🟢 | historical mean value: 84ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	41ms	1.03s	1.35s	1.08s	1.35s
domContentLoaded	736ms	38ms	715ms	1.01s	774ms	1.01s
firstPaint	81ms	13ms	64ms	200ms	88ms	200ms
firstContentfulPaint	81ms	13ms	64ms	200ms	88ms	200ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 584 Bytes (0.01%)
common: 20 Bytes (0%)

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

ui/pages/confirmations/hooks/useHasGasFeeTokenSelected.ts

metamaskbotv2 · 2026-03-12T06:47:47Z

Builds ready [9832240]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 279 261 305 16 292 305
total 279 261 305 16 292 305
Confirm Tx confirm_tx 6025 6017 6032 6 6032 6032
total 6025 6017 6032 6 6032 6032
Bridge User Actions bridge_load_page 211 204 216 4 212 216
bridge_load_asset_picker 253 234 281 16 258 281
bridge_search_token 766 753 780 9 772 780
total 1236 1221 1254 14 1253 1254

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1478 1239 1925 118 1525 1663
load 1231 1006 1594 109 1278 1417
domContentLoaded 1224 1002 1586 107 1274 1407
domInteractive 29 16 137 20 26 76
firstPaint 167 71 1171 156 213 309
backgroundConnect 221 201 326 15 224 242
firstReactRender 19 13 34 4 20 27
initialActions 1 0 7 1 2 5
loadScripts 1019 809 1385 107 1070 1201
setupStore 14 6 148 14 15 22
numNetworkReqs 36 27 83 17 36 80
Power User Home uiStartup 5981 1786 13963 2437 6828 10993
load 1367 1195 2626 171 1399 1581
domContentLoaded 1344 1185 2608 163 1371 1571
domInteractive 39 21 162 28 37 101
firstPaint 266 86 1335 207 306 378
backgroundConnect 2086 340 11002 2151 2898 5949
firstReactRender 29 19 66 8 33 45
initialActions 1 0 5 1 1 2
loadScripts 1105 948 2387 160 1123 1329
setupStore 15 6 48 8 16 37
numNetworkReqs 148 54 310 45 152 259

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 220 219 220 0 220 220
srpButtonToSrpForm 92 90 95 2 93 95
confirmSrpToPwForm 22 21 22 0 22 22
pwFormToMetricsScreen 15 15 16 0 16 16
metricsToWalletReadyScreen 16 15 18 1 17 18
doneButtonToHomeScreen 630 515 760 84 684 760
openAccountMenuToAccountListLoaded 2919 2905 2932 11 2929 2932
total 3954 3870 4036 66 3993 4036
Onboarding New Wallet createWalletToSocialScreen 223 222 224 1 223 224
srpButtonToPwForm 109 107 111 2 110 111
createPwToRecoveryScreen 9 8 9 0 9 9
skipBackupToMetricsScreen 37 34 42 3 38 42
agreeButtonToOnboardingSuccess 17 17 17 0 17 17
doneButtonToAssetList 502 479 553 30 491 553
total 894 871 939 26 884 939
Asset Details assetClickToPriceChart 56 49 71 9 53 71
total 56 49 71 9 53 71
Solana Asset Details assetClickToPriceChart 81 39 122 30 90 122
total 81 39 122 30 90 122
Import Srp Home loginToHomeScreen 2403 2328 2555 93 2469 2555
openAccountMenuAfterLogin 63 55 69 7 69 69
homeAfterImportWithNewWallet 1616 560 2330 816 2269 2330
total 4087 2959 4855 828 4726 4855
Send Transactions openSendPageFromHome 27 24 29 2 28 29
selectTokenToSendFormLoaded 32 29 35 2 32 35
reviewTransactionToConfirmationPage 920 651 1142 169 1043 1142
total 990 715 1259 184 1104 1259
Swap openSwapPageFromHome 105 76 130 19 120 130
fetchAndDisplaySwapQuotes 2698 2685 2710 11 2707 2710
total 2804 2766 2840 30 2827 2840

🌐 Dapp Page Load Benchmarks

Current Commit: 9832240 | Date: 3/12/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±42ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 733ms (±40ms) 🟢 | historical mean value: 740ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 81ms (±14ms) 🟢 | historical mean value: 85ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	42ms	1.02s	1.33s	1.07s	1.33s
domContentLoaded	733ms	40ms	710ms	1.00s	761ms	1.00s
firstPaint	81ms	14ms	64ms	188ms	88ms	188ms
firstContentfulPaint	81ms	14ms	64ms	188ms	88ms	188ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 17.39 KiB (0.33%)
ui: -27.57 KiB (-0.32%)
common: 68.52 KiB (0.61%)

metamaskbotv2 · 2026-03-12T07:25:22Z

Builds ready [c5e2ad7]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 305 289 325 15 313 325
total 305 289 325 15 313 325
Confirm Tx confirm_tx 6035 6015 6047 13 6046 6047
total 6035 6015 6047 13 6046 6047
Bridge User Actions bridge_load_page 257 213 309 36 280 309
bridge_load_asset_picker 238 205 272 28 271 272
bridge_search_token 751 730 768 14 755 768
total 1247 1224 1265 15 1253 1265

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1461 1234 1863 121 1522 1681
load 1212 1006 1488 98 1245 1400
domContentLoaded 1206 999 1477 97 1240 1393
domInteractive 29 18 91 17 26 77
firstPaint 143 73 427 68 195 242
backgroundConnect 216 197 301 16 218 243
firstReactRender 20 13 55 6 21 32
initialActions 1 0 7 1 2 4
loadScripts 1006 796 1259 96 1039 1185
setupStore 14 6 119 12 14 23
numNetworkReqs 36 27 84 17 36 77
Power User Home uiStartup 5254 2153 11304 2073 6540 8499
load 1309 1151 1799 129 1351 1577
domContentLoaded 1291 1144 1784 125 1332 1546
domInteractive 40 20 222 34 37 126
firstPaint 205 89 518 99 263 404
backgroundConnect 1872 307 8008 1742 2847 4957
firstReactRender 27 18 57 7 30 41
initialActions 4 0 236 23 1 3
loadScripts 1062 933 1494 113 1083 1300
setupStore 16 6 50 8 18 32
numNetworkReqs 136 58 253 40 145 242

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 218 221 1 220 221
srpButtonToSrpForm 96 96 96 0 96 96
confirmSrpToPwForm 22 22 22 0 22 22
pwFormToMetricsScreen 16 16 16 0 16 16
metricsToWalletReadyScreen 17 16 18 1 17 18
doneButtonToHomeScreen 597 595 598 2 598 598
openAccountMenuToAccountListLoaded 2933 2911 2970 22 2928 2970
total 3889 3883 3896 5 3888 3896
Onboarding New Wallet createWalletToSocialScreen 219 219 219 0 219 219
srpButtonToPwForm 106 105 108 1 107 108
createPwToRecoveryScreen 8 8 9 0 8 9
skipBackupToMetricsScreen 35 34 36 0 35 36
agreeButtonToOnboardingSuccess 16 15 17 1 17 17
doneButtonToAssetList 507 485 525 17 525 525
total 892 870 912 17 912 912
Asset Details assetClickToPriceChart 97 91 103 5 99 103
total 97 91 103 5 99 103
Solana Asset Details assetClickToPriceChart 105 41 165 46 149 165
total 105 41 165 46 149 165
Import Srp Home loginToHomeScreen 2409 2269 2552 114 2530 2552
openAccountMenuAfterLogin 65 46 96 18 73 96
homeAfterImportWithNewWallet 1742 609 2848 937 2335 2848
total 4215 2947 5259 937 4865 5259
Send Transactions openSendPageFromHome 31 26 40 6 30 40
selectTokenToSendFormLoaded 33 24 44 7 34 44
reviewTransactionToConfirmationPage 1141 917 1361 184 1308 1361
total 1221 977 1445 185 1394 1445
Swap openSwapPageFromHome 103 55 175 45 133 175
fetchAndDisplaySwapQuotes 2701 2689 2718 11 2705 2718
total 2804 2770 2865 36 2822 2865

🌐 Dapp Page Load Benchmarks

Current Commit: c5e2ad7 | Date: 3/12/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 961ms (±44ms) 🟢 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 675ms (±39ms) 🟢 | historical mean value: 740ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±15ms) 🟢 | historical mean value: 85ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	961ms	44ms	935ms	1.31s	990ms	1.31s
domContentLoaded	675ms	39ms	653ms	988ms	705ms	988ms
firstPaint	75ms	15ms	60ms	216ms	84ms	216ms
firstContentfulPaint	75ms	15ms	60ms	216ms	84ms	216ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 17.39 KiB (0.33%)
ui: -28.06 KiB (-0.33%)
common: 68.52 KiB (0.61%)

sonarqubecloud · 2026-03-19T06:09:30Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-03-19T06:30:54Z

Builds ready [8c3bbbe]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 286 269 301 11 295 301
total 286 269 301 11 295 301
Confirm Tx confirm_tx 6040 6015 6091 30 6029 6091
total 6040 6015 6091 30 6029 6091
Bridge User Actions bridge_load_page 251 234 268 13 264 268
bridge_load_asset_picker 264 214 319 36 282 319
bridge_search_token 758 744 773 12 770 773
total 1274 1228 1300 28 1297 1300

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1511 1270 1811 105 1546 1754
load 1247 1055 1523 96 1281 1428
domContentLoaded 1241 1049 1517 94 1276 1417
domInteractive 33 18 142 25 28 96
firstPaint 159 75 470 83 212 303
backgroundConnect 221 208 287 12 225 242
firstReactRender 22 13 228 21 21 26
initialActions 1 0 6 1 2 3
loadScripts 1035 836 1312 93 1067 1205
setupStore 15 6 41 7 17 25
numNetworkReqs 39 31 82 15 40 75
Power User Home uiStartup 5545 2434 15079 2205 6431 8232
load 1340 1113 1979 145 1383 1641
domContentLoaded 1318 1103 1936 138 1339 1611
domInteractive 40 19 175 34 33 140
firstPaint 201 93 495 94 270 354
backgroundConnect 1948 300 11320 2011 3078 4831
firstReactRender 25 15 42 5 27 35
initialActions 1 0 4 1 1 4
loadScripts 1088 892 1617 128 1112 1371
setupStore 18 6 216 21 18 32
numNetworkReqs 219 118 341 50 252 316

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 220 218 222 2 221 222
srpButtonToSrpForm 94 92 96 1 95 96
confirmSrpToPwForm 23 22 23 0 23 23
pwFormToMetricsScreen 16 15 16 0 16 16
metricsToWalletReadyScreen 16 16 16 0 16 16
doneButtonToHomeScreen 609 605 619 6 606 619
openAccountMenuToAccountListLoaded 2931 2921 2937 7 2937 2937
total 3918 3894 3951 22 3925 3951
Onboarding New Wallet createWalletToSocialScreen 218 217 219 1 218 219
srpButtonToPwForm 110 109 110 1 110 110
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 38 38 39 0 39 39
agreeButtonToOnboardingSuccess 16 15 17 1 16 17
doneButtonToAssetList 580 471 743 124 720 743
total 973 863 1135 124 1116 1135
Asset Details assetClickToPriceChart 68 49 101 19 77 101
total 68 49 101 19 77 101
Solana Asset Details assetClickToPriceChart 111 108 114 2 114 114
total 111 108 114 2 114 114
Import Srp Home loginToHomeScreen 2341 2279 2443 62 2336 2443
openAccountMenuAfterLogin 91 33 141 37 112 141
homeAfterImportWithNewWallet 1643 481 2633 954 2324 2633
total 4156 2935 5476 1028 4772 5476
Send Transactions openSendPageFromHome 33 23 51 11 30 51
selectTokenToSendFormLoaded 31 21 46 9 36 46
reviewTransactionToConfirmationPage 1145 848 1329 208 1320 1329
total 1223 920 1392 190 1380 1392
Swap openSwapPageFromHome 87 72 102 11 89 102
fetchAndDisplaySwapQuotes 2684 2679 2686 3 2686 2686
total 2740 2673 2775 37 2765 2775

🌐 Dapp Page Load Benchmarks

Current Commit: 8c3bbbe | Date: 3/19/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±42ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 735ms (±63ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 94ms (±129ms) 🟢 | historical mean value: 86ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	42ms	1.04s	1.38s	1.10s	1.38s
domContentLoaded	735ms	63ms	708ms	1.31s	765ms	1.31s
firstPaint	94ms	129ms	64ms	1.38s	92ms	1.38s
firstContentfulPaint	94ms	129ms	64ms	1.38s	92ms	1.38s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 55 Bytes (0%)
common: 20 Bytes (0%)

vinistevam added 2 commits March 11, 2026 10:39

feat: implement useIs7702Transaction hook and integrate with Transact…

499f392

…ionListItem

feat: replace useIs7702Transaction with useHasGasFeeTokenSelected in …

0b12742

…TransactionListItem test: add tests for useHasGasFeeTokenSelected and remove tests for useIs7702Transaction

vinistevam added the team-confirmations Push issues to confirmations team label Mar 11, 2026

vinistevam changed the title ~~feat: Hide Cancel and Speed up for EIP-7702 transactions in activity list~~ feat: Hide Cancel and Speed up when gas is paid with alternate token Mar 11, 2026

Merge branch 'main' into vs/hide_cancel_speedup_for_7702

d288466

vinistevam marked this pull request as ready for review March 11, 2026 14:35

vinistevam requested review from a team as code owners March 11, 2026 14:35

vinistevam had a problem deploying to pr-comment March 11, 2026 14:35 — with GitHub Actions Error

vinistevam temporarily deployed to pr-comment March 11, 2026 14:35 — with GitHub Actions Inactive

github-actions bot added the size-M label Mar 11, 2026

cursor bot reviewed Mar 11, 2026

View reviewed changes

ui/pages/confirmations/hooks/useHasGasFeeTokenSelected.ts Outdated Show resolved Hide resolved

vinistevam temporarily deployed to pr-comment March 11, 2026 15:06 — with GitHub Actions Inactive

fix pipeline

9832240

vinistevam temporarily deployed to pr-comment March 12, 2026 06:09 — with GitHub Actions Inactive

cursor bot reviewed Mar 12, 2026

View reviewed changes

ui/pages/confirmations/hooks/useHasGasFeeTokenSelected.ts Outdated Show resolved Hide resolved

vinistevam temporarily deployed to pr-comment March 12, 2026 06:42 — with GitHub Actions Inactive

simplify gasfeetoken

c5e2ad7

vinistevam temporarily deployed to pr-comment March 12, 2026 06:49 — with GitHub Actions Inactive

github-actions bot added size-S and removed size-M labels Mar 12, 2026

vinistevam temporarily deployed to pr-comment March 12, 2026 07:20 — with GitHub Actions Inactive

pedronfigueiredo approved these changes Mar 12, 2026

View reviewed changes

ameliejyc approved these changes Mar 16, 2026

View reviewed changes

vinistevam added this pull request to the merge queue Mar 18, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 18, 2026

Merge branch 'main' into vs/hide_cancel_speedup_for_7702

8c3bbbe

vinistevam temporarily deployed to pr-comment March 19, 2026 05:56 — with GitHub Actions Inactive

vinistevam temporarily deployed to pr-comment March 19, 2026 06:26 — with GitHub Actions Inactive

vinistevam added this pull request to the merge queue Mar 19, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 19, 2026

vinistevam added this pull request to the merge queue Mar 19, 2026

Merged via the queue into main with commit f8a01d8 Mar 19, 2026
205 of 206 checks passed

vinistevam deleted the vs/hide_cancel_speedup_for_7702 branch March 19, 2026 15:01

github-actions bot locked and limited conversation to collaborators Mar 19, 2026

metamaskbot added the release-13.24.0 Issue or pull request that will be included in release 13.24.0 label Mar 19, 2026

Conversation

vinistevam commented Mar 11, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Mar 11, 2026

Uh oh!

metamaskbotv2 bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

Uh oh!

metamaskbotv2 bot commented Mar 11, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

metamaskbotv2 bot commented Mar 12, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Mar 12, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

sonarqubecloud bot commented Mar 19, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 bot commented Mar 19, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vinistevam commented Mar 11, 2026 •

edited by cursor bot

Loading

metamaskbotv2 bot commented Mar 11, 2026 •

edited

Loading