feat: Add perps live stream hooks via stream provider by gambinish · Pull Request #40779 · MetaMask/metamask-extension

gambinish · 2026-03-10T21:26:58Z

Description

Builds on #40769, which wired PerpsController into the background and established the PerpsStreamBridge. This PR adds the corresponding UI streaming layer that receives those background stream updates and distributes live data to components.

What's included:

ui/index.js — adds the perpsStreamUpdate handler routing background messages into getPerpsStreamManager()
PerpsStreamManager.ts — module-level singleton replacing the old mock-backed provider; fans out stream updates to subscribed channels
PerpsDataChannel.ts + CandleStreamChannel.ts — per-channel data abstractions
ui/selectors/perps-controller.ts — Redux selectors for flattened PerpsController state
usePerpsStreamManager, usePerpsTopOfBook — new stream hooks; existing hooks updated to consume the new provider
PerpsLayout — new layout wrapper for perpsInit on mount (consumed by routes in the next PR)
Deleted PerpsControllerProvider.mock.tsx + getPerpsController.mock.ts — old mock-backed files no longer needed
import/order lint fixes across ui/hooks/perps/ and ui/components/app/perps/

Changelog

CHANGELOG entry: Add perps live stream hooks to UI

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Introduces a new background-driven streaming/caching layer and changes subscription lifecycles (including multiplexed candle streams and view-activation gating), which could impact real-time Perps data freshness and cleanup behavior across navigation/account switches.

Overview
Adds a UI-side Perps streaming layer that consumes perpsStreamUpdate notifications and fans them out through a singleton PerpsStreamManager with cached, BehaviorSubject-like channels (positions/orders/account/fills/markets/prices/orderBook) plus a new multiplexed CandleStreamChannel supporting per-key subscribe/unsubscribe, throttling, and historical backfill.

Updates hooks and entry points to use the real stream manager (replacing mock exports), wires ui/index.js to route background updates into the manager, and adds PerpsLayout to signal perpsViewActive(true/false) so the background only emits while Perps routes are mounted.

Refines background PerpsStreamBridge candle handling so candle subscriptions are keyed by symbol+interval and perpsDeactivateCandleStream tears down only the specified stream; expands tests and adjusts Jest console baselines accordingly.

^{Written by Cursor Bugbot for commit 0def20b. This will update automatically on new commits. Configure here.}

…ring development

…rps-controller-infrastructure-stream

metamaskbotv2 · 2026-03-10T21:29:41Z

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/perps (17 files, +3355 -133)

📁 app/
- 📁 scripts/
  - 📁 controllers/
    - 📁 perps/
      - 📄 perps-stream-bridge.test.ts +41 -1
      - 📄 perps-stream-bridge.ts +46 -18
📁 ui/
- 📁 components/
  - 📁 app/
    - 📁 perps/
      - 📄 perps-tab-view.tsx +2 -3
- 📁 hooks/
  - 📁 perps/
    - 📁 stream/
      - 📄 index.ts +102 -4
      - 📄 usePerpsChannel.ts +29 -5
      - 📄 usePerpsStreamManager.ts +20 -17
      - 📄 usePerpsTopOfBook.ts +52 -53
- 📁 pages/
  - 📁 perps/
    - 📄 perps-layout.tsx +37 -0
- 📁 providers/
  - 📁 perps/
    - 📁 PerpsStreamManager/
      - 📄 index.ts +6 -4
      - 📄 CandleStreamChannel.test.ts +842 -0
      - 📄 CandleStreamChannel.ts +425 -0
      - 📄 index.mock.ts +1 -24
      - 📄 index.ts +49 -4
      - 📄 PerpsDataChannel.test.ts +401 -0
      - 📄 PerpsDataChannel.ts +212 -0
      - 📄 PerpsStreamManager.test.ts +560 -0
      - 📄 PerpsStreamManager.ts +530 -0

metamaskbotv2 · 2026-03-10T22:55:47Z

Builds ready [2c31bad]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 275 266 295 12 271 295
total 275 266 295 12 271 295
Confirm Tx confirm_tx 6053 6035 6068 12 6055 6068
total 6053 6035 6068 12 6055 6068
Bridge User Actions bridge_load_page 226 202 248 16 237 248
bridge_load_asset_picker 193 139 246 44 243 246
bridge_search_token 708 702 720 7 708 720
total 1136 1075 1230 69 1211 1230

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1496 1246 1980 111 1548 1672
load 1243 1022 1747 108 1301 1421
domContentLoaded 1234 1017 1679 102 1293 1397
domInteractive 30 17 119 22 25 92
firstPaint 164 72 1242 135 206 338
backgroundConnect 221 200 292 18 223 257
firstReactRender 20 14 44 6 21 32
initialActions 1 0 7 1 2 3
loadScripts 1032 820 1472 101 1096 1191
setupStore 14 7 34 6 17 25
numNetworkReqs 36 27 94 18 27 85
Power User Home uiStartup 5284 2118 11739 1767 6225 7993
load 1263 1124 1696 125 1314 1510
domContentLoaded 1244 1116 1688 119 1289 1482
domInteractive 35 19 185 25 31 77
firstPaint 210 79 1199 160 258 339
backgroundConnect 1803 308 6038 1466 2805 4331
firstReactRender 28 20 66 7 30 38
initialActions 1 0 5 1 1 3
loadScripts 1024 898 1446 107 1064 1241
setupStore 16 6 69 9 17 30
numNetworkReqs 156 63 315 43 172 252

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 218 219 1 219 219
srpButtonToSrpForm 98 94 103 4 103 103
confirmSrpToPwForm 23 22 25 1 24 25
pwFormToMetricsScreen 16 15 18 1 17 18
metricsToWalletReadyScreen 17 16 19 1 18 19
doneButtonToHomeScreen 653 600 715 48 704 715
openAccountMenuToAccountListLoaded 2933 2912 2953 15 2947 2953
total 3961 3887 4034 61 4023 4034
Onboarding New Wallet createWalletToSocialScreen 218 217 219 1 218 219
srpButtonToPwForm 108 106 109 1 108 109
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 35 34 35 1 35 35
agreeButtonToOnboardingSuccess 16 16 16 0 16 16
doneButtonToAssetList 592 480 709 89 642 709
total 977 869 1096 89 1024 1096
Asset Details assetClickToPriceChart 138 121 148 10 146 148
total 138 121 148 10 146 148
Solana Asset Details assetClickToPriceChart 88 78 98 8 93 98
total 88 78 98 8 93 98
Import Srp Home loginToHomeScreen 2266 2194 2340 57 2301 2340
openAccountMenuAfterLogin 65 60 71 4 66 71
homeAfterImportWithNewWallet 2344 2220 2484 108 2461 2484
total 4725 4474 5049 213 4891 5049
Send Transactions openSendPageFromHome 35 17 68 19 45 68
selectTokenToSendFormLoaded 20 19 20 0 20 20
reviewTransactionToConfirmationPage 908 846 1083 101 856 1083
total 954 885 1119 96 911 1119
Swap openSwapPageFromHome 25 18 34 6 27 34
fetchAndDisplaySwapQuotes 2685 2676 2694 6 2690 2694
total 2708 2698 2716 8 2716 2716

🌐 Dapp Page Load Benchmarks

Current Commit: 2c31bad | Date: 3/10/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.07s (±42ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 754ms (±63ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 86ms (±42ms) 🟢 | historical mean value: 82ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.07s	42ms	1.04s	1.40s	1.10s	1.40s
domContentLoaded	754ms	63ms	725ms	1.33s	778ms	1.33s
firstPaint	86ms	42ms	64ms	504ms	92ms	504ms
firstContentfulPaint	86ms	42ms	64ms	504ms	92ms	504ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 7.6 MiB (100%)
ui: 8.36 MiB (100%)
common: 11 MiB (100%)

ui/components/app/perps/perps-tab-view.tsx

ui/hooks/perps/stream/usePerpsTopOfBook.ts

ui/providers/perps/PerpsStreamManager.ts

ui/providers/perps/CandleStreamChannel.ts

ui/providers/perps/PerpsStreamManager.ts

…rolled format string Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 4 total unresolved issues (including 3 from previous reviews).

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

ui/hooks/perps/stream/usePerpsChannel.ts

sonarqubecloud · 2026-03-20T18:43:53Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
86.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-03-20T19:04:52Z

Builds ready [0def20b]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 290 265 318 22 314 318
total 290 265 318 22 314 318
Confirm Tx confirm_tx 6050 6035 6060 10 6056 6060
total 6050 6035 6060 10 6056 6060
Bridge User Actions bridge_load_page 240 206 265 21 259 265
bridge_load_asset_picker 228 184 261 34 257 261
bridge_search_token 749 709 770 24 766 770
total 1217 1155 1286 51 1255 1286

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1479 1256 2023 109 1503 1667
load 1225 1022 1666 98 1250 1417
domContentLoaded 1218 1017 1658 96 1245 1388
domInteractive 30 17 107 22 26 100
firstPaint 173 73 1212 159 217 365
backgroundConnect 222 203 275 12 228 243
firstReactRender 20 13 63 6 22 29
initialActions 1 0 5 1 2 3
loadScripts 1010 816 1449 95 1033 1180
setupStore 14 7 35 5 17 23
numNetworkReqs 40 31 87 16 37 77
Power User Home uiStartup 5706 1791 14942 2521 6370 10524
load 1308 1150 2215 172 1318 1669
domContentLoaded 1285 1136 2080 163 1296 1642
domInteractive 39 20 289 41 33 133
firstPaint 225 85 1254 140 279 396
backgroundConnect 1843 312 12374 2203 2750 6199
firstReactRender 23 17 41 5 25 33
initialActions 1 0 5 1 1 3
loadScripts 1057 916 1816 155 1063 1397
setupStore 16 6 72 9 17 32
numNetworkReqs 201 68 403 57 217 312

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 221 218 224 3 224 224
srpButtonToSrpForm 94 92 99 3 94 99
confirmSrpToPwForm 22 22 23 0 23 23
pwFormToMetricsScreen 15 15 15 0 15 15
metricsToWalletReadyScreen 16 15 17 1 17 17
doneButtonToHomeScreen 540 517 563 18 551 563
openAccountMenuToAccountListLoaded 3002 2927 3109 86 3106 3109
total 3957 3813 4068 100 4037 4068
Onboarding New Wallet createWalletToSocialScreen 217 216 218 1 218 218
srpButtonToPwForm 108 104 111 3 109 111
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 39 38 42 1 40 42
agreeButtonToOnboardingSuccess 16 15 16 0 16 16
doneButtonToAssetList 507 496 515 8 515 515
total 899 881 911 13 911 911
Asset Details assetClickToPriceChart 46 40 56 6 45 56
total 46 40 56 6 45 56
Solana Asset Details assetClickToPriceChart 178 165 191 11 186 191
total 178 165 191 11 186 191
Import Srp Home loginToHomeScreen 2321 2214 2464 90 2316 2464
openAccountMenuAfterLogin 63 45 89 16 66 89
homeAfterImportWithNewWallet 1551 312 2440 969 2353 2440
total 4022 2705 4795 917 4779 4795
Send Transactions openSendPageFromHome 29 23 43 8 26 43
selectTokenToSendFormLoaded 29 26 34 3 31 34
reviewTransactionToConfirmationPage 1237 997 1511 193 1411 1511
total 1311 1086 1586 198 1510 1586
Swap openSwapPageFromHome 98 28 139 40 124 139
fetchAndDisplaySwapQuotes 2695 2681 2707 9 2700 2707
total 2792 2725 2827 37 2823 2827

🌐 Dapp Page Load Benchmarks

Current Commit: 0def20b | Date: 3/20/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 988ms (±114ms) 🟢 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 698ms (±135ms) 🟢 | historical mean value: 731ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 97ms (±200ms) 🟢 | historical mean value: 86ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	988ms	114ms	953ms	2.09s	1.01s	2.09s
domContentLoaded	698ms	135ms	665ms	2.02s	708ms	2.02s
firstPaint	97ms	200ms	64ms	2.08s	88ms	2.08s
firstContentfulPaint	97ms	200ms	64ms	2.08s	88ms	2.08s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 322 Bytes (0%)
ui: 18.45 KiB (0.22%)
common: 20 Bytes (0%)

gambinish added 14 commits March 10, 2026 10:55

feat: add perps-controller as dependency, replace local alias used du…

2e7004a

…ring development

chore: cleanup jest.integration.config

02ae4c0

chore: dedupe

372e684

chore: restore baseline to main

d05810c

feat: integrate perps infrastructure and streaming bridge

c866a24

chore: update lavamoat

6f55a13

chore: udpate lavamoat

2278e59

Merge branch 'feat/integrate-perps-controller' into feat/integrate-pe…

12ea0a0

…rps-controller-infrastructure-stream

fix: lint

c5ed6ac

fix: lint

f637c4f

chore: address merge conflicst

5bd94b4

chore: lint

bf9f17c

feat: mock init

f0a058a

feat: Add live stream hooks via stream provider

7b00408

gambinish temporarily deployed to pr-comment March 10, 2026 21:27 — with GitHub Actions Inactive

metamaskbot added the team-perps Perps team label Mar 10, 2026

github-actions bot added the size-XL label Mar 10, 2026

chore: temporarily add back mocks for phased approach

351b8e8

gambinish temporarily deployed to pr-comment March 10, 2026 21:56 — with GitHub Actions Inactive

gambinish changed the title ~~feat: Add live stream hooks via stream provider~~ feat: Add perps live stream hooks via stream provider Mar 10, 2026

fix: lint

2c31bad

gambinish temporarily deployed to pr-comment March 10, 2026 22:19 — with GitHub Actions Inactive

gambinish temporarily deployed to pr-comment March 10, 2026 22:51 — with GitHub Actions Inactive

gambinish mentioned this pull request Mar 11, 2026

feat(temp): Perps Controller integration #40078

Closed

7 tasks

gambinish marked this pull request as ready for review March 11, 2026 01:19

gambinish requested a review from a team as a code owner March 11, 2026 01:19

gambinish temporarily deployed to pr-comment March 11, 2026 01:19 — with GitHub Actions Inactive

cursor bot reviewed Mar 11, 2026

View reviewed changes

Potential fix for code scanning alert no. 312: Use of externally-cont…

f6222db

…rolled format string Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

gambinish had a problem deploying to pr-comment March 20, 2026 17:22 — with GitHub Actions Error

Potential fix for code scanning alert no. 313: Use of externally-cont…

4193995

…rolled format string Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

gambinish temporarily deployed to pr-comment March 20, 2026 17:22 — with GitHub Actions Inactive

fix: syntax error

c7a6ed3

gambinish temporarily deployed to pr-comment March 20, 2026 17:32 — with GitHub Actions Inactive

cursor bot reviewed Mar 20, 2026

View reviewed changes

ui/hooks/perps/stream/usePerpsChannel.ts Outdated Show resolved Hide resolved

aganglada previously approved these changes Mar 20, 2026

View reviewed changes

gambinish had a problem deploying to pr-comment March 20, 2026 18:02 — with GitHub Actions Error

fix: lint

a2ea232

gambinish dismissed aganglada’s stale review via a2ea232 March 20, 2026 18:06

gambinish temporarily deployed to pr-comment March 20, 2026 18:06 — with GitHub Actions Inactive

fix: unit tests

630b446

gambinish temporarily deployed to pr-comment March 20, 2026 18:16 — with GitHub Actions Inactive

fix: update baseline

0def20b

gambinish temporarily deployed to pr-comment March 20, 2026 18:30 — with GitHub Actions Inactive

gambinish enabled auto-merge March 20, 2026 18:48

gambinish disabled auto-merge March 20, 2026 18:48

gambinish enabled auto-merge March 20, 2026 18:54

gambinish temporarily deployed to pr-comment March 20, 2026 19:00 — with GitHub Actions Inactive

aganglada approved these changes Mar 20, 2026

View reviewed changes

Matt561 approved these changes Mar 20, 2026

View reviewed changes

gambinish added this pull request to the merge queue Mar 20, 2026

Merged via the queue into main with commit 350d9a4 Mar 20, 2026
206 of 207 checks passed

gambinish deleted the feat/integrate-perps-controller-streaming-hooks branch March 20, 2026 19:53

github-actions bot locked and limited conversation to collaborators Mar 20, 2026

metamaskbot added the release-13.25.0 Issue or pull request that will be included in release 13.25.0 label Mar 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add perps live stream hooks via stream provider#40779

feat: Add perps live stream hooks via stream provider#40779
gambinish merged 98 commits intomainfrom
feat/integrate-perps-controller-streaming-hooks

gambinish commented Mar 10, 2026 •

edited by cursor bot

Loading

Uh oh!

metamaskbotv2 bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

metamaskbotv2 bot commented Mar 10, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Mar 20, 2026

Uh oh!

metamaskbotv2 bot commented Mar 20, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

gambinish commented Mar 10, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbotv2 bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbotv2 bot commented Mar 10, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Mar 20, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 bot commented Mar 20, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gambinish commented Mar 10, 2026 •

edited by cursor bot

Loading

metamaskbotv2 bot commented Mar 10, 2026 •

edited

Loading