fix: migration 196 remove exception missing nativeAssetIdentifiers by maxime-oe · Pull Request #40764 · MetaMask/metamask-extension

maxime-oe · 2026-03-10T17:19:40Z

Description

The PR fixes two cases that we treated as exception (expected to never happen) but are not:

Absence of the nativeAssetIdentifiers : This field was created recently (1-2 months ago) but I thought it would be initialized to an empty object for new users, but I didn't realize migrations actually run before controller init.
Absence of the NetworkEnablementController : That one confused me even more because I thought that a controller should always be assumed to be present. The NetworkEnablementController (as opposed to NetworkController) is fairly recent (7 months) and my understanding is that the message is triggered by old users.

Changelog

CHANGELOG entry: remove thrown exceptions in migration 196 when NetworkEnablementController is absent or NetworkEnablementController.nativeAssetIdentifiers is missing.

Related issues

Fixes: #40788

Manual testing steps

Go to this page...

(if we want to test it since it is a log message thing)

Reset data.
Find a version of the Extension prior the creation of NetworkEnablementController and install it.
Update to latest.
Check if the error message will appears in the logs.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: changes only reduce Sentry noise by no longer capturing exceptions for optional/missing migration state, without altering the actual migration transformation logic.

Overview
Migration 196 no longer calls captureException when NetworkEnablementController is absent or when NetworkEnablementController.nativeAssetIdentifiers is missing; it now silently no-ops in these cases while still reporting type mismatches.

Tests for migration 196 are updated to assert that no exception is captured for these missing-state scenarios.

^{Written by Cursor Bugbot for commit 4edc86c. This will update automatically on new commits. Configure here.}

github-actions · 2026-03-10T17:19:51Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-03-10T18:01:02Z

Builds ready [42d1696]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 282 271 291 8 290 291
total 282 271 291 8 290 291
Confirm Tx confirm_tx 6015 5977 6039 23 6038 6039
total 6015 5977 6039 23 6038 6039
Bridge User Actions bridge_load_page 206 192 226 12 213 226
bridge_load_asset_picker 232 190 277 37 272 277
bridge_search_token 745 702 782 35 774 782
total 1183 1087 1266 71 1243 1266

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1458 1207 1967 118 1519 1645
load 1210 1004 1673 103 1257 1378
domContentLoaded 1204 999 1657 102 1252 1363
domInteractive 30 17 92 18 27 78
firstPaint 162 73 1170 129 216 330
backgroundConnect 213 195 268 15 215 250
firstReactRender 20 13 50 7 21 33
initialActions 1 0 8 1 2 4
loadScripts 1008 804 1448 101 1062 1169
setupStore 13 6 37 6 15 22
numNetworkReqs 36 27 96 19 28 86
Power User Home uiStartup 4061 1883 14900 2824 4696 9899
load 1280 1097 1830 147 1306 1634
domContentLoaded 1260 1082 1730 139 1282 1607
domInteractive 45 20 346 49 35 162
firstPaint 234 88 1751 233 272 428
backgroundConnect 1371 278 7970 1798 1419 5669
firstReactRender 26 18 51 6 27 36
initialActions 1 0 6 1 1 2
loadScripts 1037 873 1475 128 1061 1341
setupStore 15 6 49 8 17 32
numNetworkReqs 117 46 243 43 130 222

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 218 220 0 220 220
srpButtonToSrpForm 97 93 100 3 97 100
confirmSrpToPwForm 22 22 23 0 22 23
pwFormToMetricsScreen 16 16 17 1 17 17
metricsToWalletReadyScreen 17 16 18 1 17 18
doneButtonToHomeScreen 613 596 634 16 624 634
openAccountMenuToAccountListLoaded 2935 2930 2941 4 2941 2941
total 3934 3927 3938 4 3936 3938
Onboarding New Wallet createWalletToSocialScreen 219 218 220 1 220 220
srpButtonToPwForm 109 105 111 2 111 111
createPwToRecoveryScreen 8 8 9 0 9 9
skipBackupToMetricsScreen 36 34 38 2 37 38
agreeButtonToOnboardingSuccess 17 17 17 0 17 17
doneButtonToAssetList 600 471 783 116 672 783
total 989 858 1178 118 1059 1178
Asset Details assetClickToPriceChart 132 126 135 4 135 135
total 132 126 135 4 135 135
Solana Asset Details assetClickToPriceChart 77 75 80 2 77 80
total 77 75 80 2 77 80
Import Srp Home loginToHomeScreen 1928 1876 1994 42 1926 1994
openAccountMenuAfterLogin 44 38 54 6 43 54
homeAfterImportWithNewWallet 1835 427 2814 858 2315 2814
total 3900 2391 5254 992 4363 5254
Send Transactions openSendPageFromHome 20 18 23 2 22 23
selectTokenToSendFormLoaded 20 18 21 1 20 21
reviewTransactionToConfirmationPage 846 846 848 1 847 848
total 886 884 891 3 886 891
Swap openSwapPageFromHome 26 21 32 4 27 32
fetchAndDisplaySwapQuotes 2688 2684 2691 2 2691 2691
total 2714 2705 2720 6 2718 2720

🌐 Dapp Page Load Benchmarks

Current Commit: 42d1696 | Date: 3/10/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±41ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 733ms (±39ms) 🟢 | historical mean value: 721ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 81ms (±14ms) 🟢 | historical mean value: 82ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	41ms	1.02s	1.36s	1.07s	1.36s
domContentLoaded	733ms	39ms	712ms	1.03s	756ms	1.03s
firstPaint	81ms	14ms	60ms	208ms	88ms	208ms
firstContentfulPaint	81ms	14ms	60ms	208ms	88ms	208ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: -64 Bytes (0%)
ui: 5 Bytes (0%)
common: 20 Bytes (0%)

sonarqubecloud · 2026-03-11T09:48:16Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-03-11T10:18:50Z

Builds ready [4edc86c]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 283 263 317 20 276 317
total 283 263 317 20 276 317
Confirm Tx confirm_tx 5994 5992 5996 2 5995 5996
total 5994 5992 5996 2 5995 5996
Bridge User Actions bridge_load_page 208 196 221 10 215 221
bridge_load_asset_picker 234 226 238 6 238 238
bridge_search_token 754 706 785 29 783 785
total 1218 1181 1238 23 1235 1238

🔌 Startup Benchmarks
⚠️ Missing data: chrome/browserify/startupPowerUserHome

Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1487 1289 1917 109 1557 1675
load 1234 1031 1601 105 1262 1417
domContentLoaded 1227 1023 1596 103 1257 1393
domInteractive 31 18 128 21 26 85
firstPaint 163 74 1403 146 205 301
backgroundConnect 218 196 280 12 222 244
firstReactRender 20 13 38 4 21 30
initialActions 1 0 7 1 1 4
loadScripts 1025 821 1392 102 1053 1196
setupStore 13 7 30 5 15 20
numNetworkReqs 36 27 93 19 27 86

🧭 User Journey Benchmarks
⚠️ Missing data: chrome/browserify/userJourneyAssets

Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 218 220 1 219 220
srpButtonToSrpForm 96 95 97 1 96 97
confirmSrpToPwForm 22 22 22 0 22 22
pwFormToMetricsScreen 15 15 15 0 15 15
metricsToWalletReadyScreen 16 15 16 0 16 16
doneButtonToHomeScreen 675 594 832 98 750 832
openAccountMenuToAccountListLoaded 2931 2905 2944 16 2944 2944
total 3994 3912 4105 85 4048 4105
Onboarding New Wallet createWalletToSocialScreen 217 216 217 1 217 217
srpButtonToPwForm 103 100 106 2 104 106
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 35 33 36 1 35 36
agreeButtonToOnboardingSuccess 15 15 16 0 15 16
doneButtonToAssetList 477 468 485 6 479 485
total 854 847 859 5 858 859
Import Srp Home loginToHomeScreen 2260 1992 2560 198 2394 2560
openAccountMenuAfterLogin 72 50 106 21 85 106
homeAfterImportWithNewWallet 2498 2395 2576 77 2575 2576
total 4829 4737 4917 74 4917 4917
Send Transactions openSendPageFromHome 33 26 42 6 37 42
selectTokenToSendFormLoaded 23 19 30 5 27 30
reviewTransactionToConfirmationPage 1017 847 1383 216 1150 1383
total 1081 891 1482 236 1221 1482
Swap openSwapPageFromHome 37 19 50 13 50 50
fetchAndDisplaySwapQuotes 2696 2687 2707 7 2702 2707
total 2733 2714 2749 13 2743 2749

🌐 Dapp Page Load Benchmarks

Current Commit: 4edc86c | Date: 3/11/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.07s (±76ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 758ms (±73ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 82ms (±11ms) 🟢 | historical mean value: 84ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.07s	76ms	1.02s	1.36s	1.30s	1.36s
domContentLoaded	758ms	73ms	714ms	1.04s	970ms	1.04s
firstPaint	82ms	11ms	64ms	176ms	92ms	176ms
firstContentfulPaint	82ms	11ms	64ms	176ms	92ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: -156 Bytes (0%)
ui: 5 Bytes (0%)
common: 20 Bytes (0%)

metamaskbotv2 · 2026-03-11T10:43:51Z

Builds ready [4edc86c]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 283 263 317 20 276 317
total 283 263 317 20 276 317
Confirm Tx confirm_tx 5994 5992 5996 2 5995 5996
total 5994 5992 5996 2 5995 5996
Bridge User Actions bridge_load_page 208 196 221 10 215 221
bridge_load_asset_picker 234 226 238 6 238 238
bridge_search_token 754 706 785 29 783 785
total 1218 1181 1238 23 1235 1238

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1487 1289 1917 109 1557 1675
load 1234 1031 1601 105 1262 1417
domContentLoaded 1227 1023 1596 103 1257 1393
domInteractive 31 18 128 21 26 85
firstPaint 163 74 1403 146 205 301
backgroundConnect 218 196 280 12 222 244
firstReactRender 20 13 38 4 21 30
initialActions 1 0 7 1 1 4
loadScripts 1025 821 1392 102 1053 1196
setupStore 13 7 30 5 15 20
numNetworkReqs 36 27 93 19 27 86
Power User Home uiStartup 5080 2116 15634 2543 6017 9067
load 1337 1155 2735 192 1375 1596
domContentLoaded 1319 1148 2635 183 1351 1575
domInteractive 33 20 119 19 32 66
firstPaint 214 79 1307 139 276 354
backgroundConnect 1905 304 12345 2148 2525 5107
firstReactRender 28 19 51 7 32 40
initialActions 1 0 4 1 1 3
loadScripts 1083 935 2338 165 1098 1310
setupStore 16 6 46 8 19 30
numNetworkReqs 135 68 268 43 143 236

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 218 220 1 219 220
srpButtonToSrpForm 96 95 97 1 96 97
confirmSrpToPwForm 22 22 22 0 22 22
pwFormToMetricsScreen 15 15 15 0 15 15
metricsToWalletReadyScreen 16 15 16 0 16 16
doneButtonToHomeScreen 675 594 832 98 750 832
openAccountMenuToAccountListLoaded 2931 2905 2944 16 2944 2944
total 3994 3912 4105 85 4048 4105
Onboarding New Wallet createWalletToSocialScreen 217 216 217 1 217 217
srpButtonToPwForm 103 100 106 2 104 106
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 35 33 36 1 35 36
agreeButtonToOnboardingSuccess 15 15 16 0 15 16
doneButtonToAssetList 477 468 485 6 479 485
total 854 847 859 5 858 859
Asset Details assetClickToPriceChart 123 96 142 20 138 142
total 123 96 142 20 138 142
Solana Asset Details assetClickToPriceChart 78 76 79 1 79 79
total 78 76 79 1 79 79
Import Srp Home loginToHomeScreen 2260 1992 2560 198 2394 2560
openAccountMenuAfterLogin 72 50 106 21 85 106
homeAfterImportWithNewWallet 2498 2395 2576 77 2575 2576
total 4829 4737 4917 74 4917 4917
Send Transactions openSendPageFromHome 33 26 42 6 37 42
selectTokenToSendFormLoaded 23 19 30 5 27 30
reviewTransactionToConfirmationPage 1017 847 1383 216 1150 1383
total 1081 891 1482 236 1221 1482
Swap openSwapPageFromHome 37 19 50 13 50 50
fetchAndDisplaySwapQuotes 2696 2687 2707 7 2702 2707
total 2733 2714 2749 13 2743 2749

🌐 Dapp Page Load Benchmarks

Current Commit: 4edc86c | Date: 3/11/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.07s (±76ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 758ms (±73ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 82ms (±11ms) 🟢 | historical mean value: 84ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.07s	76ms	1.02s	1.36s	1.30s	1.36s
domContentLoaded	758ms	73ms	714ms	1.04s	970ms	1.04s
firstPaint	82ms	11ms	64ms	176ms	92ms	176ms
firstContentfulPaint	82ms	11ms	64ms	176ms	92ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: -156 Bytes (0%)
ui: 5 Bytes (0%)
common: 20 Bytes (0%)

maxime-oe temporarily deployed to pr-comment March 10, 2026 17:19 — with GitHub Actions Inactive

metamaskbot added the team-networks PRs from the Networks team label Mar 10, 2026

github-actions bot added the size-S label Mar 10, 2026

maxime-oe temporarily deployed to pr-comment March 10, 2026 17:48 — with GitHub Actions Inactive

maxime-oe force-pushed the fix/remove-exception-migration-196-missing-nativeAssetIdentifiers branch from 42d1696 to f81faf5 Compare March 11, 2026 09:17

maxime-oe temporarily deployed to pr-comment March 11, 2026 09:17 — with GitHub Actions Inactive

maxime-oe marked this pull request as ready for review March 11, 2026 09:26

maxime-oe temporarily deployed to pr-comment March 11, 2026 09:26 — with GitHub Actions Inactive

fix: migration 196 remove exception missing nativeAssetIdentifiers

4edc86c

maxime-oe force-pushed the fix/remove-exception-migration-196-missing-nativeAssetIdentifiers branch from f81faf5 to 4edc86c Compare March 11, 2026 09:31

maxime-oe temporarily deployed to pr-comment March 11, 2026 09:31 — with GitHub Actions Inactive

Prithpal-Sooriya approved these changes Mar 11, 2026

View reviewed changes

wantedsystem approved these changes Mar 11, 2026

View reviewed changes

maxime-oe temporarily deployed to pr-comment March 11, 2026 10:11 — with GitHub Actions Inactive

maxime-oe temporarily deployed to pr-comment March 11, 2026 10:38 — with GitHub Actions Inactive

davidmurdoch added this pull request to the merge queue Mar 11, 2026

Merged via the queue into main with commit c4b8960 Mar 11, 2026
344 of 348 checks passed

davidmurdoch deleted the fix/remove-exception-migration-196-missing-nativeAssetIdentifiers branch March 11, 2026 16:58

github-actions bot locked and limited conversation to collaborators Mar 11, 2026

metamaskbot added the release-13.23.0 Issue or pull request that will be included in release 13.23.0 label Mar 11, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: migration 196 remove exception missing nativeAssetIdentifiers#40764

fix: migration 196 remove exception missing nativeAssetIdentifiers#40764
davidmurdoch merged 1 commit intomainfrom
fix/remove-exception-migration-196-missing-nativeAssetIdentifiers

maxime-oe commented Mar 10, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 10, 2026

Uh oh!

metamaskbotv2 bot commented Mar 10, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud bot commented Mar 11, 2026

Uh oh!

metamaskbotv2 bot commented Mar 11, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Mar 11, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

maxime-oe commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Mar 10, 2026

Uh oh!

metamaskbotv2 bot commented Mar 10, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud bot commented Mar 11, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 bot commented Mar 11, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Mar 11, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

maxime-oe commented Mar 10, 2026 •

edited

Loading