feat: enhance speed up and cancel logic by vinistevam · Pull Request #40734 · MetaMask/metamask-extension

vinistevam · 2026-03-10T06:34:08Z

Description

This PR modernizes the cancel/speed-up transaction UI to use the same GasFeeModal context and gas-details patterns as the main confirmation flow, and fixes the "useConfirmContext must be used within ConfirmContextProvider" error when opening the gas modal from cancel-speedup.

What was done

GasFeeModal context: Extended with optional transactionMeta and editGasMode. GasFeeModalWrapper wraps modal content in ConfirmContextProvider with currentConfirmationOverride={transactionMeta} when opened from cancel-speedup so gas modals can use useConfirmContext().
Cancel-speedup: Removed GasFeeContextProvider. Uses GasFeeModalContextProvider(transactionMeta, editGasMode), useCancelSpeedupGasState, and useCancelSpeedupInitialGas. Renders shared gas UI (e.g. GasFeesSection) and opens the gas modal via context.
Gas modals/hooks: AdvancedEIP1559Modal, AdvancedGasPriceModal, and useGasFeeEstimateLevelOptions use useConfirmContext() again; no useTransactionForGasModal in the modal flow.
Confirm context: ConfirmContextProvider supports optional currentConfirmationOverride; when set, route sync and navigate-on-dismiss are skipped so the gas modal can be used outside the confirm route.
Hooks: useCancelSpeedupGasState provides effective transaction and actions; useCancelSpeedupInitialGas runs the initial gas rule (medium vs tenPercentIncreased) when the cancel-speedup modal is open.

Changelog

CHANGELOG entry: Fixed gas edit opening from cancel/speed-up transaction flow and aligned cancel-speedup gas UI with the main confirmation flow.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/7051

Manual testing steps

Start the extension and have a pending transaction.
Open Activity, open the cancel or speed-up action for that transaction so the cancel-speedup modal is shown.
Click the Edit (gas) icon/button.
Confirm the gas modal opens with no error.
Change gas option or open advanced gas, save/cancel, and confirm behavior is correct.
Confirm the initial gas selection (medium vs +10%) still applies when the cancel-speedup modal first opens.

Screenshots/Recordings

cancel_new_ex.webm

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches transaction replacement gas calculation and confirmation/gas modal context wiring; mistakes could cause underpriced replacements or broken cancel/speed-up UX, but changes are localized and well-covered by tests.

Overview
Modernizes the cancel/speed-up transaction modal to use the shared confirmation gas modal flow. The cancel/speed-up UI now uses GasFeeModalContextProvider + GasFeeModalWrapper, shared fee display hooks (useFeeCalculations, useEIP1559TxFees), and new hooks (useCancelSpeedupGasState, useCancelSpeedupInitialGas) instead of the legacy GasFeeContextProvider/inline logic.

Fixes gas modal usage outside the confirm route. ConfirmContextProvider now supports currentConfirmationOverride, and GasFeeModalWrapper wraps the modal in ConfirmContextProvider when opened from cancel/speed-up, preventing useConfirmContext errors; related gas UI components add fallback estimate sourcing and safer optional context access.

Hardens replacement transaction gas pricing. Adds getGasValuesForReplacement and updates useTransactionFunctions to ensure cancel/speed-up transactions use at least previousGas × CANCEL_RATE/SPEED_UP_RATE, while persisting previousGas when the modal opens and disabling confirm until it exists.

Tests and policy updates. Updates/extends unit tests and E2E page objects/specs for the new modal behavior and labels (e.g. "Site suggested"), and expands LavaMoat MV3 policies to allow new controller dependencies (@metamask/gas-fee-controller, @metamask/polling-controller, nonce-tracker deps).

^{Written by Cursor Bugbot for commit 6475ccd. This will update automatically on new commits. Configure here.}

github-actions · 2026-03-10T06:34:16Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-03-10T06:34:52Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (20 files, +601 -250)

📁 ui/
- 📁 pages/
  - 📁 confirmations/
    - 📁 cancel-speedup/
      - 📄 cancel-speedup.test.tsx +93 -52
      - 📄 cancel-speedup.tsx +115 -137
    - 📁 components/
      - 📁 confirm/
        
        📁 info/
        
        📁 hooks/
        
        📄 useFeeCalculations.test.ts +1 -1
        
        📄 useFeeCalculations.ts +5 -2
      - 📁 edit-gas-fee-popover/
        
        📁 network-statistics/
        
        📁 status-slider/
        
        📄 status-slider.js +10 -3
        
        📄 status-slider.test.js +14 -3
        
        📄 network-statistics.js +13 -2
        
        📄 network-statistics.test.js +63 -0
        
        📄 edit-gas-fee-popover.stories.tsx +32 -13
        
        📄 edit-gas-fee-popover.test.js +4 -0
      - 📁 gas-timing/
        
        📄 gas-timing.component.js +28 -5
        
        📄 gas-timing.component.test.js +73 -1
      - 📁 modals/
        
        📁 advanced-eip1559-modal/
        
        📄 advanced-eip1559-modal.tsx +14 -7
        
        📁 advanced-gas-price-modal/
        
        📄 advanced-gas-price-modal.tsx +10 -5
        
        📁 gas-fee-modal/
        
        📄 gas-fee-modal.tsx +0 -1
    - 📁 context/
      - 📁 confirm/
        
        📄 index.tsx +15 -3
      - 📁 dapp-swap/
        
        📄 index.tsx +8 -0
      - 📁 gas-fee-modal/
        
        📄 index.tsx +48 -5
    - 📁 hooks/
      - 📁 gas/
        
        📄 useGasFeeEstimateLevelOptions.test.ts +26 -4
        
        📄 useGasFeeEstimateLevelOptions.ts +29 -6

👨‍🔧 @MetaMask/core-extension-ux (1 files, +1 -13)

📁 ui/
- 📁 components/
  - 📁 app/
    - 📁 transaction-list-item/
      - 📄 transaction-list-item.component.js +1 -13

📜 @MetaMask/policy-reviewers (4 files, +308 -4)

📁 lavamoat/
- 📁 webpack/
  - 📁 mv3/
    - 📁 beta/
      - 📄 policy.json +77 -1
    - 📁 experimental/
      - 📄 policy.json +77 -1
    - 📁 flask/
      - 📄 policy.json +77 -1
    - 📁 main/
      - 📄 policy.json +77 -1

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

🧪 @MetaMask/qa (2 files, +87 -9)

📁 test/
- 📁 e2e/
  - 📁 page-objects/
    - 📁 pages/
      - 📁 confirmations/
        
        📄 speed-up-and-cancel-modal.ts +87 -0
      - 📁 home/
        
        📄 activity-list.ts +0 -9

metamaskbotv2 · 2026-03-10T07:11:12Z

Builds ready [d67145b]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 319 278 364 38 350 364
total 319 278 364 38 350 364
Confirm Tx confirm_tx 6161 6147 6169 10 6169 6169
total 6161 6147 6169 10 6169 6169
Bridge User Actions bridge_load_page 262 214 292 30 283 292
bridge_load_asset_picker 221 167 278 37 237 278
bridge_search_token 736 716 751 13 750 751
total 1227 1210 1246 15 1246 1246

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1429 1194 1994 117 1488 1615
load 1195 999 1666 101 1249 1350
domContentLoaded 1188 995 1654 101 1244 1341
domInteractive 29 17 122 19 25 71
firstPaint 159 70 1193 130 211 278
backgroundConnect 213 194 262 13 215 243
firstReactRender 19 12 46 5 21 29
initialActions 1 0 5 1 2 4
loadScripts 992 804 1446 100 1044 1146
setupStore 13 6 36 5 15 21
numNetworkReqs 31 22 95 20 22 84
Power User Home uiStartup 2034 1679 2625 170 2118 2344
load 1189 1048 1890 173 1170 1701
domContentLoaded 1173 1035 1786 164 1154 1658
domInteractive 39 20 186 29 38 108
firstPaint 196 76 1802 187 228 363
backgroundConnect 306 263 488 33 317 365
firstReactRender 25 17 62 8 27 39
initialActions 1 0 8 1 1 3
loadScripts 954 827 1540 158 936 1430
setupStore 17 8 54 7 19 31
numNetworkReqs 78 36 284 52 84 172

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 217 222 2 220 222
srpButtonToSrpForm 96 94 99 2 96 99
confirmSrpToPwForm 22 22 23 1 23 23
pwFormToMetricsScreen 16 16 17 0 16 17
metricsToWalletReadyScreen 17 17 17 0 17 17
doneButtonToHomeScreen 664 598 736 61 714 736
openAccountMenuToAccountListLoaded 2939 2932 2947 6 2947 2947
total 4012 3922 4124 75 4055 4124
Onboarding New Wallet createWalletToSocialScreen 220 218 222 2 221 222
srpButtonToPwForm 107 105 108 1 108 108
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 35 34 36 1 36 36
agreeButtonToOnboardingSuccess 16 15 16 0 16 16
doneButtonToAssetList 713 483 1049 225 911 1049
total 1100 870 1433 223 1295 1433
Asset Details assetClickToPriceChart 132 105 167 22 138 167
total 132 105 167 22 138 167
Solana Asset Details assetClickToPriceChart 78 70 83 5 83 83
total 78 70 83 5 83 83
Import Srp Home loginToHomeScreen 2176 2002 2476 188 2320 2476
openAccountMenuAfterLogin 63 38 90 19 72 90
homeAfterImportWithNewWallet 2401 2290 2512 80 2439 2512
total 4641 4435 4923 199 4836 4923
Send Transactions openSendPageFromHome 20 13 33 7 24 33
selectTokenToSendFormLoaded 19 18 20 1 19 20
reviewTransactionToConfirmationPage 866 845 902 23 884 902
total 905 883 933 19 919 933
Swap openSwapPageFromHome 53 19 79 21 72 79
fetchAndDisplaySwapQuotes 2682 2680 2684 2 2682 2684
total 2746 2736 2759 10 2754 2759

🌐 Dapp Page Load Benchmarks

Current Commit: d67145b | Date: 3/10/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±44ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 739ms (±41ms) 🟢 | historical mean value: 740ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 81ms (±11ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	44ms	1.02s	1.37s	1.09s	1.37s
domContentLoaded	739ms	41ms	714ms	1.04s	768ms	1.04s
firstPaint	81ms	11ms	64ms	176ms	88ms	176ms
firstContentfulPaint	81ms	11ms	64ms	176ms	88ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 5.15 MiB (100%)
ui: 8.2 MiB (100%)
common: 10.99 MiB (100%)

metamaskbotv2 · 2026-03-10T10:55:19Z

Builds ready [f8b973b]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
lavamoat build viz: Build System
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 286 265 304 15 294 304
total 286 265 304 15 294 304
Confirm Tx confirm_tx 6031 6004 6069 25 6052 6069
total 6031 6004 6069 25 6052 6069
Bridge User Actions bridge_load_page 221 195 259 26 246 259
bridge_load_asset_picker 208 176 254 28 225 254
bridge_search_token 741 700 786 35 770 786
total 1170 1082 1241 70 1235 1241

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1421 1232 1917 112 1453 1624
load 1183 1010 1601 95 1217 1362
domContentLoaded 1176 993 1565 93 1212 1340
domInteractive 28 18 86 16 25 77
firstPaint 164 69 1372 177 197 296
backgroundConnect 211 193 262 12 212 241
firstReactRender 18 13 30 3 20 23
initialActions 1 0 7 1 2 4
loadScripts 981 802 1356 90 1013 1141
setupStore 13 7 47 6 15 21
numNetworkReqs 31 22 89 19 22 82
Power User Home uiStartup 3102 1718 13168 2075 3867 4995
load 1294 1104 1840 171 1352 1678
domContentLoaded 1273 1091 1827 164 1329 1630
domInteractive 37 19 159 26 35 114
firstPaint 244 78 1840 231 302 384
backgroundConnect 1050 272 10823 1652 1201 2943
firstReactRender 26 17 66 8 27 40
initialActions 1 0 5 1 1 4
loadScripts 1047 880 1604 157 1094 1368
setupStore 15 7 37 5 18 26
numNetworkReqs 87 36 215 44 104 178

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 216 223 2 219 223
srpButtonToSrpForm 93 92 94 1 93 94
confirmSrpToPwForm 22 21 23 1 22 23
pwFormToMetricsScreen 15 15 16 0 15 16
metricsToWalletReadyScreen 16 15 17 1 16 17
doneButtonToHomeScreen 628 589 714 48 644 714
openAccountMenuToAccountListLoaded 2907 2894 2936 17 2902 2936
total 3881 3853 3925 29 3889 3925
Onboarding New Wallet createWalletToSocialScreen 220 218 222 1 221 222
srpButtonToPwForm 109 107 111 1 110 111
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 35 33 37 1 36 37
agreeButtonToOnboardingSuccess 16 15 17 0 16 17
doneButtonToAssetList 555 473 676 75 603 676
total 945 864 1064 75 994 1064
Asset Details assetClickToPriceChart 128 109 161 19 135 161
total 128 109 161 19 135 161
Solana Asset Details assetClickToPriceChart 81 75 88 5 83 88
total 81 75 88 5 83 88
Import Srp Home loginToHomeScreen 2035 1961 2097 55 2096 2097
openAccountMenuAfterLogin 68 65 73 4 70 73
homeAfterImportWithNewWallet 2484 2360 2611 86 2542 2611
total 4583 4485 4755 103 4646 4755
Send Transactions openSendPageFromHome 34 21 57 13 39 57
selectTokenToSendFormLoaded 19 17 21 2 19 21
reviewTransactionToConfirmationPage 846 845 847 1 847 847
total 893 889 904 6 892 904
Swap openSwapPageFromHome 36 27 43 6 43 43
fetchAndDisplaySwapQuotes 2699 2682 2718 14 2711 2718
total 2735 2725 2744 8 2743 2744

🌐 Dapp Page Load Benchmarks

Current Commit: f8b973b | Date: 3/10/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±43ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 749ms (±40ms) 🟢 | historical mean value: 735ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 83ms (±11ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	43ms	1.03s	1.36s	1.11s	1.36s
domContentLoaded	749ms	40ms	721ms	1.03s	778ms	1.03s
firstPaint	83ms	11ms	68ms	176ms	100ms	176ms
firstContentfulPaint	83ms	11ms	68ms	176ms	100ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 5.15 MiB (100%)
ui: 8.22 MiB (100%)
common: 10.99 MiB (100%)

metamaskbotv2 · 2026-03-10T11:43:36Z

Builds ready [3d4bdab]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
lavamoat build viz: Build System
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 278 273 282 3 279 282
total 278 273 282 3 279 282
Confirm Tx confirm_tx 6066 6037 6084 19 6081 6084
total 6066 6037 6084 19 6081 6084
Bridge User Actions bridge_load_page 212 209 216 3 216 216
bridge_load_asset_picker 193 179 203 10 203 203
bridge_search_token 716 710 720 4 717 720
total 1113 1108 1122 5 1113 1122

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1454 1207 1885 115 1513 1648
load 1216 1008 1665 106 1273 1382
domContentLoaded 1206 1000 1570 100 1266 1362
domInteractive 30 16 120 20 25 79
firstPaint 155 70 490 81 210 282
backgroundConnect 220 197 400 28 223 262
firstReactRender 21 11 159 15 22 34
initialActions 1 0 8 1 2 4
loadScripts 1007 806 1359 99 1065 1161
setupStore 13 7 32 5 15 21
numNetworkReqs 31 22 87 19 25 82
Power User Home uiStartup 2413 1692 11223 1377 2270 4470
load 1198 1037 1721 162 1208 1598
domContentLoaded 1181 1028 1702 153 1196 1551
domInteractive 38 20 159 22 38 83
firstPaint 171 75 457 83 230 315
backgroundConnect 521 261 5859 919 334 1596
firstReactRender 26 17 154 15 27 40
initialActions 1 0 8 1 1 3
loadScripts 965 815 1472 144 984 1329
setupStore 16 6 48 7 17 30
numNetworkReqs 77 36 240 49 79 185

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 217 221 2 221 221
srpButtonToSrpForm 98 96 99 1 98 99
confirmSrpToPwForm 22 22 23 1 23 23
pwFormToMetricsScreen 16 15 16 0 16 16
metricsToWalletReadyScreen 17 16 17 1 17 17
doneButtonToHomeScreen 653 599 722 48 679 722
openAccountMenuToAccountListLoaded 2931 2919 2936 7 2935 2936
total 3950 3906 4029 50 3958 4029
Onboarding New Wallet createWalletToSocialScreen 219 217 219 1 219 219
srpButtonToPwForm 109 103 114 4 111 114
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 36 35 38 1 36 38
agreeButtonToOnboardingSuccess 16 15 17 1 16 17
doneButtonToAssetList 641 618 663 18 653 663
total 1027 1000 1051 19 1037 1051
Asset Details assetClickToPriceChart 133 112 163 18 137 163
total 133 112 163 18 137 163
Solana Asset Details assetClickToPriceChart 94 79 122 16 104 122
total 94 79 122 16 104 122
Import Srp Home loginToHomeScreen 1902 1863 1973 44 1902 1973
openAccountMenuAfterLogin 52 37 70 14 67 70
homeAfterImportWithNewWallet 2613 2395 2985 215 2699 2985
total 4673 4368 4930 217 4871 4930
Send Transactions openSendPageFromHome 23 18 32 6 27 32
selectTokenToSendFormLoaded 19 18 19 0 19 19
reviewTransactionToConfirmationPage 994 848 1115 119 1081 1115
total 1036 885 1165 119 1119 1165
Swap openSwapPageFromHome 24 20 27 2 25 27
fetchAndDisplaySwapQuotes 2687 2681 2693 4 2689 2693
total 2709 2704 2714 4 2712 2714

🌐 Dapp Page Load Benchmarks

Current Commit: 3d4bdab | Date: 3/10/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±42ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 733ms (±38ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 82ms (±11ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	42ms	1.02s	1.33s	1.09s	1.33s
domContentLoaded	733ms	38ms	709ms	1.00s	778ms	1.00s
firstPaint	82ms	11ms	68ms	176ms	92ms	176ms
firstContentfulPaint	82ms	11ms	68ms	176ms	92ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 5.15 MiB (100%)
ui: 8.22 MiB (100%)
common: 10.99 MiB (100%)

ui/pages/confirmations/hooks/useCancelSpeedupInitialGas.ts

ui/pages/confirmations/cancel-speedup/cancel-speedup.test.tsx

cryptotavares · 2026-03-10T14:56:02Z

Review — posted on behalf of @cryptotavares

I reviewed this PR as part of tracking Q1 confirmation work. Architecture in issue-7051 was written by the implementor and has no recorded team sign-off or discussion comments. The spec is detailed, but there is no evidence of collaborative pre-approval before 4 reviewer teams were engaged. The confirmations team review is especially critical here.

Beyond the process concern, the diff contains two bugs that I believe will block users from submitting cancel/speedup on production:

BUG 1 — HIGH: EIP-1559 cancel/speedup confirm button permanently disabled

File: ui/pages/confirmations/hooks/useCancelSpeedupInitialGas.ts (approx. line 70)

const hasEIP1559Gas =
  txParams?.maxFeePerGas &&
  txParams?.maxPriorityFeePerGas &&
  txParams?.gasLimit;   // ← wrong field

txParams.gasLimit is typically undefined on real transactions — the field is txParams.gas. Because hasEIP1559Gas evaluates falsy, updatePreviousGasParams is never dispatched, effectiveTransaction.previousGas is never populated, and the Confirm button (disabled={!effectiveTransaction.previousGas}) stays permanently disabled for EIP-1559 transactions.

The fix is already demonstrated elsewhere in the same PR (useCancelSpeedupGasState.ts uses txParams?.gasLimit ?? txParams?.gas correctly). The guard should be:

txParams?.gasLimit ?? txParams?.gas

BUG 2 — HIGH: Legacy (non-EIP-1559) cancel/speedup always blocked

Same hasEIP1559Gas path: for gasPrice-only transactions (BSC, any non-EIP-1559 network), maxFeePerGas and maxPriorityFeePerGas are absent, so the condition is always falsy, previousGas is never set, and the Confirm button is permanently disabled. Users on non-EIP-1559 chains cannot cancel or speed up transactions at all after this PR.

A separate path is needed to set previousGas for legacy transactions using gasPrice.

BUG 3 — MEDIUM: Tests assert known-wrong fee values

File: ui/pages/confirmations/cancel-speedup/cancel-speedup.test.tsx (approx. lines 423–424)

The test file contains inline comments acknowledging that the expected fee constants are incorrect (the author notes the intended values should be higher). Merging these tests locks in a broken fee display as the regression baseline. Either fix the underlying fee calculation and update the constants, or do not assert specific fee strings until the logic is correct.

Minor: Dead state

File: ui/pages/confirmations/hooks/useCancelSpeedupGasState.ts (approx. line 2023)

retryTxMeta state is written but never read — effectiveTransaction is derived entirely from Redux. Cosmetic, but could mislead maintainers.

Bugs 1 and 2 together mean the cancel/speedup flow would be broken for all users on both EIP-1559 and legacy networks. Would recommend blocking merge until these are resolved.

ui/pages/confirmations/hooks/useCancelSpeedupGasState.ts

ui/pages/confirmations/components/gas-timing/gas-timing.component.js

metamaskbot · 2026-03-20T10:46:39Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

✅ lavamoat/browserify/beta/policy.json changes match main/policy.json policy changes
✅ lavamoat/browserify/experimental/policy.json changes match main/policy.json policy changes
✅ lavamoat/browserify/flask/policy.json changes match main/policy.json policy changes
✅ lavamoat/webpack/mv2/beta/policy.json changes match mv2/main/policy.json policy changes
✅ lavamoat/webpack/mv2/experimental/policy.json changes match mv2/main/policy.json policy changes
✅ lavamoat/webpack/mv2/flask/policy.json changes match mv2/main/policy.json policy changes
👀 lavamoat/webpack/mv3/beta/policy.json changes differ from mv3/main/policy.json policy changes
👀 lavamoat/webpack/mv3/experimental/policy.json changes differ from mv3/main/policy.json policy changes
👀 lavamoat/webpack/mv3/flask/policy.json changes differ from mv3/main/policy.json policy changes

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

ui/pages/confirmations/hooks/useCancelSpeedupInitialGas.ts

sonarqubecloud · 2026-03-20T11:00:54Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-03-20T11:24:16Z

Builds ready [6475ccd]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
lavamoat build viz: Build System
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 366 266 517 92 348 517
total 366 266 517 92 348 517
Confirm Tx confirm_tx 6053 6045 6065 8 6055 6065
total 6053 6045 6065 8 6055 6065
Bridge User Actions bridge_load_page 238 214 258 17 250 258
bridge_load_asset_picker 194 168 215 19 215 215
bridge_search_token 734 721 748 10 739 748
total 1164 1139 1194 20 1165 1194

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1470 1229 1980 107 1505 1641
load 1220 1012 1682 100 1252 1385
domContentLoaded 1213 1009 1675 98 1248 1377
domInteractive 30 17 135 20 27 80
firstPaint 161 74 440 80 213 282
backgroundConnect 219 202 269 13 221 242
firstReactRender 19 13 34 4 21 27
initialActions 1 0 6 1 2 3
loadScripts 1011 800 1464 98 1046 1173
setupStore 14 7 37 5 15 22
numNetworkReqs 39 31 86 16 40 80
Power User Home uiStartup 5888 2225 15083 2566 6766 11139
load 1356 1175 1918 136 1384 1664
domContentLoaded 1338 1161 1904 133 1361 1638
domInteractive 44 19 370 54 34 143
firstPaint 283 95 1648 205 316 532
backgroundConnect 2543 293 11505 2306 3644 6746
firstReactRender 24 16 41 5 25 35
initialActions 1 0 8 1 1 4
loadScripts 1102 946 1626 126 1130 1402
setupStore 16 8 87 9 17 28
numNetworkReqs 240 88 459 77 299 347

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 218 220 1 220 220
srpButtonToSrpForm 93 91 95 1 94 95
confirmSrpToPwForm 22 22 23 0 22 23
pwFormToMetricsScreen 15 15 16 0 15 16
metricsToWalletReadyScreen 16 16 16 0 16 16
doneButtonToHomeScreen 519 408 610 72 539 610
openAccountMenuToAccountListLoaded 3061 2896 3140 97 3110 3140
total 3941 3780 4084 103 4012 4084
Onboarding New Wallet createWalletToSocialScreen 219 219 219 0 219 219
srpButtonToPwForm 109 107 110 1 109 110
createPwToRecoveryScreen 9 8 9 0 9 9
skipBackupToMetricsScreen 41 38 45 3 43 45
agreeButtonToOnboardingSuccess 16 15 17 1 16 17
doneButtonToAssetList 591 516 665 56 621 665
total 985 913 1053 54 1019 1053
Asset Details assetClickToPriceChart 55 49 59 5 59 59
total 55 49 59 5 59 59
Solana Asset Details assetClickToPriceChart 103 47 150 37 134 150
total 103 47 150 37 134 150
Import Srp Home loginToHomeScreen 2349 2281 2400 52 2400 2400
openAccountMenuAfterLogin 59 58 59 1 59 59
homeAfterImportWithNewWallet 383 302 453 54 395 453
total 3345 2767 4717 748 3577 4717
Send Transactions openSendPageFromHome 28 25 33 3 27 33
selectTokenToSendFormLoaded 35 34 38 1 36 38
reviewTransactionToConfirmationPage 1152 906 1688 299 1272 1688
total 1221 970 1766 302 1333 1766
Swap openSwapPageFromHome 124 99 157 24 135 157
fetchAndDisplaySwapQuotes 2704 2691 2714 9 2712 2714
total 2825 2802 2861 22 2826 2861

🌐 Dapp Page Load Benchmarks

Current Commit: 6475ccd | Date: 3/20/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±44ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 739ms (±41ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 81ms (±9ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	44ms	1.02s	1.37s	1.09s	1.37s
domContentLoaded	739ms	41ms	716ms	1.04s	772ms	1.04s
firstPaint	81ms	9ms	64ms	160ms	88ms	160ms
firstContentfulPaint	81ms	9ms	64ms	160ms	88ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 58 Bytes (0%)
ui: -46.23 KiB (-0.54%)
common: 20 Bytes (0%)

feat: enhance speed up and cancel logic

d67145b

vinistevam added the team-confirmations Push issues to confirmations team label Mar 10, 2026

vinistevam temporarily deployed to pr-comment March 10, 2026 06:34 — with GitHub Actions Inactive

github-actions bot added the size-XL label Mar 10, 2026

applied suggestions

9872a76

vinistevam temporarily deployed to pr-comment March 10, 2026 07:06 — with GitHub Actions Inactive

vinistevam added 2 commits March 10, 2026 09:58

apply suggestion

11b1a58

update policy

f8b973b

vinistevam temporarily deployed to pr-comment March 10, 2026 10:21 — with GitHub Actions Inactive

vinistevam temporarily deployed to pr-comment March 10, 2026 10:50 — with GitHub Actions Inactive

fix unit tests

3d4bdab

vinistevam temporarily deployed to pr-comment March 10, 2026 11:11 — with GitHub Actions Inactive

vinistevam temporarily deployed to pr-comment March 10, 2026 11:38 — with GitHub Actions Inactive

vinistevam marked this pull request as ready for review March 10, 2026 12:32

vinistevam requested review from a team as code owners March 10, 2026 12:32

vinistevam temporarily deployed to pr-comment March 10, 2026 12:32 — with GitHub Actions Inactive

vinistevam mentioned this pull request Mar 10, 2026

fix: enhance speed up and cancel logic #40396

Closed

7 tasks

cursor bot reviewed Mar 10, 2026

View reviewed changes

ui/pages/confirmations/hooks/useCancelSpeedupInitialGas.ts Outdated Show resolved Hide resolved

ui/pages/confirmations/cancel-speedup/cancel-speedup.test.tsx Outdated Show resolved Hide resolved

fix pipeline

c72ecd4

vinistevam temporarily deployed to pr-comment March 10, 2026 14:58 — with GitHub Actions Inactive

cursor bot reviewed Mar 10, 2026

View reviewed changes

ui/pages/confirmations/hooks/useCancelSpeedupGasState.ts Outdated Show resolved Hide resolved

ui/pages/confirmations/components/gas-timing/gas-timing.component.js Outdated Show resolved Hide resolved

Update LavaMoat policies

411f6ab

metamaskbot dismissed stale reviews from pedronfigueiredo, NidhiKJha, seaona, and jpuri via 411f6ab March 20, 2026 10:46

metamaskbot had a problem deploying to pr-comment March 20, 2026 10:46 — with GitHub Actions Error

vinistevam temporarily deployed to pr-comment March 20, 2026 10:46 — with GitHub Actions Inactive

Merge branch 'main' into vs/enhance-speed-up-cancel-logic

6475ccd

vinistevam temporarily deployed to pr-comment March 20, 2026 10:47 — with GitHub Actions Inactive

cursor bot reviewed Mar 20, 2026

View reviewed changes

ui/pages/confirmations/hooks/useCancelSpeedupInitialGas.ts Show resolved Hide resolved

vinistevam temporarily deployed to pr-comment March 20, 2026 11:19 — with GitHub Actions Inactive

vinistevam requested a review from jpuri March 20, 2026 11:25

jpuri approved these changes Mar 20, 2026

View reviewed changes

vinistevam requested review from NidhiKJha, pedronfigueiredo and seaona March 20, 2026 11:27

pedronfigueiredo approved these changes Mar 20, 2026

View reviewed changes

seaona approved these changes Mar 20, 2026

View reviewed changes

NidhiKJha approved these changes Mar 20, 2026

View reviewed changes

vinistevam added this pull request to the merge queue Mar 20, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 20, 2026

vinistevam added this pull request to the merge queue Mar 20, 2026

Merged via the queue into main with commit 156f7fb Mar 20, 2026
206 of 207 checks passed

vinistevam deleted the vs/enhance-speed-up-cancel-logic branch March 20, 2026 14:14

github-actions bot locked and limited conversation to collaborators Mar 20, 2026

metamaskbot added the release-13.25.0 Issue or pull request that will be included in release 13.25.0 label Mar 20, 2026

Conversation

vinistevam commented Mar 10, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Mar 10, 2026

Uh oh!

metamaskbotv2 bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbotv2 bot commented Mar 10, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Mar 10, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Mar 10, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

cryptotavares commented Mar 10, 2026

BUG 1 — HIGH: EIP-1559 cancel/speedup confirm button permanently disabled

BUG 2 — HIGH: Legacy (non-EIP-1559) cancel/speedup always blocked

BUG 3 — MEDIUM: Tests assert known-wrong fee values

Minor: Dead state

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Mar 20, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Mar 20, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 bot commented Mar 20, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

vinistevam commented Mar 10, 2026 •

edited by cursor bot

Loading

metamaskbotv2 bot commented Mar 10, 2026 •

edited

Loading