feat: BridgeQuotesModal v2 by micaelae · Pull Request #40720 · MetaMask/metamask-extension

micaelae · 2026-03-09T19:54:08Z

Description

implements the new bridge quotes list UI
also fixes a bug where the quoted destination token amount disappears after quotes expire

Changelog

CHANGELOG entry: feat: update the bridge quotes list modal UI

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-3645

Manual testing steps

Request quotes and expand quotes modal
Inspect quoted values and compare to the selected quote
Try to select an alternate quote
Verify that selected quote is not preserved after refreshing quotes

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Moderate risk because it changes quote selection/active-quote derivation and displayed quote values, which can affect user decision-making and metrics events, though no auth/funds-moving logic is modified.

Overview
Updates BridgeQuotesModal to a new quote list layout: adds explanatory copy about cost-based sorting, shows provider + destination amount, formats Total cost consistently (with a Lowest cost tag), and removes the in-modal sort toggles/time column.

Fixes a prepare-page display bug by reading destination amount/fiat from unvalidatedQuote so the quoted receive amount doesn’t disappear when quotes expire, and extends getBridgeQuotes to compute activeQuote from selectedQuote.

Adjusts i18n strings across locales (adds bridgeLowestCost, bridgeQuotesSortedByCost, bridgeSelectQuote, updates quotedTotalCost, removes unused keys), updates Storybook mocks/snapshots, and updates E2E Solana swap fixtures/tests to use conversion/currency rates and the new quote text assertions.

^{Written by Cursor Bugbot for commit 9562eeb. This will update automatically on new commits. Configure here.}

… list

metamaskbotv2 · 2026-03-09T19:54:53Z

✨ Files requiring CODEOWNER review ✨

🧪 @MetaMask/qa (1 files, +4 -5)

📁 test/
- 📁 e2e/
  - 📁 page-objects/
    - 📁 pages/
      - 📁 swap/
        
        📄 swap-page.ts +4 -5

🔄 @MetaMask/swaps-engineers (7 files, +773 -317)

📁 ui/
- 📁 ducks/
  - 📁 bridge/
    - 📄 selectors.ts +12 -3
- 📁 pages/
  - 📁 bridge/
    - 📁 prepare/
      - 📄 prepare-bridge-page.tsx +7 -4
    - 📁 quotes/
      - 📁 __snapshots__/
        
        📄 bridge-quotes-modal.test.tsx.snap +394 -51
        
        📄 bridge-quotes-modal.stories.tsx +19 -3
        
        📄 bridge-quotes-modal.test.tsx +194 -2
        
        📄 bridge-quotes-modal.tsx +143 -254
        
        📄 index.scss +4 -0

metamaskbotv2 · 2026-03-09T20:49:57Z

Builds ready [7674130]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 317 303 326 10 326 326
total 317 303 326 10 326 326
Confirm Tx confirm_tx 6105 6025 6188 63 6139 6188
total 6105 6025 6188 63 6139 6188
Bridge User Actions bridge_load_page 235 202 266 27 256 266
bridge_load_asset_picker 166 130 195 25 193 195
bridge_search_token 720 705 734 12 734 734
total 1126 1108 1141 14 1139 1141

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1444 1213 1718 105 1498 1643
load 1205 1005 1425 99 1259 1386
domContentLoaded 1198 1000 1416 98 1254 1380
domInteractive 29 17 108 18 25 72
firstPaint 147 73 391 72 208 256
backgroundConnect 215 197 260 13 217 250
firstReactRender 19 13 46 5 21 27
initialActions 1 0 5 1 2 4
loadScripts 1000 801 1223 97 1048 1178
setupStore 13 6 46 6 16 22
numNetworkReqs 31 22 93 20 22 81
Power User Home uiStartup 2987 1778 12455 2360 2394 10985
load 1233 1052 1715 151 1267 1605
domContentLoaded 1213 1044 1708 146 1244 1592
domInteractive 38 20 216 29 38 103
firstPaint 202 76 1513 155 262 345
backgroundConnect 1113 264 9789 2169 414 8585
firstReactRender 25 16 54 8 28 41
initialActions 1 0 7 1 1 3
loadScripts 995 847 1434 137 1028 1350
setupStore 16 6 48 8 18 36
numNetworkReqs 89 39 227 47 102 205

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 221 220 222 1 221 222
srpButtonToSrpForm 96 93 98 2 98 98
confirmSrpToPwForm 22 22 22 0 22 22
pwFormToMetricsScreen 16 15 16 0 16 16
metricsToWalletReadyScreen 16 15 16 0 16 16
doneButtonToHomeScreen 690 594 830 90 755 830
openAccountMenuToAccountListLoaded 2936 2934 2937 1 2937 2937
total 4001 3911 4133 85 4058 4133
Onboarding New Wallet createWalletToSocialScreen 219 217 220 1 219 220
srpButtonToPwForm 105 104 107 1 105 107
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 35 33 38 2 35 38
agreeButtonToOnboardingSuccess 16 15 16 0 16 16
doneButtonToAssetList 584 493 698 81 650 698
total 971 872 1077 82 1037 1077
Asset Details assetClickToPriceChart 139 133 148 6 148 148
total 139 133 148 6 148 148
Solana Asset Details assetClickToPriceChart 78 75 81 2 81 81
total 78 75 81 2 81 81
Import Srp Home loginToHomeScreen 2017 1846 2383 203 2089 2383
openAccountMenuAfterLogin 43 37 54 7 43 54
homeAfterImportWithNewWallet 2540 2464 2664 81 2560 2664
total 4431 4137 4623 197 4598 4623
Send Transactions openSendPageFromHome 19 15 27 5 17 27
selectTokenToSendFormLoaded 19 16 24 3 18 24
reviewTransactionToConfirmationPage 946 846 1188 134 996 1188
total 997 880 1276 157 1065 1276
Swap openSwapPageFromHome 17 16 18 1 17 18
fetchAndDisplaySwapQuotes 2689 2682 2696 6 2695 2696
total 2707 2698 2714 6 2712 2714

🌐 Dapp Page Load Benchmarks

Current Commit: 7674130 | Date: 3/9/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±41ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 733ms (±38ms) 🟢 | historical mean value: 742ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 80ms (±12ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	41ms	1.02s	1.35s	1.07s	1.35s
domContentLoaded	733ms	38ms	712ms	1.01s	761ms	1.01s
firstPaint	80ms	12ms	64ms	188ms	88ms	188ms
firstContentfulPaint	80ms	12ms	64ms	188ms	88ms	188ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 5.15 MiB (100%)
ui: 8.24 MiB (100%)
common: 10.99 MiB (100%)

metamaskbotv2 · 2026-03-09T23:02:21Z

Builds ready [66762c0]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 287 275 306 12 289 306
total 287 275 306 12 289 306
Confirm Tx confirm_tx 6055 6025 6083 26 6077 6083
total 6055 6025 6083 26 6077 6083
Bridge User Actions bridge_load_page 275 253 289 13 281 289
bridge_load_asset_picker 189 124 235 40 216 235
bridge_search_token 733 704 773 25 746 773
total 1183 1110 1278 68 1248 1278

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1400 1181 1675 100 1433 1600
load 1168 990 1375 87 1207 1345
domContentLoaded 1162 983 1370 87 1201 1333
domInteractive 28 16 162 21 24 79
firstPaint 171 69 1049 119 220 294
backgroundConnect 208 195 253 11 209 235
firstReactRender 20 13 56 8 20 38
initialActions 2 0 6 2 2 5
loadScripts 970 798 1180 87 1010 1142
setupStore 13 6 37 6 16 23
numNetworkReqs 31 22 91 19 22 82
Power User Home uiStartup 2679 1576 11622 1661 2605 4805
load 1184 1014 2667 224 1198 1604
domContentLoaded 1170 1000 2626 222 1189 1596
domInteractive 36 19 224 26 34 83
firstPaint 200 71 517 96 253 322
backgroundConnect 724 252 6703 1079 497 2711
firstReactRender 24 16 51 6 26 35
initialActions 1 0 5 1 1 2
loadScripts 961 789 2393 214 979 1364
setupStore 15 5 84 10 16 31
numNetworkReqs 87 35 202 46 99 177

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 217 221 1 219 221
srpButtonToSrpForm 91 91 92 1 92 92
confirmSrpToPwForm 21 21 21 0 21 21
pwFormToMetricsScreen 15 15 15 0 15 15
metricsToWalletReadyScreen 16 15 18 1 18 18
doneButtonToHomeScreen 693 603 762 69 761 762
openAccountMenuToAccountListLoaded 2908 2906 2909 1 2909 2909
total 3969 3862 4065 79 4033 4065
Onboarding New Wallet createWalletToSocialScreen 220 216 223 3 222 223
srpButtonToPwForm 106 104 108 1 106 108
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 36 35 38 1 36 38
agreeButtonToOnboardingSuccess 16 16 16 0 16 16
doneButtonToAssetList 609 479 722 98 713 722
total 995 866 1112 97 1094 1112
Asset Details assetClickToPriceChart 124 109 143 15 141 143
total 124 109 143 15 141 143
Solana Asset Details assetClickToPriceChart 96 75 117 20 114 117
total 96 75 117 20 114 117
Import Srp Home loginToHomeScreen 1916 1893 1944 21 1930 1944
openAccountMenuAfterLogin 48 35 70 13 56 70
homeAfterImportWithNewWallet 2323 2231 2444 82 2348 2444
total 4284 4162 4412 91 4313 4412
Send Transactions openSendPageFromHome 20 17 24 3 23 24
selectTokenToSendFormLoaded 18 17 19 1 19 19
reviewTransactionToConfirmationPage 858 845 883 15 869 883
total 897 884 926 16 903 926
Swap openSwapPageFromHome 64 26 98 24 77 98
fetchAndDisplaySwapQuotes 2685 2683 2687 2 2686 2687
total 2749 2714 2784 24 2760 2784

🌐 Dapp Page Load Benchmarks

Current Commit: 66762c0 | Date: 3/9/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±75ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 751ms (±73ms) 🟢 | historical mean value: 740ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 83ms (±10ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	75ms	1.02s	1.36s	1.32s	1.36s
domContentLoaded	751ms	73ms	711ms	1.02s	1.00s	1.02s
firstPaint	83ms	10ms	68ms	156ms	100ms	156ms
firstContentfulPaint	83ms	10ms	68ms	156ms	100ms	156ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 5.15 MiB (100%)
ui: 8.24 MiB (100%)
common: 10.99 MiB (100%)

ui/ducks/bridge/selectors.ts

ui/pages/bridge/quotes/bridge-quotes-modal.tsx

test/e2e/page-objects/pages/swap/swap-page.ts

ui/pages/bridge/quotes/bridge-quotes-modal.tsx

metamaskbotv2 · 2026-03-10T16:30:29Z

Builds ready [4f35acb]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 289 265 336 26 299 336
total 289 265 336 26 299 336
Confirm Tx confirm_tx 6025 6012 6044 12 6029 6044
total 6025 6012 6044 12 6029 6044
Bridge User Actions bridge_load_page 256 221 285 27 283 285
bridge_load_asset_picker 190 134 255 46 213 255
bridge_search_token 727 695 766 24 737 766
total 1174 1057 1260 76 1233 1260

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1441 1191 1979 119 1477 1660
load 1191 996 1661 102 1224 1378
domContentLoaded 1185 991 1648 101 1221 1357
domInteractive 29 17 105 19 25 83
firstPaint 162 69 1403 146 201 274
backgroundConnect 214 197 381 21 214 245
firstReactRender 21 12 42 6 22 34
initialActions 1 0 8 1 2 4
loadScripts 988 788 1434 99 1022 1160
setupStore 13 6 50 7 16 26
numNetworkReqs 36 27 97 19 30 80
Power User Home uiStartup 3610 1896 13952 2568 4405 8583
load 1248 1041 1877 168 1289 1561
domContentLoaded 1228 1033 1847 161 1269 1546
domInteractive 40 19 250 39 33 133
firstPaint 206 80 540 99 276 345
backgroundConnect 1306 270 10970 2283 793 5037
firstReactRender 25 17 44 5 27 33
initialActions 1 0 3 1 1 2
loadScripts 1007 822 1600 149 1045 1306
setupStore 15 7 49 6 16 24
numNetworkReqs 148 84 291 47 162 247

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 220 219 222 1 221 222
srpButtonToSrpForm 94 93 96 1 94 96
confirmSrpToPwForm 21 21 21 0 21 21
pwFormToMetricsScreen 15 15 15 0 15 15
metricsToWalletReadyScreen 16 16 17 1 16 17
doneButtonToHomeScreen 703 593 795 79 760 795
openAccountMenuToAccountListLoaded 2836 2707 2959 103 2899 2959
total 3909 3716 4069 128 4031 4069
Onboarding New Wallet createWalletToSocialScreen 219 219 219 0 219 219
srpButtonToPwForm 105 103 107 1 107 107
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 33 33 34 1 34 34
agreeButtonToOnboardingSuccess 16 16 16 0 16 16
doneButtonToAssetList 593 482 704 93 687 704
total 976 864 1090 95 1069 1090
Asset Details assetClickToPriceChart 133 108 162 20 147 162
total 133 108 162 20 147 162
Solana Asset Details assetClickToPriceChart 83 79 86 2 85 86
total 83 79 86 2 85 86
Import Srp Home loginToHomeScreen 2054 1972 2134 59 2075 2134
openAccountMenuAfterLogin 65 37 108 26 82 108
homeAfterImportWithNewWallet 2181 2144 2226 34 2226 2226
total 4533 4164 4859 273 4719 4859
Send Transactions openSendPageFromHome 34 23 56 13 41 56
selectTokenToSendFormLoaded 20 18 22 2 21 22
reviewTransactionToConfirmationPage 846 842 849 3 847 849
total 894 889 901 4 895 901
Swap openSwapPageFromHome 31 21 38 6 35 38
fetchAndDisplaySwapQuotes 2694 2682 2713 13 2706 2713
total 2724 2713 2740 9 2728 2740

🌐 Dapp Page Load Benchmarks

Current Commit: 4f35acb | Date: 3/10/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±43ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 750ms (±65ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 86ms (±43ms) 🟢 | historical mean value: 82ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	43ms	1.04s	1.39s	1.09s	1.39s
domContentLoaded	750ms	65ms	726ms	1.34s	771ms	1.34s
firstPaint	86ms	43ms	64ms	512ms	92ms	512ms
firstContentfulPaint	86ms	43ms	64ms	512ms	92ms	512ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 5.15 MiB (100%)
ui: 8.34 MiB (100%)
common: 10.99 MiB (100%)

ui/pages/bridge/quotes/bridge-quotes-modal.tsx

metamaskbotv2 · 2026-03-10T18:04:33Z

Builds ready [d3aade4]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 301 262 355 35 326 355
total 301 262 355 35 326 355
Confirm Tx confirm_tx 5999 5994 6005 5 6003 6005
total 5999 5994 6005 5 6003 6005
Bridge User Actions bridge_load_page 201 196 207 4 205 207
bridge_load_asset_picker 214 166 308 54 242 308
bridge_search_token 733 700 801 41 760 801
total 1149 1067 1310 96 1207 1310

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1442 1210 1731 103 1486 1631
load 1196 984 1412 90 1230 1383
domContentLoaded 1189 979 1409 88 1226 1358
domInteractive 30 18 119 21 26 83
firstPaint 151 70 418 77 208 272
backgroundConnect 215 196 287 13 216 238
firstReactRender 21 13 53 6 22 31
initialActions 1 0 10 2 1 5
loadScripts 990 790 1199 87 1029 1167
setupStore 13 6 35 6 15 23
numNetworkReqs 36 27 90 19 27 88
Power User Home uiStartup 3852 1880 15283 2746 3457 11091
load 1274 1074 1667 137 1320 1588
domContentLoaded 1252 1054 1648 129 1284 1551
domInteractive 37 20 157 29 33 117
firstPaint 225 88 1515 158 281 364
backgroundConnect 1460 282 12137 2539 773 8412
firstReactRender 26 19 48 6 29 38
initialActions 1 0 9 1 1 4
loadScripts 1029 837 1411 118 1054 1301
setupStore 14 5 51 7 15 24
numNetworkReqs 162 82 367 50 184 259

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 220 217 223 2 221 223
srpButtonToSrpForm 94 92 96 1 94 96
confirmSrpToPwForm 22 21 23 1 23 23
pwFormToMetricsScreen 15 15 16 0 16 16
metricsToWalletReadyScreen 17 17 18 0 17 18
doneButtonToHomeScreen 658 594 734 59 719 734
openAccountMenuToAccountListLoaded 2918 2903 2929 11 2929 2929
total 3942 3801 4123 111 4004 4123
Onboarding New Wallet createWalletToSocialScreen 220 218 223 2 223 223
srpButtonToPwForm 107 104 111 3 110 111
createPwToRecoveryScreen 8 8 9 0 9 9
skipBackupToMetricsScreen 35 34 35 0 35 35
agreeButtonToOnboardingSuccess 16 16 16 0 16 16
doneButtonToAssetList 496 492 498 3 498 498
total 878 866 888 8 880 888
Asset Details assetClickToPriceChart 96 92 98 3 98 98
total 96 92 98 3 98 98
Solana Asset Details assetClickToPriceChart 79 74 83 3 81 83
total 79 74 83 3 81 83
Import Srp Home loginToHomeScreen 2020 2012 2025 6 2025 2025
openAccountMenuAfterLogin 48 47 48 0 48 48
homeAfterImportWithNewWallet 2495 2291 2710 160 2655 2710
total 4576 4247 4771 195 4728 4771
Send Transactions openSendPageFromHome 26 21 32 4 25 32
selectTokenToSendFormLoaded 18 17 19 1 19 19
reviewTransactionToConfirmationPage 846 844 850 2 846 850
total 890 886 894 3 893 894
Swap openSwapPageFromHome 26 21 37 6 30 37
fetchAndDisplaySwapQuotes 2686 2684 2691 3 2686 2691
total 2713 2704 2722 6 2714 2722

🌐 Dapp Page Load Benchmarks

Current Commit: d3aade4 | Date: 3/10/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±43ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 744ms (±40ms) 🟢 | historical mean value: 728ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 82ms (±12ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	43ms	1.02s	1.35s	1.10s	1.35s
domContentLoaded	744ms	40ms	712ms	1.02s	778ms	1.02s
firstPaint	82ms	12ms	64ms	192ms	88ms	192ms
firstContentfulPaint	82ms	12ms	64ms	192ms	88ms	192ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 5.15 MiB (100%)
ui: 8.34 MiB (100%)
common: 10.99 MiB (100%)

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

ui/pages/bridge/quotes/bridge-quotes-modal.tsx

app/_locales/es/messages.json

metamaskbotv2 · 2026-03-10T19:52:32Z

Builds ready [9c0bc35]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 270 267 273 2 272 273
total 270 267 273 2 272 273
Confirm Tx confirm_tx 5998 5987 6010 8 6003 6010
total 5998 5987 6010 8 6003 6010
Bridge User Actions bridge_load_page 249 207 292 33 282 292
bridge_load_asset_picker 183 144 221 28 191 221
bridge_search_token 725 698 745 19 744 745
total 1182 1079 1277 81 1244 1277

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1442 1219 1824 102 1485 1624
load 1194 995 1582 93 1232 1369
domContentLoaded 1188 992 1571 91 1227 1359
domInteractive 29 17 122 20 25 81
firstPaint 147 71 369 74 208 294
backgroundConnect 213 196 264 14 217 247
firstReactRender 20 13 61 6 22 26
initialActions 1 0 15 2 1 4
loadScripts 989 799 1362 88 1025 1155
setupStore 13 6 38 5 15 21
numNetworkReqs 36 27 92 19 27 87
Power User Home uiStartup 5741 2186 17462 3034 6828 10561
load 1340 1141 2621 188 1400 1612
domContentLoaded 1323 1136 2608 182 1376 1571
domInteractive 36 21 278 29 35 77
firstPaint 213 90 1280 141 276 360
backgroundConnect 2357 299 14576 2821 3008 5021
firstReactRender 28 20 50 5 30 36
initialActions 1 0 4 1 1 3
loadScripts 1094 919 2327 175 1154 1333
setupStore 17 6 50 9 20 30
numNetworkReqs 130 64 295 41 139 233

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 218 220 1 220 220
srpButtonToSrpForm 92 91 94 1 92 94
confirmSrpToPwForm 21 21 22 0 21 22
pwFormToMetricsScreen 15 15 15 0 15 15
metricsToWalletReadyScreen 16 16 16 0 16 16
doneButtonToHomeScreen 711 602 850 96 766 850
openAccountMenuToAccountListLoaded 2917 2897 2940 18 2935 2940
total 3998 3901 4147 89 4034 4147
Onboarding New Wallet createWalletToSocialScreen 220 217 225 3 222 225
srpButtonToPwForm 107 106 110 2 107 110
createPwToRecoveryScreen 8 8 9 0 9 9
skipBackupToMetricsScreen 35 35 36 0 36 36
agreeButtonToOnboardingSuccess 16 16 17 0 16 17
doneButtonToAssetList 553 488 597 42 582 597
total 946 896 980 33 972 980
Asset Details assetClickToPriceChart 129 100 158 21 142 158
total 129 100 158 21 142 158
Solana Asset Details assetClickToPriceChart 79 73 88 6 79 88
total 79 73 88 6 79 88
Import Srp Home loginToHomeScreen 2203 2158 2238 31 2225 2238
openAccountMenuAfterLogin 74 60 86 9 79 86
homeAfterImportWithNewWallet 2492 2220 3047 307 2600 3047
total 4626 4478 4819 123 4612 4819
Send Transactions openSendPageFromHome 32 30 34 1 34 34
selectTokenToSendFormLoaded 34 16 54 16 53 54
reviewTransactionToConfirmationPage 1146 846 1582 277 1255 1582
total 1218 880 1713 309 1342 1713
Swap openSwapPageFromHome 33 20 49 10 39 49
fetchAndDisplaySwapQuotes 2691 2689 2694 2 2690 2694
total 2720 2710 2730 7 2721 2730

🌐 Dapp Page Load Benchmarks

Current Commit: 9c0bc35 | Date: 3/10/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±45ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 734ms (±40ms) 🟢 | historical mean value: 736ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 81ms (±11ms) 🟢 | historical mean value: 84ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	45ms	992ms	1.34s	1.07s	1.34s
domContentLoaded	734ms	40ms	696ms	1.01s	755ms	1.01s
firstPaint	81ms	11ms	64ms	180ms	88ms	180ms
firstContentfulPaint	81ms	11ms	64ms	180ms	88ms	180ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 5.15 MiB (100%)
ui: 8.32 MiB (100%)
common: 11 MiB (100%)

sonarqubecloud · 2026-03-11T17:05:07Z

Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-03-11T17:29:30Z

Builds ready [9562eeb]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 301 271 335 29 325 335
total 301 271 335 29 325 335
Confirm Tx confirm_tx 6043 6018 6076 23 6062 6076
total 6043 6018 6076 23 6062 6076
Bridge User Actions bridge_load_page 237 223 263 16 234 263
bridge_load_asset_picker 174 145 204 21 179 204
bridge_search_token 736 706 783 30 760 783
total 1187 1108 1281 67 1252 1281

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1477 1218 1986 125 1520 1684
load 1223 1009 1636 107 1267 1404
domContentLoaded 1216 1005 1629 105 1262 1390
domInteractive 30 17 134 20 26 74
firstPaint 165 67 1379 147 221 322
backgroundConnect 219 197 286 16 222 245
firstReactRender 21 14 53 6 22 36
initialActions 1 0 5 1 1 3
loadScripts 1013 815 1421 103 1057 1191
setupStore 13 6 41 6 16 22
numNetworkReqs 35 27 86 17 28 81
Power User Home uiStartup 5991 2195 18343 2989 6795 11637
load 1360 1131 1866 132 1404 1599
domContentLoaded 1338 1121 1846 122 1389 1551
domInteractive 38 21 159 27 35 107
firstPaint 250 82 1669 231 303 412
backgroundConnect 2369 328 14987 2746 3283 7607
firstReactRender 27 19 59 6 29 37
initialActions 1 0 6 1 1 4
loadScripts 1105 915 1572 111 1141 1314
setupStore 17 8 61 7 19 27
numNetworkReqs 196 68 358 54 222 299

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 221 216 224 3 222 224
srpButtonToSrpForm 100 94 106 5 104 106
confirmSrpToPwForm 22 21 22 0 22 22
pwFormToMetricsScreen 15 15 15 0 15 15
metricsToWalletReadyScreen 16 16 16 0 16 16
doneButtonToHomeScreen 652 595 755 58 668 755
openAccountMenuToAccountListLoaded 2922 2910 2936 10 2930 2936
total 3918 3874 3952 30 3938 3952
Onboarding New Wallet createWalletToSocialScreen 221 217 223 2 221 223
srpButtonToPwForm 106 105 108 1 107 108
createPwToRecoveryScreen 8 8 9 0 9 9
skipBackupToMetricsScreen 35 35 36 0 35 36
agreeButtonToOnboardingSuccess 16 16 16 0 16 16
doneButtonToAssetList 493 490 495 2 495 495
total 879 871 889 6 880 889
Asset Details assetClickToPriceChart 139 111 163 22 154 163
total 139 111 163 22 154 163
Solana Asset Details assetClickToPriceChart 89 82 98 5 92 98
total 89 82 98 5 92 98
Import Srp Home loginToHomeScreen 2225 2159 2270 41 2245 2270
openAccountMenuAfterLogin 65 61 68 2 66 68
homeAfterImportWithNewWallet 2344 2303 2382 30 2360 2382
total 4732 4530 4958 153 4838 4958
Send Transactions openSendPageFromHome 28 24 39 6 27 39
selectTokenToSendFormLoaded 29 19 43 9 30 43
reviewTransactionToConfirmationPage 959 848 1079 110 1058 1079
total 1135 891 1575 248 1184 1575
Swap openSwapPageFromHome 32 20 49 13 48 49
fetchAndDisplaySwapQuotes 2693 2690 2696 2 2693 2696
total 2728 2713 2740 10 2738 2740

🌐 Dapp Page Load Benchmarks

Current Commit: 9562eeb | Date: 3/11/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.08s (±41ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 760ms (±39ms) 🟢 | historical mean value: 741ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 84ms (±13ms) 🟢 | historical mean value: 83ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.08s	41ms	1.06s	1.38s	1.10s	1.38s
domContentLoaded	760ms	39ms	736ms	1.04s	784ms	1.04s
firstPaint	84ms	13ms	64ms	200ms	96ms	200ms
firstContentfulPaint	84ms	13ms	64ms	200ms	96ms	200ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 58 Bytes (0%)
ui: -1.1 KiB (-0.01%)
common: 24 Bytes (0%)

micaelae added 4 commits March 9, 2026 12:31

fix: continue showing destTokenAmount after expiration

7e0b19d

fix: ignore selectedQuote if requestId does not exist in sortedQuotes…

4288efb

… list

chore: update quotes modal storybook

9b72fd1

feat: bridge-quotes-modal v2

8544f60

micaelae temporarily deployed to pr-comment March 9, 2026 19:54 — with GitHub Actions Inactive

metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Mar 9, 2026

github-actions bot added the size-L label Mar 9, 2026

fix: unit tests

2635ff3

micaelae temporarily deployed to pr-comment March 9, 2026 19:58 — with GitHub Actions Inactive

fix: lint error

7674130

micaelae temporarily deployed to pr-comment March 9, 2026 20:16 — with GitHub Actions Inactive

micaelae temporarily deployed to pr-comment March 9, 2026 20:45 — with GitHub Actions Inactive

fix: solana swap e2e tests

de7dd7a

micaelae temporarily deployed to pr-comment March 9, 2026 22:07 — with GitHub Actions Inactive

chore: add unit tests

66762c0

micaelae temporarily deployed to pr-comment March 9, 2026 22:30 — with GitHub Actions Inactive

micaelae temporarily deployed to pr-comment March 9, 2026 22:57 — with GitHub Actions Inactive

micaelae marked this pull request as ready for review March 10, 2026 15:27

micaelae requested review from a team as code owners March 10, 2026 15:27

micaelae temporarily deployed to pr-comment March 10, 2026 15:27 — with GitHub Actions Inactive

cursor bot reviewed Mar 10, 2026

View reviewed changes

ui/ducks/bridge/selectors.ts Show resolved Hide resolved

ui/pages/bridge/quotes/bridge-quotes-modal.tsx Outdated Show resolved Hide resolved

fix: best_quote_provider

4f35acb

micaelae temporarily deployed to pr-comment March 10, 2026 15:53 — with GitHub Actions Inactive

cursor bot reviewed Mar 10, 2026

View reviewed changes

test/e2e/page-objects/pages/swap/swap-page.ts Show resolved Hide resolved

ui/pages/bridge/quotes/bridge-quotes-modal.tsx Show resolved Hide resolved

micaelae temporarily deployed to pr-comment March 10, 2026 16:24 — with GitHub Actions Inactive

cursor bot reviewed Mar 10, 2026

View reviewed changes

ui/pages/bridge/quotes/bridge-quotes-modal.tsx Outdated Show resolved Hide resolved

micaelae temporarily deployed to pr-comment March 10, 2026 17:59 — with GitHub Actions Inactive

fix: lint error

323af52

micaelae temporarily deployed to pr-comment March 10, 2026 19:02 — with GitHub Actions Inactive

cursor bot reviewed Mar 10, 2026

View reviewed changes

ui/pages/bridge/quotes/bridge-quotes-modal.tsx Show resolved Hide resolved

app/_locales/es/messages.json Show resolved Hide resolved

fix: cursor got confused

9c0bc35

micaelae temporarily deployed to pr-comment March 10, 2026 19:17 — with GitHub Actions Inactive

micaelae temporarily deployed to pr-comment March 10, 2026 19:47 — with GitHub Actions Inactive

micaelae enabled auto-merge March 10, 2026 19:56

davibroc previously approved these changes Mar 11, 2026

View reviewed changes

Merge branch 'main' into swaps3645-more-quotes-v2

ccaf757

micaelae dismissed davibroc’s stale review via ccaf757 March 11, 2026 15:49

micaelae temporarily deployed to pr-comment March 11, 2026 15:49 — with GitHub Actions Inactive

fix: strings

5746629

micaelae temporarily deployed to pr-comment March 11, 2026 16:07 — with GitHub Actions Inactive

micaelae had a problem deploying to pr-comment March 11, 2026 16:37 — with GitHub Actions Error

fix: rm unused string

9562eeb

micaelae temporarily deployed to pr-comment March 11, 2026 16:51 — with GitHub Actions Inactive

davibroc approved these changes Mar 11, 2026

View reviewed changes

micaelae temporarily deployed to pr-comment March 11, 2026 17:24 — with GitHub Actions Inactive

infiniteflower approved these changes Mar 11, 2026

View reviewed changes

micaelae added this pull request to the merge queue Mar 11, 2026

Merged via the queue into main with commit d0c67fd Mar 11, 2026
184 checks passed

micaelae deleted the swaps3645-more-quotes-v2 branch March 11, 2026 17:56

metamaskbot added the release-13.23.0 Issue or pull request that will be included in release 13.23.0 label Mar 11, 2026

Conversation

micaelae commented Mar 9, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbotv2 bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbotv2 bot commented Mar 9, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Mar 9, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metamaskbotv2 bot commented Mar 10, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

metamaskbotv2 bot commented Mar 10, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

metamaskbotv2 bot commented Mar 10, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud bot commented Mar 11, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 bot commented Mar 11, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

micaelae commented Mar 9, 2026 •

edited by cursor bot

Loading

metamaskbotv2 bot commented Mar 9, 2026 •

edited

Loading