feat: added contacts metrics and replace settings contacts with hamburger menu by NidhiKJha · Pull Request #40714 · MetaMask/metamask-extension

NidhiKJha · 2026-03-09T14:32:44Z

Added contacts metrics and replace settings contacts with standalone flow

Description

Reason for the change: The contacts (address book) experience lived only under Settings and had no product analytics. We need a single, standalone contacts entry point from the global menu and to measure usage via MetaMetrics.

Improvement/solution:

Metrics: Add MetaMetrics for the new contacts flow—page views (list, details), add/edit/delete actions, and QR scanner usage—with category Contacts and contact_address in sensitiveProperties where applicable.
Remove legacy Settings contacts: Remove the "Contacts" tab and all /settings/contact-list routes and delete the old contact-list-tab UI.
Standalone contacts only: Contacts are now only in the standalone flow; expose them from the global menu (Manage → Contacts) and move shared ContactNetworks into ui/pages/contacts/components.
E2E: Update all contact-related E2E tests to use the new flow (updated page object, HeaderNavbar.openContactsPage()), and remove the "Contacts tab" settings-search test.

Changelog

CHANGELOG entry: Replaced the Settings contacts tab with a standalone Contacts page accessible from the global menu and added analytics for the contacts list and add/edit/delete actions.

Related issues

Fixes: CEUX-940

Manual testing steps

Build and load the extension (yarn start), then unlock the wallet.
Open the global menu (account/hamburger icon) and confirm Contacts appears under the Manage section.
Click Contacts and confirm the contacts list loads (empty or with existing contacts).
Add a contact (name + address, optionally change network), save, and confirm it appears in the list.
Open a contact, then Edit (change name/address/network and save) and Delete (confirm in modal) and confirm the list updates.
On the add-contact screen, click the QR scan button and confirm the scanner opens (or is blocked by environment as expected).
Open Settings and confirm there is no Contacts tab.
(Optional) With MetaMetrics enabled, confirm contact events fire for the actions above.

Screenshots/Recordings

Before

NA

After

Screen.Recording.2026-03-10.at.12.35.43.PM.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Moderate risk due to navigation/routing changes and broad test refactors around the contacts flow; analytics additions are low-impact but can surface runtime issues if event wiring or selectors are incorrect.

Overview
Moves the Contacts (address book) experience out of Settings and into a standalone /contacts flow reachable from the global menu (Manage → Contacts), removing the legacy settings tab/routes and related settings-search coverage.

Adds MetaMetrics instrumentation for contacts usage (page/detail views and add/edit/delete + QR scanner actions), updates contacts UI components (theme-specific empty-state artwork, network picker moved into ui/pages/contacts/components, duplicate indicator, avatar usage), and refactors E2E page objects/tests to navigate via the new global-menu entry point and updated selectors.

^{Written by Cursor Bugbot for commit bcfe395. This will update automatically on new commits. Configure here.}

- Add MetaMetrics events for contacts: ContactsPageViewed, ContactDetailsViewed, AddContactClicked, ContactAddQrScannerClicked, ContactAdded, EditContactClicked, ContactUpdated, DeleteContactClicked, ContactDeleted (category: Contacts) - Include contact_address in sensitiveProperties where applicable - Remove old Settings > Contact list tab and routes (CONTACT_LIST_ROUTE, etc.) - Move ContactNetworks to ui/pages/contacts/components - Enable Contacts in global menu (Manage section) - Update E2E: contacts page object for new UI, HeaderNavbar.openContactsPage(), address-book, settings-search, contact-syncing specs use new contacts flow Made-with: Cursor

metamaskbotv2 · 2026-03-09T16:43:24Z

Builds ready [a010299]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 271 267 278 4 270 278
total 271 267 278 4 270 278
Confirm Tx confirm_tx 6054 6048 6059 5 6059 6059
total 6054 6048 6059 5 6059 6059
Bridge User Actions bridge_load_page 258 244 284 16 254 284
bridge_load_asset_picker 176 130 244 40 194 244
bridge_search_token 734 702 764 27 763 764
total 1187 1094 1286 75 1256 1286

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1432 1209 1793 113 1496 1621
load 1191 999 1459 102 1241 1373
domContentLoaded 1183 990 1452 100 1235 1363
domInteractive 30 17 121 20 26 86
firstPaint 169 71 1197 131 215 331
backgroundConnect 217 195 395 27 221 242
firstReactRender 21 12 68 9 23 39
initialActions 2 0 10 2 2 4
loadScripts 988 799 1249 99 1041 1160
setupStore 14 7 47 7 16 25
numNetworkReqs 31 22 86 19 22 81
Power User Home uiStartup 3246 1706 12172 2146 3864 5548
load 1246 1056 1815 157 1291 1618
domContentLoaded 1228 1041 1806 151 1270 1583
domInteractive 41 19 267 36 35 109
firstPaint 216 84 1331 179 251 447
backgroundConnect 1054 265 9473 1755 994 3120
firstReactRender 25 17 52 7 26 41
initialActions 1 0 6 1 1 3
loadScripts 1011 816 1573 142 1044 1346
setupStore 16 7 72 9 17 37
numNetworkReqs 95 37 220 43 109 190

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 220 218 223 2 221 223
srpButtonToSrpForm 98 95 101 2 98 101
confirmSrpToPwForm 23 22 24 1 23 24
pwFormToMetricsScreen 17 16 17 0 17 17
metricsToWalletReadyScreen 17 16 18 1 17 18
doneButtonToHomeScreen 660 603 725 53 699 725
openAccountMenuToAccountListLoaded 2935 2925 2944 7 2939 2944
total 4007 3910 4138 88 4061 4138
Onboarding New Wallet createWalletToSocialScreen 219 216 223 2 221 223
srpButtonToPwForm 114 108 120 4 117 120
createPwToRecoveryScreen 9 9 9 0 9 9
skipBackupToMetricsScreen 38 35 42 3 41 42
agreeButtonToOnboardingSuccess 17 16 17 0 17 17
doneButtonToAssetList 630 605 673 31 673 673
total 991 874 1080 74 1012 1080
Asset Details assetClickToPriceChart 128 99 166 25 139 166
total 128 99 166 25 139 166
Solana Asset Details assetClickToPriceChart 71 67 76 3 74 76
total 71 67 76 3 74 76
Import Srp Home loginToHomeScreen 1936 1857 1994 50 1955 1994
openAccountMenuAfterLogin 47 45 50 2 50 50
homeAfterImportWithNewWallet 2663 2588 2740 62 2706 2740
total 4714 4573 4796 88 4782 4796
Send Transactions openSendPageFromHome 22 21 23 1 23 23
selectTokenToSendFormLoaded 18 16 20 1 18 20
reviewTransactionToConfirmationPage 855 849 861 5 859 861
total 903 888 936 19 895 936
Swap openSwapPageFromHome 52 44 67 8 54 67
fetchAndDisplaySwapQuotes 2689 2688 2692 1 2690 2692
total 2742 2732 2756 9 2743 2756

🌐 Dapp Page Load Benchmarks

Current Commit: a010299 | Date: 3/9/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±42ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 740ms (±40ms) 🟢 | historical mean value: 741ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 82ms (±12ms) 🟢 | historical mean value: 81ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	42ms	1.02s	1.37s	1.10s	1.37s
domContentLoaded	740ms	40ms	717ms	1.04s	776ms	1.04s
firstPaint	82ms	12ms	68ms	184ms	92ms	184ms
firstContentfulPaint	82ms	12ms	68ms	184ms	92ms	184ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 5.15 MiB (100%)
ui: 8.2 MiB (100%)
common: 10.99 MiB (100%)

metamaskbotv2 · 2026-03-10T10:10:49Z

Builds ready [162a90e]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 279 265 295 11 283 295
total 279 265 295 11 283 295
Confirm Tx confirm_tx 6064 6017 6103 36 6093 6103
total 6064 6017 6103 36 6093 6103
Bridge User Actions bridge_load_page 219 184 259 31 247 259
bridge_load_asset_picker 213 145 271 45 246 271
bridge_search_token 747 707 811 41 777 811
total 1179 1073 1282 85 1266 1282

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1392 1142 1689 112 1455 1581
load 1164 954 1400 101 1209 1338
domContentLoaded 1157 951 1393 101 1204 1328
domInteractive 28 17 98 18 25 79
firstPaint 166 64 1138 118 203 285
backgroundConnect 204 187 240 11 208 225
firstReactRender 18 12 40 5 19 26
initialActions 2 0 8 2 2 6
loadScripts 970 761 1200 100 1014 1142
setupStore 13 6 35 5 15 24
numNetworkReqs 31 22 93 20 22 89
Power User Home uiStartup 2816 1582 12462 2049 2647 5456
load 1213 1035 1733 152 1241 1507
domContentLoaded 1196 1026 1642 145 1226 1500
domInteractive 37 19 131 23 39 94
firstPaint 172 75 492 82 223 317
backgroundConnect 855 262 9730 1607 489 3228
firstReactRender 25 15 52 6 27 32
initialActions 1 0 3 1 1 2
loadScripts 981 822 1425 139 1009 1290
setupStore 15 7 38 6 16 28
numNetworkReqs 83 37 221 47 95 183

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 221 218 224 2 222 224
srpButtonToSrpForm 96 93 98 2 97 98
confirmSrpToPwForm 22 21 24 1 23 24
pwFormToMetricsScreen 16 15 16 0 16 16
metricsToWalletReadyScreen 17 16 17 1 17 17
doneButtonToHomeScreen 655 610 761 59 679 761
openAccountMenuToAccountListLoaded 2921 2909 2935 10 2927 2935
total 3892 3854 3912 24 3912 3912
Onboarding New Wallet createWalletToSocialScreen 218 217 220 1 218 220
srpButtonToPwForm 108 104 115 5 108 115
createPwToRecoveryScreen 9 8 9 0 9 9
skipBackupToMetricsScreen 39 36 41 2 41 41
agreeButtonToOnboardingSuccess 18 16 21 2 19 21
doneButtonToAssetList 504 492 519 10 507 519
total 935 877 1045 62 955 1045
Asset Details assetClickToPriceChart 136 107 157 18 145 157
total 136 107 157 18 145 157
Solana Asset Details assetClickToPriceChart 78 73 86 6 83 86
total 78 73 86 6 83 86
Import Srp Home loginToHomeScreen 2090 2076 2100 10 2100 2100
openAccountMenuAfterLogin 51 50 52 1 52 52
homeAfterImportWithNewWallet 2581 2445 2803 134 2639 2803
total 4643 4511 4782 107 4706 4782
Send Transactions openSendPageFromHome 37 20 67 19 51 67
selectTokenToSendFormLoaded 23 18 32 5 22 32
reviewTransactionToConfirmationPage 1031 864 1202 142 1177 1202
total 1109 917 1382 176 1219 1382
Swap openSwapPageFromHome 36 20 62 19 56 62
fetchAndDisplaySwapQuotes 2693 2685 2703 7 2697 2703
total 2729 2708 2765 22 2741 2765

🌐 Dapp Page Load Benchmarks

Current Commit: 162a90e | Date: 3/10/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±47ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 740ms (±43ms) 🟢 | historical mean value: 732ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 82ms (±12ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	47ms	1.02s	1.39s	1.07s	1.39s
domContentLoaded	740ms	43ms	713ms	1.05s	753ms	1.05s
firstPaint	82ms	12ms	64ms	188ms	88ms	188ms
firstContentfulPaint	82ms	12ms	64ms	188ms	88ms	188ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 5.15 MiB (100%)
ui: 8.2 MiB (100%)
common: 10.99 MiB (100%)

metamaskbotv2 · 2026-03-10T12:05:32Z

Builds ready [ac9f364]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 278 268 300 13 273 300
total 278 268 300 13 273 300
Confirm Tx confirm_tx 6045 6044 6047 1 6047 6047
total 6045 6044 6047 1 6047 6047
Bridge User Actions bridge_load_page 247 242 251 3 248 251
bridge_load_asset_picker 209 134 268 56 250 268
bridge_search_token 742 703 784 32 766 784
total 1192 1084 1280 83 1257 1280

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1468 1223 2142 136 1528 1707
load 1222 1021 1709 113 1286 1413
domContentLoaded 1215 1017 1698 111 1279 1392
domInteractive 30 18 109 19 27 80
firstPaint 155 75 390 74 214 256
backgroundConnect 217 196 280 16 220 253
firstReactRender 19 14 38 4 20 30
initialActions 2 0 6 1 2 4
loadScripts 1015 816 1489 110 1072 1194
setupStore 13 7 37 6 15 23
numNetworkReqs 31 22 90 19 22 83
Power User Home uiStartup 2982 1759 13203 2014 2836 5762
load 1231 1093 1769 145 1263 1575
domContentLoaded 1217 1082 1761 143 1252 1551
domInteractive 36 21 125 20 36 85
firstPaint 185 82 464 83 266 323
backgroundConnect 914 276 9868 1570 729 2622
firstReactRender 26 16 68 8 28 44
initialActions 1 0 7 1 1 2
loadScripts 991 860 1514 135 1019 1309
setupStore 17 7 49 7 18 29
numNetworkReqs 83 36 217 45 98 182

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 220 218 221 1 221 221
srpButtonToSrpForm 94 94 94 0 94 94
confirmSrpToPwForm 22 21 22 0 22 22
pwFormToMetricsScreen 15 15 16 0 16 16
metricsToWalletReadyScreen 16 15 17 1 17 17
doneButtonToHomeScreen 732 594 1042 176 817 1042
openAccountMenuToAccountListLoaded 2935 2914 2951 13 2941 2951
total 3908 3902 3912 5 3912 3912
Onboarding New Wallet createWalletToSocialScreen 221 218 224 2 222 224
srpButtonToPwForm 114 108 123 7 122 123
createPwToRecoveryScreen 8 8 9 0 8 9
skipBackupToMetricsScreen 36 34 37 1 36 37
agreeButtonToOnboardingSuccess 17 16 17 0 17 17
doneButtonToAssetList 525 486 581 33 539 581
total 904 879 927 17 908 927
Asset Details assetClickToPriceChart 146 138 158 8 146 158
total 146 138 158 8 146 158
Solana Asset Details assetClickToPriceChart 79 76 82 3 81 82
total 79 76 82 3 81 82
Import Srp Home loginToHomeScreen 2194 1946 2584 256 2412 2584
openAccountMenuAfterLogin 47 41 54 5 53 54
homeAfterImportWithNewWallet 2270 2132 2394 98 2318 2394
total 4599 4338 5157 320 4760 5157
Send Transactions openSendPageFromHome 22 17 31 5 22 31
selectTokenToSendFormLoaded 22 20 24 2 21 24
reviewTransactionToConfirmationPage 1129 846 1495 247 1260 1495
total 1181 886 1584 264 1315 1584
Swap openSwapPageFromHome 42 32 53 8 48 53
fetchAndDisplaySwapQuotes 2690 2688 2694 2 2689 2694
total 2735 2720 2754 13 2742 2754

🌐 Dapp Page Load Benchmarks

Current Commit: ac9f364 | Date: 3/10/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±38ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 749ms (±36ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 83ms (±9ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	38ms	1.02s	1.34s	1.09s	1.34s
domContentLoaded	749ms	36ms	714ms	1.01s	779ms	1.01s
firstPaint	83ms	9ms	68ms	152ms	92ms	152ms
firstContentfulPaint	83ms	9ms	68ms	152ms	92ms	152ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 5.15 MiB (100%)
ui: 8.22 MiB (100%)
common: 10.99 MiB (100%)

…e-settings-contact

ui/pages/contacts/components/contact-list-item.tsx

ui/pages/contacts/contacts-list-page.tsx

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

test/e2e/page-objects/pages/settings/contacts-settings.ts

metamaskbotv2 · 2026-03-11T12:29:44Z

Builds ready [e6b1bc4]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 306 272 373 41 302 373
total 306 272 373 41 302 373
Confirm Tx confirm_tx 6045 6032 6057 10 6052 6057
total 6045 6032 6057 10 6052 6057
Bridge User Actions bridge_load_page 228 202 271 28 251 271
bridge_load_asset_picker 167 122 195 27 185 195
bridge_search_token 705 698 713 5 707 713
total 1100 1091 1106 6 1105 1106

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1474 1218 1739 114 1527 1686
load 1217 1016 1473 99 1253 1396
domContentLoaded 1210 1011 1464 98 1249 1390
domInteractive 30 17 125 21 26 87
firstPaint 176 72 1212 193 207 305
backgroundConnect 217 195 435 25 217 241
firstReactRender 20 11 75 7 22 30
initialActions 1 0 7 1 2 4
loadScripts 1010 811 1264 96 1050 1175
setupStore 14 7 28 5 17 22
numNetworkReqs 36 27 89 18 27 85
Power User Home uiStartup 5399 1947 16764 3309 6089 15655
load 1279 1089 2706 188 1332 1519
domContentLoaded 1257 1075 2696 185 1301 1489
domInteractive 35 18 342 35 34 70
firstPaint 228 75 1254 163 272 358
backgroundConnect 2365 298 13622 3206 3480 13147
firstReactRender 26 17 43 5 29 36
initialActions 1 0 4 1 1 3
loadScripts 1050 882 2476 181 1103 1275
setupStore 14 6 36 6 15 27
numNetworkReqs 200 110 341 48 223 279

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 220 218 222 2 220 222
srpButtonToSrpForm 95 93 96 1 95 96
confirmSrpToPwForm 22 22 22 0 22 22
pwFormToMetricsScreen 16 15 16 1 16 16
metricsToWalletReadyScreen 17 16 17 0 17 17
doneButtonToHomeScreen 611 593 632 14 616 632
openAccountMenuToAccountListLoaded 2928 2903 2958 22 2951 2958
total 3918 3876 3955 28 3924 3955
Onboarding New Wallet createWalletToSocialScreen 222 221 222 0 222 222
srpButtonToPwForm 117 110 127 7 126 127
createPwToRecoveryScreen 9 8 9 0 9 9
skipBackupToMetricsScreen 36 35 37 1 37 37
agreeButtonToOnboardingSuccess 17 17 18 0 17 18
doneButtonToAssetList 550 482 640 72 634 640
total 950 876 1037 66 1021 1037
Asset Details assetClickToPriceChart 145 137 161 9 143 161
total 145 137 161 9 143 161
Solana Asset Details assetClickToPriceChart 83 62 114 19 87 114
total 83 62 114 19 87 114
Import Srp Home loginToHomeScreen 2378 2248 2485 105 2482 2485
openAccountMenuAfterLogin 67 33 103 25 87 103
homeAfterImportWithNewWallet 2354 2205 2476 94 2427 2476
total 4799 4621 4939 121 4930 4939
Send Transactions openSendPageFromHome 31 25 39 5 31 39
selectTokenToSendFormLoaded 25 18 33 6 31 33
reviewTransactionToConfirmationPage 1053 846 1459 254 1248 1459
total 1119 892 1566 273 1311 1566
Swap openSwapPageFromHome 26 19 33 6 31 33
fetchAndDisplaySwapQuotes 2695 2683 2722 15 2701 2722
total 2728 2706 2755 18 2741 2755

🌐 Dapp Page Load Benchmarks

Current Commit: e6b1bc4 | Date: 3/11/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.08s (±41ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 757ms (±39ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 85ms (±13ms) 🟢 | historical mean value: 83ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.08s	41ms	1.05s	1.39s	1.10s	1.39s
domContentLoaded	757ms	39ms	734ms	1.04s	778ms	1.04s
firstPaint	85ms	13ms	72ms	204ms	92ms	204ms
firstContentfulPaint	85ms	13ms	72ms	204ms	92ms	204ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 58 Bytes (0%)
ui: -42.02 KiB (-0.49%)
common: -325 Bytes (0%)

test/e2e/page-objects/pages/settings/contacts-settings.ts

seaona

Added a small suggestion for e2e files. Overall looks good!

ameliejyc

Thanks for making those changes! It's looking great, a couple more things I noticed though:

There is a border radius on the selected network active style which we should remove
The Testnets section needs to have the same margin as the networks

I think it would better to have the toast above the Add contact button if design agrees

ui/pages/contacts/components/contact-networks.tsx

ui/pages/contacts/contacts-list-page.tsx

sonarqubecloud · 2026-03-11T13:30:58Z

Quality Gate failed

Failed conditions
18.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-03-11T13:52:50Z

Builds ready [bcfe395]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 282 272 292 9 289 292
total 282 272 292 9 289 292
Confirm Tx confirm_tx 6091 6070 6135 26 6084 6135
total 6091 6070 6135 26 6084 6135
Bridge User Actions bridge_load_page 240 198 262 23 258 262
bridge_load_asset_picker 188 169 210 18 209 210
bridge_search_token 719 700 736 13 727 736
total 1131 1108 1154 16 1132 1154

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1494 1263 1966 117 1553 1684
load 1239 1026 1629 102 1294 1395
domContentLoaded 1232 1017 1619 99 1291 1387
domInteractive 30 18 121 20 27 83
firstPaint 149 71 358 70 208 298
backgroundConnect 223 199 343 17 228 245
firstReactRender 20 12 43 5 22 31
initialActions 1 0 9 2 2 5
loadScripts 1024 822 1404 97 1079 1176
setupStore 13 7 37 5 15 22
numNetworkReqs 36 27 89 18 27 84
Power User Home uiStartup 5686 2130 16542 2959 6152 12102
load 1263 1113 1573 103 1285 1503
domContentLoaded 1246 1106 1520 95 1272 1457
domInteractive 31 19 181 19 31 52
firstPaint 181 84 335 77 257 311
backgroundConnect 2118 325 13273 2850 2584 8044
firstReactRender 25 19 50 5 27 32
initialActions 1 0 6 1 1 3
loadScripts 1023 906 1293 88 1050 1217
setupStore 14 5 45 5 16 21
numNetworkReqs 173 87 315 46 197 252

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 222 218 227 3 224 227
srpButtonToSrpForm 99 97 100 1 100 100
confirmSrpToPwForm 22 22 23 0 22 23
pwFormToMetricsScreen 16 15 16 0 16 16
metricsToWalletReadyScreen 17 16 18 1 17 18
doneButtonToHomeScreen 651 588 755 60 661 755
openAccountMenuToAccountListLoaded 2920 2918 2924 3 2924 2924
total 3951 3888 4049 60 3970 4049
Onboarding New Wallet createWalletToSocialScreen 218 217 220 1 219 220
srpButtonToPwForm 104 104 105 0 105 105
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 36 33 39 2 36 39
agreeButtonToOnboardingSuccess 16 15 16 0 16 16
doneButtonToAssetList 512 475 583 39 525 583
total 905 855 965 43 946 965
Asset Details assetClickToPriceChart 149 118 199 30 168 199
total 149 118 199 30 168 199
Solana Asset Details assetClickToPriceChart 81 71 87 7 87 87
total 81 71 87 7 87 87
Import Srp Home loginToHomeScreen 2220 2148 2303 69 2271 2303
openAccountMenuAfterLogin 69 44 106 22 76 106
homeAfterImportWithNewWallet 2650 2353 2921 187 2747 2921
total 4970 4905 5062 67 5062 5062
Send Transactions openSendPageFromHome 52 26 73 21 70 73
selectTokenToSendFormLoaded 35 31 38 3 38 38
reviewTransactionToConfirmationPage 1104 1051 1135 38 1135 1135
total 1197 1154 1248 39 1248 1248
Swap openSwapPageFromHome 18 17 18 1 18 18
fetchAndDisplaySwapQuotes 2683 2683 2684 0 2684 2684
total 2702 2701 2703 1 2702 2703

🌐 Dapp Page Load Benchmarks

Current Commit: bcfe395 | Date: 3/11/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±43ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 740ms (±40ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 81ms (±10ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	43ms	1.03s	1.35s	1.07s	1.35s
domContentLoaded	740ms	40ms	718ms	1.03s	753ms	1.03s
firstPaint	81ms	10ms	60ms	152ms	88ms	152ms
firstContentfulPaint	81ms	10ms	60ms	152ms	88ms	152ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 58 Bytes (0%)
ui: -41.65 KiB (-0.49%)
common: -325 Bytes (0%)

gantunesr

Approved for accounts

- test/e2e/tests/identity/contact-syncing/backup-and-sync-settings.spec.ts
- test/e2e/tests/identity/contact-syncing/sync-existing-user.spec.ts
- test/e2e/tests/identity/contact-syncing/sync-new-user.spec.ts

NidhiKJha temporarily deployed to pr-comment March 9, 2026 14:32 — with GitHub Actions Inactive

metamaskbot added the team-core-extension-ux Core Extension UX team label Mar 9, 2026

github-actions bot added the size-XL label Mar 9, 2026

refactor

a010299

NidhiKJha temporarily deployed to pr-comment March 9, 2026 16:09 — with GitHub Actions Inactive

NidhiKJha temporarily deployed to pr-comment March 9, 2026 16:38 — with GitHub Actions Inactive

updated lint errrors

162a90e

NidhiKJha temporarily deployed to pr-comment March 10, 2026 09:37 — with GitHub Actions Inactive

NidhiKJha temporarily deployed to pr-comment March 10, 2026 10:05 — with GitHub Actions Inactive

lint fix

8d63fd3

NidhiKJha temporarily deployed to pr-comment March 10, 2026 11:18 — with GitHub Actions Inactive

baseline error fix

ac9f364

NidhiKJha temporarily deployed to pr-comment March 10, 2026 11:32 — with GitHub Actions Inactive

NidhiKJha temporarily deployed to pr-comment March 10, 2026 12:00 — with GitHub Actions Inactive

updated lint errors and css

a3d13ea

NidhiKJha temporarily deployed to pr-comment March 10, 2026 12:22 — with GitHub Actions Inactive

added green color for copied state

3a95042

NidhiKJha had a problem deploying to pr-comment March 10, 2026 12:26 — with GitHub Actions Error

NidhiKJha marked this pull request as ready for review March 10, 2026 12:26

NidhiKJha requested review from a team as code owners March 10, 2026 12:26

NidhiKJha had a problem deploying to pr-comment March 10, 2026 12:26 — with GitHub Actions Error

Merge branch 'main' into CEUX-940-add-contacts-metrics-and-replace-th…

c464655

…e-settings-contact

NidhiKJha temporarily deployed to pr-comment March 10, 2026 12:26 — with GitHub Actions Inactive

cursor bot reviewed Mar 10, 2026

View reviewed changes

ui/pages/contacts/components/contact-list-item.tsx Outdated Show resolved Hide resolved

ui/pages/contacts/contacts-list-page.tsx Show resolved Hide resolved

lint fix

e6b1bc4

NidhiKJha temporarily deployed to pr-comment March 11, 2026 11:54 — with GitHub Actions Inactive

cursor bot reviewed Mar 11, 2026

View reviewed changes

test/e2e/page-objects/pages/settings/contacts-settings.ts Show resolved Hide resolved

NidhiKJha temporarily deployed to pr-comment March 11, 2026 12:25 — with GitHub Actions Inactive

seaona reviewed Mar 11, 2026

View reviewed changes

test/e2e/page-objects/pages/settings/contacts-settings.ts Outdated Show resolved Hide resolved

seaona reviewed Mar 11, 2026

View reviewed changes

seaona previously approved these changes Mar 11, 2026

View reviewed changes

ameliejyc reviewed Mar 11, 2026

View reviewed changes

lint fix

bcfe395

NidhiKJha dismissed seaona’s stale review via bcfe395 March 11, 2026 13:17

NidhiKJha temporarily deployed to pr-comment March 11, 2026 13:17 — with GitHub Actions Inactive

NidhiKJha commented Mar 11, 2026

View reviewed changes

ui/pages/contacts/components/contact-networks.tsx Show resolved Hide resolved

NidhiKJha commented Mar 11, 2026

View reviewed changes

ui/pages/contacts/contacts-list-page.tsx Show resolved Hide resolved

NidhiKJha requested review from ameliejyc and seaona March 11, 2026 13:45

NidhiKJha temporarily deployed to pr-comment March 11, 2026 13:48 — with GitHub Actions Inactive

seaona approved these changes Mar 11, 2026

View reviewed changes

ameliejyc approved these changes Mar 11, 2026

View reviewed changes

NidhiKJha enabled auto-merge March 11, 2026 13:58

gantunesr approved these changes Mar 11, 2026

View reviewed changes

NidhiKJha added this pull request to the merge queue Mar 11, 2026

Merged via the queue into main with commit cc257bc Mar 11, 2026
182 of 184 checks passed

NidhiKJha deleted the CEUX-940-add-contacts-metrics-and-replace-the-settings-contact branch March 11, 2026 15:03

github-actions bot locked and limited conversation to collaborators Mar 11, 2026

metamaskbot added the release-13.23.0 Issue or pull request that will be included in release 13.23.0 label Mar 11, 2026

NidhiKJha restored the CEUX-940-add-contacts-metrics-and-replace-the-settings-contact branch March 12, 2026 14:42

Conversation

NidhiKJha commented Mar 9, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbotv2 bot commented Mar 9, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Mar 10, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Mar 10, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

metamaskbotv2 bot commented Mar 11, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

seaona left a comment

Choose a reason for hiding this comment

Uh oh!

ameliejyc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Mar 11, 2026

Quality Gate failed

Uh oh!

metamaskbotv2 bot commented Mar 11, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

gantunesr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

NidhiKJha commented Mar 9, 2026 •

edited by cursor bot

Loading