feat: adds skeleton loader for quote fetching#40702
Merged
ghgoodreau merged 8 commits intomainfrom Mar 12, 2026
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨🔄 @MetaMask/swaps-engineers (6 files, +183 -107)
|
Contributor
Builds ready [240ac68]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [5f85e51]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [9df1659]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [70a2cc3]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [33c2a22]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
infiniteflower
previously approved these changes
Mar 10, 2026
micaelae
previously approved these changes
Mar 10, 2026
5349745
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Contributor
Builds ready [5349745]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
micaelae
reviewed
Mar 11, 2026
| // If the old toToken's chain is disabled, it can't be set as the | ||
| // fromToken, so fall back to a supported default token. | ||
| if ( | ||
| fromChains.every( |
Member
There was a problem hiding this comment.
This has been moved to actions.ts as "setToToken". Can you verify if the logic is the same and update this if so?
Contributor
Author
There was a problem hiding this comment.
erroneously added during a merge conflict resolution - this should be good now
|
Contributor
Builds ready [514e043]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Contributor
Builds ready [514e043]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
micaelae
approved these changes
Mar 12, 2026
infiniteflower
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the fox loader and 'calculating...' with skeleton loader animations.
Changelog
CHANGELOG entry: improves the loading experience during quote fetching.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk UI-only change that alters loading states for bridge quote fetching; main risk is minor regressions in conditional rendering/tests for the initial quote-loading path.
Overview
Improves the bridge quote-fetching UX by replacing the previous “Calculating…” / fox loader indicators with skeleton loaders.
The destination amount input can now render a
Skeletonwhile quotes are loading (via a newshowAmountSkeletonprop), and the quote details area shows a newMultichainBridgeQuoteCardSkeletonduring initial quote load; the footer CTA area no longer renders during that initial loading state.Removes the
bridgeCalculatingAmounti18n string from all locales and updates/extends tests to cover the new skeleton-rendering behavior.Written by Cursor Bugbot for commit 514e043. This will update automatically on new commits. Configure here.