chore: replace deprecated identicon by n3ps · Pull Request #40687 · MetaMask/metamask-extension

n3ps · 2026-03-06T21:41:49Z

Description

Replace the token avatar component in the add suggested token screen

(Part of cleaning up usages of the deprecated identicon component)

Changelog

CHANGELOG entry: chore: replace deprecated identicon

Related issues

Fixes:

Manual testing steps

Trigger wallet_watchAsset

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI-only change that swaps the token avatar component and tweaks layout spacing; no changes to token add/cancel logic or data handling.

Overview
Updates the confirm-add-suggested-token page to stop using the deprecated Identicon and instead render token images via the design-system AvatarToken (AvatarTokenSize.Xl).

Also adjusts the token row layout by adding a gap-2 spacing class around the avatar/name block.

^{Written by Cursor Bugbot for commit e7bf871. This will update automatically on new commits. Configure here.}

github-actions · 2026-03-06T21:42:01Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

sonarqubecloud · 2026-03-06T21:54:41Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-03-06T22:15:38Z

Builds ready [e7bf871]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 278 267 302 14 271 302
total 278 267 302 14 271 302
Confirm Tx confirm_tx 6047 6042 6052 4 6046 6052
total 6047 6042 6052 4 6046 6052
Bridge User Actions bridge_load_page 270 202 354 53 302 354
bridge_load_asset_picker 225 197 271 29 229 271
bridge_search_token 756 710 793 30 766 793
total 1259 1239 1280 17 1280 1280

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1413 1214 1680 107 1447 1631
load 1181 997 1401 91 1214 1379
domContentLoaded 1175 976 1396 88 1207 1346
domInteractive 28 17 101 17 26 75
firstPaint 142 71 428 76 175 302
backgroundConnect 219 196 356 20 223 245
firstReactRender 19 13 47 5 20 30
initialActions 1 0 7 1 2 4
loadScripts 972 786 1196 87 1001 1151
setupStore 13 6 48 7 14 26
numNetworkReqs 32 22 91 19 31 82
Power User Home uiStartup 2308 1696 4844 723 2210 4419
load 1225 1072 1802 158 1242 1645
domContentLoaded 1210 1063 1784 158 1224 1614
domInteractive 38 18 207 29 37 105
firstPaint 224 78 1746 205 272 362
backgroundConnect 478 267 3281 555 336 1924
firstReactRender 24 16 56 6 25 35
initialActions 1 0 7 1 1 2
loadScripts 990 853 1573 151 1009 1365
setupStore 16 7 49 7 17 29
numNetworkReqs 78 37 177 42 95 169

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 218 221 1 220 221
srpButtonToSrpForm 94 93 96 1 95 96
confirmSrpToPwForm 22 21 22 0 22 22
pwFormToMetricsScreen 15 15 16 0 16 16
metricsToWalletReadyScreen 16 15 17 1 17 17
doneButtonToHomeScreen 809 600 1024 161 968 1024
openAccountMenuToAccountListLoaded 2809 2492 2942 175 2934 2942
total 3985 3882 4083 82 4053 4083
Onboarding New Wallet createWalletToSocialScreen 218 216 220 2 219 220
srpButtonToPwForm 106 104 110 2 106 110
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 35 34 36 1 36 36
agreeButtonToOnboardingSuccess 16 16 16 0 16 16
doneButtonToAssetList 493 470 529 23 496 529
total 885 857 922 26 897 922
Asset Details assetClickToPriceChart 150 84 239 54 163 239
total 150 84 239 54 163 239
Solana Asset Details assetClickToPriceChart 74 70 80 4 75 80
total 74 70 80 4 75 80
Import Srp Home loginToHomeScreen 2038 1917 2294 140 2074 2294
openAccountMenuAfterLogin 39 33 48 5 38 48
homeAfterImportWithNewWallet 2510 2371 2685 111 2569 2685
total 4480 4327 4611 124 4592 4611
Send Transactions openSendPageFromHome 52 19 72 20 71 72
selectTokenToSendFormLoaded 34 20 48 11 47 48
reviewTransactionToConfirmationPage 1299 850 1791 380 1500 1791
total 1385 895 1892 404 1618 1892
Swap openSwapPageFromHome 23 20 28 3 22 28
fetchAndDisplaySwapQuotes 2686 2684 2688 2 2687 2688
total 2712 2706 2718 5 2715 2718

🌐 Dapp Page Load Benchmarks

Current Commit: e7bf871 | Date: 3/6/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.08s (±73ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 763ms (±69ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 83ms (±15ms) 🟢 | historical mean value: 81ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.08s	73ms	1.03s	1.43s	1.33s	1.43s
domContentLoaded	763ms	69ms	719ms	1.09s	986ms	1.09s
firstPaint	83ms	15ms	64ms	212ms	96ms	212ms
firstContentfulPaint	83ms	15ms	64ms	212ms	96ms	212ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 5.15 MiB (100%)
ui: 8.2 MiB (100%)
common: 10.99 MiB (100%)

replace deprecated identicon

e7bf871

n3ps temporarily deployed to pr-comment March 6, 2026 21:41 — with GitHub Actions Inactive

metamaskbot added the team-core-extension-ux Core Extension UX team label Mar 6, 2026

n3ps enabled auto-merge March 6, 2026 21:42

github-actions bot added the size-S label Mar 6, 2026

HowardBraham approved these changes Mar 6, 2026

View reviewed changes

n3ps temporarily deployed to pr-comment March 6, 2026 22:11 — with GitHub Actions Inactive

georgewrmarshall approved these changes Mar 7, 2026

View reviewed changes

n3ps added this pull request to the merge queue Mar 7, 2026

Merged via the queue into main with commit 2ddb15e Mar 7, 2026
202 of 203 checks passed

n3ps deleted the n3ps/cleanup-identicon-add-token branch March 7, 2026 02:57

github-actions bot locked and limited conversation to collaborators Mar 7, 2026

metamaskbot added the release-13.23.0 Issue or pull request that will be included in release 13.23.0 label Mar 7, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: replace deprecated identicon#40687

chore: replace deprecated identicon#40687
n3ps merged 1 commit intomainfrom
n3ps/cleanup-identicon-add-token

n3ps commented Mar 6, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 6, 2026

Uh oh!

sonarqubecloud bot commented Mar 6, 2026

Uh oh!

metamaskbotv2 bot commented Mar 6, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

n3ps commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Mar 6, 2026

Uh oh!

sonarqubecloud bot commented Mar 6, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 bot commented Mar 6, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

n3ps commented Mar 6, 2026 •

edited

Loading