fix: maintain activity tab scroll position by n3ps · Pull Request #40681 · MetaMask/metamask-extension

n3ps · 2026-03-06T18:36:33Z

Description

Maintain scroll position when navigating to the Activity tab

Changelog

CHANGELOG entry: fix: maintain activity tab scroll position

Related issues

Fixes:

Manual testing steps

Scroll down the Tokens list
Switch to the Activity tab

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low-risk UI change that tweaks @tanstack/react-virtual options; main risk is minor scrolling/virtualization regressions (e.g., unexpected jump or offset) in the Activity tab.

Overview
Preserves the Activity tab’s scroll position by initializing the useVirtualizer offset from the current scroll container scrollTop.

Updates the virtualizer to use the shared noAdjustmentsScroll scrollToFn, aligning scroll behavior with other virtualized lists and preventing unwanted scroll adjustments on navigation.

^{Written by Cursor Bugbot for commit f7ceae8. This will update automatically on new commits. Configure here.}

github-actions · 2026-03-06T18:36:44Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-03-06T18:37:15Z

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (1 files, +3 -0)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 activity-v2/
      - 📄 activity-list.tsx +3 -0

sonarqubecloud · 2026-03-06T18:49:17Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-03-06T19:12:00Z

Builds ready [f7ceae8]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 282 275 289 6 285 289
total 282 275 289 6 285 289
Confirm Tx confirm_tx 6051 6004 6078 27 6068 6078
total 6051 6004 6078 27 6068 6078
Bridge User Actions bridge_load_page 246 200 296 38 271 296
bridge_load_asset_picker 226 191 256 25 247 256
bridge_search_token 745 733 760 10 746 760
total 1210 1122 1288 72 1267 1288

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1426 1208 1933 108 1463 1614
load 1191 1001 1570 93 1237 1350
domContentLoaded 1185 999 1562 92 1229 1343
domInteractive 29 17 129 20 25 80
firstPaint 146 67 387 72 201 264
backgroundConnect 210 194 277 13 211 240
firstReactRender 20 13 49 6 21 33
initialActions 1 0 6 1 2 4
loadScripts 991 815 1343 92 1036 1147
setupStore 12 6 35 5 14 22
numNetworkReqs 31 22 89 19 22 81
Power User Home uiStartup 2768 1802 12084 1627 2540 4735
load 1268 1085 2031 185 1305 1662
domContentLoaded 1250 1075 2007 179 1275 1613
domInteractive 40 21 242 32 37 105
firstPaint 200 77 438 86 269 346
backgroundConnect 793 266 10298 1505 371 2469
firstReactRender 25 17 66 8 27 43
initialActions 1 0 6 1 1 4
loadScripts 1020 848 1750 170 1042 1371
setupStore 17 7 107 12 18 31
numNetworkReqs 82 34 246 48 94 201

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 217 220 1 220 220
srpButtonToSrpForm 94 93 96 1 95 96
confirmSrpToPwForm 21 21 22 0 22 22
pwFormToMetricsScreen 15 15 15 0 15 15
metricsToWalletReadyScreen 16 16 16 0 16 16
doneButtonToHomeScreen 611 594 649 22 604 649
openAccountMenuToAccountListLoaded 2916 2902 2934 13 2934 2934
total 3888 3860 3914 20 3897 3914
Onboarding New Wallet createWalletToSocialScreen 222 221 223 1 223 223
srpButtonToPwForm 106 104 108 1 107 108
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 35 34 35 0 35 35
agreeButtonToOnboardingSuccess 16 16 16 0 16 16
doneButtonToAssetList 680 617 725 40 700 725
total 1068 1014 1105 34 1087 1105
Asset Details assetClickToPriceChart 148 128 163 13 157 163
total 148 128 163 13 157 163
Solana Asset Details assetClickToPriceChart 79 74 83 4 82 83
total 79 74 83 4 82 83
Import Srp Home loginToHomeScreen 2335 2111 2620 225 2593 2620
openAccountMenuAfterLogin 68 51 79 10 75 79
homeAfterImportWithNewWallet 2581 2408 2764 126 2675 2764
total 4984 4764 5182 141 5076 5182
Send Transactions openSendPageFromHome 17 16 18 1 16 18
selectTokenToSendFormLoaded 21 18 27 4 22 27
reviewTransactionToConfirmationPage 848 847 848 0 848 848
total 882 881 885 1 882 885
Swap openSwapPageFromHome 19 17 20 1 20 20
fetchAndDisplaySwapQuotes 2682 2681 2684 1 2683 2684
total 2701 2699 2703 1 2701 2703

🌐 Dapp Page Load Benchmarks

Current Commit: f7ceae8 | Date: 3/6/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.07s (±42ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 751ms (±39ms) 🟢 | historical mean value: 740ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 84ms (±14ms) 🟢 | historical mean value: 81ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.07s	42ms	1.04s	1.39s	1.10s	1.39s
domContentLoaded	751ms	39ms	725ms	1.05s	777ms	1.05s
firstPaint	84ms	14ms	68ms	212ms	100ms	212ms
firstContentfulPaint	84ms	14ms	68ms	212ms	100ms	212ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 219 Bytes (0%)
common: 20 Bytes (0%)

fix: activity scroll position

f7ceae8

n3ps requested a review from a team as a code owner March 6, 2026 18:36

n3ps added the team-core-extension-ux Core Extension UX team label Mar 6, 2026

n3ps temporarily deployed to pr-comment March 6, 2026 18:36 — with GitHub Actions Inactive

github-actions bot added the size-XS label Mar 6, 2026

n3ps enabled auto-merge March 6, 2026 18:39

n3ps temporarily deployed to pr-comment March 6, 2026 19:06 — with GitHub Actions Inactive

HowardBraham approved these changes Mar 6, 2026

View reviewed changes

vinnyhoward approved these changes Mar 9, 2026

View reviewed changes

n3ps added this pull request to the merge queue Mar 9, 2026

Merged via the queue into main with commit fb655a9 Mar 9, 2026
194 of 195 checks passed

n3ps deleted the n3ps/fix-activity-scroll branch March 9, 2026 07:14

github-actions bot locked and limited conversation to collaborators Mar 9, 2026

metamaskbot added the release-13.23.0 Issue or pull request that will be included in release 13.23.0 label Mar 9, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: maintain activity tab scroll position#40681

fix: maintain activity tab scroll position#40681
n3ps merged 1 commit intomainfrom
n3ps/fix-activity-scroll

n3ps commented Mar 6, 2026 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Mar 6, 2026

Uh oh!

metamaskbotv2 bot commented Mar 6, 2026

Uh oh!

sonarqubecloud bot commented Mar 6, 2026

Uh oh!

metamaskbotv2 bot commented Mar 6, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

n3ps commented Mar 6, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Mar 6, 2026

Uh oh!

metamaskbotv2 bot commented Mar 6, 2026

✨ Files requiring CODEOWNER review ✨

Uh oh!

sonarqubecloud bot commented Mar 6, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 bot commented Mar 6, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

n3ps commented Mar 6, 2026 •

edited by cursor bot

Loading