fix: error handling for Ledger hardware wallet errors by david0xd · Pull Request #40597 · MetaMask/metamask-extension

david0xd · 2026-03-04T11:09:08Z

Description

This PR adds fix for error handling and message display for Ledger hardware wallets.

Changelog

CHANGELOG entry: Fix error message displayed for Ledger hardware wallets

Related issues

Fixes: #39726

Manual testing steps

Go to MetaMask extension account list and start process for adding hardware wallet.
Choose Ledger.
On Ledger, open apps that are not supported (e.g. Solana, BTC) or close all apps.
Click continue and allow Ledger device to connect to the web browser.
Observe error message displayed at the top of the MetaMask extension page.
Make sure that there are no "UNKNOWN ERRORS".
Make sure that Ethereum app is working as expected.

Screenshots/Recordings

Before

After

Testing with multiple apps or when all are closed
Test device used: Ledger Flex
Browser: Chrome
Running local extension build from main

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI behavior change limited to Ledger connect error messaging; main risk is misclassification of certain errors leading to different user-facing messages.

Overview
Improves Ledger hardware-wallet connection error display by first mapping thrown errors through shared hw-wallet-sdk logic (toHardwareWalletError) and showing the SDK-provided userMessage for recognized Ledger status codes (excluding Unknown/ConnectionClosed).

Keeps the existing fallback error parsing for U2F/timeout/legacy Ledger error codes, but updates LEDGER_ERRORS_CODES messages to be localized via t.

Adds tests covering the new Ledger mapping behavior (mapped status code shows SDK message; unmapped/connection-closed cases fall back to the original error message).

^{Written by Cursor Bugbot for commit b646dc9. This will update automatically on new commits. Configure here.}

github-actions · 2026-03-04T11:09:25Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

montelaidev · 2026-03-04T11:21:41Z

We should be able to use this util to create the error

metamask-extension/ui/contexts/hardware-wallets/rpcErrorUtils.ts

Lines 503 to 508 in d42a431

    
           export function toHardwareWalletError( 
        
             error: unknown, 
        
             walletType: HardwareWalletType, 
        
           ): HardwareWalletError { 
        
             if (error instanceof HardwareWalletError) { 
        
               return error;

metamaskbotv2 · 2026-03-04T11:40:55Z

Builds ready [c384961]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 290 287 293 2 293 293
total 290 287 293 2 293 293
Confirm Tx confirm_tx 6086 6043 6127 32 6107 6127
total 6086 6043 6127 32 6107 6127
Bridge User Actions bridge_load_page 267 248 276 11 273 276
bridge_load_asset_picker 184 130 282 59 221 282
bridge_search_token 716 701 733 13 730 733
total 1127 1104 1155 20 1135 1155

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1387 1159 1765 118 1462 1596
load 1168 949 1444 103 1250 1329
domContentLoaded 1158 934 1436 101 1236 1319
domInteractive 27 16 110 19 24 77
firstPaint 196 62 1317 190 213 348
backgroundConnect 199 181 380 22 201 231
firstReactRender 19 12 47 6 20 31
initialActions 1 0 7 1 2 4
loadScripts 977 757 1251 99 1057 1135
setupStore 13 6 40 6 14 25
numNetworkReqs 31 22 90 20 22 87
Power User Home uiStartup 2502 1432 9732 1849 2105 8727
load 1201 1045 1689 145 1230 1548
domContentLoaded 1184 1032 1670 141 1212 1517
domInteractive 35 19 134 20 34 86
firstPaint 182 78 407 82 252 341
backgroundConnect 878 265 6799 1543 365 5157
firstReactRender 25 15 49 8 26 40
initialActions 1 0 5 1 1 2
loadScripts 970 829 1446 136 1006 1301
setupStore 16 7 48 9 19 40
numNetworkReqs 73 40 163 25 84 127

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 218 216 220 1 218 220
srpButtonToSrpForm 92 91 93 1 92 93
confirmSrpToPwForm 21 21 21 0 21 21
pwFormToMetricsScreen 15 15 15 0 15 15
metricsToWalletReadyScreen 16 15 16 0 16 16
doneButtonToHomeScreen 600 572 635 23 604 635
openAccountMenuToAccountListLoaded 2806 2476 2979 190 2933 2979
total 3857 3823 3883 25 3883 3883
Onboarding New Wallet createWalletToSocialScreen 219 219 219 0 219 219
srpButtonToPwForm 105 104 108 1 105 108
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 35 34 37 1 35 37
agreeButtonToOnboardingSuccess 16 15 16 1 16 16
doneButtonToAssetList 521 485 568 34 552 568
total 912 867 949 35 938 949
Asset Details assetClickToPriceChart 47 42 54 4 49 54
total 47 42 54 4 49 54
Solana Asset Details assetClickToPriceChart 84 80 87 3 87 87
total 84 80 87 3 87 87
Import Srp Home loginToHomeScreen 1996 1904 2056 58 2037 2056
openAccountMenuAfterLogin 54 31 72 17 69 72
homeAfterImportWithNewWallet 2935 2739 3218 191 3095 3218
total 5067 4713 5561 312 5277 5561
Send Transactions openSendPageFromHome 32 26 43 7 38 43
selectTokenToSendFormLoaded 22 18 28 4 23 28
reviewTransactionToConfirmationPage 850 849 850 1 850 850
total 905 893 915 8 909 915
Swap openSwapPageFromHome 114 112 117 2 115 117
fetchAndDisplaySwapQuotes 2898 2897 2900 1 2900 2900
total 3013 3011 3015 1 3015 3015

🌐 Dapp Page Load Benchmarks

Current Commit: c384961 | Date: 3/4/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±39ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 738ms (±37ms) 🟢 | historical mean value: 748ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 81ms (±11ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	39ms	1.03s	1.34s	1.07s	1.34s
domContentLoaded	738ms	37ms	715ms	1.02s	748ms	1.02s
firstPaint	81ms	11ms	64ms	180ms	88ms	180ms
firstContentfulPaint	81ms	11ms	64ms	180ms	88ms	180ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.34 KiB (0.03%)
ui: -7.75 KiB (-0.09%)
common: 618 Bytes (0.01%)

metamaskbotv2 · 2026-03-04T12:32:55Z

Builds ready [da11506]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 302 267 355 36 332 355
total 302 267 355 36 332 355
Confirm Tx confirm_tx 6095 6081 6108 10 6101 6108
total 6095 6081 6108 10 6101 6108
Bridge User Actions bridge_load_page 210 198 224 10 212 224
bridge_load_asset_picker 195 185 205 7 198 205
bridge_search_token 713 703 736 13 709 736
total 1154 1099 1268 63 1176 1268

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1460 1238 1996 104 1501 1631
load 1225 1021 1646 96 1270 1389
domContentLoaded 1218 1016 1617 94 1266 1373
domInteractive 30 18 124 21 25 88
firstPaint 153 75 382 72 210 263
backgroundConnect 214 191 299 16 216 249
firstReactRender 19 13 37 4 20 28
initialActions 1 0 6 1 2 4
loadScripts 1021 814 1406 93 1071 1171
setupStore 13 6 32 5 15 23
numNetworkReqs 31 22 93 20 22 84
Power User Home uiStartup 1799 1457 2641 163 1842 2059
load 1221 1083 1907 172 1199 1693
domContentLoaded 1204 1070 1887 167 1187 1664
domInteractive 42 21 246 35 39 110
firstPaint 204 80 1742 180 258 413
backgroundConnect 312 272 498 27 324 347
firstReactRender 23 16 48 5 24 31
initialActions 1 0 4 1 1 3
loadScripts 975 843 1649 165 952 1459
setupStore 16 8 43 6 18 28
numNetworkReqs 60 37 154 27 58 140

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 218 221 1 220 221
srpButtonToSrpForm 97 92 104 5 102 104
confirmSrpToPwForm 22 21 23 1 22 23
pwFormToMetricsScreen 15 15 16 0 15 16
metricsToWalletReadyScreen 16 16 17 0 17 17
doneButtonToHomeScreen 650 596 710 50 688 710
openAccountMenuToAccountListLoaded 2919 2897 2944 19 2930 2944
total 3931 3875 4012 54 3978 4012
Onboarding New Wallet createWalletToSocialScreen 219 219 219 0 219 219
srpButtonToPwForm 105 102 110 3 105 110
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 36 34 39 2 37 39
agreeButtonToOnboardingSuccess 16 16 16 0 16 16
doneButtonToAssetList 617 480 725 100 686 725
total 1007 864 1108 93 1070 1108
Asset Details assetClickToPriceChart 64 38 98 27 96 98
total 64 38 98 27 96 98
Solana Asset Details assetClickToPriceChart 78 70 83 5 83 83
total 78 70 83 5 83 83
Import Srp Home loginToHomeScreen 2256 1964 2575 209 2386 2575
openAccountMenuAfterLogin 51 44 56 6 56 56
homeAfterImportWithNewWallet 2630 2531 2711 70 2677 2711
total 4971 4890 5120 106 5120 5120
Send Transactions openSendPageFromHome 24 18 36 7 27 36
selectTokenToSendFormLoaded 25 15 34 7 32 34
reviewTransactionToConfirmationPage 851 843 859 7 858 859
total 899 891 913 8 904 913
Swap openSwapPageFromHome 106 102 110 3 106 110
fetchAndDisplaySwapQuotes 2892 2884 2902 6 2896 2902
total 2999 2990 3006 6 3003 3006

🌐 Dapp Page Load Benchmarks

Current Commit: da11506 | Date: 3/4/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±59ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 741ms (±56ms) 🟢 | historical mean value: 748ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 82ms (±9ms) 🟢 | historical mean value: 82ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	59ms	1.02s	1.37s	1.07s	1.37s
domContentLoaded	741ms	56ms	712ms	1.05s	761ms	1.05s
firstPaint	82ms	9ms	68ms	156ms	96ms	156ms
firstContentfulPaint	82ms	9ms	68ms	156ms	96ms	156ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.72 KiB (0.03%)
ui: -4.97 KiB (-0.06%)
common: 617 Bytes (0.01%)

metamaskbotv2 · 2026-03-04T15:29:31Z

Builds ready [21eb102]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 294 265 341 27 306 341
total 294 265 341 27 306 341
Confirm Tx confirm_tx 6068 6045 6087 14 6075 6087
total 6068 6045 6087 14 6075 6087
Bridge User Actions bridge_load_page 229 212 255 16 236 255
bridge_load_asset_picker 207 181 228 18 217 228
bridge_search_token 720 704 743 17 740 743
total 1170 1122 1274 59 1198 1274

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1429 1225 1831 107 1469 1619
load 1202 1013 1485 96 1239 1387
domContentLoaded 1196 1007 1471 95 1235 1379
domInteractive 29 16 124 20 26 79
firstPaint 150 71 413 71 199 264
backgroundConnect 212 194 270 13 216 235
firstReactRender 20 13 50 7 21 33
initialActions 2 0 7 1 2 4
loadScripts 999 803 1255 93 1031 1182
setupStore 13 6 25 4 15 20
numNetworkReqs 31 22 90 19 22 79
Power User Home uiStartup 2172 1470 6620 741 2285 3777
load 1263 1059 2061 160 1281 1666
domContentLoaded 1247 1051 2032 158 1265 1625
domInteractive 39 22 177 28 36 98
firstPaint 206 85 537 102 280 377
backgroundConnect 472 276 2481 394 399 1162
firstReactRender 26 18 62 7 28 39
initialActions 1 0 5 1 1 3
loadScripts 1021 839 1778 152 1032 1399
setupStore 16 6 48 7 19 27
numNetworkReqs 74 39 163 26 83 128

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 217 221 2 220 221
srpButtonToSrpForm 93 92 94 1 93 94
confirmSrpToPwForm 21 21 22 0 22 22
pwFormToMetricsScreen 15 15 15 0 15 15
metricsToWalletReadyScreen 16 15 16 1 16 16
doneButtonToHomeScreen 705 582 846 117 837 846
openAccountMenuToAccountListLoaded 2685 2501 2965 221 2946 2965
total 3753 3538 3912 137 3892 3912
Onboarding New Wallet createWalletToSocialScreen 219 216 222 2 221 222
srpButtonToPwForm 111 103 123 8 118 123
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 34 33 35 1 34 35
agreeButtonToOnboardingSuccess 16 15 16 0 16 16
doneButtonToAssetList 563 492 709 80 589 709
total 918 890 968 30 912 968
Asset Details assetClickToPriceChart 42 37 44 3 44 44
total 42 37 44 3 44 44
Solana Asset Details assetClickToPriceChart 71 67 76 3 71 76
total 71 67 76 3 71 76
Import Srp Home loginToHomeScreen 2004 1972 2051 29 2002 2051
openAccountMenuAfterLogin 51 34 64 10 57 64
homeAfterImportWithNewWallet 2948 2733 3183 175 3104 3183
total 5064 4751 5557 287 5190 5557
Send Transactions openSendPageFromHome 23 16 31 7 30 31
selectTokenToSendFormLoaded 21 20 21 0 21 21
reviewTransactionToConfirmationPage 848 845 850 2 848 850
total 888 883 897 5 889 897
Swap openSwapPageFromHome 120 112 134 9 127 134
fetchAndDisplaySwapQuotes 2894 2893 2895 1 2894 2895
total 3020 3005 3040 13 3027 3040

🌐 Dapp Page Load Benchmarks

Current Commit: 21eb102 | Date: 3/4/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±40ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 730ms (±38ms) 🟢 | historical mean value: 746ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 80ms (±11ms) 🟢 | historical mean value: 82ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	40ms	1.01s	1.34s	1.05s	1.34s
domContentLoaded	730ms	38ms	703ms	1.01s	741ms	1.01s
firstPaint	80ms	11ms	60ms	176ms	88ms	176ms
firstContentfulPaint	80ms	11ms	60ms	176ms	88ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.45 KiB (0.03%)
ui: -2.73 KiB (-0.03%)
common: 442 Bytes (0%)

sonarqubecloud · 2026-03-04T15:42:38Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-03-04T16:26:02Z

Builds ready [b646dc9]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 291 273 307 17 307 307
total 291 273 307 17 307 307
Confirm Tx confirm_tx 6056 6032 6116 35 6038 6116
total 6056 6032 6116 35 6038 6116
Bridge User Actions bridge_load_page 260 242 276 14 271 276
bridge_load_asset_picker 250 173 305 56 303 305
bridge_search_token 723 710 735 11 731 735
total 1248 1135 1349 78 1316 1349

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1410 1189 1840 114 1445 1612
load 1184 968 1504 98 1211 1363
domContentLoaded 1178 966 1495 97 1207 1355
domInteractive 29 17 102 19 25 77
firstPaint 155 66 1257 133 198 286
backgroundConnect 212 191 370 20 216 238
firstReactRender 19 12 46 6 20 31
initialActions 1 0 6 1 2 5
loadScripts 983 786 1290 97 1013 1165
setupStore 12 6 28 5 15 21
numNetworkReqs 31 22 89 19 22 80
Power User Home uiStartup 1979 1333 5681 686 2060 2885
load 1183 1039 1802 157 1183 1583
domContentLoaded 1166 1029 1795 155 1175 1560
domInteractive 39 20 199 29 36 103
firstPaint 195 82 1803 178 253 311
backgroundConnect 428 265 4209 469 342 933
firstReactRender 23 16 56 6 24 32
initialActions 1 0 4 1 1 2
loadScripts 957 810 1560 150 965 1328
setupStore 15 6 41 6 18 25
numNetworkReqs 69 37 165 25 75 126

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 221 220 223 1 221 223
srpButtonToSrpForm 99 99 100 1 99 100
confirmSrpToPwForm 24 23 25 1 24 25
pwFormToMetricsScreen 17 17 17 0 17 17
metricsToWalletReadyScreen 18 18 19 0 18 19
doneButtonToHomeScreen 679 603 803 78 735 803
openAccountMenuToAccountListLoaded 2947 2936 2956 8 2952 2956
total 4018 3923 4136 88 4112 4136
Onboarding New Wallet createWalletToSocialScreen 217 216 219 1 218 219
srpButtonToPwForm 107 107 107 0 107 107
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 35 35 36 1 35 36
agreeButtonToOnboardingSuccess 16 16 16 0 16 16
doneButtonToAssetList 584 489 666 69 642 666
total 972 873 1050 65 1025 1050
Asset Details assetClickToPriceChart 42 34 48 5 44 48
total 42 34 48 5 44 48
Solana Asset Details assetClickToPriceChart 71 67 83 7 67 83
total 71 67 83 7 67 83
Import Srp Home loginToHomeScreen 2080 1887 2254 145 2186 2254
openAccountMenuAfterLogin 37 33 40 3 38 40
homeAfterImportWithNewWallet 2700 2694 2712 8 2712 2712
total 4750 4614 4879 108 4830 4879
Send Transactions openSendPageFromHome 25 25 25 0 25 25
selectTokenToSendFormLoaded 20 19 21 1 21 21
reviewTransactionToConfirmationPage 846 845 849 1 846 849
total 891 883 897 5 893 897
Swap openSwapPageFromHome 115 114 117 1 117 117
fetchAndDisplaySwapQuotes 2892 2891 2893 1 2892 2893
total 3010 3006 3015 4 3014 3015

🌐 Dapp Page Load Benchmarks

Current Commit: b646dc9 | Date: 3/4/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±45ms) 🟡 | historical mean value: 1.06s ⬆️ (historical data)
domContentLoaded-> current mean value: 746ms (±43ms) 🟢 | historical mean value: 746ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 84ms (±18ms) 🟢 | historical mean value: 82ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	45ms	1.02s	1.39s	1.11s	1.39s
domContentLoaded	746ms	43ms	714ms	1.07s	782ms	1.07s
firstPaint	84ms	18ms	64ms	216ms	92ms	216ms
firstContentfulPaint	84ms	18ms	64ms	216ms	92ms	216ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.45 KiB (0.03%)
ui: -2.73 KiB (-0.03%)
common: 442 Bytes (0%)

Fix error handling for Ledger hardware wallet errors

c384961

david0xd self-assigned this Mar 4, 2026

david0xd added the team-accounts-framework Accounts team label Mar 4, 2026

david0xd temporarily deployed to pr-comment March 4, 2026 11:09 — with GitHub Actions Inactive

metamaskbot added the team-extension-platform Extension Platform team label Mar 4, 2026

github-actions bot added the size-S label Mar 4, 2026

david0xd temporarily deployed to pr-comment March 4, 2026 11:36 — with GitHub Actions Inactive

Change approach for error handling

da11506

david0xd temporarily deployed to pr-comment March 4, 2026 12:03 — with GitHub Actions Inactive

david0xd temporarily deployed to pr-comment March 4, 2026 12:28 — with GitHub Actions Inactive

Change approach to use UI only for Ledger error handling

21eb102

david0xd temporarily deployed to pr-comment March 4, 2026 14:59 — with GitHub Actions Inactive

david0xd temporarily deployed to pr-comment March 4, 2026 15:25 — with GitHub Actions Inactive

Add unit tests

b646dc9

david0xd temporarily deployed to pr-comment March 4, 2026 15:29 — with GitHub Actions Inactive

david0xd marked this pull request as ready for review March 4, 2026 16:15

david0xd temporarily deployed to pr-comment March 4, 2026 16:15 — with GitHub Actions Inactive

david0xd temporarily deployed to pr-comment March 4, 2026 16:21 — with GitHub Actions Inactive

hmalik88 approved these changes Mar 4, 2026

View reviewed changes

david0xd enabled auto-merge March 4, 2026 18:43

gantunesr approved these changes Mar 4, 2026

View reviewed changes

david0xd added this pull request to the merge queue Mar 4, 2026

Merged via the queue into main with commit ebc6541 Mar 4, 2026
342 of 347 checks passed

david0xd deleted the dd/fix-hw-wallet-errors branch March 4, 2026 19:34

github-actions bot locked and limited conversation to collaborators Mar 4, 2026

metamaskbot added the release-13.22.0 Issue or pull request that will be included in release 13.22.0 label Mar 4, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: error handling for Ledger hardware wallet errors#40597

fix: error handling for Ledger hardware wallet errors#40597
david0xd merged 4 commits intomainfrom
dd/fix-hw-wallet-errors

david0xd commented Mar 4, 2026 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

montelaidev commented Mar 4, 2026

Uh oh!

metamaskbotv2 bot commented Mar 4, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Mar 4, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Mar 4, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud bot commented Mar 4, 2026

Uh oh!

metamaskbotv2 bot commented Mar 4, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

david0xd commented Mar 4, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

montelaidev commented Mar 4, 2026

Uh oh!

metamaskbotv2 bot commented Mar 4, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Mar 4, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Mar 4, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud bot commented Mar 4, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 bot commented Mar 4, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

david0xd commented Mar 4, 2026 •

edited by cursor bot

Loading