feat: increase swap submission friction when price impact is high by micaelae · Pull Request #40586 · MetaMask/metamask-extension

micaelae · 2026-03-03T22:11:42Z

Description

Changes

Show a price impact error modal before submitting a high-PI transaction to make sure the user agrees with the quoted values
Always show the price impact and indicate warning and error states
Show 0% when price impact is negative

Changelog

CHANGELOG entry: feat: increase swap submission friction when price impact is high

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-4023

Manual testing steps

See acceptance criteria: https://docs.google.com/document/d/1bCKM-dJgJOYBfzPYdcsjDncvr0fL01IWbaWJGzRv8Is/edit?tab=t.0

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Updates bridge transaction submission flow (including hardware-wallet routing) to add a new high price-impact confirmation step, which could affect when/if transactions are sent. Risk is mitigated by added selectors and extensive unit/snapshot test coverage, but mistakes could still block valid swaps or allow unintended submissions.

Overview
Bridge now computes and surfaces price impact as a first-class validation signal. New selectors parse quote.priceData.priceImpact, format it for display, and derive isPriceImpactWarning/isPriceImpactError using feature-flag thresholds (with defaults for warning/error). Negative/invalid price impact is now treated as 0%.

High price impact submissions add friction via a new modal. BridgeCTAButton opens BridgePriceImpactWarningModal instead of submitting when isPriceImpactError, and the quote card always shows a Price impact row with warning/error styling plus a details button that opens the modal.

Submission logic is centralized and hardened. useSubmitBridgeTransaction now owns isSubmitting, performs hardware-wallet ensureDeviceReady() checks, routes hardware wallets to the awaiting-signatures page, and prevents duplicate submits; tests and mocks were updated accordingly.

Localization and tests updated. Adds new bridgePriceImpact* strings (and proceed) in en/en_GB, removes the old bridgePriceImpactNormalWarning string from many locales, updates mock quote/store data to include priceData.priceImpact and priceImpactThreshold, and adds/updates unit and snapshot tests (including baseline adjustments).

^{Written by Cursor Bugbot for commit b651eb7. This will update automatically on new commits. Configure here.}

metamaskbotv2 · 2026-03-03T22:12:29Z

✨ Files requiring CODEOWNER review ✨

🔄 @MetaMask/swaps-engineers (11 files, +1015 -113)

📁 test/
- 📁 data/
  - 📁 bridge/
    - 📄 mock-bridge-store.ts +6 -0
    - 📄 mock-quotes-native-erc20.json +6 -0
📁 ui/
- 📁 ducks/
  - 📁 bridge/
    - 📄 selectors.test.ts +72 -0
    - 📄 selectors.ts +45 -1
- 📁 pages/
  - 📁 bridge/
    - 📁 hooks/
      - 📁 __snapshots__/
        
        📄 useSubmitBridgeTransaction.test.tsx.snap +2 -2
        
        📄 useSubmitBridgeTransaction.test.tsx +122 -23
        
        📄 useSubmitBridgeTransaction.ts +47 -46
    - 📁 prepare/
      - 📁 __snapshots__/
        
        📄 bridge-price-impact-modal.test.tsx.snap +563 -0
        
        📄 bridge-cta-button.test.tsx +137 -10
        
        📄 bridge-cta-button.tsx +11 -30
      - 📄 index.test.tsx +4 -1

metamaskbotv2 · 2026-03-03T22:44:54Z

Builds ready [6bf0778]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 279 269 290 8 278 290
total 279 269 290 8 278 290
Confirm Tx confirm_tx 6059 6013 6093 28 6080 6093
total 6059 6013 6093 28 6080 6093
Bridge User Actions bridge_load_page 243 216 259 17 257 259
bridge_load_asset_picker 247 183 331 51 265 331
bridge_search_token 733 713 748 14 744 748
total 1200 1136 1256 44 1221 1256

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1488 1239 1931 120 1534 1710
load 1260 1045 1597 105 1313 1421
domContentLoaded 1252 1038 1584 103 1308 1415
domInteractive 30 17 123 22 27 87
firstPaint 209 70 1390 220 247 394
backgroundConnect 219 196 275 17 225 254
firstReactRender 19 12 48 7 20 35
initialActions 1 0 8 2 2 5
loadScripts 1052 833 1372 103 1107 1209
setupStore 15 7 107 11 17 28
numNetworkReqs 31 22 94 20 22 87
Power User Home uiStartup 2472 1428 9976 1481 2312 4922
load 1212 1051 1865 162 1220 1652
domContentLoaded 1192 1042 1713 148 1203 1574
domInteractive 40 19 204 32 36 121
firstPaint 209 86 475 95 276 397
backgroundConnect 697 258 3993 859 476 2789
firstReactRender 24 16 54 7 26 35
initialActions 1 0 6 1 1 2
loadScripts 978 825 1438 140 1001 1345
setupStore 15 5 44 7 16 32
numNetworkReqs 67 33 139 24 82 115

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 217 217 218 0 218 218
srpButtonToSrpForm 91 89 93 1 92 93
confirmSrpToPwForm 21 21 22 1 22 22
pwFormToMetricsScreen 14 14 15 0 14 15
metricsToWalletReadyScreen 16 15 16 0 15 16
doneButtonToHomeScreen 593 584 608 9 590 608
openAccountMenuToAccountListLoaded 2940 2911 2972 21 2948 2972
total 3924 3862 3999 47 3948 3999
Onboarding New Wallet createWalletToSocialScreen 218 216 220 1 219 220
srpButtonToPwForm 108 103 116 5 113 116
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 36 35 36 0 36 36
agreeButtonToOnboardingSuccess 16 15 16 0 16 16
doneButtonToAssetList 608 474 740 109 698 740
total 996 856 1146 115 1079 1146
Asset Details assetClickToPriceChart 37 35 39 2 38 39
total 37 35 39 2 38 39
Solana Asset Details assetClickToPriceChart 71 67 75 3 73 75
total 71 67 75 3 73 75
Import Srp Home loginToHomeScreen 1998 1950 2068 45 2006 2068
openAccountMenuAfterLogin 50 42 64 9 58 64
homeAfterImportWithNewWallet 2709 2580 2876 112 2775 2876
total 4837 4809 4868 24 4868 4868
Send Transactions openSendPageFromHome 17 17 18 0 18 18
selectTokenToSendFormLoaded 18 15 20 2 19 20
reviewTransactionToConfirmationPage 958 844 1165 128 1051 1165
total 994 881 1200 128 1084 1200
Swap openSwapPageFromHome 120 118 122 2 121 122
fetchAndDisplaySwapQuotes 2885 2882 2890 3 2886 2890
total 3004 3002 3006 2 3006 3006

🌐 Dapp Page Load Benchmarks

Current Commit: 6bf0778 | Date: 3/3/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±41ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 740ms (±38ms) 🟢 | historical mean value: 742ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 81ms (±12ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	41ms	1.02s	1.35s	1.08s	1.35s
domContentLoaded	740ms	38ms	716ms	1.02s	772ms	1.02s
firstPaint	81ms	12ms	64ms	192ms	96ms	192ms
firstContentfulPaint	81ms	12ms	64ms	192ms	96ms	192ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: -25 Bytes (0%)
common: 20 Bytes (0%)

metamaskbotv2 · 2026-03-03T23:45:09Z

Builds ready [369df73]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 307 272 337 23 324 337
total 307 272 337 23 324 337
Confirm Tx confirm_tx 6065 6053 6082 11 6065 6082
total 6065 6053 6082 11 6065 6082
Bridge User Actions bridge_load_page 243 237 247 4 245 247
bridge_load_asset_picker 231 170 304 45 248 304
bridge_search_token 728 704 744 14 739 744
total 1196 1115 1260 49 1218 1260

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1420 1185 1798 109 1477 1620
load 1191 974 1457 100 1244 1388
domContentLoaded 1182 970 1452 98 1240 1378
domInteractive 30 17 102 19 26 82
firstPaint 193 68 1284 201 216 346
backgroundConnect 205 180 255 14 208 234
firstReactRender 19 11 44 5 21 31
initialActions 2 0 6 1 2 4
loadScripts 997 789 1240 96 1057 1193
setupStore 13 7 41 5 16 22
numNetworkReqs 31 21 98 20 22 87
Power User Home uiStartup 1676 1289 2206 165 1737 1993
load 1147 1016 1672 139 1137 1517
domContentLoaded 1132 1008 1657 135 1122 1510
domInteractive 32 19 106 14 34 53
firstPaint 166 73 413 79 215 329
backgroundConnect 293 261 349 19 301 328
firstReactRender 23 15 42 7 24 39
initialActions 1 0 7 1 1 3
loadScripts 920 807 1421 132 911 1254
setupStore 15 7 47 7 17 25
numNetworkReqs 56 36 155 24 55 110

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 221 220 222 1 222 222
srpButtonToSrpForm 97 96 100 1 98 100
confirmSrpToPwForm 22 22 23 0 23 23
pwFormToMetricsScreen 16 15 17 0 16 17
metricsToWalletReadyScreen 16 15 17 1 17 17
doneButtonToHomeScreen 619 609 645 15 613 645
openAccountMenuToAccountListLoaded 2916 2914 2917 1 2917 2917
total 3903 3875 3931 20 3905 3931
Onboarding New Wallet createWalletToSocialScreen 220 218 222 1 219 222
srpButtonToPwForm 115 107 134 11 119 134
createPwToRecoveryScreen 9 8 9 0 9 9
skipBackupToMetricsScreen 36 35 37 1 36 37
agreeButtonToOnboardingSuccess 16 16 17 0 16 17
doneButtonToAssetList 614 603 633 13 633 633
total 1003 989 1025 16 1025 1025
Asset Details assetClickToPriceChart 57 38 86 18 66 86
total 57 38 86 18 66 86
Solana Asset Details assetClickToPriceChart 78 66 88 8 82 88
total 78 66 88 8 82 88
Import Srp Home loginToHomeScreen 2051 1897 2353 176 2150 2353
openAccountMenuAfterLogin 51 33 64 11 60 64
homeAfterImportWithNewWallet 2800 2571 2993 164 2961 2993
total 4902 4571 5406 300 4995 5406
Send Transactions openSendPageFromHome 27 24 31 3 28 31
selectTokenToSendFormLoaded 19 16 21 2 19 21
reviewTransactionToConfirmationPage 846 846 846 0 846 846
total 891 889 896 3 890 896
Swap openSwapPageFromHome 104 99 107 3 106 107
fetchAndDisplaySwapQuotes 2894 2890 2899 4 2898 2899
total 2997 2991 3006 6 2996 3006

🌐 Dapp Page Load Benchmarks

Current Commit: 369df73 | Date: 3/3/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±45ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 740ms (±37ms) 🟢 | historical mean value: 742ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 82ms (±11ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	45ms	1.02s	1.34s	1.10s	1.34s
domContentLoaded	740ms	37ms	711ms	1.01s	759ms	1.01s
firstPaint	82ms	11ms	72ms	172ms	92ms	172ms
firstContentfulPaint	82ms	11ms	72ms	172ms	92ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 162 Bytes (0%)
common: 156 Bytes (0%)

metamaskbotv2 · 2026-03-04T18:45:54Z

Builds ready [3312657]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 416 268 714 178 529 714
total 416 268 714 178 529 714
Confirm Tx confirm_tx 6074 6061 6082 9 6082 6082
total 6074 6061 6082 9 6082 6082
Bridge User Actions bridge_load_page 268 250 299 19 270 299
bridge_load_asset_picker 184 124 237 47 233 237
bridge_search_token 722 704 757 19 728 757
total 1162 1093 1264 76 1244 1264

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1463 1249 1895 105 1516 1639
load 1226 1006 1588 98 1273 1402
domContentLoaded 1220 1000 1582 98 1267 1395
domInteractive 30 18 113 21 25 92
firstPaint 183 75 1368 143 227 316
backgroundConnect 218 199 268 15 225 251
firstReactRender 21 12 52 7 21 35
initialActions 2 0 14 2 2 6
loadScripts 1018 815 1384 96 1070 1182
setupStore 14 6 39 6 17 26
numNetworkReqs 31 22 92 20 22 83
Power User Home uiStartup 2587 1424 10044 1379 3697 4162
load 1244 1090 1777 141 1278 1570
domContentLoaded 1225 1074 1760 140 1251 1545
domInteractive 35 20 173 23 34 77
firstPaint 214 89 1271 142 272 374
backgroundConnect 908 257 8177 1196 1335 2566
firstReactRender 23 16 46 6 24 37
initialActions 1 0 10 1 1 3
loadScripts 1009 869 1517 134 1035 1338
setupStore 16 7 41 7 18 33
numNetworkReqs 79 43 154 24 87 123

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 219 220 1 219 220
srpButtonToSrpForm 92 92 93 0 93 93
confirmSrpToPwForm 21 21 22 0 21 22
pwFormToMetricsScreen 15 15 15 0 15 15
metricsToWalletReadyScreen 16 15 17 1 16 17
doneButtonToHomeScreen 641 598 706 40 660 706
openAccountMenuToAccountListLoaded 2932 2927 2937 4 2936 2937
total 3914 3891 3937 20 3930 3937
Onboarding New Wallet createWalletToSocialScreen 222 217 228 5 227 228
srpButtonToPwForm 106 105 108 1 107 108
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 36 35 36 1 36 36
agreeButtonToOnboardingSuccess 16 15 16 0 16 16
doneButtonToAssetList 613 493 886 154 682 886
total 1001 879 1270 151 1065 1270
Asset Details assetClickToPriceChart 46 43 49 2 46 49
total 46 43 49 2 46 49
Solana Asset Details assetClickToPriceChart 94 67 134 30 127 134
total 94 67 134 30 127 134
Import Srp Home loginToHomeScreen 2038 2031 2051 9 2051 2051
openAccountMenuAfterLogin 61 52 67 6 66 67
homeAfterImportWithNewWallet 3011 2818 3317 191 3142 3317
total 4997 4830 5241 152 4990 5241
Send Transactions openSendPageFromHome 22 18 27 3 24 27
selectTokenToSendFormLoaded 24 19 28 4 28 28
reviewTransactionToConfirmationPage 850 845 863 7 847 863
total 896 885 915 11 893 915
Swap openSwapPageFromHome 33 31 35 2 35 35
fetchAndDisplaySwapQuotes 2904 2894 2915 10 2913 2915
total 2934 2924 2947 10 2947 2947

🌐 Dapp Page Load Benchmarks

Current Commit: 3312657 | Date: 3/4/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.02s (±70ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 716ms (±85ms) 🟢 | historical mean value: 740ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 96ms (±148ms) 🟢 | historical mean value: 82ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.02s	70ms	976ms	1.60s	1.08s	1.60s
domContentLoaded	716ms	85ms	681ms	1.50s	749ms	1.50s
firstPaint	96ms	148ms	68ms	1.56s	96ms	1.56s
firstContentfulPaint	96ms	148ms	68ms	1.56s	96ms	1.56s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 162 Bytes (0%)
common: 156 Bytes (0%)

ui/ducks/bridge/selectors.test.ts

ui/pages/bridge/hooks/useSubmitBridgeTransaction.ts

ui/pages/bridge/quotes/multichain-bridge-quote-card.tsx

ui/ducks/bridge/selectors.test.ts

micaelae · 2026-03-05T22:11:29Z

ui/pages/bridge/hooks/useSubmitBridgeTransaction.ts

+    try {
+      if (isHardwareWalletAccount) {
+        const isDeviceReady = await ensureDeviceReady();


This try-catch block was moved over from bridge-cta-button so that the same submission flow can be used by the price impact modal Proceed button

ui/pages/bridge/hooks/useSubmitBridgeTransaction.ts

ui/pages/bridge/quotes/multichain-bridge-quote-card.tsx

ui/pages/bridge/hooks/useSubmitBridgeTransaction.ts

ui/pages/bridge/prepare/bridge-price-impact-modal.tsx

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

ui/ducks/bridge/selectors.ts

metamaskbotv2 · 2026-03-06T01:48:04Z

Builds ready [b651eb7]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 288 275 310 13 285 310
total 288 275 310 13 285 310
Confirm Tx confirm_tx 6072 6066 6076 4 6076 6076
total 6072 6066 6076 4 6076 6076
Bridge User Actions bridge_load_page 240 237 244 3 244 244
bridge_load_asset_picker 179 111 238 46 215 238
bridge_search_token 717 705 746 16 724 746
total 1137 1089 1206 53 1198 1206

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1445 1211 1947 122 1502 1631
load 1222 1024 1626 113 1278 1402
domContentLoaded 1214 1018 1617 112 1272 1394
domInteractive 30 18 114 21 26 90
firstPaint 154 71 435 80 209 301
backgroundConnect 217 195 297 16 222 248
firstReactRender 20 13 44 6 21 36
initialActions 1 0 9 1 2 4
loadScripts 1015 811 1422 112 1073 1186
setupStore 13 7 40 6 15 25
numNetworkReqs 32 22 90 19 25 83
Power User Home uiStartup 1964 1657 2598 152 2026 2228
load 1161 1035 1795 141 1155 1525
domContentLoaded 1145 1023 1728 134 1141 1485
domInteractive 35 19 176 25 35 64
firstPaint 174 75 446 77 225 289
backgroundConnect 301 261 414 28 314 355
firstReactRender 23 16 43 6 24 37
initialActions 1 0 7 1 1 2
loadScripts 929 819 1490 131 928 1271
setupStore 16 6 55 7 17 28
numNetworkReqs 68 35 178 43 55 169

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 222 220 224 1 223 224
srpButtonToSrpForm 101 98 106 3 102 106
confirmSrpToPwForm 25 24 26 0 25 26
pwFormToMetricsScreen 18 16 20 1 18 20
metricsToWalletReadyScreen 19 18 20 1 19 20
doneButtonToHomeScreen 634 609 668 22 638 668
openAccountMenuToAccountListLoaded 2923 2915 2934 8 2928 2934
total 3939 3909 3963 20 3949 3963
Onboarding New Wallet createWalletToSocialScreen 219 217 221 2 220 221
srpButtonToPwForm 107 105 108 1 108 108
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 37 35 39 2 38 39
agreeButtonToOnboardingSuccess 16 15 17 0 16 17
doneButtonToAssetList 648 583 773 73 688 773
total 1035 966 1164 75 1076 1164
Asset Details assetClickToPriceChart 130 105 150 19 149 150
total 130 105 150 19 149 150
Solana Asset Details assetClickToPriceChart 73 70 75 2 74 75
total 73 70 75 2 74 75
Import Srp Home loginToHomeScreen 2007 1868 2123 93 2098 2123
openAccountMenuAfterLogin 42 38 45 3 45 45
homeAfterImportWithNewWallet 2419 2389 2445 23 2445 2445
total 4492 4320 4810 179 4556 4810
Send Transactions openSendPageFromHome 21 18 26 3 22 26
selectTokenToSendFormLoaded 18 17 19 1 19 19
reviewTransactionToConfirmationPage 960 846 1125 120 1085 1125
total 1013 885 1233 140 1122 1233
Swap openSwapPageFromHome 39 28 51 8 42 51
fetchAndDisplaySwapQuotes 2700 2684 2731 19 2713 2731
total 2749 2715 2798 32 2773 2798

🌐 Dapp Page Load Benchmarks

Current Commit: b651eb7 | Date: 3/6/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±41ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 735ms (±38ms) 🟢 | historical mean value: 734ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 80ms (±12ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	41ms	1.02s	1.36s	1.07s	1.36s
domContentLoaded	735ms	38ms	713ms	1.02s	758ms	1.02s
firstPaint	80ms	12ms	64ms	184ms	88ms	184ms
firstContentfulPaint	80ms	12ms	64ms	184ms	88ms	184ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 6.03 KiB (0.07%)
common: 581 Bytes (0.01%)

sonarqubecloud · 2026-03-06T20:53:48Z

Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

micaelae added 2 commits March 3, 2026 13:58

chore: always show price impact in quote card

d5f4cee

chore: show 0 when priceImpact is negative

6bf0778

micaelae temporarily deployed to pr-comment March 3, 2026 22:11 — with GitHub Actions Inactive

metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Mar 3, 2026

github-actions bot added the size-XS label Mar 3, 2026

micaelae temporarily deployed to pr-comment March 3, 2026 22:40 — with GitHub Actions Inactive

micaelae temporarily deployed to pr-comment March 3, 2026 22:49 — with GitHub Actions Inactive

github-actions bot added size-S and removed size-XS labels Mar 3, 2026

chore: priceImpact warning and error thresholds

369df73

micaelae force-pushed the swaps4023-price-impact branch from ab1c96b to 369df73 Compare March 3, 2026 23:14

micaelae temporarily deployed to pr-comment March 3, 2026 23:14 — with GitHub Actions Inactive

github-actions bot added size-M and removed size-S labels Mar 3, 2026

micaelae temporarily deployed to pr-comment March 3, 2026 23:40 — with GitHub Actions Inactive

Merge branch 'main' into swaps4023-price-impact

3312657

micaelae temporarily deployed to pr-comment March 4, 2026 18:07 — with GitHub Actions Inactive

micaelae temporarily deployed to pr-comment March 4, 2026 18:34 — with GitHub Actions Inactive

Merge branch 'main' into swaps4023-price-impact

b3aaf61

micaelae temporarily deployed to pr-comment March 4, 2026 19:23 — with GitHub Actions Inactive

micaelae added 4 commits March 4, 2026 11:39

refactor: move CTA onClick logic to useSubmitBridgeTransaction

489098f

feat: price impact modal

88c0059

feat: open price impact modal when there is an error or warning

50a7612

modal

7fe5815

micaelae temporarily deployed to pr-comment March 4, 2026 19:40 — with GitHub Actions Inactive

micaelae temporarily deployed to pr-comment March 4, 2026 20:08 — with GitHub Actions Inactive

cursor bot reviewed Mar 5, 2026

View reviewed changes

ui/ducks/bridge/selectors.test.ts Outdated Show resolved Hide resolved

ui/pages/bridge/hooks/useSubmitBridgeTransaction.ts Show resolved Hide resolved

ui/pages/bridge/quotes/multichain-bridge-quote-card.tsx Show resolved Hide resolved

ui/ducks/bridge/selectors.test.ts Show resolved Hide resolved

micaelae commented Mar 5, 2026

View reviewed changes

fix: add tests

bff7964

micaelae temporarily deployed to pr-comment March 5, 2026 22:19 — with GitHub Actions Inactive

cursor bot reviewed Mar 5, 2026

View reviewed changes

ui/pages/bridge/hooks/useSubmitBridgeTransaction.ts Show resolved Hide resolved

fix: return after HW rejection

e0bfd1b

micaelae temporarily deployed to pr-comment March 5, 2026 22:25 — with GitHub Actions Inactive

micaelae enabled auto-merge March 5, 2026 22:25

cursor bot reviewed Mar 5, 2026

View reviewed changes

ui/pages/bridge/quotes/multichain-bridge-quote-card.tsx Show resolved Hide resolved

chore: price impact tooltip

1d6ab4d

cursor bot reviewed Mar 5, 2026

View reviewed changes

ui/pages/bridge/hooks/useSubmitBridgeTransaction.ts Show resolved Hide resolved

ui/pages/bridge/hooks/useSubmitBridgeTransaction.ts Show resolved Hide resolved

micaelae temporarily deployed to pr-comment March 5, 2026 22:46 — with GitHub Actions Inactive

fix: return after HW rejection

a3ceb9c

cursor bot reviewed Mar 6, 2026

View reviewed changes

ui/pages/bridge/prepare/bridge-price-impact-modal.tsx Show resolved Hide resolved

Merge remote-tracking branch 'origin/main' into swaps4023-price-impact

d843004

micaelae temporarily deployed to pr-comment March 6, 2026 01:04 — with GitHub Actions Inactive

cursor bot reviewed Mar 6, 2026

View reviewed changes

ui/ducks/bridge/selectors.ts Outdated Show resolved Hide resolved

fix: cursor comments

b651eb7

micaelae temporarily deployed to pr-comment March 6, 2026 01:14 — with GitHub Actions Inactive

micaelae temporarily deployed to pr-comment March 6, 2026 01:43 — with GitHub Actions Inactive

ghgoodreau approved these changes Mar 6, 2026

View reviewed changes

SteP-n-s approved these changes Mar 6, 2026

View reviewed changes

micaelae added this pull request to the merge queue Mar 6, 2026

Merged via the queue into main with commit 2c650eb Mar 6, 2026
498 of 506 checks passed

micaelae deleted the swaps4023-price-impact branch March 6, 2026 21:20

github-actions bot locked and limited conversation to collaborators Mar 6, 2026

metamaskbot added the release-13.23.0 Issue or pull request that will be included in release 13.23.0 label Mar 6, 2026

Conversation

micaelae commented Mar 3, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbotv2 bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbotv2 bot commented Mar 3, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Mar 3, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Mar 4, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

micaelae Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

metamaskbotv2 bot commented Mar 6, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud bot commented Mar 6, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

micaelae commented Mar 3, 2026 •

edited by cursor bot

Loading

metamaskbotv2 bot commented Mar 3, 2026 •

edited

Loading