fix: network list migration by n3ps · Pull Request #40579 · MetaMask/metamask-extension

n3ps · 2026-03-03T17:23:21Z

Description

Fixes migration 171 so enabledNetworkMap is merged by namespace + chain ID instead of shallow-overwriting namespace objects.

When both tokenNetworkFilter and selectedMultichainNetworkChainId resolve to eip155, existing EVM entries are now preserved and the selected chain is set to true, rather than collapsing the map to only the selected chain.

Changelog

CHANGELOG entry: fix: network list migration

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Updates state-migration logic for enabledNetworkMap, which can affect users’ persisted network enablement settings if the merge behavior is incorrect. Scope is small and covered by expanded unit tests for EVM and non-EVM cases.

Overview
Migration 171 now merges enabledNetworkMap by namespace while preserving existing chain entries, avoiding the previous shallow spread that could overwrite an entire namespace when both maps resolve to eip155.

Tests were updated/added to assert EVM token filter entries are preserved and that a selected custom EVM chain (and other expected chain IDs) is added/enabled correctly.

^{Written by Cursor Bugbot for commit d1ec7f6. This will update automatically on new commits. Configure here.}

github-actions · 2026-03-03T17:23:33Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

n3ps · 2026-03-03T17:24:28Z

app/scripts/migrations/171.test.ts

      ).toStrictEqual({
        eip155: {
          '0x1': true,
+          '0x89': false,


Evidence that script was not preserving networks

metamaskbotv2 · 2026-03-03T17:53:36Z

Builds ready [ab83042]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 274 272 277 2 277 277
total 274 272 277 2 277 277
Confirm Tx confirm_tx 6060 6048 6075 9 6065 6075
total 6060 6048 6075 9 6065 6075
Bridge User Actions bridge_load_page 266 199 378 65 277 378
bridge_load_asset_picker 173 114 239 47 203 239
bridge_search_token 706 704 708 2 707 708
total 1101 1089 1110 9 1109 1110

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1452 1240 1997 111 1479 1647
load 1221 1031 1631 100 1246 1410
domContentLoaded 1212 1024 1619 97 1240 1393
domInteractive 29 17 117 18 26 76
firstPaint 171 72 1182 132 224 374
backgroundConnect 216 198 381 20 218 238
firstReactRender 21 14 48 6 22 33
initialActions 2 0 8 2 2 5
loadScripts 1013 822 1424 96 1036 1192
setupStore 14 7 35 6 16 27
numNetworkReqs 31 22 91 19 22 83
Power User Home uiStartup 1733 1403 2371 166 1787 2130
load 1150 1038 1677 128 1147 1480
domContentLoaded 1136 1026 1668 126 1132 1453
domInteractive 33 19 120 18 34 76
firstPaint 172 77 519 83 227 299
backgroundConnect 296 259 423 24 304 341
firstReactRender 24 15 57 9 26 46
initialActions 1 0 4 1 1 3
loadScripts 920 819 1412 122 909 1261
setupStore 15 7 42 6 17 27
numNetworkReqs 57 37 152 23 56 117

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 217 222 2 219 222
srpButtonToSrpForm 98 94 104 4 100 104
confirmSrpToPwForm 22 21 23 1 22 23
pwFormToMetricsScreen 16 15 16 0 16 16
metricsToWalletReadyScreen 17 16 19 1 18 19
doneButtonToHomeScreen 609 596 624 10 610 624
openAccountMenuToAccountListLoaded 2926 2913 2941 11 2938 2941
total 3905 3895 3913 7 3910 3913
Onboarding New Wallet createWalletToSocialScreen 220 216 223 2 222 223
srpButtonToPwForm 110 106 116 4 111 116
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 36 36 36 0 36 36
agreeButtonToOnboardingSuccess 16 15 16 0 16 16
doneButtonToAssetList 636 582 675 34 648 675
total 1006 864 1083 80 1069 1083
Asset Details assetClickToPriceChart 50 40 60 7 54 60
total 50 40 60 7 54 60
Solana Asset Details assetClickToPriceChart 108 75 181 41 127 181
total 108 75 181 41 127 181
Import Srp Home loginToHomeScreen 2169 2150 2196 20 2196 2196
openAccountMenuAfterLogin 38 35 42 2 39 42
homeAfterImportWithNewWallet 2790 2453 3509 395 2911 3509
total 4760 4584 5108 204 4684 5108
Send Transactions openSendPageFromHome 20 13 24 4 23 24
selectTokenToSendFormLoaded 25 18 33 6 28 33
reviewTransactionToConfirmationPage 848 846 853 3 847 853
total 892 881 899 7 897 899
Swap openSwapPageFromHome 116 105 129 8 119 129
fetchAndDisplaySwapQuotes 2905 2894 2927 12 2909 2927
total 3014 2999 3023 10 3023 3023

🌐 Dapp Page Load Benchmarks

Current Commit: ab83042 | Date: 3/3/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±58ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 744ms (±56ms) 🟢 | historical mean value: 740ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 81ms (±14ms) 🟢 | historical mean value: 87ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	58ms	1.03s	1.37s	1.10s	1.37s
domContentLoaded	744ms	56ms	714ms	1.05s	778ms	1.05s
firstPaint	81ms	14ms	64ms	208ms	92ms	208ms
firstContentfulPaint	81ms	14ms	64ms	208ms	92ms	208ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.26 KiB (0.04%)
ui: 26.4 KiB (0.32%)
common: -4.47 KiB (-0.04%)

sonarqubecloud · 2026-03-03T18:37:46Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-03-03T22:25:54Z

Builds ready [d1ec7f6]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 293 261 331 24 305 331
total 293 261 331 24 305 331
Confirm Tx confirm_tx 6077 6057 6104 18 6090 6104
total 6077 6057 6104 18 6090 6104
Bridge User Actions bridge_load_page 211 187 228 16 226 228
bridge_load_asset_picker 206 165 255 30 219 255
bridge_search_token 709 700 728 10 714 728
total 1113 1109 1115 3 1115 1115

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1452 1199 1787 116 1506 1653
load 1219 1004 1510 104 1261 1418
domContentLoaded 1212 999 1501 102 1255 1382
domInteractive 30 17 162 23 26 83
firstPaint 161 68 485 86 222 273
backgroundConnect 218 191 403 27 223 260
firstReactRender 21 14 52 7 24 31
initialActions 2 0 9 1 2 4
loadScripts 1014 808 1296 101 1053 1189
setupStore 14 6 62 8 17 27
numNetworkReqs 31 22 93 20 22 84
Power User Home uiStartup 1987 1397 8326 798 2007 2601
load 1218 1054 1896 151 1252 1588
domContentLoaded 1200 1046 1879 144 1229 1561
domInteractive 37 21 152 21 38 72
firstPaint 214 80 1630 170 278 362
backgroundConnect 402 267 3532 412 342 700
firstReactRender 23 16 56 6 25 34
initialActions 1 0 5 1 1 2
loadScripts 977 833 1629 140 1011 1329
setupStore 17 7 44 7 20 28
numNetworkReqs 65 27 142 21 75 104

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 220 219 221 1 220 221
srpButtonToSrpForm 94 94 95 0 94 95
confirmSrpToPwForm 22 22 22 0 22 22
pwFormToMetricsScreen 16 15 16 0 16 16
metricsToWalletReadyScreen 16 15 17 1 17 17
doneButtonToHomeScreen 652 596 714 50 687 714
openAccountMenuToAccountListLoaded 2926 2905 2957 20 2929 2957
total 3946 3877 4020 52 3986 4020
Onboarding New Wallet createWalletToSocialScreen 218 217 218 0 218 218
srpButtonToPwForm 113 108 121 5 117 121
createPwToRecoveryScreen 9 8 9 0 9 9
skipBackupToMetricsScreen 36 35 37 1 36 37
agreeButtonToOnboardingSuccess 16 15 17 1 16 17
doneButtonToAssetList 582 552 630 32 591 630
total 978 939 1016 28 986 1016
Asset Details assetClickToPriceChart 38 37 39 1 39 39
total 38 37 39 1 39 39
Solana Asset Details assetClickToPriceChart 74 68 77 3 77 77
total 74 68 77 3 77 77
Import Srp Home loginToHomeScreen 2032 1783 2255 189 2247 2255
openAccountMenuAfterLogin 49 34 65 12 57 65
homeAfterImportWithNewWallet 2779 2392 3294 312 2949 3294
total 4676 4439 4985 201 4698 4985
Send Transactions openSendPageFromHome 23 21 24 1 23 24
selectTokenToSendFormLoaded 19 18 21 1 20 21
reviewTransactionToConfirmationPage 847 847 848 0 848 848
total 893 887 899 5 897 899
Swap openSwapPageFromHome 113 106 126 8 116 126
fetchAndDisplaySwapQuotes 2905 2889 2932 17 2907 2932
total 3010 3001 3016 7 3016 3016

🌐 Dapp Page Load Benchmarks

Current Commit: d1ec7f6 | Date: 3/3/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±39ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 720ms (±37ms) 🟢 | historical mean value: 743ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 81ms (±15ms) 🟢 | historical mean value: 85ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	39ms	1.02s	1.34s	1.08s	1.34s
domContentLoaded	720ms	37ms	694ms	994ms	750ms	994ms
firstPaint	81ms	15ms	64ms	188ms	96ms	188ms
firstContentfulPaint	81ms	15ms	64ms	188ms	96ms	188ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 149 Bytes (0%)
ui: 5 Bytes (0%)
common: 20 Bytes (0%)

fix: network migration

ab83042

n3ps requested a review from gambinish March 3, 2026 17:23

n3ps added the team-core-extension-ux Core Extension UX team label Mar 3, 2026

n3ps temporarily deployed to pr-comment March 3, 2026 17:23 — with GitHub Actions Inactive

n3ps requested a review from a team March 3, 2026 17:23

n3ps commented Mar 3, 2026

View reviewed changes

n3ps marked this pull request as ready for review March 3, 2026 17:24

n3ps temporarily deployed to pr-comment March 3, 2026 17:24 — with GitHub Actions Inactive

github-actions bot added the size-S label Mar 3, 2026

n3ps temporarily deployed to pr-comment March 3, 2026 17:49 — with GitHub Actions Inactive

Merge branch 'main' into n3ps/fix-networks-migration

d1ec7f6

n3ps temporarily deployed to pr-comment March 3, 2026 18:21 — with GitHub Actions Inactive

n3ps had a problem deploying to pr-comment March 3, 2026 19:03 — with GitHub Actions Failure

n3ps temporarily deployed to pr-comment March 3, 2026 22:21 — with GitHub Actions Inactive

gambinish approved these changes Mar 4, 2026

View reviewed changes

n3ps enabled auto-merge March 5, 2026 18:10

AndyMBridges approved these changes Mar 5, 2026

View reviewed changes

n3ps added this pull request to the merge queue Mar 5, 2026

Merged via the queue into main with commit 887465b Mar 5, 2026
339 of 342 checks passed

n3ps deleted the n3ps/fix-networks-migration branch March 5, 2026 21:20

metamaskbot added the release-13.23.0 Issue or pull request that will be included in release 13.23.0 label Mar 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: network list migration#40579

fix: network list migration#40579
n3ps merged 2 commits intomainfrom
n3ps/fix-networks-migration

n3ps commented Mar 3, 2026 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

n3ps Mar 3, 2026

Uh oh!

metamaskbotv2 bot commented Mar 3, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud bot commented Mar 3, 2026

Uh oh!

metamaskbotv2 bot commented Mar 3, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

n3ps commented Mar 3, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

n3ps Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

metamaskbotv2 bot commented Mar 3, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud bot commented Mar 3, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 bot commented Mar 3, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

n3ps commented Mar 3, 2026 •

edited by cursor bot

Loading