feat: replace Activity list in asset page#40542
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (1 files, +6 -17)
👨🔧 @MetaMask/core-extension-ux (8 files, +6 -2886)
|
n3ps
commented
Mar 2, 2026
|
|
||
| // Token-specific filtering (for asset page) | ||
| const { tokenAddress } = filter ?? {}; | ||
| if (tokenAddress) { |
Contributor
Builds ready [5d4aa87]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
The ActivityList component uses @tanstack/react-query's useInfiniteQuery which behaves differently in CI vs local environments. In CI, nock's disableNetConnect() immediately rejects the API request, causing the query to resolve to error state (isInitialLoading=false), rendering the empty state. Locally, the query may stay in loading state during snapshot capture. Mocking ActivityList makes the snapshot deterministic since asset-page tests are for AssetPage, not ActivityList internals. Co-authored-by: Francis Nepomuceno <n3ps@users.noreply.github.com>
Contributor
Builds ready [5771551]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Co-authored-by: Francis Nepomuceno <n3ps@users.noreply.github.com>
Contributor
Builds ready [699f96b]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
|
Contributor
Builds ready [4c52ee4]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
NidhiKJha
approved these changes
Mar 4, 2026
gantunesr
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reuse the new ActivityList (v2) component on the token/asset detail page, replacing the old UnifiedTransactionList. The ActivityList now accepts an optional filter (tokenAddress, chainId)
Changelog
CHANGELOG entry: feat: replace activity list in asset page
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Changes the asset detail activity feed to a new, filterable
ActivityListand removes the legacy transaction list implementation, which could affect which transactions appear (or pagination/virtualization behavior) on asset pages.Overview
Replaces the asset detail page’s activity section with the multichain
ActivityList(v2), passing a per-asset filter (CAIPchainId+ native/token scope) instead of rendering the oldUnifiedTransactionList.Updates
ActivityListto accept an optionalfilter, applying chain/asset filtering across API EVM results, local pending groups, and non‑EVM transactions; the API query hook now supports server-side EVM chain narrowing and disables querying when no EVM networks apply. Virtualization is adjusted to account for scroll margin.Removes the legacy
transaction-listandunified-transaction-listcomponents (and related SCSS, tests, snapshots, and theviewMorei18n string), plus deletes an unused multichain transactions selector and a deadTransactionKindconstant. Adds/updates unit tests and snapshots for the new filtering and query behavior.Written by Cursor Bugbot for commit 4c52ee4. This will update automatically on new commits. Configure here.