chore: move claim CTA to cover token PCT change by Jwhiles · Pull Request #40535 · MetaMask/metamask-extension

Jwhiles · 2026-03-02T15:46:38Z

Description

Changelog

CHANGELOG entry: Moved the Claim Bonus CTA to cover token percent change, rather than token quantity

Related issues

Fixes: MUSD-299

Manual testing steps

Enabled the earnMerklCampaignClaiming feature flag
Navigate to an account with rewards to claim
Observe that claim CTA is correctly positioned and still functions as expected.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI-only layout change that reorders footer content in TokenCell; main risk is unintended visual regression or misalignment in asset lists.

Overview
Moves the Merkl ClaimBonusBadge in TokenCell to render in footerLeftDisplay, replacing the percent-change display when rewards are claimable, and always shows the token’s primary amount in footerRightDisplay.

^{Written by Cursor Bugbot for commit a3cd526. This will update automatically on new commits. Configure here.}

github-actions · 2026-03-02T15:46:50Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-03-02T15:47:22Z

✨ Files requiring CODEOWNER review ✨

💎 @MetaMask/metamask-assets (1 files, +8 -6)

📁 ui/
- 📁 components/
  - 📁 app/
    - 📁 assets/
      - 📁 token-cell/
        
        📄 token-cell.tsx +8 -6

sonarqubecloud · 2026-03-02T15:58:53Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-03-02T16:30:15Z

Builds ready [a3cd526]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 370 272 527 109 479 527
total 370 272 527 109 479 527
Confirm Tx confirm_tx 6049 6039 6058 9 6057 6058
total 6049 6039 6058 9 6057 6058
Bridge User Actions bridge_load_page 253 237 267 11 258 267
bridge_load_asset_picker 218 210 222 5 222 222
bridge_search_token 718 704 731 11 730 731
total 1196 1110 1259 51 1234 1259

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1404 1203 1726 100 1447 1585
load 1181 992 1413 91 1228 1354
domContentLoaded 1173 980 1408 90 1214 1343
domInteractive 27 17 92 18 24 77
firstPaint 180 71 1298 166 224 350
backgroundConnect 207 191 257 12 209 232
firstReactRender 18 13 34 4 19 25
initialActions 1 0 5 1 2 4
loadScripts 983 799 1191 89 1021 1149
setupStore 13 7 35 5 16 20
numNetworkReqs 31 22 95 19 25 84
Power User Home uiStartup 2404 1433 10641 1596 2087 4377
load 1239 1056 1715 159 1270 1648
domContentLoaded 1223 1048 1704 155 1253 1616
domInteractive 41 21 253 36 37 97
firstPaint 192 77 485 94 267 374
backgroundConnect 778 268 8356 1442 361 2512
firstReactRender 24 15 53 7 25 38
initialActions 1 0 5 1 1 2
loadScripts 1003 836 1480 152 1028 1392
setupStore 16 8 54 7 17 35
numNetworkReqs 74 40 160 27 89 127

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 217 222 2 219 222
srpButtonToSrpForm 93 91 94 1 94 94
confirmSrpToPwForm 22 21 22 0 22 22
pwFormToMetricsScreen 16 15 16 0 16 16
metricsToWalletReadyScreen 16 16 16 0 16 16
doneButtonToHomeScreen 1101 797 1564 291 1268 1564
openAccountMenuToAccountListLoaded 7305 7025 7633 271 7618 7633
total 8677 8462 8806 136 8778 8806
Onboarding New Wallet createWalletToSocialScreen 219 217 220 1 220 220
srpButtonToPwForm 108 105 112 3 108 112
createPwToRecoveryScreen 9 8 9 0 9 9
skipBackupToMetricsScreen 36 35 37 1 36 37
agreeButtonToOnboardingSuccess 16 16 17 0 17 17
doneButtonToAssetList 693 470 853 141 761 853
total 1099 855 1309 163 1148 1309
Asset Details assetClickToPriceChart 35 31 39 3 37 39
total 35 31 39 3 37 39
Solana Asset Details assetClickToPriceChart 58 56 59 1 58 59
total 58 56 59 1 58 59
Import Srp Home loginToHomeScreen 2027 1852 2164 129 2135 2164
openAccountMenuAfterLogin 44 33 58 8 47 58
homeAfterImportWithNewWallet 2588 2449 2665 84 2644 2665
total 4750 4451 5214 297 4801 5214
Send Transactions openSendPageFromHome 18 18 18 0 18 18
selectTokenToSendFormLoaded 21 20 23 1 21 23
reviewTransactionToConfirmationPage 855 852 863 5 853 863
total 898 891 908 7 900 908
Swap openSwapPageFromHome 116 108 124 6 123 124
fetchAndDisplaySwapQuotes 4730 4725 4734 4 4734 4734
total 4844 4833 4854 9 4854 4854

🌐 Dapp Page Load Benchmarks

Current Commit: a3cd526 | Date: 3/2/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 977ms (±38ms) 🟢 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 685ms (±36ms) 🟢 | historical mean value: 734ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±11ms) 🟢 | historical mean value: 81ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	977ms	38ms	950ms	1.25s	1.01s	1.25s
domContentLoaded	685ms	36ms	663ms	942ms	706ms	942ms
firstPaint	76ms	11ms	64ms	172ms	84ms	172ms
firstContentfulPaint	76ms	11ms	64ms	172ms	84ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 5 Bytes (0%)
common: 20 Bytes (0%)

chore: move claim CTA to cover token PCT change

a3cd526

Jwhiles temporarily deployed to pr-comment March 2, 2026 15:46 — with GitHub Actions Inactive

metamaskbot added the team-earn label Mar 2, 2026

github-actions bot added the size-S label Mar 2, 2026

Jwhiles marked this pull request as ready for review March 2, 2026 16:05

Jwhiles requested a review from a team as a code owner March 2, 2026 16:05

Jwhiles temporarily deployed to pr-comment March 2, 2026 16:05 — with GitHub Actions Inactive

Matt561 self-requested a review March 2, 2026 16:07

Matt561 approved these changes Mar 2, 2026

View reviewed changes

Jwhiles temporarily deployed to pr-comment March 2, 2026 16:14 — with GitHub Actions Inactive

Jwhiles requested a review from nickewansmith March 2, 2026 21:09

shane-t approved these changes Mar 3, 2026

View reviewed changes

juanmigdr approved these changes Mar 3, 2026

View reviewed changes

bergarces approved these changes Mar 3, 2026

View reviewed changes

Jwhiles added this pull request to the merge queue Mar 3, 2026

Merged via the queue into main with commit def63c6 Mar 3, 2026
211 of 214 checks passed

Jwhiles deleted the MUSD-299 branch March 3, 2026 15:10

github-actions bot locked and limited conversation to collaborators Mar 3, 2026

metamaskbot added the release-13.22.0 Issue or pull request that will be included in release 13.22.0 label Mar 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: move claim CTA to cover token PCT change#40535

chore: move claim CTA to cover token PCT change#40535
Jwhiles merged 1 commit intomainfrom
MUSD-299

Jwhiles commented Mar 2, 2026 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

metamaskbotv2 bot commented Mar 2, 2026

Uh oh!

sonarqubecloud bot commented Mar 2, 2026

Uh oh!

metamaskbotv2 bot commented Mar 2, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

Jwhiles commented Mar 2, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

metamaskbotv2 bot commented Mar 2, 2026

✨ Files requiring CODEOWNER review ✨

Uh oh!

sonarqubecloud bot commented Mar 2, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 bot commented Mar 2, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Jwhiles commented Mar 2, 2026 •

edited by cursor bot

Loading