Skip to content

ci: scope MetaMaskBot tokens to environments (INFRA-3334)#40533

Merged
Qbandev merged 4 commits intomainfrom
infra-3334/scope-metamaskbot-tokens
Mar 3, 2026
Merged

ci: scope MetaMaskBot tokens to environments (INFRA-3334)#40533
Qbandev merged 4 commits intomainfrom
infra-3334/scope-metamaskbot-tokens

Conversation

@Qbandev
Copy link
Copy Markdown
Contributor

@Qbandev Qbandev commented Mar 2, 2026

Description

Scope MetaMaskBot write tokens to environments (INFRA-3334):

  • Migrate trigger-regression-validation from release-branchrelease-ci environment
  • Add environment: release-ci to merge-previous-release-branches
  • Add environment: default-branch to merge-my-pr
  • Add conditional environment: default-branch to page-load-benchmark (same pattern as build-storybook.yml)

This scopes MetaMaskBot write tokens (METAMASK_REGRESSION_TRIGGER_TEST, METAMASK_EXTENSION_BRANCH_SYNC_TOKEN, EXTENSION_BENCHMARK_STATS_TOKEN) to specific environments instead of being repo-level, unblocking INFRA-3247 (adding required_reviewers to release-branch).

Depends on: Patroll PR #64 must merge first to provision secrets to release-ci and default-branch environments.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes: INFRA-3334

Manual testing steps

  1. Verify patroll PR grunt to gulp readme changes #64 is merged (secrets provisioned to release-ci and default-branch)
  2. Push to a release/* branch → trigger-regression-validation runs with release-ci environment
  3. Create a release branch → merge-previous-release-branches runs with release-ci environment
  4. Comment "Merge my PR" on a version-bump PR → merge-my-pr runs with default-branch environment
  5. Push to main → benchmark stats upload and storybook deploy still work

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Migrate CI workflows to scoped environments so unscoped MetaMaskBot
write tokens can be removed from the repo-level, unblocking INFRA-3247.

- trigger-regression-validation: release-branch → release-ci
- merge-previous-release-branches: add environment release-ci
- merge-my-pr: add environment default-branch
- page-load-benchmark: add conditional environment default-branch

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Mar 2, 2026

Builds ready [08c07d3]
⚡ Performance Benchmarks
👆 Interaction Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account28826830716298307
total28826830716298307
Confirm Txconfirm_tx6107606661653661316165
total6107606661653661316165
Bridge User Actionsbridge_load_page25921230534290305
bridge_load_asset_picker22016129951257299
bridge_search_token7337317373737737
total1238120012833012371283
🔌 Startup Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Standard HomeuiStartup14141177184911114531627
load1184997156810012251371
domContentLoaded117798515609912101360
domInteractive2916127212585
firstPaint162671253137214372
backgroundConnect21219427215217240
firstReactRender20136472231
initialActions1013224
loadScripts98379513629910181169
setupStore1464671727
numNetworkReqs312290192284
Power User HomeuiStartup2634146211147164127094549
load12491082206416212981566
domContentLoaded12281073195615012691530
domInteractive3621216283376
firstPaint223801969235273367
backgroundConnect934269932515285392670
firstReactRender25164872640
initialActions104113
loadScripts1004847173114210501270
setupStore1565061723
numNetworkReqs77401602493113
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2192182201220220
srpButtonToSrpForm9795100297100
confirmSrpToPwForm23222312323
pwFormToMetricsScreen15151601616
metricsToWalletReadyScreen19162432024
doneButtonToHomeScreen954572133830112801338
openAccountMenuToAccountListLoaded74287042770030576757700
total8808871888666488668866
Onboarding New WalletcreateWalletToSocialScreen2202182222221222
srpButtonToPwForm1041021061105106
createPwToRecoveryScreen888088
skipBackupToMetricsScreen36344123741
agreeButtonToOnboardingSuccess16151601616
doneButtonToAssetList61758371054589710
total10029711089509781089
Asset DetailsassetClickToPriceChart73677847678
total73677847678
Solana Asset DetailsassetClickToPriceChart48445545155
total48445545155
Import Srp HomeloginToHomeScreen1977194720082519962008
openAccountMenuAfterLogin533872126272
homeAfterImportWithNewWallet25322320266212726522662
total45284376468410945394684
Send TransactionsopenSendPageFromHome261839103739
selectTokenToSendFormLoaded21182532325
reviewTransactionToConfirmationPage89785396445939964
total9448891005479941005
SwapopenSwapPageFromHome12810216223145162
fetchAndDisplaySwapQuotes56204571645783862326457
total57484676660285763746602
🌐 Dapp Page Load Benchmarks

Current Commit: 08c07d3 | Date: 3/2/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±42ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 732ms (±37ms) 🟢 | historical mean value: 739ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±10ms) 🟢 | historical mean value: 82ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 42ms 1.01s 1.35s 1.07s 1.35s
domContentLoaded 732ms 37ms 706ms 1.03s 752ms 1.03s
firstPaint 79ms 10ms 60ms 156ms 88ms 156ms
firstContentfulPaint 79ms 10ms 60ms 156ms 88ms 156ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 5 Bytes (0%)
  • common: 20 Bytes (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 3, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Mar 3, 2026

Builds ready [026c3b5]
⚡ Performance Benchmarks
👆 Interaction Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account28427030212294302
total28427030212294302
Confirm Txconfirm_tx6025601860441160206044
total6025601860441160206044
Bridge User Actionsbridge_load_page23620127928247279
bridge_load_asset_picker21813827957262279
bridge_search_token73470476325760763
total1188110712606112311260
🔌 Startup Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Standard HomeuiStartup15101263183210815551705
load1260105515099513021432
domContentLoaded1252104714939312971425
domInteractive3118128212689
firstPaint190731285176224400
backgroundConnect22520642324225260
firstReactRender2113133122232
initialActions107114
loadScripts104883912879310881212
setupStore1464261626
numNetworkReqs312289192381
Power User HomeuiStartup2127138510807141219614109
load11871057181914712081543
domContentLoaded11691046171714111821523
domInteractive37201482437103
firstPaint1887550787261327
backgroundConnect4482624835675330998
firstReactRender24155272642
initialActions108112
loadScripts95383914901389661311
setupStore1684561723
numNetworkReqs65301562669129
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2212182232223223
srpButtonToSrpForm96959819698
confirmSrpToPwForm22222302223
pwFormToMetricsScreen16161601616
metricsToWalletReadyScreen17161811718
doneButtonToHomeScreen86581290840908908
openAccountMenuToAccountListLoaded7585746376678876677667
total88368647903213289079032
Onboarding New WalletcreateWalletToSocialScreen2192162222220222
srpButtonToPwForm1111031217115121
createPwToRecoveryScreen889099
skipBackupToMetricsScreen38354334043
agreeButtonToOnboardingSuccess16161601616
doneButtonToAssetList66060178171637781
total105099011636710291163
Asset DetailsassetClickToPriceChart554079177279
total554079177279
Solana Asset DetailsassetClickToPriceChart45434824648
total45434824648
Import Srp HomeloginToHomeScreen1922184819765519751976
openAccountMenuAfterLogin45355895458
homeAfterImportWithNewWallet24352185262316426072623
total44664087490428246374904
Send TransactionsopenSendPageFromHome20182112121
selectTokenToSendFormLoaded22212312323
reviewTransactionToConfirmationPage86084787811863878
total8998909067905906
SwapopenSwapPageFromHome1201161232121123
fetchAndDisplaySwapQuotes4617457546604146564660
total4733469347793947644779
🌐 Dapp Page Load Benchmarks

Current Commit: 026c3b5 | Date: 3/3/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 985ms (±36ms) 🟢 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 690ms (±34ms) 🟢 | historical mean value: 737ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±10ms) 🟢 | historical mean value: 82ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 985ms 36ms 951ms 1.24s 1.01s 1.24s
domContentLoaded 690ms 34ms 668ms 936ms 710ms 936ms
firstPaint 77ms 10ms 64ms 168ms 84ms 168ms
firstContentfulPaint 77ms 10ms 64ms 168ms 84ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 5 Bytes (0%)
  • common: 20 Bytes (0%)

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@chloeYue chloeYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 3, 2026

@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Mar 3, 2026

Builds ready [f2fc0dd]
⚡ Performance Benchmarks
👆 Interaction Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account28826533628278336
total28826533628278336
Confirm Txconfirm_tx6071599761736060986173
total6071599761736060986173
Bridge User Actionsbridge_load_page22918028140251281
bridge_load_asset_picker23921125719257257
bridge_search_token72270074518732745
total1190109212837512381283
🔌 Startup Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Standard HomeuiStartup14541241180710415051640
load1216101314519212621393
domContentLoaded1209100914448912561377
domInteractive2917100192584
firstPaint188671393180220298
backgroundConnect21519641924215239
firstReactRender20124252230
initialActions109113
loadScripts101381112438810571184
setupStore1373451722
numNetworkReqs312289192384
Power User HomeuiStartup270014619953185924816477
load12641079193717213281656
domContentLoaded12431067185816512961647
domInteractive39211432637100
firstPaint2028945290280344
backgroundConnect743276695110554762807
firstReactRender27176482943
initialActions105114
loadScripts1018853158615810671420
setupStore1785681931
numNetworkReqs75421512490120
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2192192200220220
srpButtonToSrpForm94929729597
confirmSrpToPwForm21212102121
pwFormToMetricsScreen15151601616
metricsToWalletReadyScreen16151601616
doneButtonToHomeScreen61059264621602646
openAccountMenuToAccountListLoaded2920289429452029342945
total3968385140979040384097
Onboarding New WalletcreateWalletToSocialScreen2202192211221221
srpButtonToPwForm1091081101110110
createPwToRecoveryScreen989099
skipBackupToMetricsScreen36353713637
agreeButtonToOnboardingSuccess17171701717
doneButtonToAssetList6306226366636636
total102010141026510261026
Asset DetailsassetClickToPriceChart41404314143
total41404314143
Solana Asset DetailsassetClickToPriceChart82759578495
total82759578495
Import Srp HomeloginToHomeScreen1979192220364520082036
openAccountMenuAfterLogin39324354343
homeAfterImportWithNewWallet27622583299816529112998
total47864576510320549535103
Send TransactionsopenSendPageFromHome18172111921
selectTokenToSendFormLoaded18161911919
reviewTransactionToConfirmationPage8488458533849853
total8848808894889889
SwapopenSwapPageFromHome1121041238119123
fetchAndDisplaySwapQuotes288828832891328892891
total300129923008630063008
🌐 Dapp Page Load Benchmarks

Current Commit: f2fc0dd | Date: 3/3/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.08s (±38ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 744ms (±36ms) 🟢 | historical mean value: 737ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 84ms (±10ms) 🟢 | historical mean value: 85ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.08s 38ms 1.05s 1.36s 1.11s 1.36s
domContentLoaded 744ms 36ms 719ms 1.01s 772ms 1.01s
firstPaint 84ms 10ms 68ms 164ms 92ms 164ms
firstContentfulPaint 84ms 10ms 68ms 164ms 92ms 164ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 5 Bytes (0%)
  • common: 20 Bytes (0%)

@Qbandev Qbandev added this pull request to the merge queue Mar 3, 2026
Merged via the queue into main with commit 3e33ff8 Mar 3, 2026
333 of 336 checks passed
@Qbandev Qbandev deleted the infra-3334/scope-metamaskbot-tokens branch March 3, 2026 16:20
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2026
@metamaskbot metamaskbot added the release-13.22.0 Issue or pull request that will be included in release 13.22.0 label Mar 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.22.0 Issue or pull request that will be included in release 13.22.0 size-XS team-dev-ops DevOps team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants