Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
n3ps
commented
Feb 27, 2026
| }; | ||
| const statusKey = KEYRING_TRANSACTION_STATUS_KEY[status]; | ||
|
|
||
| const accountComponent = (label: string, address?: string) => { |
Contributor
Author
There was a problem hiding this comment.
- Just extracted as-is
n3ps
commented
Feb 27, 2026
| chain: string; | ||
| }; | ||
|
|
||
| const AccountRow = ({ label, address, chain }: Props) => { |
Contributor
Author
There was a problem hiding this comment.
- Extracted from previously inline "accountComponent" for reusability
n3ps
commented
Feb 27, 2026
| ); | ||
|
|
||
| /** | ||
| * Get the account group display name for a given address. |
Contributor
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (2 files, +60 -0)
|
Contributor
Builds ready [68ff5f7]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
gantunesr
reviewed
Feb 27, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
|
Contributor
Builds ready [dadb13f]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
gantunesr
approved these changes
Feb 27, 2026
AndyMBridges
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Render the account group display name instead of the internal name
Changelog
CHANGELOG entry: fix: non-evm txn details account display name
Related issues
Fixes: #40090
Manual testing steps
Screenshots/Recordings
Before: "Snap Account X"
After: User-defined name
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk UI/selector change that only affects how account names are resolved/displayed in the transaction details modal; primary risk is incorrect/undefined name lookup for some addresses.
Overview
Updates the multichain transaction details modal to render From/To rows via a new
AccountRowcomponent that resolves a user-facing account group display name (falling back toshortenAddress) rather than showing the internal account name.Adds a new selector,
selectAccountGroupNameByAddress, plus tests, to map an address to its containing account group name (or fall back to the internal account name when no group metadata exists).Written by Cursor Bugbot for commit dadb13f. This will update automatically on new commits. Configure here.