fix: limit smart account nav to entropy and simple accounts by gantunesr · Pull Request #40487 · MetaMask/metamask-extension

gantunesr · 2026-02-27T13:58:22Z

Description

Update navigation condition to only allow "Entropy" and "Simple" accounts to access the Smart Account page.

Changelog

CHANGELOG entry: limit smart account navigation to entropy and simple accounts

Related issues

Fixes: #40276
Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1501

Manual testing steps

Import a Ledger Account (or any hardware wallet account)
Click Account details
There should not be a option to navigate to the Smart Account page

Screenshots/Recordings

Before

Check #40276

After

Screen.Recording.2026-02-27.at.10.52.37.AM.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes route/UI gating for the Smart Account flow based on keyring type; a mismatch in keyring metadata or selectors could incorrectly hide/deny access for some accounts.

Overview
Limits Smart Account (EIP-7702) setup to supported keyrings only by introducing KEYRING_TYPES_SUPPORTING_7702 (hd, simple) and using it to gate the “Setup Smart Account” row on MultichainAccountDetailsPage.

Adds a guard in SmartAccountPage to redirect back (and render nothing) when the selected account’s keyring type does not support EIP-7702, preventing direct URL access for hardware/snap accounts; updates/extends unit tests and adjusts the Jest console baseline accordingly.

^{Written by Cursor Bugbot for commit 170440b. This will update automatically on new commits. Configure here.}

metamaskbotv2 · 2026-02-27T13:59:11Z

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (4 files, +79 -17)

📁 ui/
- 📁 pages/
  - 📁 multichain-accounts/
    - 📁 multichain-account-details-page/
      - 📄 multichain-account-details-page.test.tsx +12 -0
      - 📄 multichain-account-details-page.tsx +23 -15
    - 📁 smart-account-page/
      - 📄 smart-account-page.test.tsx +20 -1
      - 📄 smart-account-page.tsx +24 -1

metamaskbotv2 · 2026-02-27T14:30:17Z

Builds ready [193e922]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 288 271 304 13 296 304
total 288 271 304 13 296 304
Confirm Tx confirm_tx 6081 6080 6084 2 6084 6084
total 6081 6080 6084 2 6084 6084
Bridge User Actions bridge_load_page 245 239 250 5 250 250
bridge_load_asset_picker 221 180 258 29 249 258
bridge_search_token 725 708 746 15 740 746
total 1197 1138 1254 44 1240 1254

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1415 1187 2165 141 1456 1618
load 1188 987 1829 125 1243 1365
domContentLoaded 1179 978 1784 120 1237 1344
domInteractive 28 16 101 18 25 70
firstPaint 236 65 1812 279 219 463
backgroundConnect 209 181 261 17 214 243
firstReactRender 18 11 42 5 19 29
initialActions 2 0 7 1 2 5
loadScripts 989 785 1568 118 1047 1158
setupStore 13 6 50 6 15 25
numNetworkReqs 31 22 99 21 22 90
Power User Home uiStartup 2382 1450 10328 1614 2112 4602
load 1186 1034 1691 144 1220 1540
domContentLoaded 1169 1025 1605 138 1205 1524
domInteractive 39 20 221 29 36 109
firstPaint 176 74 488 79 239 307
backgroundConnect 742 253 8193 1272 331 2659
firstReactRender 23 16 42 6 25 37
initialActions 1 0 5 1 1 2
loadScripts 960 819 1404 137 994 1309
setupStore 16 7 88 9 18 27
numNetworkReqs 72 38 149 27 87 126

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 220 218 221 1 221 221
srpButtonToSrpForm 94 92 96 1 95 96
confirmSrpToPwForm 22 22 22 0 22 22
pwFormToMetricsScreen 16 15 16 0 16 16
metricsToWalletReadyScreen 17 16 18 1 18 18
doneButtonToHomeScreen 1167 862 1563 258 1278 1563
openAccountMenuToAccountListLoaded 7401 7075 7830 285 7638 7830
total 8937 8805 9102 105 9007 9102
Onboarding New Wallet createWalletToSocialScreen 223 222 224 1 223 224
srpButtonToPwForm 113 112 116 1 113 116
createPwToRecoveryScreen 9 9 9 0 9 9
skipBackupToMetricsScreen 37 36 37 0 37 37
agreeButtonToOnboardingSuccess 17 17 18 0 17 18
doneButtonToAssetList 898 583 1312 290 1170 1312
total 1302 980 1717 298 1595 1717
Asset Details assetClickToPriceChart 38 36 39 1 39 39
total 38 36 39 1 39 39
Solana Asset Details assetClickToPriceChart 58 56 61 2 59 61
total 58 56 61 2 59 61
Import Srp Home loginToHomeScreen 1954 1924 1975 21 1972 1975
openAccountMenuAfterLogin 48 44 55 5 49 55
homeAfterImportWithNewWallet 2630 2529 2739 81 2673 2739
total 4625 4272 4970 231 4754 4970
Send Transactions openSendPageFromHome 25 17 37 9 36 37
selectTokenToSendFormLoaded 20 18 22 2 20 22
reviewTransactionToConfirmationPage 856 845 870 9 857 870
total 899 882 925 16 897 925
Swap openSwapPageFromHome 116 103 126 9 119 126
fetchAndDisplaySwapQuotes 4586 4567 4606 16 4598 4606
total 4686 4625 4725 42 4725 4725

🌐 Dapp Page Load Benchmarks

Current Commit: 193e922 | Date: 2/27/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±40ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 737ms (±37ms) 🟢 | historical mean value: 732ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 82ms (±13ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	40ms	1.02s	1.34s	1.09s	1.34s
domContentLoaded	737ms	37ms	712ms	1.01s	772ms	1.01s
firstPaint	82ms	13ms	68ms	200ms	88ms	200ms
firstContentfulPaint	82ms	13ms	68ms	200ms	88ms	200ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 1.49 KiB (0.02%)
common: 21 Bytes (0%)

sonarqubecloud · 2026-02-27T17:21:06Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-02-27T17:41:26Z

Builds ready [170440b]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 268 261 278 6 269 278
total 268 261 278 6 269 278
Confirm Tx confirm_tx 6039 6029 6047 8 6045 6047
total 6039 6029 6047 8 6045 6047
Bridge User Actions bridge_load_page 255 230 289 22 262 289
bridge_load_asset_picker 197 131 277 66 277 277
bridge_search_token 742 703 810 42 770 810
total 1194 1096 1279 81 1254 1279

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1428 1210 1948 109 1462 1617
load 1197 1006 1649 100 1230 1380
domContentLoaded 1189 1000 1640 97 1223 1342
domInteractive 28 17 134 21 25 82
firstPaint 165 72 1296 139 221 293
backgroundConnect 212 192 265 15 218 247
firstReactRender 20 12 46 6 21 32
initialActions 1 0 8 2 2 4
loadScripts 994 810 1434 97 1024 1151
setupStore 14 6 32 5 17 24
numNetworkReqs 31 22 89 19 22 84
Power User Home uiStartup 3290 1521 10767 2037 4169 7304
load 1267 1064 1807 142 1301 1616
domContentLoaded 1252 1049 1797 141 1280 1607
domInteractive 39 20 262 34 35 108
firstPaint 214 89 572 93 284 343
backgroundConnect 1397 269 8996 1777 2052 4266
firstReactRender 25 18 49 5 26 31
initialActions 1 0 9 1 1 4
loadScripts 1033 849 1585 140 1053 1389
setupStore 16 6 69 8 18 29
numNetworkReqs 83 40 148 23 96 131

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 218 219 1 219 219
srpButtonToSrpForm 95 93 98 2 95 98
confirmSrpToPwForm 22 21 22 0 22 22
pwFormToMetricsScreen 15 15 15 0 15 15
metricsToWalletReadyScreen 16 15 18 1 16 18
doneButtonToHomeScreen 723 603 865 118 813 865
openAccountMenuToAccountListLoaded 7820 7695 8031 134 7840 8031
total 8909 8682 9028 127 9023 9028
Onboarding New Wallet createWalletToSocialScreen 220 217 223 2 220 223
srpButtonToPwForm 106 106 107 0 107 107
createPwToRecoveryScreen 8 8 9 0 8 9
skipBackupToMetricsScreen 35 35 35 0 35 35
agreeButtonToOnboardingSuccess 17 16 17 0 17 17
doneButtonToAssetList 854 560 1270 320 1220 1270
total 1241 945 1656 319 1604 1656
Asset Details assetClickToPriceChart 60 40 92 20 74 92
total 60 40 92 20 74 92
Solana Asset Details assetClickToPriceChart 52 47 57 3 53 57
total 52 47 57 3 53 57
Import Srp Home loginToHomeScreen 2072 1967 2234 93 2104 2234
openAccountMenuAfterLogin 40 39 41 1 41 41
homeAfterImportWithNewWallet 2289 2113 2561 166 2385 2561
total 4346 4273 4391 48 4387 4391
Send Transactions openSendPageFromHome 30 19 40 9 37 40
selectTokenToSendFormLoaded 27 20 40 7 29 40
reviewTransactionToConfirmationPage 865 853 882 12 870 882
total 922 909 945 14 924 945
Swap openSwapPageFromHome 128 106 150 16 133 150
fetchAndDisplaySwapQuotes 6294 6265 6309 20 6309 6309
total 6423 6372 6489 46 6442 6489

🌐 Dapp Page Load Benchmarks

Current Commit: 170440b | Date: 2/27/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±145ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 740ms (±161ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 101ms (±231ms) 🟢 | historical mean value: 82ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	145ms	1.01s	2.47s	1.07s	2.47s
domContentLoaded	740ms	161ms	708ms	2.33s	752ms	2.33s
firstPaint	101ms	231ms	60ms	2.40s	88ms	2.40s
firstContentfulPaint	101ms	231ms	60ms	2.40s	88ms	2.40s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 58 Bytes (0%)
ui: -13.87 KiB (-0.17%)
common: -635 Bytes (-0.01%)

fix: limit smart account nav to entropy and simple accounts

193e922

gantunesr temporarily deployed to pr-comment February 27, 2026 13:58 — with GitHub Actions Inactive

metamaskbot added the team-accounts-framework Accounts team label Feb 27, 2026

github-actions bot added the size-S label Feb 27, 2026

gantunesr marked this pull request as ready for review February 27, 2026 14:02

gantunesr requested a review from a team as a code owner February 27, 2026 14:02

gantunesr temporarily deployed to pr-comment February 27, 2026 14:02 — with GitHub Actions Inactive

gantunesr temporarily deployed to pr-comment February 27, 2026 14:25 — with GitHub Actions Inactive

fix: update baseline file

170440b

gantunesr temporarily deployed to pr-comment February 27, 2026 17:08 — with GitHub Actions Inactive

github-actions bot added size-M and removed size-S labels Feb 27, 2026

gantunesr temporarily deployed to pr-comment February 27, 2026 17:36 — with GitHub Actions Inactive

mathieuartu approved these changes Feb 27, 2026

View reviewed changes

montelaidev approved these changes Mar 2, 2026

View reviewed changes

gantunesr added this pull request to the merge queue Mar 2, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 2, 2026

gantunesr added this pull request to the merge queue Mar 2, 2026

Merged via the queue into main with commit ed5beef Mar 2, 2026
184 checks passed

gantunesr deleted the gar/fix/smart-account-nav branch March 2, 2026 15:50

github-actions bot locked and limited conversation to collaborators Mar 2, 2026

metamaskbot added the release-13.22.0 Issue or pull request that will be included in release 13.22.0 label Mar 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: limit smart account nav to entropy and simple accounts#40487

fix: limit smart account nav to entropy and simple accounts#40487
gantunesr merged 2 commits intomainfrom
gar/fix/smart-account-nav

gantunesr commented Feb 27, 2026 •

edited

Loading

Uh oh!

metamaskbotv2 bot commented Feb 27, 2026

Uh oh!

metamaskbotv2 bot commented Feb 27, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud bot commented Feb 27, 2026

Uh oh!

metamaskbotv2 bot commented Feb 27, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

gantunesr commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbotv2 bot commented Feb 27, 2026

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbotv2 bot commented Feb 27, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud bot commented Feb 27, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 bot commented Feb 27, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gantunesr commented Feb 27, 2026 •

edited

Loading