fix: nft image startsWith error#40413
Merged
Prithpal-Sooriya merged 1 commit intomainfrom Feb 26, 2026
Merged
Conversation
Fixes #40412 The error 'Pe.startsWith is not a function' occurred because nftSrcUrl could be a non-string value (e.g., object, array, number) when the NFT metadata returned from token URI contained a non-string image field. Changes: - In useFetchNftDetailsFromTokenURI.ts: validate that data.image and data.name are strings before setting state - In nft-details.tsx: add type guard to ensure nftSrcUrl is a string before calling .startsWith() - Added test case to verify non-string image/name values are ignored Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>
|
Cursor Agent can help with this pull request. Just |
Contributor
✨ Files requiring CODEOWNER review ✨💎 @MetaMask/metamask-assets (1 files, +2 -1)
|
|
startsWith error
Contributor
Builds ready [e7e5afd]
⚡ Performance Benchmarks (1417 ± 111 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
sahar-fehri
reviewed
Feb 25, 2026
| } | ||
| if (typeof data.name === 'string') { | ||
| setName(data.name); | ||
| } |
Contributor
There was a problem hiding this comment.
I was not able to repro the bug locally for the reported NFT ; but trying to use a malformed data worked (screenshot)
Most NFTs return { "image": "https://..." } (a string). But some return malformed metadata like { "image": { "url": "https://..." } } or { "image": ["img1", "img2"] } ; an object or array instead of a string; the UI wont know what to do with this so better not call setImage;
The component uses the value as a fallback when imageOriginal and image are both missing:
const nftSrcUrl = imageOriginal ?? image ?? imageFromTokenURI;
So in case we fallback to imageFromTokenURI it will be empty
sahar-fehri
approved these changes
Feb 25, 2026
juanmigdr
approved these changes
Feb 26, 2026
salimtb
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes
TypeError: Pe.startsWith is not a functionwhen loading NFT images by ensuringnftSrcUrlis a string.The error occurred because
nftSrcUrlcould be a non-string value (e.g., an object or number) if the NFT metadata from the token URI contained a non-stringimagefield. The optional chaining (?.) only guards againstnull/undefined, not against calling.startsWith()on a defined non-string value. This PR adds explicit type checks to prevent this.Changelog
CHANGELOG entry: fix: nft image
startsWitherrorRelated issues
Fixes: #40412 https://consensyssoftware.atlassian.net/browse/ASSETS-2793
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Small defensive type-guard changes plus a unit test; behavior only changes for malformed/unsupported tokenURI metadata.
Overview
Prevents a runtime crash in NFT details rendering by only calling
startsWith('ipfs:')when the computednftSrcUrlis actually a string.Hardens
useFetchNftDetailsFromTokenURIto only populateimage/namewhen the tokenURI JSON fields are strings, and adds a test case covering non-string metadata responses.Written by Cursor Bugbot for commit e7e5afd. This will update automatically on new commits. Configure here.