fix: don't prevent users from removing account that are from account snap accounts#40404
Merged
fix: don't prevent users from removing account that are from account snap accounts#40404
Conversation
Contributor
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (2 files, +1 -13)
|
5354a2a to
8ae89fc
Compare
Contributor
Builds ready [8ae89fc]
⚡ Performance Benchmarks (1432 ± 106 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
...ages/multichain-accounts/multichain-account-details-page/multichain-account-details-page.tsx
Outdated
Show resolved
Hide resolved
Contributor
Builds ready [acd318c]
⚡ Performance Benchmarks (1394 ± 99 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
|
Contributor
Builds ready [ce49af3]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
gantunesr
reviewed
Feb 26, 2026
Comment on lines
-129
to
-137
| it('does not render remove account section for Snap wallet type', () => { | ||
| mockUseParams.mockReturnValue({ | ||
| id: 'snap:local:snap-id/0xb552685e3d2790efd64a175b00d51f02cdafee5d', | ||
| }); | ||
|
|
||
| renderComponent(); | ||
|
|
||
| expect(screen.queryByText(/remove account/iu)).not.toBeInTheDocument(); | ||
| }); |
Member
There was a problem hiding this comment.
The caveat here is that is should only be true for 3rd party snap. I think this is ok now that we have multichain accounts
Member
Author
There was a problem hiding this comment.
Yes, it is because e.g. solana accounts don't get the snap wallet type, they don't join entropy account groups. Minor correction though, it's not for third party snaps, but for "account snaps that do not join entropy account groups" - which includes third party snaps but also the institutional one
Member
There was a problem hiding this comment.
The 1st vs 3rd party snap rule for deletion was decided before multichain accounts and institutional snaps. We have to update it now with the new standards
gantunesr
approved these changes
Feb 26, 2026
mathieuartu
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Institutional snap users need to be able to remove the accounts, so that they can (for example) update their tokens
Changelog
CHANGELOG entry: Allow users to remove snap accounts if they are from a snap account wallet
Related issues
N/A
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Expands when account removal UI is exposed; incorrect wallet-type detection could allow unintended removals or confuse users, though the change is small and localized.
Overview
Allows the Remove account section to appear for Snap wallet types by changing the removability check in
MultichainAccountDetailsPageto only block Entropy wallets.Updates the page test suite by removing the expectation that Snap wallets cannot be removed, keeping coverage for Entropy (not removable) and Keyring (removable).
Written by Cursor Bugbot for commit ce49af3. This will update automatically on new commits. Configure here.