Skip to content

chore: update default address styles#40393

Merged
ameliejyc merged 2 commits intomainfrom
fix-popover-position
Feb 25, 2026
Merged

chore: update default address styles#40393
ameliejyc merged 2 commits intomainfrom
fix-popover-position

Conversation

@ameliejyc
Copy link
Copy Markdown
Contributor

@ameliejyc ameliejyc commented Feb 25, 2026

Description

  • Tiny styling tweaks to Default Address feature
  • Update to dynamic popover position on hovered account network group component to reflect the height of the popover more accurately

Figma here: https://www.figma.com/design/IVt20ztP5OpMtBpIzGX0Q4/Adding-default-address-toggle-for-home-address-and-account-list?node-id=230-34467&m=dev

Changelog

CHANGELOG entry: Small styling tweaks to default address feature

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/CEUX-935

Manual testing steps

Verify the following changes:

  1. Changing the text to from body/sm/regular to body/sm/medium (image 1)
  2. Changing the text size on the account picker from body/xs/regular to body/sm/regular (image 2).
  3. Changing it to "Address copied" too on the account picker view (image 3)
  4. Dynamic popover position for hovered account network group is similar to before but stays at bottom for smaller screen sizes than previously (see screenshot section)
image image image

Screenshots/Recordings

Before

Popover position pops to the top on small screen heights when there is still plenty of space to render beneath:
image

After

Popover stays at bottom for smaller screen heights than before:
image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI-only tweaks: changes text styling/copy feedback and adjusts a popover height/position heuristic; no sensitive logic or data flows are modified.

Overview
Improves the multichain account picker/default-address UI by bumping address text to BodySm, using medium weight in the default-address network group, and showing the localized addressCopied label in the account cell after copying (instead of continuing to show the shortened address).

Adjusts the hovered address rows popover sizing assumptions by reducing maxHeight (and its matching estimated height used for top/bottom positioning) from 400px to 275px, so the popover more accurately stays below the trigger when there’s sufficient viewport space.

Written by Cursor Bugbot for commit 5bd0574. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-core-extension-ux Core Extension UX team label Feb 25, 2026
@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Feb 25, 2026

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (3 files, +9 -5)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain-accounts/
        • 📁 multichain-account-cell/
          • 📄 multichain-account-cell.tsx +4 -2
        • 📁 multichain-account-network-group-with-default-address/
          • 📄 multichain-account-network-group-with-default-address.tsx +3 -1
        • 📁 multichain-address-rows-hovered-list/
          • 📄 multichain-hovered-address-rows-hovered-list.tsx +2 -2

@ameliejyc ameliejyc marked this pull request as ready for review February 25, 2026 09:56
@ameliejyc ameliejyc requested a review from a team as a code owner February 25, 2026 09:56
@ameliejyc ameliejyc changed the title Fix popover position chore: update default address styles Feb 25, 2026
@sonarqubecloud
Copy link
Copy Markdown

@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Feb 25, 2026

Builds ready [5bd0574]
⚡ Performance Benchmarks (1359 ± 90 ms)
👆 Interaction Benchmarks
ActionMetricMean (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account28916299311
total28916299311
Confirm Txconfirm_tx60633260876100
total60633260876100
Bridge User Actionsbridge_load_page2707280280
bridge_load_asset_picker18019183206
bridge_search_token7199726730
total11987012591296
🔌 Startup Benchmarks
BuildMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
Chrome Browserify Startup Standard HomeuiStartup1359117015839014001528
load114797413698711901310
domContentLoaded114094313648511851294
domInteractive271590182377
firstPaint153651298134197254
backgroundConnect20218325113202229
firstReactRender18103332023
initialActions104112
loadScripts9557601158849951110
setupStore1262741519
numNetworkReqs312294202383
Chrome Browserify Startup Power User HomeuiStartup17161406234115417582034
load11291010171413011071469
domContentLoaded11161005170012710991436
domInteractive3518137233498
firstPaint1697242382224304
backgroundConnect28425746526290317
firstReactRender25165082942
initialActions107114
loadScripts90981213471198921229
setupStore1674771927
numNetworkReqs59371602657142
Chrome Webpack Startup Standard HomeuiStartup8666991164999281039
load74761395693822898
domContentLoaded74260994893817891
domInteractive2715108202383
firstPaint1105930655133226
backgroundConnect27195273044
firstReactRender18123762032
initialActions106112
loadScripts73960794692815887
setupStore1173041220
numNetworkReqs3122100202585
Chrome Webpack Startup Power User HomeuiStartup1220860179916412811563
load72263711401097141013
domContentLoaded71463211291087051004
domInteractive33171502731105
firstPaint1516345791190330
backgroundConnect17912935052193290
firstReactRender22163132427
initialActions102011
loadScripts7116311112105703991
setupStore1154251216
numNetworkReqs1063825951134237
Firefox Browserify Startup Standard HomeuiStartup15761338217615516001949
load1318113916119413531535
domContentLoaded1317113916109413531530
domInteractive81352173697138
firstPaint------
backgroundConnect61282513756118
firstReactRender13104841315
initialActions102112
loadScripts1290111815308213311447
setupStore2071933215102
numNetworkReqs3220102222596
Firefox Browserify Startup Power User HomeuiStartup26291974425743227813410
load15421176228027116812120
domContentLoaded15411175228027116812119
domInteractive12236655116125332
firstPaint------
backgroundConnect208105867169190591
firstReactRender17135951721
initialActions216122
loadScripts14991152225626616112086
setupStore1318713186122623
numNetworkReqs60301473481132
Firefox Webpack Startup Standard HomeuiStartup17021467326231416722092
load14231190294724614211556
domContentLoaded14231189294624614211555
domInteractive1002924447130190
firstPaint------
backgroundConnect7526136113766184
firstReactRender15122631521
initialActions102012
loadScripts13981175291824413991493
setupStore207164251658
numNetworkReqs312096172769
Firefox Webpack Startup Power User HomeuiStartup27011929433146328383696
load15881259277833017472348
domContentLoaded15871258277733017462348
domInteractive15132760181116649
firstPaint------
backgroundConnect2761111370231241869
firstReactRender22167072430
initialActions213122
loadScripts15511236274831916912302
setupStore1538783210122692
numNetworkReqs59301843685136
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2224225230
srpButtonToSrpForm9109191
confirmSrpToPwForm2102122
pwFormToMetricsScreen1501515
metricsToWalletReadyScreen1611617
doneButtonToHomeScreen91234511991440
openAccountMenuToAccountListLoaded742759578808018
total884113489148969
Onboarding New WalletcreateWalletToSocialScreen2171217218
srpButtonToPwForm1062108108
createPwToRecoveryScreen8099
skipBackupToMetricsScreen3613737
agreeButtonToOnboardingSuccess1611717
doneButtonToAssetList669118753854
total105311811341239
Asset DetailsassetClickToPriceChart50186975
total50186975
Solana Asset DetailsassetClickToPriceChart4925051
total4925051
Import Srp HomeloginToHomeScreen18211718271846
openAccountMenuAfterLogin4334450
homeAfterImportWithNewWallet221114323522388
total417228942604696
Send TransactionsopenSendPageFromHome3944242
selectTokenToSendFormLoaded2102222
reviewTransactionToConfirmationPage86318862892
total91722925948
SwapopenSwapPageFromHome10632135141
fetchAndDisplaySwapQuotes46456046604733
total47544747864801
🌐 Dapp Page Load Benchmarks

Current Commit: 5bd0574 | Date: 2/25/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±37ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 721ms (±35ms) 🟢 | historical mean value: 725ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±11ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 37ms 1.00s 1.32s 1.05s 1.32s
domContentLoaded 721ms 35ms 695ms 994ms 734ms 994ms
firstPaint 75ms 11ms 56ms 176ms 84ms 176ms
firstContentfulPaint 75ms 11ms 56ms 176ms 84ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 1.56 KiB (0.02%)
  • common: -141 Bytes (0%)

@ameliejyc ameliejyc enabled auto-merge February 25, 2026 13:25
@ameliejyc ameliejyc added this pull request to the merge queue Feb 25, 2026
Merged via the queue into main with commit abf780c Feb 25, 2026
208 of 213 checks passed
@ameliejyc ameliejyc deleted the fix-popover-position branch February 25, 2026 13:57
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2026
@metamaskbot metamaskbot added the release-13.21.0 Issue or pull request that will be included in release 13.21.0 label Feb 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.21.0 Issue or pull request that will be included in release 13.21.0 size-S team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants