fix: inconsistent decimals between all and selected network by n3ps · Pull Request #40341 · MetaMask/metamask-extension

n3ps · 2026-02-23T19:24:49Z

Description

Fix the inconsistent decimal handling of non EVM transactions when choosing between All Networks and the selected network

Changelog

CHANGELOG entry: fix: inconsistent decimals between and and selected network

Related issues

Fixes: #40242

Manual testing steps

Select Solana network
Send amount with several decimals, in Solana network and confirm
Go to Activity
See tx with decimals
Select All popular network
See tx decimals are different

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Small, localized change to transaction amount formatting and a hook signature; main risk is display regressions for chains where transaction.chain doesn’t map to MULTICHAIN_NETWORK_DECIMAL_PLACES.

Overview
Fixes inconsistent decimal formatting for non-EVM/multichain transactions by making useMultichainTransactionDisplay derive decimalPlaces from transaction.chain instead of the currently selected network.

Updates call sites (e.g., MultichainTransactionDetailsModal and NonEvmActivityListItem) to stop selecting/passing getSelectedMultichainNetworkConfiguration, simplifying the API and ensuring amounts render consistently when switching between All Networks and a specific network.

^{Written by Cursor Bugbot for commit b70bf1c. This will update automatically on new commits. Configure here.}

github-actions · 2026-02-23T19:25:17Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-02-23T19:25:37Z

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (1 files, +1 -3)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 activity-v2/
      - 📄 non-evm-activity-list-item.tsx +1 -3

metamaskbotv2 · 2026-02-23T20:23:57Z

Builds ready [b70bf1c]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (1385 ± 100 ms)

👆 Interaction Benchmarks
Action Metric Mean (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 275 2 277 277
total 275 2 277 277
Confirm Tx confirm_tx 6036 12 6047 6049
total 6036 12 6047 6049
Bridge User Actions bridge_load_page 266 22 279 294
bridge_load_asset_picker 170 34 194 203
bridge_search_token 698 3 698 702
total 1121 46 1156 1194

🔌 Startup Benchmarks
Build Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P 75 (ms) P 95 (ms)
Chrome Browserify Startup Standard Home uiStartup 1385 1182 1726 100 1415 1560
load 1170 976 1394 89 1210 1336
domContentLoaded 1163 971 1389 87 1204 1322
domInteractive 26 16 92 17 23 75
firstPaint 197 66 1287 213 218 328
backgroundConnect 203 187 256 12 207 225
firstReactRender 18 11 37 5 19 27
initialActions 1 0 5 1 1 3
loadScripts 975 783 1196 87 1016 1136
setupStore 14 6 55 7 16 25
numNetworkReqs 31 22 97 20 22 85
Chrome Browserify Startup Power User Home uiStartup 1816 1317 8565 778 1727 2296
load 1111 996 1626 126 1108 1411
domContentLoaded 1095 987 1595 118 1087 1382
domInteractive 31 18 149 18 31 55
firstPaint 189 72 1605 209 228 303
backgroundConnect 386 241 6700 685 287 368
firstReactRender 24 14 45 7 27 38
initialActions 1 0 7 1 1 2
loadScripts 897 788 1373 116 886 1191
setupStore 17 7 58 9 18 35
numNetworkReqs 60 37 149 23 67 123
Chrome Webpack Startup Standard Home uiStartup 831 690 1247 92 849 1011
load 713 607 1106 92 754 877
domContentLoaded 707 603 1095 90 748 873
domInteractive 27 15 122 23 22 86
firstPaint 119 58 850 105 124 227
backgroundConnect 27 19 49 6 31 39
firstReactRender 19 12 40 7 21 32
initialActions 1 0 4 1 1 2
loadScripts 704 601 1086 89 746 867
setupStore 11 6 38 5 12 19
numNetworkReqs 31 22 104 21 25 88
Chrome Webpack Startup Power User Home uiStartup 1270 913 2279 202 1330 1608
load 743 653 1305 125 730 1061
domContentLoaded 732 640 1297 125 716 1047
domInteractive 40 19 176 31 39 122
firstPaint 148 67 645 91 158 312
backgroundConnect 185 132 944 93 171 300
firstReactRender 23 17 40 4 25 29
initialActions 1 0 2 1 1 1
loadScripts 729 637 1287 122 714 1034
setupStore 13 5 37 5 14 22
numNetworkReqs 114 40 264 51 141 243
Firefox Browserify Startup Standard Home uiStartup 1649 1407 2387 230 1669 2282
load 1384 1176 2101 190 1415 1764
domContentLoaded 1383 1175 2096 190 1415 1763
domInteractive 74 34 273 41 93 148
firstPaint - - - - - -
backgroundConnect 57 26 162 23 60 113
firstReactRender 14 11 20 2 15 17
initialActions 1 0 2 1 1 2
loadScripts 1356 1150 2071 184 1386 1683
setupStore 18 7 132 22 16 33
numNetworkReqs 32 19 97 21 27 94
Firefox Browserify Startup Power User Home uiStartup 2763 2073 6707 545 2845 3396
load 1619 1256 5166 444 1632 2106
domContentLoaded 1618 1248 5166 445 1631 2105
domInteractive 139 38 1682 192 115 450
firstPaint - - - - - -
backgroundConnect 237 105 880 177 220 723
firstReactRender 19 14 66 8 19 27
initialActions 2 1 3 1 2 2
loadScripts 1581 1238 5125 436 1586 2044
setupStore 122 8 711 162 138 499
numNetworkReqs 60 28 145 33 78 130
Firefox Webpack Startup Standard Home uiStartup 1714 1403 3215 253 1732 2048
load 1451 1181 2891 228 1475 1631
domContentLoaded 1450 1181 2891 228 1471 1630
domInteractive 91 29 309 49 130 168
firstPaint - - - - - -
backgroundConnect 61 27 251 38 60 141
firstReactRender 15 12 28 3 16 25
initialActions 1 0 2 1 1 2
loadScripts 1425 1169 2871 227 1444 1574
setupStore 22 7 162 26 20 61
numNetworkReqs 31 19 89 18 27 83
Firefox Webpack Startup Power User Home uiStartup 2689 1973 3779 397 2794 3601
load 1581 1302 2466 269 1659 2254
domContentLoaded 1580 1302 2466 269 1659 2254
domInteractive 123 35 690 128 108 474
firstPaint - - - - - -
backgroundConnect 241 110 1221 180 231 589
firstReactRender 22 16 68 7 23 28
initialActions 2 1 3 1 2 2
loadScripts 1538 1272 2443 239 1614 2055
setupStore 181 9 731 211 256 662
numNetworkReqs 59 27 178 35 91 121

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 218 2 219 220
srpButtonToSrpForm 96 2 98 98
confirmSrpToPwForm 23 1 24 25
pwFormToMetricsScreen 17 0 17 18
metricsToWalletReadyScreen 17 1 18 19
doneButtonToHomeScreen 1000 250 1130 1434
openAccountMenuToAccountListLoaded 7374 425 7666 7731
total 8867 27 8905 8905
Onboarding New Wallet createWalletToSocialScreen 217 1 218 219
srpButtonToPwForm 104 1 104 105
createPwToRecoveryScreen 8 0 8 8
skipBackupToMetricsScreen 34 1 34 34
agreeButtonToOnboardingSuccess 16 1 16 17
doneButtonToAssetList 834 339 1146 1329
total 1218 340 1529 1718
Asset Details assetClickToPriceChart 42 4 45 48
total 42 4 45 48
Solana Asset Details assetClickToPriceChart 48 3 49 53
total 48 3 49 53
Import Srp Home loginToHomeScreen 2096 61 2130 2162
openAccountMenuAfterLogin 47 2 48 50
homeAfterImportWithNewWallet 2678 36 2683 2725
total 4910 152 4954 5173
Send Transactions openSendPageFromHome 18 1 18 19
selectTokenToSendFormLoaded 19 1 20 21
reviewTransactionToConfirmationPage 864 7 869 873
total 899 7 902 907
Swap openSwapPageFromHome 113 6 119 119
fetchAndDisplaySwapQuotes 5332 872 6376 6419
total 5444 886 6481 6574

🌐 Dapp Page Load Benchmarks

Current Commit: b70bf1c | Date: 2/23/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±38ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 721ms (±36ms) 🟢 | historical mean value: 736ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±10ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	38ms	1.01s	1.32s	1.06s	1.32s
domContentLoaded	721ms	36ms	700ms	990ms	740ms	990ms
firstPaint	75ms	10ms	60ms	152ms	84ms	152ms
firstContentfulPaint	75ms	10ms	60ms	152ms	84ms	152ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: -238 Bytes (0%)
common: 20 Bytes (0%)

fix: inconsistent decimals

033329f

n3ps requested a review from a team as a code owner February 23, 2026 19:24

n3ps added the team-core-extension-ux Core Extension UX team label Feb 23, 2026

n3ps temporarily deployed to pr-comment February 23, 2026 19:24 — with GitHub Actions Inactive

github-actions bot added the size-S label Feb 23, 2026

n3ps enabled auto-merge February 23, 2026 19:28

lint

b70bf1c

n3ps temporarily deployed to pr-comment February 23, 2026 19:46 — with GitHub Actions Inactive

n3ps temporarily deployed to pr-comment February 23, 2026 20:18 — with GitHub Actions Inactive

AndyMBridges approved these changes Feb 24, 2026

View reviewed changes

ameliejyc approved these changes Feb 24, 2026

View reviewed changes

n3ps added this pull request to the merge queue Feb 24, 2026

Merged via the queue into main with commit a4307a0 Feb 24, 2026
177 checks passed

n3ps deleted the n3ps/legacy-txn-decimal branch February 24, 2026 14:06

github-actions bot locked and limited conversation to collaborators Feb 24, 2026

metamaskbot added the release-13.21.0 Issue or pull request that will be included in release 13.21.0 label Feb 24, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: inconsistent decimals between all and selected network#40341

fix: inconsistent decimals between all and selected network#40341
n3ps merged 2 commits intomainfrom
n3ps/legacy-txn-decimal

n3ps commented Feb 23, 2026 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

metamaskbotv2 bot commented Feb 23, 2026

Uh oh!

metamaskbotv2 bot commented Feb 23, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

n3ps commented Feb 23, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

metamaskbotv2 bot commented Feb 23, 2026

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbotv2 bot commented Feb 23, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

n3ps commented Feb 23, 2026 •

edited by cursor bot

Loading