chore: map staking transaction icon by n3ps · Pull Request #40339 · MetaMask/metamask-extension

n3ps · 2026-02-23T18:14:16Z

Description

Staking transactions were previously never mapped to icons

Changelog

CHANGELOG entry: chore: map staking transaction icon

Related issues

Fixes: #40283

Manual testing steps

Perform a stake deposit
Go to Activity tab
Check UI console

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

^{Cursor Bugbot is generating a summary for commit 86cafc0. Configure here.}

github-actions · 2026-02-23T18:14:31Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

ui/components/app/transaction-icon/transaction-icon.js

metamaskbotv2 · 2026-02-23T18:44:58Z

Builds ready [86cafc0]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (1374 ± 99 ms)

👆 Interaction Benchmarks
Action Metric Mean (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 370 99 483 494
total 370 99 483 494
Confirm Tx confirm_tx 6058 13 6068 6072
total 6058 13 6068 6072
Bridge User Actions bridge_load_page 255 34 280 284
bridge_load_asset_picker 224 37 251 260
bridge_search_token 763 54 811 820
total 1241 121 1338 1364

🔌 Startup Benchmarks
Build Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P 75 (ms) P 95 (ms)
Chrome Browserify Startup Standard Home uiStartup 1374 1190 1688 99 1415 1572
load 1158 961 1435 92 1200 1335
domContentLoaded 1151 957 1420 90 1195 1319
domInteractive 28 16 111 22 24 87
firstPaint 192 69 1371 228 210 363
backgroundConnect 204 186 249 15 207 239
firstReactRender 20 13 43 7 21 37
initialActions 1 0 7 1 2 3
loadScripts 965 775 1217 89 1012 1134
setupStore 13 6 42 6 15 24
numNetworkReqs 31 22 87 19 22 86
Chrome Browserify Startup Power User Home uiStartup 1695 1380 2280 135 1738 1930
load 1131 1025 1743 122 1127 1468
domContentLoaded 1115 1018 1638 114 1116 1396
domInteractive 33 18 146 20 34 54
firstPaint 172 74 473 81 243 296
backgroundConnect 285 254 354 18 295 321
firstReactRender 24 15 54 8 28 41
initialActions 1 0 6 1 1 2
loadScripts 910 815 1415 112 903 1197
setupStore 17 7 75 12 17 38
numNetworkReqs 55 35 145 21 56 99
Chrome Webpack Startup Standard Home uiStartup 889 713 1325 114 964 1092
load 766 624 1047 105 853 945
domContentLoaded 760 620 1040 104 849 937
domInteractive 29 16 116 21 25 91
firstPaint 121 63 387 72 151 245
backgroundConnect 28 19 65 9 31 45
firstReactRender 18 13 40 6 21 30
initialActions 1 0 4 1 1 2
loadScripts 758 618 1033 103 847 935
setupStore 12 6 29 4 12 18
numNetworkReqs 31 22 101 20 25 87
Chrome Webpack Startup Power User Home uiStartup 1218 878 1930 167 1334 1544
load 719 623 1277 117 706 1006
domContentLoaded 709 618 1269 118 693 998
domInteractive 36 18 171 32 34 120
firstPaint 138 65 417 81 170 314
backgroundConnect 180 128 402 59 173 320
firstReactRender 23 18 33 3 25 28
initialActions 1 0 3 1 1 2
loadScripts 706 616 1259 115 691 986
setupStore 13 5 51 7 13 19
numNetworkReqs 106 35 261 54 133 248
Firefox Browserify Startup Standard Home uiStartup 1713 1403 2730 240 1716 2297
load 1440 1182 2378 187 1460 1773
domContentLoaded 1438 1182 2371 186 1455 1772
domInteractive 94 33 307 49 129 139
firstPaint - - - - - -
backgroundConnect 59 32 203 23 59 100
firstReactRender 14 11 19 1 14 17
initialActions 1 0 3 1 2 2
loadScripts 1411 1159 2347 181 1431 1709
setupStore 22 7 247 33 16 48
numNetworkReqs 32 20 95 20 27 90
Firefox Browserify Startup Power User Home uiStartup 2684 1957 4022 424 2838 3476
load 1559 1321 2326 243 1646 2147
domContentLoaded 1559 1320 2326 242 1641 2147
domInteractive 112 35 435 94 113 393
firstPaint - - - - - -
backgroundConnect 252 101 900 216 206 873
firstReactRender 17 14 28 2 18 22
initialActions 2 0 2 1 2 2
loadScripts 1518 1208 2305 237 1584 2095
setupStore 108 8 770 160 96 513
numNetworkReqs 59 27 147 35 86 136
Firefox Webpack Startup Standard Home uiStartup 1784 1531 3427 290 1829 2168
load 1508 1255 3137 267 1528 1779
domContentLoaded 1508 1255 3137 267 1528 1779
domInteractive 108 31 1405 139 130 221
firstPaint - - - - - -
backgroundConnect 65 26 239 39 66 135
firstReactRender 16 12 26 3 17 23
initialActions 1 0 3 1 2 2
loadScripts 1482 1236 3110 265 1501 1760
setupStore 22 7 161 25 18 65
numNetworkReqs 31 20 94 18 27 79
Firefox Webpack Startup Power User Home uiStartup 2794 2079 3992 472 2969 3839
load 1660 1357 2686 339 1770 2473
domContentLoaded 1660 1356 2681 339 1770 2473
domInteractive 162 31 1303 217 114 724
firstPaint - - - - - -
backgroundConnect 275 110 1005 232 232 886
firstReactRender 22 17 71 6 24 30
initialActions 2 1 3 1 2 2
loadScripts 1625 1338 2665 330 1735 2429
setupStore 139 10 798 190 158 633
numNetworkReqs 58 29 147 36 78 132

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 218 1 219 219
srpButtonToSrpForm 91 1 91 92
confirmSrpToPwForm 21 0 21 22
pwFormToMetricsScreen 15 0 15 15
metricsToWalletReadyScreen 15 1 15 16
doneButtonToHomeScreen 1381 108 1446 1467
openAccountMenuToAccountListLoaded 6925 104 7020 7039
total 8428 421 8811 8848
Onboarding New Wallet createWalletToSocialScreen 220 2 222 222
srpButtonToPwForm 105 0 106 106
createPwToRecoveryScreen 8 0 8 9
skipBackupToMetricsScreen 37 2 38 39
agreeButtonToOnboardingSuccess 17 1 18 19
doneButtonToAssetList 942 390 1355 1477
total 1335 398 1778 1864
Asset Details assetClickToPriceChart 40 2 40 43
total 40 2 40 43
Solana Asset Details assetClickToPriceChart 45 1 46 47
total 45 1 46 47
Import Srp Home loginToHomeScreen 1940 25 1975 1975
openAccountMenuAfterLogin 42 2 43 44
homeAfterImportWithNewWallet 2591 107 2709 2729
total 4510 121 4551 4668
Send Transactions openSendPageFromHome 33 9 37 44
selectTokenToSendFormLoaded 20 1 20 20
reviewTransactionToConfirmationPage 847 2 848 850
total 901 2 903 903
Swap openSwapPageFromHome 136 23 145 177
fetchAndDisplaySwapQuotes 5293 830 6210 6399
total 5429 816 6326 6521

🌐 Dapp Page Load Benchmarks

Current Commit: 86cafc0 | Date: 2/23/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.02s (±38ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 714ms (±36ms) 🟢 | historical mean value: 736ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±10ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.02s	38ms	1.00s	1.31s	1.06s	1.31s
domContentLoaded	714ms	36ms	692ms	987ms	741ms	987ms
firstPaint	75ms	10ms	56ms	156ms	84ms	156ms
firstContentfulPaint	75ms	10ms	56ms	156ms	84ms	156ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 105 Bytes (0%)
common: 20 Bytes (0%)

feat: map staking txn icon

86cafc0

n3ps added the team-core-extension-ux Core Extension UX team label Feb 23, 2026

n3ps temporarily deployed to pr-comment February 23, 2026 18:14 — with GitHub Actions Inactive

cursor bot reviewed Feb 23, 2026

View reviewed changes

ui/components/app/transaction-icon/transaction-icon.js Show resolved Hide resolved

github-actions bot added the size-XS label Feb 23, 2026

n3ps requested a review from a team February 23, 2026 18:31

n3ps temporarily deployed to pr-comment February 23, 2026 18:40 — with GitHub Actions Inactive

AndyMBridges approved these changes Feb 23, 2026

View reviewed changes

n3ps enabled auto-merge February 24, 2026 05:00

ameliejyc approved these changes Feb 24, 2026

View reviewed changes

n3ps added this pull request to the merge queue Feb 24, 2026

Merged via the queue into main with commit dda94a7 Feb 24, 2026
189 of 190 checks passed

n3ps deleted the n3ps/txn-icon-staking branch February 24, 2026 14:05

github-actions bot locked and limited conversation to collaborators Feb 24, 2026

metamaskbot added the release-13.21.0 Issue or pull request that will be included in release 13.21.0 label Feb 24, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: map staking transaction icon#40339

chore: map staking transaction icon#40339
n3ps merged 1 commit intomainfrom
n3ps/txn-icon-staking

n3ps commented Feb 23, 2026 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

metamaskbotv2 bot commented Feb 23, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

n3ps commented Feb 23, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

metamaskbotv2 bot commented Feb 23, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

n3ps commented Feb 23, 2026 •

edited by github-actions bot

Loading