feat: cp-13.20.0 added vertical scroll to drawer by NidhiKJha · Pull Request #40301 · MetaMask/metamask-extension

NidhiKJha · 2026-02-20T17:33:18Z

This PR is to add vertical scroll to drawer

Changelog

CHANGELOG entry: adds vertical scroll to drawer

Related issues

Fixes:

Manual testing steps

Go to small window size for full screen
check drawer is scrollable

Screenshots/Recordings

Before

After

Screen.Recording.2026-02-20.at.6.03.35.PM.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
UI-only styling/layout changes localized to the global menu drawer; main risk is regressions in drawer sizing/positioning across fullscreen vs sidepanel views.

Overview
Improves GlobalMenuDrawer fullscreen positioning by consistently applying a 90px top offset (for the logo) to both the backdrop and the drawer panel, and by explicitly pinning the panel with top/bottom instead of relying on h-full/inset classes.

Updates the drawer’s internal flex layout (min-h-0, flex-shrink-0, and overflow-y-auto + padding) so long content can scroll vertically and the header/close button stays fixed without causing overflow glitches.

^{Written by Cursor Bugbot for commit b58db8a. This will update automatically on new commits. Configure here.}

metamaskbotv2 · 2026-02-20T17:34:11Z

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (1 files, +13 -12)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 global-menu-drawer/
      - 📄 global-menu-drawer.tsx +13 -12

ui/components/multichain/global-menu-drawer/global-menu-drawer.tsx

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

ui/components/multichain/global-menu-drawer/global-menu-drawer.tsx

metamaskbotv2 · 2026-02-20T18:47:48Z

Builds ready [9b03601]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (1383 ± 114 ms)

👆 Interaction Benchmarks
Action Metric Mean (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 265 5 264 272
total 265 5 264 272
Confirm Tx confirm_tx 6052 10 6060 6063
total 6052 10 6060 6063
Bridge User Actions bridge_load_page 201 1 200 203
bridge_load_asset_picker 194 2 194 196
bridge_search_token 697 3 697 700
total 1089 7 1091 1098

🔌 Startup Benchmarks
Build Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P 75 (ms) P 95 (ms)
Chrome Browserify Startup Standard Home uiStartup 1383 1169 1781 114 1428 1582
load 1181 968 1509 109 1225 1362
domContentLoaded 1173 964 1497 107 1219 1352
domInteractive 27 16 106 19 23 79
firstPaint 166 66 1202 156 209 376
backgroundConnect 201 188 267 11 205 222
firstReactRender 18 13 43 4 20 24
initialActions 1 0 8 1 2 4
loadScripts 987 783 1307 107 1033 1173
setupStore 13 6 38 5 16 20
numNetworkReqs 31 22 90 20 22 87
Chrome Browserify Startup Power User Home uiStartup 1655 1338 2169 132 1729 1870
load 1093 991 1541 123 1082 1472
domContentLoaded 1078 983 1533 119 1063 1387
domInteractive 32 17 188 24 30 81
firstPaint 166 72 363 78 229 307
backgroundConnect 270 246 348 17 278 299
firstReactRender 23 14 47 7 26 40
initialActions 1 0 8 1 1 3
loadScripts 884 792 1344 117 865 1191
setupStore 16 8 57 8 17 27
numNetworkReqs 57 22 139 22 56 107
Chrome Webpack Startup Standard Home uiStartup 874 700 1261 102 915 1073
load 743 619 1074 91 798 890
domContentLoaded 737 615 1062 90 791 883
domInteractive 31 16 148 23 25 86
firstPaint 122 63 429 71 146 234
backgroundConnect 29 19 83 10 34 47
firstReactRender 19 12 36 6 21 32
initialActions 1 0 5 1 1 2
loadScripts 734 613 1052 89 789 875
setupStore 13 5 50 7 14 22
numNetworkReqs 31 22 98 21 25 88
Chrome Webpack Startup Power User Home uiStartup 1247 884 2119 184 1334 1618
load 723 642 1286 119 716 1038
domContentLoaded 714 633 1272 118 703 1033
domInteractive 37 18 181 31 35 117
firstPaint 135 68 491 85 149 288
backgroundConnect 169 130 418 52 163 261
firstReactRender 24 18 34 4 25 32
initialActions 1 0 2 0 1 1
loadScripts 711 631 1253 116 701 1022
setupStore 13 4 41 6 14 21
numNetworkReqs 101 37 244 49 137 198
Firefox Browserify Startup Standard Home uiStartup 1648 1382 2710 234 1643 2086
load 1398 1183 2433 213 1409 1750
domContentLoaded 1397 1183 2433 213 1409 1749
domInteractive 83 33 544 68 102 161
firstPaint - - - - - -
backgroundConnect 55 27 215 24 57 76
firstReactRender 13 11 18 1 14 15
initialActions 1 0 2 0 1 2
loadScripts 1372 1163 2406 210 1385 1709
setupStore 18 8 209 26 15 43
numNetworkReqs 31 19 95 18 25 75
Firefox Browserify Startup Power User Home uiStartup 2749 2085 3840 330 2868 3595
load 1568 1331 2380 208 1617 1958
domContentLoaded 1567 1331 2380 208 1617 1958
domInteractive 110 35 460 91 114 395
firstPaint - - - - - -
backgroundConnect 260 112 915 202 249 871
firstReactRender 20 15 72 10 19 24
initialActions 1 0 3 1 2 2
loadScripts 1529 1306 2320 195 1581 1865
setupStore 116 9 818 174 119 465
numNetworkReqs 60 31 146 34 87 135
Firefox Webpack Startup Standard Home uiStartup 1760 1480 3532 309 1781 2088
load 1497 1231 3180 288 1496 1749
domContentLoaded 1497 1231 3179 288 1495 1749
domInteractive 121 29 1713 168 131 213
firstPaint - - - - - -
backgroundConnect 63 27 209 32 70 127
firstReactRender 15 13 27 3 16 21
initialActions 1 0 3 1 2 2
loadScripts 1471 1212 3144 286 1475 1710
setupStore 24 8 151 27 20 77
numNetworkReqs 31 19 91 17 27 77
Firefox Webpack Startup Power User Home uiStartup 2697 1909 3771 436 2865 3630
load 1562 1203 2401 267 1693 2144
domContentLoaded 1562 1202 2400 267 1693 2144
domInteractive 123 31 772 144 108 522
firstPaint - - - - - -
backgroundConnect 276 52 1262 230 278 884
firstReactRender 21 16 68 8 23 30
initialActions 1 0 3 1 2 2
loadScripts 1525 1187 2330 246 1647 2005
setupStore 187 7 789 219 330 702
numNetworkReqs 58 29 155 36 71 134

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 217 1 217 218
srpButtonToSrpForm 91 1 92 92
confirmSrpToPwForm 21 0 21 22
pwFormToMetricsScreen 15 0 15 15
metricsToWalletReadyScreen 16 0 16 16
doneButtonToHomeScreen 684 81 707 795
openAccountMenuToAccountListLoaded 7272 390 7625 7850
total 8421 408 8781 8876
Onboarding New Wallet createWalletToSocialScreen 219 0 220 220
srpButtonToPwForm 106 1 106 107
createPwToRecoveryScreen 9 0 9 9
skipBackupToMetricsScreen 36 1 36 36
agreeButtonToOnboardingSuccess 16 0 16 16
doneButtonToAssetList 651 180 595 951
total 1040 183 980 1345
Asset Details assetClickToPriceChart 37 2 36 40
total 37 2 36 40
Solana Asset Details assetClickToPriceChart 45 1 46 47
total 45 1 46 47
Import Srp Home loginToHomeScreen 1948 181 2001 2270
openAccountMenuAfterLogin 39 3 41 43
homeAfterImportWithNewWallet 2424 152 2537 2665
total 4410 146 4520 4616
Send Transactions openSendPageFromHome 19 1 19 21
selectTokenToSendFormLoaded 32 8 40 40
reviewTransactionToConfirmationPage 850 1 852 852
total 909 2 911 911
Swap openSwapPageFromHome 120 17 132 147
fetchAndDisplaySwapQuotes 4698 108 4790 4830
total 4819 123 4937 4962

🌐 Dapp Page Load Benchmarks

Current Commit: 9b03601 | Date: 2/20/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.01s (±40ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 705ms (±37ms) 🟢 | historical mean value: 726ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 74ms (±11ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.01s	40ms	976ms	1.30s	1.04s	1.30s
domContentLoaded	705ms	37ms	671ms	978ms	723ms	978ms
firstPaint	74ms	11ms	60ms	172ms	80ms	172ms
firstContentfulPaint	74ms	11ms	60ms	172ms	80ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 23 Bytes (0%)
common: 20 Bytes (0%)

metamaskbotv2 · 2026-02-23T12:04:49Z

Builds ready [b58db8a]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (1306 ± 105 ms)

👆 Interaction Benchmarks
Action Metric Mean (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 304 42 332 371
total 304 42 332 371
Confirm Tx confirm_tx 6080 27 6102 6108
total 6080 27 6102 6108
Bridge User Actions bridge_load_page 274 25 301 301
bridge_load_asset_picker 168 21 186 191
bridge_search_token 724 11 734 736
total 1178 32 1194 1228

🔌 Startup Benchmarks
Build Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P 75 (ms) P 95 (ms)
Chrome Browserify Startup Standard Home uiStartup 1306 1094 1556 105 1374 1499
load 1110 916 1332 96 1177 1278
domContentLoaded 1102 912 1327 95 1174 1273
domInteractive 26 15 98 20 22 82
firstPaint 196 58 1115 170 216 329
backgroundConnect 191 178 231 10 195 217
firstReactRender 16 12 27 3 18 21
initialActions 1 0 5 1 1 3
loadScripts 927 737 1145 95 1002 1094
setupStore 11 7 28 4 14 19
numNetworkReqs 31 22 97 21 22 89
Chrome Browserify Startup Power User Home uiStartup 1766 1374 5986 474 1782 2010
load 1142 1014 1667 141 1142 1465
domContentLoaded 1127 1005 1654 135 1116 1457
domInteractive 34 19 200 25 33 82
firstPaint 175 71 521 87 240 301
backgroundConnect 338 256 4124 395 299 367
firstReactRender 23 15 54 6 25 34
initialActions 1 0 4 1 1 1
loadScripts 924 803 1443 133 918 1252
setupStore 16 5 55 9 19 29
numNetworkReqs 62 38 154 26 65 134
Chrome Webpack Startup Standard Home uiStartup 829 646 1270 115 886 1042
load 698 578 1035 97 743 864
domContentLoaded 692 575 1029 96 737 860
domInteractive 26 15 115 21 21 76
firstPaint 127 56 723 88 154 265
backgroundConnect 26 17 61 10 29 49
firstReactRender 17 12 43 6 19 30
initialActions 1 0 4 1 1 2
loadScripts 689 573 1022 95 733 858
setupStore 12 6 40 6 12 23
numNetworkReqs 31 22 96 21 25 90
Chrome Webpack Startup Power User Home uiStartup 1205 859 2063 176 1275 1510
load 711 621 1270 114 700 1013
domContentLoaded 702 616 1247 113 690 1000
domInteractive 37 18 175 34 34 120
firstPaint 132 66 498 83 149 311
backgroundConnect 179 127 666 73 176 312
firstReactRender 22 16 33 3 24 27
initialActions 1 0 2 1 1 1
loadScripts 699 614 1229 110 688 984
setupStore 13 5 49 7 13 29
numNetworkReqs 109 39 263 52 138 231
Firefox Browserify Startup Standard Home uiStartup 1733 1455 2849 244 1741 2189
load 1467 1240 2593 222 1489 1796
domContentLoaded 1465 1240 2593 222 1489 1795
domInteractive 97 34 968 132 91 234
firstPaint - - - - - -
backgroundConnect 61 28 243 28 63 102
firstReactRender 14 12 18 1 14 17
initialActions 1 0 3 1 2 2
loadScripts 1437 1215 2566 215 1461 1743
setupStore 21 8 160 26 18 49
numNetworkReqs 31 19 95 20 27 87
Firefox Browserify Startup Power User Home uiStartup 2697 1888 3993 389 2817 3501
load 1524 1220 2329 219 1592 1957
domContentLoaded 1523 1220 2329 219 1589 1957
domInteractive 114 33 540 101 116 375
firstPaint - - - - - -
backgroundConnect 283 109 956 232 295 875
firstReactRender 18 13 64 8 18 23
initialActions 1 0 3 1 2 2
loadScripts 1485 1197 2305 208 1551 1887
setupStore 146 9 1203 227 117 694
numNetworkReqs 60 27 142 29 81 116
Firefox Webpack Startup Standard Home uiStartup 1728 1419 3915 325 1748 2015
load 1450 1194 3665 277 1461 1656
domContentLoaded 1450 1193 3665 278 1461 1655
domInteractive 111 29 1495 147 131 183
firstPaint - - - - - -
backgroundConnect 72 25 1391 137 60 154
firstReactRender 15 12 27 3 16 23
initialActions 1 0 3 1 1 2
loadScripts 1422 1171 3638 275 1434 1590
setupStore 20 5 203 26 15 50
numNetworkReqs 31 19 95 18 27 80
Firefox Webpack Startup Power User Home uiStartup 2797 1941 9107 983 2825 3606
load 1630 1324 7277 650 1689 2269
domContentLoaded 1630 1317 7277 651 1688 2268
domInteractive 103 30 695 102 96 236
firstPaint - - - - - -
backgroundConnect 280 108 5416 534 241 556
firstReactRender 22 16 87 8 22 30
initialActions 2 0 4 1 2 2
loadScripts 1538 1293 3259 303 1643 2107
setupStore 194 9 775 229 307 702
numNetworkReqs 60 27 161 35 76 132

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 218 1 219 219
srpButtonToSrpForm 92 0 91 92
confirmSrpToPwForm 21 0 22 22
pwFormToMetricsScreen 15 0 15 15
metricsToWalletReadyScreen 15 0 16 16
doneButtonToHomeScreen 655 58 661 733
openAccountMenuToAccountListLoaded 6944 107 7018 7079
total 8222 404 8524 8839
Onboarding New Wallet createWalletToSocialScreen 218 0 219 219
srpButtonToPwForm 104 1 105 106
createPwToRecoveryScreen 8 0 8 8
skipBackupToMetricsScreen 35 1 35 36
agreeButtonToOnboardingSuccess 16 0 16 16
doneButtonToAssetList 530 49 567 589
total 916 44 944 972
Asset Details assetClickToPriceChart 54 19 62 86
total 54 19 62 86
Solana Asset Details assetClickToPriceChart 59 1 60 60
total 59 1 60 60
Import Srp Home loginToHomeScreen 2088 206 2188 2441
openAccountMenuAfterLogin 43 2 44 46
homeAfterImportWithNewWallet 2497 74 2586 2586
total 4629 272 4817 5071
Send Transactions openSendPageFromHome 19 1 20 21
selectTokenToSendFormLoaded 21 1 21 22
reviewTransactionToConfirmationPage 868 14 867 891
total 912 14 922 930
Swap openSwapPageFromHome 130 1 131 131
fetchAndDisplaySwapQuotes 4592 21 4595 4625
total 4726 33 4711 4783

🌐 Dapp Page Load Benchmarks

Current Commit: b58db8a | Date: 2/23/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±37ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 722ms (±35ms) 🟢 | historical mean value: 725ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±12ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	37ms	1.01s	1.31s	1.05s	1.31s
domContentLoaded	722ms	35ms	699ms	977ms	738ms	977ms
firstPaint	76ms	12ms	60ms	180ms	84ms	180ms
firstContentfulPaint	76ms	12ms	60ms	180ms	84ms	180ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 23 Bytes (0%)
common: 20 Bytes (0%)

added scroll to drawer

0a399af

NidhiKJha requested a review from a team as a code owner February 20, 2026 17:33

NidhiKJha temporarily deployed to pr-comment February 20, 2026 17:33 — with GitHub Actions Inactive

metamaskbot added team-core-extension-ux Core Extension UX team INVALID-PR-TEMPLATE PR's body doesn't match template labels Feb 20, 2026

github-actions bot added the size-XS label Feb 20, 2026

cursor bot reviewed Feb 20, 2026

View reviewed changes

ui/components/multichain/global-menu-drawer/global-menu-drawer.tsx Show resolved Hide resolved

NidhiKJha had a problem deploying to pr-comment February 20, 2026 17:59 — with GitHub Actions Error

lint fix

1991880

NidhiKJha temporarily deployed to pr-comment February 20, 2026 18:03 — with GitHub Actions Inactive

cursor bot reviewed Feb 20, 2026

View reviewed changes

ui/components/multichain/global-menu-drawer/global-menu-drawer.tsx Show resolved Hide resolved

github-actions bot added size-S and removed size-XS labels Feb 20, 2026

NidhiKJha changed the title ~~feat: cp-13.13.0 added vertical scroll to drawer~~ feat: cp-13.20.0 added vertical scroll to drawer Feb 20, 2026

lint fix

e2155b5

NidhiKJha temporarily deployed to pr-comment February 20, 2026 18:09 — with GitHub Actions Inactive

Merge branch 'main' into add-scroll-to-hamburger

9b03601

NidhiKJha temporarily deployed to pr-comment February 20, 2026 18:17 — with GitHub Actions Inactive

n3ps approved these changes Feb 20, 2026

View reviewed changes

NidhiKJha temporarily deployed to pr-comment February 20, 2026 18:43 — with GitHub Actions Inactive

vinnyhoward approved these changes Feb 20, 2026

View reviewed changes

NidhiKJha enabled auto-merge February 20, 2026 19:54

Merge branch 'main' into add-scroll-to-hamburger

b58db8a

NidhiKJha temporarily deployed to pr-comment February 23, 2026 11:31 — with GitHub Actions Inactive

NidhiKJha temporarily deployed to pr-comment February 23, 2026 12:00 — with GitHub Actions Inactive

NidhiKJha added this pull request to the merge queue Feb 23, 2026

Merged via the queue into main with commit cb1f3f9 Feb 23, 2026
177 checks passed

NidhiKJha deleted the add-scroll-to-hamburger branch February 23, 2026 12:36

github-actions bot locked and limited conversation to collaborators Feb 23, 2026

metamaskbot added the release-13.21.0 Issue or pull request that will be included in release 13.21.0 label Feb 23, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: cp-13.20.0 added vertical scroll to drawer#40301

feat: cp-13.20.0 added vertical scroll to drawer#40301
NidhiKJha merged 5 commits intomainfrom
add-scroll-to-hamburger

NidhiKJha commented Feb 20, 2026 •

edited by cursor bot

Loading

Uh oh!

metamaskbotv2 bot commented Feb 20, 2026 •

edited

Loading

Uh oh!

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

metamaskbotv2 bot commented Feb 20, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Feb 23, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

NidhiKJha commented Feb 20, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbotv2 bot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

metamaskbotv2 bot commented Feb 20, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Feb 23, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NidhiKJha commented Feb 20, 2026 •

edited by cursor bot

Loading

metamaskbotv2 bot commented Feb 20, 2026 •

edited

Loading