chore: update delete button from red to white by vinnyhoward · Pull Request #40261 · MetaMask/metamask-extension

vinnyhoward · 2026-02-19T23:45:32Z

Description

Update delete button from red to white

Changelog

CHANGELOG entry:null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MDP-660

Manual testing steps

Go to this page network picker from the home page
Click on the more icon
Observe change

Screenshots/Recordings

~

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Purely a UI styling change to the network list item menu with no logic, data flow, or security impact.

Overview
Updates NetworkListItemMenu so the Delete menu item no longer uses error (red) styling: removes the legacy IconColor.errorDefault icon color and TextColor.errorDefault text color, leaving the default menu styling (white) for the delete action.

^{Written by Cursor Bugbot for commit 6d14f22. This will update automatically on new commits. Configure here.}

github-actions · 2026-02-19T23:45:40Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-02-19T23:46:21Z

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (1 files, +1 -3)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 network-list-item-menu/
      - 📄 network-list-item-menu.js +1 -3

metamaskbotv2 · 2026-02-20T00:30:18Z

Builds ready [6d14f22]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

UI Startup Metrics (1409 ± 111 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1409	1165	1790	111	1450	1626
			load	1183	989	1453	98	1226	1373
			domContentLoaded	1177	983	1407	96	1222	1349
			domInteractive	28	16	93	16	25	70
			firstPaint	159	70	1031	117	201	333
			backgroundConnect	209	187	274	14	212	234
			firstReactRender	19	12	37	4	20	29
			initialActions	1	0	4	1	1	3
			loadScripts	983	792	1215	96	1028	1154
			setupStore	13	7	49	6	15	22
			numNetworkReqs	31	22	90	20	22	84
	Browserify	Power User Home	uiStartup	2763	1389	10875	2103	2762	9188
			load	1185	1004	1785	148	1234	1533
			domContentLoaded	1170	996	1705	144	1217	1508
			domInteractive	32	19	130	17	30	74
			firstPaint	178	74	326	70	243	284
			backgroundConnect	1124	248	9120	1928	491	4169
			firstReactRender	24	16	44	6	26	35
			initialActions	2	0	148	15	1	3
			loadScripts	966	806	1477	140	1015	1302
			setupStore	16	6	42	7	19	33
			numNetworkReqs	75	33	135	24	92	119
	Webpack	Standard Home	uiStartup	831	682	1076	92	883	1031
			load	712	607	883	82	753	863
			domContentLoaded	706	603	877	81	749	847
			domInteractive	28	15	118	22	23	71
			firstPaint	109	60	406	52	143	189
			backgroundConnect	28	18	65	10	31	51
			firstReactRender	18	12	73	7	19	28
			initialActions	1	0	6	1	1	2
			loadScripts	704	601	870	80	747	845
			setupStore	11	7	38	5	12	20
			numNetworkReqs	31	22	101	21	25	87
	Webpack	Power User Home	uiStartup	1290	895	2765	283	1357	1760
			load	771	637	1192	116	776	1060
			domContentLoaded	760	633	1175	114	768	1047
			domInteractive	41	19	181	31	40	107
			firstPaint	156	68	400	79	184	327
			backgroundConnect	175	133	546	63	168	293
			firstReactRender	23	17	38	4	24	31
			initialActions	1	0	1	0	1	1
			loadScripts	757	631	1166	112	766	1044
			setupStore	12	4	36	5	15	20
			numNetworkReqs	96	39	232	36	118	153
Firefox	Browserify	Standard Home	uiStartup	1592	1381	1998	145	1615	1925
			load	1350	1178	1733	119	1385	1585
			domContentLoaded	1349	1178	1733	119	1383	1585
			domInteractive	71	32	213	38	92	140
			firstPaint	-	-	-	-	-	-
			backgroundConnect	56	30	181	19	59	97
			firstReactRender	13	11	18	1	13	15
			initialActions	1	0	2	1	1	2
			loadScripts	1323	1158	1648	111	1361	1538
			setupStore	16	7	151	20	14	31
			numNetworkReqs	31	20	98	20	25	91
	Browserify	Power User Home	uiStartup	2748	2115	4738	420	2892	3503
			load	1576	1315	3106	254	1645	2001
			domContentLoaded	1575	1315	3106	255	1644	2001
			domInteractive	167	37	1703	194	157	392
			firstPaint	-	-	-	-	-	-
			backgroundConnect	356	77	1130	276	425	951
			firstReactRender	19	15	65	9	18	22
			initialActions	2	0	6	1	2	2
			loadScripts	1534	1294	3072	242	1615	1935
			setupStore	134	7	800	185	116	638
			numNetworkReqs	74	29	169	35	92	145
	Webpack	Standard Home	uiStartup	1842	1451	3384	357	1821	2187
			load	1535	1269	2964	290	1528	1749
			domContentLoaded	1534	1269	2964	290	1528	1748
			domInteractive	117	31	1438	147	132	228
			firstPaint	-	-	-	-	-	-
			backgroundConnect	66	29	155	29	77	138
			firstReactRender	17	13	34	4	18	28
			initialActions	1	0	3	1	2	2
			loadScripts	1507	1255	2933	289	1500	1726
			setupStore	28	8	201	34	25	75
			numNetworkReqs	30	20	89	16	27	72
	Webpack	Power User Home	uiStartup	2782	2021	5979	552	2953	3657
			load	1605	1282	4754	493	1664	2313
			domContentLoaded	1604	1282	4754	493	1664	2312
			domInteractive	183	40	1684	230	161	604
			firstPaint	-	-	-	-	-	-
			backgroundConnect	364	105	1202	264	489	923
			firstReactRender	22	15	65	9	23	29
			initialActions	2	1	3	1	2	2
			loadScripts	1562	1262	4725	484	1610	2077
			setupStore	172	7	1157	234	207	678
			numNetworkReqs	73	29	221	40	84	147

📊 Page Load Benchmark Results

Current Commit: 6d14f22 | Date: 2/20/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±43ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 732ms (±39ms) 🟢 | historical mean value: 742ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±12ms) 🟢 | historical mean value: 81ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	43ms	1.03s	1.38s	1.08s	1.38s
domContentLoaded	732ms	39ms	711ms	1.03s	758ms	1.03s
firstPaint	78ms	12ms	60ms	188ms	84ms	188ms
firstContentfulPaint	78ms	12ms	60ms	188ms	84ms	188ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: -160 Bytes (0%)
common: 20 Bytes (0%)

chore: update delete button from red to white

acb6ace

vinnyhoward requested a review from a team as a code owner February 19, 2026 23:45

vinnyhoward temporarily deployed to pr-comment February 19, 2026 23:45 — with GitHub Actions Inactive

metamaskbot added the team-mobile-ux Mobile UX team label Feb 19, 2026

github-actions bot added the size-XS label Feb 19, 2026

fix: remove unused imports

6d14f22

vinnyhoward temporarily deployed to pr-comment February 19, 2026 23:59 — with GitHub Actions Inactive

vinnyhoward temporarily deployed to pr-comment February 20, 2026 00:25 — with GitHub Actions Inactive

NidhiKJha approved these changes Feb 20, 2026

View reviewed changes

hjetpoluru approved these changes Feb 20, 2026

View reviewed changes

vinnyhoward added this pull request to the merge queue Feb 20, 2026

Merged via the queue into main with commit 1b8db1d Feb 20, 2026
177 checks passed

vinnyhoward deleted the chore-mdp-660-change-delete-network-color branch February 20, 2026 16:53

github-actions bot locked and limited conversation to collaborators Feb 20, 2026

metamaskbot added the release-13.21.0 Issue or pull request that will be included in release 13.21.0 label Feb 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update delete button from red to white#40261

chore: update delete button from red to white#40261
vinnyhoward merged 2 commits intomainfrom
chore-mdp-660-change-delete-network-color

vinnyhoward commented Feb 19, 2026 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

metamaskbotv2 bot commented Feb 19, 2026 •

edited

Loading

Uh oh!

metamaskbotv2 bot commented Feb 20, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

vinnyhoward commented Feb 19, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

metamaskbotv2 bot commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbotv2 bot commented Feb 20, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vinnyhoward commented Feb 19, 2026 •

edited by cursor bot

Loading

metamaskbotv2 bot commented Feb 19, 2026 •

edited

Loading