feat: refresh new state by salimtb · Pull Request #40230 · MetaMask/metamask-extension

salimtb · 2026-02-19T10:47:52Z

Description

refresh new state

Changelog

CHANGELOG entry: refresh new state

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches asset refresh flow across UI and background and introduces a forced-update fetch, which could increase network/load or cause refresh regressions, but the behavior is gated behind a feature flag and covered by tests.

Overview
Adds a new background API getAssets (forcing refresh) and a UI thunk refreshAssetsForSelectedAccount to fetch unified assets for specific accounts with optional chainIds/assetTypes.

Updates the asset list refresh control to call this new unified refresh path behind the assets-unify-state feature flag while keeping existing balance/token detection refresh behavior, and fixes non‑EVM historical price fetching to no-op when no internalAccount is available. Includes unit tests covering the new refresh action’s background call behavior and error handling.

^{Written by Cursor Bugbot for commit 6ce4011. This will update automatically on new commits. Configure here.}

github-actions · 2026-02-19T10:48:02Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-02-19T10:48:42Z

✨ Files requiring CODEOWNER review ✨

💎 @MetaMask/metamask-assets (1 files, +13 -0)

📁 ui/
- 📁 components/
  - 📁 app/
    - 📁 assets/
      - 📁 asset-list/
        
        📁 asset-list-control-bar/
        
        📄 asset-list-control-bar.tsx +13 -0

metamaskbotv2 · 2026-02-19T11:29:33Z

Builds ready [8456a0f]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

UI Startup Metrics (1423 ± 100 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1423	1218	1657	100	1467	1600
			load	1224	1039	1422	93	1267	1406
			domContentLoaded	1217	1018	1414	93	1254	1396
			domInteractive	28	18	100	17	24	70
			firstPaint	167	68	1419	146	215	260
			backgroundConnect	254	231	302	13	258	281
			firstReactRender	20	12	170	16	19	25
			initialActions	1	0	4	1	1	3
			loadScripts	978	788	1175	91	1019	1154
			setupStore	13	6	35	5	15	22
			numNetworkReqs	31	22	88	20	22	85
	Browserify	Power User Home	uiStartup	2141	1338	10547	1349	2040	4144
			load	1212	1046	1663	142	1273	1529
			domContentLoaded	1195	1039	1569	135	1251	1483
			domInteractive	35	19	241	26	35	73
			firstPaint	204	75	1588	163	260	352
			backgroundConnect	631	306	8736	1239	373	2053
			firstReactRender	24	15	44	6	26	38
			initialActions	1	0	3	1	1	2
			loadScripts	937	790	1313	128	981	1218
			setupStore	16	7	46	7	17	33
			numNetworkReqs	65	29	126	23	75	114
	Webpack	Standard Home	uiStartup	910	725	1220	105	969	1097
			load	775	621	1045	105	858	959
			domContentLoaded	769	617	1040	104	852	949
			domInteractive	30	17	122	21	26	74
			firstPaint	126	66	430	69	140	229
			backgroundConnect	29	21	52	8	32	46
			firstReactRender	18	13	36	6	20	32
			initialActions	1	0	2	1	1	2
			loadScripts	766	615	1038	103	850	941
			setupStore	12	7	28	4	13	20
			numNetworkReqs	32	22	95	20	31	84
	Webpack	Power User Home	uiStartup	1256	943	2188	184	1351	1585
			load	745	650	1333	120	738	1026
			domContentLoaded	736	643	1320	120	724	1019
			domInteractive	38	20	148	26	37	124
			firstPaint	138	71	338	63	158	266
			backgroundConnect	166	133	415	46	166	282
			firstReactRender	22	17	34	3	24	28
			initialActions	1	0	4	1	1	1
			loadScripts	733	641	1311	118	722	1011
			setupStore	13	4	43	6	15	21
			numNetworkReqs	117	41	247	43	146	203
Firefox	Browserify	Standard Home	uiStartup	1650	1408	2136	153	1699	1973
			load	1391	1184	1811	124	1432	1673
			domContentLoaded	1390	1180	1810	124	1432	1672
			domInteractive	82	33	303	58	92	193
			firstPaint	-	-	-	-	-	-
			backgroundConnect	58	26	185	19	62	84
			firstReactRender	14	11	21	2	14	16
			initialActions	1	0	3	0	1	2
			loadScripts	1364	1170	1773	119	1409	1573
			setupStore	23	8	217	34	16	94
			numNetworkReqs	31	19	96	19	27	86
	Browserify	Power User Home	uiStartup	2940	2247	4251	416	3162	3731
			load	1666	1306	2445	253	1766	2192
			domContentLoaded	1665	1305	2445	253	1766	2191
			domInteractive	140	34	788	130	129	369
			firstPaint	-	-	-	-	-	-
			backgroundConnect	341	117	1044	254	386	914
			firstReactRender	21	15	79	8	21	30
			initialActions	2	1	3	1	2	3
			loadScripts	1625	1274	2418	241	1702	2120
			setupStore	157	6	794	210	155	673
			numNetworkReqs	63	25	168	37	80	134
	Webpack	Standard Home	uiStartup	1777	1437	3217	315	1796	2117
			load	1471	1212	2842	210	1508	1623
			domContentLoaded	1470	1211	2842	210	1507	1619
			domInteractive	98	29	218	46	133	183
			firstPaint	-	-	-	-	-	-
			backgroundConnect	79	26	1417	141	73	166
			firstReactRender	17	12	51	5	17	25
			initialActions	1	0	4	1	2	2
			loadScripts	1445	1199	2811	207	1482	1572
			setupStore	25	7	216	32	20	68
			numNetworkReqs	31	20	90	16	28	71
	Webpack	Power User Home	uiStartup	2767	1991	4247	470	2896	3690
			load	1586	1294	3284	308	1709	2215
			domContentLoaded	1585	1294	3284	308	1709	2215
			domInteractive	119	30	1245	137	125	290
			firstPaint	-	-	-	-	-	-
			backgroundConnect	348	82	1597	285	424	916
			firstReactRender	22	16	66	7	24	33
			initialActions	2	0	3	1	2	3
			loadScripts	1538	1275	3198	292	1624	1863
			setupStore	170	8	859	222	216	674
			numNetworkReqs	61	26	158	33	76	127

📊 Page Load Benchmark Results

Current Commit: 8456a0f | Date: 2/19/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±45ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 747ms (±41ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 82ms (±13ms) 🟢 | historical mean value: 86ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	45ms	1.02s	1.39s	1.11s	1.39s
domContentLoaded	747ms	41ms	713ms	1.05s	796ms	1.05s
firstPaint	82ms	13ms	64ms	200ms	92ms	200ms
firstContentfulPaint	82ms	13ms	64ms	200ms	92ms	200ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -428 Bytes (-0.01%)
ui: 1.37 KiB (0.02%)
common: 914 Bytes (0.01%)

ui/store/actions.ts

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

ui/components/app/assets/asset-list/asset-list-control-bar/asset-list-control-bar.tsx

metamaskbotv2 · 2026-02-19T14:25:02Z

Builds ready [6ce4011]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

UI Startup Metrics (1383 ± 103 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1383	1147	1708	103	1421	1561
			load	1166	960	1474	95	1204	1332
			domContentLoaded	1158	948	1469	95	1199	1326
			domInteractive	27	15	126	19	24	74
			firstPaint	163	62	1153	125	202	333
			backgroundConnect	230	207	394	24	234	256
			firstReactRender	16	10	37	4	18	22
			initialActions	1	0	6	1	1	3
			loadScripts	948	748	1246	94	977	1117
			setupStore	12	7	46	5	13	20
			numNetworkReqs	31	22	100	21	22	89
	Browserify	Power User Home	uiStartup	2909	1480	10689	1753	3107	6236
			load	1211	1022	2101	160	1246	1470
			domContentLoaded	1190	1006	1957	145	1229	1437
			domInteractive	35	19	227	29	33	93
			firstPaint	251	75	1646	258	256	605
			backgroundConnect	975	279	8269	1221	1138	3123
			firstReactRender	24	16	56	7	26	35
			initialActions	1	0	3	1	1	2
			loadScripts	961	798	1683	136	995	1198
			setupStore	16	7	65	9	17	29
			numNetworkReqs	81	33	155	25	93	131
	Webpack	Standard Home	uiStartup	891	721	1284	118	921	1143
			load	757	625	1047	100	800	945
			domContentLoaded	751	620	1037	99	794	937
			domInteractive	31	15	114	23	26	93
			firstPaint	121	65	421	66	136	245
			backgroundConnect	28	20	56	7	32	41
			firstReactRender	19	12	42	7	22	34
			initialActions	1	0	4	1	1	3
			loadScripts	748	618	1035	98	791	935
			setupStore	13	6	41	6	14	25
			numNetworkReqs	31	22	94	20	25	88
	Webpack	Power User Home	uiStartup	1286	879	2732	229	1394	1642
			load	774	662	1346	116	770	1044
			domContentLoaded	762	652	1329	116	757	1038
			domInteractive	45	20	216	36	42	139
			firstPaint	174	79	597	90	217	310
			backgroundConnect	182	133	1312	122	169	278
			firstReactRender	22	18	32	3	23	27
			initialActions	1	0	2	1	1	1
			loadScripts	760	650	1319	114	755	1028
			setupStore	13	5	48	7	15	22
			numNetworkReqs	126	42	251	45	156	197
Firefox	Browserify	Standard Home	uiStartup	1645	1398	2527	194	1665	2037
			load	1375	1178	2177	152	1405	1646
			domContentLoaded	1374	1178	2176	152	1404	1646
			domInteractive	76	33	188	37	94	139
			firstPaint	-	-	-	-	-	-
			backgroundConnect	63	30	300	34	68	133
			firstReactRender	14	11	25	2	14	16
			initialActions	1	0	3	1	2	2
			loadScripts	1347	1154	2145	148	1380	1606
			setupStore	21	8	180	31	15	99
			numNetworkReqs	31	20	99	20	25	88
	Browserify	Power User Home	uiStartup	2944	2035	8058	644	3039	3686
			load	1669	1323	6520	571	1712	2217
			domContentLoaded	1668	1323	6520	571	1711	2216
			domInteractive	193	55	1821	252	188	484
			firstPaint	-	-	-	-	-	-
			backgroundConnect	497	119	1731	327	758	993
			firstReactRender	19	14	69	8	19	27
			initialActions	2	0	47	5	2	2
			loadScripts	1621	1301	6473	564	1662	2085
			setupStore	146	14	767	183	142	666
			numNetworkReqs	85	31	208	34	96	154
	Webpack	Standard Home	uiStartup	1719	1457	3243	315	1705	2088
			load	1457	1196	2976	291	1462	1668
			domContentLoaded	1456	1195	2976	292	1461	1668
			domInteractive	79	29	341	49	100	140
			firstPaint	-	-	-	-	-	-
			backgroundConnect	60	22	219	36	61	134
			firstReactRender	15	12	28	3	16	19
			initialActions	1	0	3	1	2	2
			loadScripts	1429	1182	2948	288	1433	1651
			setupStore	18	6	139	21	15	50
			numNetworkReqs	31	19	94	18	27	78
	Webpack	Power User Home	uiStartup	2898	1923	8579	826	3025	3466
			load	1664	1303	7293	730	1625	2262
			domContentLoaded	1664	1303	7293	730	1625	2261
			domInteractive	188	47	1017	192	205	690
			firstPaint	-	-	-	-	-	-
			backgroundConnect	415	120	1234	278	515	1029
			firstReactRender	22	16	75	10	23	32
			initialActions	2	0	3	1	2	2
			loadScripts	1625	1272	7219	724	1579	2226
			setupStore	159	11	700	166	234	557
			numNetworkReqs	84	32	240	39	90	174

📊 Page Load Benchmark Results

Current Commit: 6ce4011 | Date: 2/19/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±40ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 724ms (±38ms) 🟢 | historical mean value: 726ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 80ms (±12ms) 🟢 | historical mean value: 84ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	40ms	1.01s	1.34s	1.06s	1.34s
domContentLoaded	724ms	38ms	702ms	1.02s	750ms	1.02s
firstPaint	80ms	12ms	64ms	176ms	92ms	176ms
firstContentfulPaint	80ms	12ms	64ms	176ms	92ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -428 Bytes (-0.01%)
ui: 1.39 KiB (0.02%)
common: 914 Bytes (0.01%)

feat: refresh new state

11dd818

salimtb temporarily deployed to pr-comment February 19, 2026 10:48 — with GitHub Actions Inactive

metamaskbot added the team-assets label Feb 19, 2026

github-actions bot added the size-S label Feb 19, 2026

fix: add unit tests

8456a0f

salimtb temporarily deployed to pr-comment February 19, 2026 10:55 — with GitHub Actions Inactive

github-actions bot added size-M and removed size-S labels Feb 19, 2026

salimtb temporarily deployed to pr-comment February 19, 2026 11:25 — with GitHub Actions Inactive

Merge branch 'main' into feat/refresh-new-state

b15f696

salimtb had a problem deploying to pr-comment February 19, 2026 13:16 — with GitHub Actions Error

salimtb marked this pull request as ready for review February 19, 2026 13:16

salimtb requested a review from a team as a code owner February 19, 2026 13:16

salimtb temporarily deployed to pr-comment February 19, 2026 13:16 — with GitHub Actions Inactive

cursor bot reviewed Feb 19, 2026

View reviewed changes

ui/store/actions.ts Show resolved Hide resolved

fix: clean up

b75210e

salimtb temporarily deployed to pr-comment February 19, 2026 13:29 — with GitHub Actions Inactive

cursor bot reviewed Feb 19, 2026

View reviewed changes

ui/components/app/assets/asset-list/asset-list-control-bar/asset-list-control-bar.tsx Show resolved Hide resolved

fix: fix lint error

6ce4011

salimtb temporarily deployed to pr-comment February 19, 2026 13:51 — with GitHub Actions Inactive

salimtb temporarily deployed to pr-comment February 19, 2026 14:20 — with GitHub Actions Inactive

Prithpal-Sooriya approved these changes Feb 20, 2026

View reviewed changes

juanmigdr approved these changes Feb 20, 2026

View reviewed changes

salimtb added this pull request to the merge queue Feb 20, 2026

Merged via the queue into main with commit 397ad0e Feb 20, 2026
177 checks passed

salimtb deleted the feat/refresh-new-state branch February 20, 2026 15:58

github-actions bot locked and limited conversation to collaborators Feb 20, 2026

metamaskbot added the release-13.21.0 Issue or pull request that will be included in release 13.21.0 label Feb 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: refresh new state#40230

feat: refresh new state#40230
salimtb merged 5 commits intomainfrom
feat/refresh-new-state

salimtb commented Feb 19, 2026 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

metamaskbotv2 bot commented Feb 19, 2026

Uh oh!

metamaskbotv2 bot commented Feb 19, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

metamaskbotv2 bot commented Feb 19, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

salimtb commented Feb 19, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

metamaskbotv2 bot commented Feb 19, 2026

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbotv2 bot commented Feb 19, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

metamaskbotv2 bot commented Feb 19, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

salimtb commented Feb 19, 2026 •

edited by cursor bot

Loading