feat: new assets controllers integration#40228
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (1 files, +26 -0)
|
Contributor
Builds ready [9346080]
UI Startup Metrics (1444 ± 107 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [3db9a7c]
UI Startup Metrics (1442 ± 108 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ui/components/multichain/import-tokens-modal/import-tokens-modal.js
Outdated
Show resolved
Hide resolved
ui/pages/confirm-add-suggested-token/confirm-add-suggested-token.js
Outdated
Show resolved
Hide resolved
ui/pages/confirm-add-suggested-token/confirm-add-suggested-token.js
Outdated
Show resolved
Hide resolved
19c3ee5 to
63bc65c
Compare
Contributor
Builds ready [63bc65c]
UI Startup Metrics (1437 ± 115 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Prithpal-Sooriya
approved these changes
Feb 20, 2026
n3ps
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
support import/hide tokens for the new controller
make sure the FF
isAssetsUnifyStateFeatureEnabledis onChangelog
CHANGELOG entry: support import/hide tokens for the new controller
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
after.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Touches token import/hide flows and adds new background RPC actions for the unified AssetsController; behavior now branches on a feature flag and CAIP-19 ID handling, which could affect asset visibility and state refresh timing.
Overview
Adds unified AssetsController integration for token import/hide when the
assetsUnifyStatefeature flag is enabled.The background API and Redux actions now support
hideAsset,unhideAsset,addCustomAsset,removeCustomAsset, plus a newimportCustomAssetsBatchthat avoids per-token state refreshes by batching requests and refreshing once.UI flows are updated to use CAIP-19
assetIds: the hide-token confirmation will either remove a custom asset from the account or hide it in preferences, and the import-tokens modal will batch add/unhide imported tokens while preserving hidden state; new selectors/tests are added for readingassetPreferences/customAssetsand checking hidden/custom status.Written by Cursor Bugbot for commit 19c3ee5. This will update automatically on new commits. Configure here.