Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (1 files, +8 -6)
👨🔧 @MetaMask/core-extension-ux (5 files, +36 -28)
🎨 @MetaMask/design-system-engineers (6 files, +131 -0)
🔄 @MetaMask/swaps-engineers (3 files, +23 -23)
|
ui/pages/bridge/prepare/__snapshots__/bridge-input-group.test.tsx.snap
Outdated
Show resolved
Hide resolved
Builds ready [3958b67]
UI Startup Metrics (1454 ± 104 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
ui/components/app/transaction-breakdown/transaction-breakdown.component.js
Outdated
Show resolved
Hide resolved
Builds ready [18e9c1c]
UI Startup Metrics (1497 ± 190 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
ui/components/app/transaction-breakdown/transaction-breakdown.component.js
Outdated
Show resolved
Hide resolved
Builds ready [9e89127]
UI Startup Metrics (1424 ± 113 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [c5bf0c9]
UI Startup Metrics (1370 ± 102 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [178b51f]
UI Startup Metrics (1504 ± 102 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [8451283]
UI Startup Metrics (1474 ± 118 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [d8bd7e7]
UI Startup Metrics (1547 ± 130 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
brianacnguyen
left a comment
There was a problem hiding this comment.
success-pill is not needed. can you just use the tag component
georgewrmarshall
left a comment
There was a problem hiding this comment.
Approved to unblock. Should be replaced with Tag if applicable now, in a follow up PR or once we have the component from MMDS
Description
Updates the gas sponsorship UI so "Paid by MetaMask" and "No network fee" use a green pill style across Send, Dapp, Swap, and network lists.
N.B: Feature flags to show gas sponsorship are enabled on dev-only for now.
Changelog
CHANGELOG entry: Gas sponsorship UI
Related issues
Fixes:
Manual testing steps
1. Send – confirmation:
2. Send – transaction details
3. Network lists – “No network fee”
4. Bridge/Swap – quote card
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
UI-only component addition and label rendering changes; primary risk is minor visual/layout regressions in network list rows and fee displays.
Overview
Adds a new component-library primitive,
SuccessPill, to render success-styled (green) pill labels and includes unit/snapshot coverage.Replaces plain
Textlabels withSuccessPillfor gas sponsorship messaging: “Paid by MetaMask” in transaction breakdown, confirm gas fee row, and bridge quote card, and “No network fee” next to sponsored networks in network list surfaces. Network list layouts were adjusted (row flex +gap) to keep the pill inline with the network name, updating related snapshots.Written by Cursor Bugbot for commit d8bd7e7. This will update automatically on new commits. Configure here.