fix: migrate hype slip44 correct value NE ctrl#40206
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
a13c2d5 to
f46995d
Compare
f46995d to
4c65f18
Compare
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/extension-platform (1 files, +2 -2)
📜 @MetaMask/policy-reviewers (8 files, +20 -252)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🧪 @MetaMask/qa (1 files, +2 -2)
|
Contributor
Builds ready [4c65f18]
UI Startup Metrics (1422 ± 105 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
f8fa485 to
81ff7a6
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
Builds ready [81ff7a6]
UI Startup Metrics (1558 ± 119 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
81ff7a6 to
3d711f7
Compare
Contributor
Builds ready [3d711f7]
UI Startup Metrics (1475 ± 112 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
3d711f7 to
075d581
Compare
075d581 to
e54980e
Compare
Contributor
Builds ready [e54980e]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Contributor
Author
|
@metamaskbot update-policies |
Contributor
Author
Following https://consensys.slack.com/archives/CTQAGKY5V/p1687770825299589 after getting |
Contributor
Builds ready [e54980e]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff 👀 lavamoat/browserify/beta/policy.json changes differ from main/policy.json policy changes |
Contributor
Builds ready [4bb4c11]
UI Startup Metrics (1400 ± 115 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
MajorLift
approved these changes
Feb 23, 2026
Contributor
MajorLift
left a comment
There was a problem hiding this comment.
policy changes: internal packages only, transitive + removals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context: HYPE token (
eip155:999/slip44:2457) was incorrectly set toeip155:999/slip44:1(1instead of2457)for some users in NetworkEnablementController.nativeAssetIdentifiers state.
This is because https://chainid.network/chains.json is fetched to populate this state,
and that chainId "999" references a "WanChain testnet" instead of HyperEVM.
PR MetaMask/core#7975 addresses future population by forcing an
override at fetch-time.
However such fetching is not always triggered if an user had already added the network,
hence the need for this migration that - ontop of the PR above - will migrate the incorrect
entry ('eip155:999/slip44:1') to the correct one ('eip155:999/slip44:2457').
This migration will operate only if an entry already exists AND is not 'eip155:999/slip44:2457'.
Changelog
CHANGELOG entry: migrates
NetworkEnablementController.nativeAssetIdentifiers['eip155:999']to valueeip155:999/slip44:2457if applicable.Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/NEB-574
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Migration is narrowly scoped to a single stored key and is guarded by shape checks and “only-if-present” logic; main risk is incorrect assumptions about persisted state shapes, mitigated by early exits and Sentry logging.
Overview
Adds state migration
196to fix an incorrectNetworkEnablementController.nativeAssetIdentifiers['eip155:999']value by overwriting it witheip155:999/slip44:2457only when the key already exists and is not already correct, and recordsNetworkEnablementControlleras changed.Introduces a small
196_utilsvalidator that Sentry-logs unexpected/missing controller state shapes, adds comprehensive unit coverage for these edge cases, wires the migration into the main migrations list, and bumps e2e fixture migration versions accordingly. Also updates@metamask/network-enablement-controller(and related lockfile/policy entries) to the newer patch release.Written by Cursor Bugbot for commit 4bb4c11. This will update automatically on new commits. Configure here.