chore: remove pinned swap token from asset picker by micaelae · Pull Request #40204 · MetaMask/metamask-extension

micaelae · 2026-02-18T14:29:39Z

Description

Preserves the selected asset's sorting order instead of pinning it to the top of the list

Changelog

CHANGELOG entry: chore: remove pinned swap token from asset picker

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-3982

Manual testing steps

Select asset in Swap flow
Reopen the asset picker and verify selected asset does not appear at the top of the list

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Small UI/data-fetch parameter tweak limited to the bridge asset picker; main risk is subtle changes to token ordering and API caching behavior.

Overview
Updates the bridge asset picker to stop forcing the currently selected asset into the assetsToInclude list, so token fetches and resulting ordering are no longer influenced by the selected token.

This removes selectedAsset from the useMemo that builds assetsToInclude (and its dependency), and updates the BridgeInputGroup Jest snapshots to reflect the changed includeAssets request bodies and cache keys.

^{Written by Cursor Bugbot for commit 07fcfa9. This will update automatically on new commits. Configure here.}

metamaskbotv2 · 2026-02-18T14:30:29Z

✨ Files requiring CODEOWNER review ✨

🔄 @MetaMask/swaps-engineers (2 files, +8 -8)

📁 ui/
- 📁 pages/
  - 📁 bridge/
    - 📁 prepare/
      - 📁 __snapshots__/
        
        📄 bridge-input-group.test.tsx.snap +6 -6
      - 📁 components/
        
        📁 bridge-asset-picker/
        
        📄 index.tsx +2 -2

metamaskbotv2 · 2026-02-18T15:03:01Z

Builds ready [3bc6076]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

UI Startup Metrics (1440 ± 106 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1440	1234	1925	106	1496	1623
			load	1234	1049	1599	92	1278	1398
			domContentLoaded	1226	1044	1592	92	1267	1388
			domInteractive	28	17	102	19	25	77
			firstPaint	175	69	1283	173	218	358
			backgroundConnect	262	241	403	20	266	288
			firstReactRender	20	10	186	23	19	25
			initialActions	1	0	5	1	1	3
			loadScripts	981	801	1334	92	1024	1141
			setupStore	12	6	49	5	15	22
			numNetworkReqs	23	15	88	20	15	82
	Browserify	Power User Home	uiStartup	3379	1685	11017	2135	4063	9409
			load	1336	1114	1734	149	1413	1693
			domContentLoaded	1314	1102	1705	137	1365	1649
			domInteractive	37	21	186	26	34	93
			firstPaint	253	86	1608	229	290	350
			backgroundConnect	1293	317	9024	1736	1337	3820
			firstReactRender	25	18	47	5	26	35
			initialActions	1	0	5	1	1	2
			loadScripts	1042	852	1445	130	1073	1337
			setupStore	16	6	164	16	17	24
			numNetworkReqs	91	41	152	25	107	134
	Webpack	Standard Home	uiStartup	857	710	1127	93	937	987
			load	749	631	923	91	821	900
			domContentLoaded	743	628	913	91	815	895
			domInteractive	27	16	103	18	24	78
			firstPaint	114	63	321	49	138	211
			backgroundConnect	26	19	42	6	29	41
			firstReactRender	16	10	132	12	17	24
			initialActions	1	0	4	1	1	2
			loadScripts	740	626	911	90	813	893
			setupStore	12	6	38	5	12	22
			numNetworkReqs	23	15	86	20	15	82
	Webpack	Power User Home	uiStartup	1368	915	2994	342	1411	2098
			load	788	677	1141	106	799	1049
			domContentLoaded	776	663	1135	107	786	1036
			domInteractive	43	22	238	34	39	119
			firstPaint	176	84	456	88	214	361
			backgroundConnect	189	137	912	100	180	316
			firstReactRender	23	18	31	3	25	29
			initialActions	1	0	2	0	1	1
			loadScripts	773	661	1125	104	784	1027
			setupStore	13	5	28	5	16	21
			numNetworkReqs	140	75	300	37	158	189
Firefox	Browserify	Standard Home	uiStartup	1559	1310	2323	193	1599	2025
			load	1346	1151	2092	151	1400	1661
			domContentLoaded	1344	1150	2087	151	1396	1660
			domInteractive	71	32	312	54	90	171
			firstPaint	-	-	-	-	-	-
			backgroundConnect	54	25	177	23	54	103
			firstReactRender	12	10	25	2	13	17
			initialActions	1	0	3	1	1	2
			loadScripts	1320	1133	2058	144	1374	1630
			setupStore	16	6	174	26	13	44
			numNetworkReqs	24	12	98	21	17	81
	Browserify	Power User Home	uiStartup	2797	2050	6103	475	2897	3370
			load	1579	1314	4938	396	1634	1882
			domContentLoaded	1579	1314	4938	396	1634	1881
			domInteractive	174	51	1407	171	198	475
			firstPaint	-	-	-	-	-	-
			backgroundConnect	386	124	1205	254	462	900
			firstReactRender	20	14	66	10	20	52
			initialActions	2	0	53	5	2	2
			loadScripts	1531	1268	4893	391	1568	1829
			setupStore	135	13	844	174	144	560
			numNetworkReqs	94	43	187	32	111	167
	Webpack	Standard Home	uiStartup	1643	1352	3218	204	1688	1824
			load	1435	1191	2841	172	1488	1572
			domContentLoaded	1435	1191	2841	172	1487	1572
			domInteractive	112	30	1486	147	132	195
			firstPaint	-	-	-	-	-	-
			backgroundConnect	52	24	212	31	56	98
			firstReactRender	13	11	27	2	14	17
			initialActions	1	0	2	0	2	2
			loadScripts	1412	1173	2806	168	1462	1547
			setupStore	13	6	165	18	12	32
			numNetworkReqs	23	12	96	17	17	63
	Webpack	Power User Home	uiStartup	2868	2199	8916	829	2940	3440
			load	1635	1337	7653	642	1660	2118
			domContentLoaded	1635	1337	7653	642	1659	2117
			domInteractive	156	50	754	150	135	604
			firstPaint	-	-	-	-	-	-
			backgroundConnect	471	122	1329	306	683	1047
			firstReactRender	22	15	67	7	23	32
			initialActions	2	0	5	1	2	2
			loadScripts	1573	1305	7580	634	1564	2030
			setupStore	152	17	3674	381	121	558
			numNetworkReqs	95	42	223	38	102	174

📊 Page Load Benchmark Results

Current Commit: 3bc6076 | Date: 2/18/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±55ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 747ms (±53ms) 🟢 | historical mean value: 741ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 82ms (±12ms) 🟢 | historical mean value: 86ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	55ms	1.03s	1.35s	1.13s	1.35s
domContentLoaded	747ms	53ms	719ms	1.04s	793ms	1.04s
firstPaint	82ms	12ms	68ms	180ms	92ms	180ms
firstContentfulPaint	82ms	12ms	68ms	180ms	92ms	180ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: -12 Bytes (0%)
common: 20 Bytes (0%)

…asset

chore: remove pinned swap token from asset picker

3bc6076

micaelae temporarily deployed to pr-comment February 18, 2026 14:29 — with GitHub Actions Inactive

metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Feb 18, 2026

github-actions bot added the size-XS label Feb 18, 2026

micaelae temporarily deployed to pr-comment February 18, 2026 14:58 — with GitHub Actions Inactive

micaelae marked this pull request as ready for review February 18, 2026 15:59

micaelae requested a review from a team as a code owner February 18, 2026 15:59

micaelae had a problem deploying to pr-comment February 18, 2026 15:59 — with GitHub Actions Failure

Merge branch 'main' into swaps3982-rm-pinned-asset

3b3a88e

micaelae temporarily deployed to pr-comment February 18, 2026 16:37 — with GitHub Actions Inactive

micaelae enabled auto-merge February 18, 2026 16:48

micaelae temporarily deployed to pr-comment February 18, 2026 17:04 — with GitHub Actions Inactive

Merge branch 'main' into swaps3982-rm-pinned-asset

27fa537

micaelae temporarily deployed to pr-comment February 18, 2026 17:41 — with GitHub Actions Inactive

micaelae changed the base branch from main to swaps/fix-bridge-input-flaky February 18, 2026 17:41

Merge branch 'swaps/fix-bridge-input-flaky' into swaps3982-rm-pinned-…

07fcfa9

…asset

micaelae had a problem deploying to pr-comment February 18, 2026 17:42 — with GitHub Actions Failure

micaelae merged commit 08376f6 into swaps/fix-bridge-input-flaky Feb 18, 2026
4 of 6 checks passed

micaelae deleted the swaps3982-rm-pinned-asset branch February 18, 2026 17:42

github-actions bot locked and limited conversation to collaborators Feb 18, 2026

micaelae temporarily deployed to pr-comment February 18, 2026 18:11 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove pinned swap token from asset picker#40204

chore: remove pinned swap token from asset picker#40204
micaelae merged 4 commits intoswaps/fix-bridge-input-flakyfrom
swaps3982-rm-pinned-asset

micaelae commented Feb 18, 2026 •

edited by cursor bot

Loading

Uh oh!

metamaskbotv2 bot commented Feb 18, 2026

Uh oh!

metamaskbotv2 bot commented Feb 18, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

micaelae commented Feb 18, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbotv2 bot commented Feb 18, 2026

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbotv2 bot commented Feb 18, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

micaelae commented Feb 18, 2026 •

edited by cursor bot

Loading