feat(rewards): hardware wallet support by VGR-GIT · Pull Request #40202 · MetaMask/metamask-extension

VGR-GIT · 2026-02-18T13:24:21Z

Description

Support for hardware wallets in rewards feature for extension.

Changelog

CHANGELOG entry: support for hardware wallets in rewards feature for extension.

Screenshots

Message shown to users when we know their hardware wallet is associated with a subscription but can't authenticate with it unless they explicitly sign a message:

sign-message-to-authenticate-existing-sub

Multi subscription balance (hardware wallet = subscription B). Hot wallet was already opted in

Fresh wallet & hardware wallet without existing subscriptions & opt in + link account(s) via swap flow

Opting in while ledger is not connected/paired (message from existing thrown error)

Note

High Risk
High: introduces new SIWE auth + challenge endpoints and changes rewards authentication/subscription selection logic, which can affect opt-in/linking and access to balances (especially across mixed hardware/software account groups).

Overview
Adds hardware-wallet support to Rewards by introducing a SIWE-based authentication path: the controller can now generateChallenge, request SIWE-aware signPersonalMessage, and call new data-service endpoints siweLogin/siweJoin for opt-in and account linking.

Refines subscription-id handling and caching so hardware accounts don’t persist/use a subscriptionId unless a usable session token exists, skips hardware accounts during silent auth attempts, and extends season discovery/metadata to include previous seasons (with a shorter metadata cache TTL).

Updates the UI to handle the new “hardware wallet needs explicit sign-in” state (error-existing-subscription-hardware-wallet-explicit-sign) by showing a sign-in / signing-in badge, adjusts onboarding to no longer block hardware wallets, and ensures the onboarding modal stays behind QR signing modals via z-index/outside-click tweaks. Locale strings for the removed hardware-wallet onboarding error are deleted and new sign-in strings are added.

^{Written by Cursor Bugbot for commit 02a3cdc. This will update automatically on new commits. Configure here.}

github-actions · 2026-02-18T13:24:30Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

app/scripts/controllers/rewards/rewards-controller.ts

ui/components/app/rewards/RewardsPointsBalance.tsx

app/scripts/controllers/rewards/rewards-controller.test.ts

ui/components/app/rewards/RewardsPointsBalance.tsx

app/scripts/controllers/rewards/rewards-controller.ts

VGR-GIT · 2026-02-23T12:16:09Z

Code review

Found 1 issue:

getHasAccountOptedIn silently changed to a compound condition — hardware wallets that have opted in but not yet completed SIWE authentication (subscriptionId === null) now return false, even though they are opted in. The method name and JSDoc still document only the hasOptedIn check, making this a silent behavioral break for any caller relying on the original semantics to distinguish consent from authentication state.

metamask-extension/app/scripts/controllers/rewards/rewards-controller.ts

Lines 1062 to 1071 in 2feb193

    
           async getHasAccountOptedIn(account: CaipAccountId): Promise<boolean> { 
        
             const rewardsEnabled = this.isRewardsFeatureEnabled(); 
        
             if (!rewardsEnabled) { 
        
               return false; 
        
             } 
        
             return ( 
        
               (this.#getAccountState(account)?.hasOptedIn && 
        
                 this.#getAccountState(account)?.subscriptionId !== null) ?? 
        
               false 
        
             );

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

metamaskbotv2 · 2026-02-23T12:28:26Z

Builds ready [2feb193]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (1355 ± 98 ms)

👆 Interaction Benchmarks
Action Metric Mean (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 299 5 304 304
total 299 5 304 304
Confirm Tx confirm_tx 6030 11 6036 6049
total 6030 11 6036 6049
Bridge User Actions bridge_load_page 186 2 189 189
bridge_load_asset_picker 198 1 199 199
bridge_search_token 699 1 699 700
total 1074 7 1079 1082

🔌 Startup Benchmarks
Build Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P 75 (ms) P 95 (ms)
Chrome Browserify Startup Standard Home uiStartup 1355 1148 1651 98 1410 1550
load 1144 954 1385 89 1196 1311
domContentLoaded 1135 950 1344 87 1192 1290
domInteractive 26 15 102 20 23 83
firstPaint 192 58 1346 198 212 314
backgroundConnect 204 182 244 14 212 236
firstReactRender 17 11 38 5 19 25
initialActions 1 0 3 1 1 2
loadScripts 949 762 1158 86 1001 1102
setupStore 12 7 24 4 13 18
numNetworkReqs 31 21 93 20 22 89
Chrome Browserify Startup Power User Home uiStartup 1980 1304 6159 739 2000 3721
load 1154 992 1843 159 1191 1515
domContentLoaded 1133 988 1719 145 1175 1440
domInteractive 35 17 164 26 32 100
firstPaint 243 72 1535 183 266 364
backgroundConnect 420 261 2595 407 335 1062
firstReactRender 24 14 58 8 25 41
initialActions 1 0 4 1 1 1
loadScripts 928 780 1505 139 956 1217
setupStore 15 6 56 7 17 25
numNetworkReqs 72 37 158 26 79 133
Chrome Webpack Startup Standard Home uiStartup 853 689 1128 100 891 1076
load 727 614 1045 86 780 870
domContentLoaded 722 610 1038 85 775 863
domInteractive 27 16 111 20 23 83
firstPaint 108 61 324 51 126 203
backgroundConnect 26 19 53 7 30 40
firstReactRender 18 12 43 6 20 33
initialActions 1 0 4 1 1 2
loadScripts 719 608 1036 84 773 854
setupStore 11 6 45 6 11 23
numNetworkReqs 31 22 98 21 25 89
Chrome Webpack Startup Power User Home uiStartup 1198 988 2030 191 1269 1583
load 689 599 1065 101 675 942
domContentLoaded 679 595 1059 101 666 935
domInteractive 35 17 153 26 36 104
firstPaint 145 61 704 93 188 297
backgroundConnect 179 141 705 75 168 282
firstReactRender 22 17 38 4 23 30
initialActions 1 0 3 1 1 1
loadScripts 677 593 1048 99 664 926
setupStore 10 4 33 4 11 15
numNetworkReqs 123 38 274 50 149 200
Firefox Browserify Startup Standard Home uiStartup 1646 1419 2536 218 1639 2108
load 1393 1174 2254 183 1402 1656
domContentLoaded 1392 1173 2254 183 1400 1655
domInteractive 94 32 898 91 123 145
firstPaint - - - - - -
backgroundConnect 55 29 181 24 57 100
firstReactRender 13 11 21 1 14 15
initialActions 1 0 2 1 1 2
loadScripts 1369 1144 2238 182 1381 1623
setupStore 22 7 180 35 15 127
numNetworkReqs 31 20 101 20 25 88
Firefox Browserify Startup Power User Home uiStartup 2738 2125 4148 354 2885 3359
load 1556 1235 2627 229 1637 2067
domContentLoaded 1555 1229 2627 229 1636 2067
domInteractive 160 36 668 131 184 445
firstPaint - - - - - -
backgroundConnect 321 109 1151 246 362 847
firstReactRender 18 14 62 7 18 27
initialActions 1 0 4 1 2 2
loadScripts 1511 1203 2601 222 1577 1994
setupStore 132 8 815 187 113 608
numNetworkReqs 77 28 206 38 85 146
Firefox Webpack Startup Standard Home uiStartup 1737 1431 3224 298 1751 2135
load 1453 1211 2945 233 1481 1729
domContentLoaded 1453 1211 2945 233 1481 1729
domInteractive 88 29 256 49 126 166
firstPaint - - - - - -
backgroundConnect 59 25 217 30 67 118
firstReactRender 16 12 30 3 16 24
initialActions 1 0 3 1 1 2
loadScripts 1430 1195 2915 231 1455 1707
setupStore 36 6 1402 141 15 122
numNetworkReqs 31 20 91 18 27 83
Firefox Webpack Startup Power User Home uiStartup 2684 2037 3784 361 2825 3448
load 1535 1295 2371 233 1643 1960
domContentLoaded 1534 1295 2371 233 1642 1960
domInteractive 139 35 735 143 123 496
firstPaint - - - - - -
backgroundConnect 355 121 1348 256 506 859
firstReactRender 23 15 99 12 23 34
initialActions 1 0 3 1 2 2
loadScripts 1486 1273 2006 192 1600 1888
setupStore 168 6 738 189 194 604
numNetworkReqs 72 29 213 39 84 145

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 217 1 217 218
srpButtonToSrpForm 90 1 90 90
confirmSrpToPwForm 21 0 21 21
pwFormToMetricsScreen 15 0 15 15
metricsToWalletReadyScreen 15 0 15 16
doneButtonToHomeScreen 707 141 765 912
openAccountMenuToAccountListLoaded 7060 90 7016 7215
total 8400 493 8906 9081
Onboarding New Wallet createWalletToSocialScreen 217 0 217 217
srpButtonToPwForm 114 11 125 129
createPwToRecoveryScreen 8 1 9 9
skipBackupToMetricsScreen 34 0 34 34
agreeButtonToOnboardingSuccess 16 0 16 16
doneButtonToAssetList 526 73 489 652
total 918 77 883 1051
Asset Details assetClickToPriceChart 49 14 55 72
total 49 14 55 72
Solana Asset Details assetClickToPriceChart 46 1 47 48
total 46 1 47 48
Import Srp Home loginToHomeScreen 1846 25 1862 1878
openAccountMenuAfterLogin 40 2 41 43
homeAfterImportWithNewWallet 2447 247 2567 2869
total 4227 159 4213 4483
Send Transactions openSendPageFromHome 26 9 36 37
selectTokenToSendFormLoaded 29 8 37 40
reviewTransactionToConfirmationPage 850 7 846 863
total 907 9 903 922
Swap openSwapPageFromHome 118 19 123 150
fetchAndDisplaySwapQuotes 5361 766 6224 6371
total 5479 769 6374 6468

🌐 Dapp Page Load Benchmarks

Current Commit: 2feb193 | Date: 2/23/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±39ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 722ms (±37ms) 🟢 | historical mean value: 725ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	39ms	1.01s	1.31s	1.06s	1.31s
domContentLoaded	722ms	37ms	703ms	979ms	735ms	979ms
firstPaint	77ms	12ms	60ms	188ms	84ms	188ms
firstContentfulPaint	77ms	12ms	60ms	188ms	84ms	188ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 4.45 KiB (0.1%)
ui: 3.82 KiB (0.05%)
common: 162 Bytes (0%)

…ontroller - Remove unused `useMemo` import from useOptIn - Fix import order: move `isHardwareAccount` before local imports - Delete extra blank lines (prettier) - Wrap long lines to satisfy prettier print width - Fix `no-param-reassign` in rewards-controller by using local variable Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

app/scripts/controllers/rewards/rewards-controller.ts

Add app/scripts/controllers/rewards/rewards-data-service.test.ts to the unit test console baseline to allow its expected console.error output (RewardsDataService: Failed to fetch geolocation) during CI runs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

app/scripts/controllers/rewards/utils/isHardwareAccount.ts

metamaskbotv2 · 2026-02-23T14:07:40Z

Builds ready [1bea1ec]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (1391 ± 106 ms)

👆 Interaction Benchmarks
Action Metric Mean (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 289 32 296 338
total 289 32 296 338
Confirm Tx confirm_tx 6064 49 6081 6149
total 6064 49 6081 6149
Bridge User Actions bridge_load_page 237 46 256 311
bridge_load_asset_picker 215 43 243 281
bridge_search_token 721 14 731 736
total 1173 55 1209 1256

🔌 Startup Benchmarks
Build Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P 75 (ms) P 95 (ms)
Chrome Browserify Startup Standard Home uiStartup 1391 1151 1653 106 1444 1584
load 1173 963 1420 95 1238 1329
domContentLoaded 1166 958 1412 93 1231 1322
domInteractive 29 16 136 24 23 92
firstPaint 186 68 1427 205 210 330
backgroundConnect 203 184 251 12 205 228
firstReactRender 18 11 46 5 20 24
initialActions 1 0 5 1 1 3
loadScripts 979 769 1217 93 1041 1133
setupStore 14 6 123 12 16 22
numNetworkReqs 31 22 91 20 22 86
Chrome Browserify Startup Power User Home uiStartup 3141 1430 10753 2017 4038 7296
load 1253 1076 1973 143 1286 1511
domContentLoaded 1236 1063 1966 140 1270 1488
domInteractive 36 19 185 26 34 72
firstPaint 227 79 1678 198 270 343
backgroundConnect 1313 257 8895 1761 2114 3859
firstReactRender 24 16 49 6 26 36
initialActions 1 0 3 1 1 2
loadScripts 1026 863 1687 134 1050 1277
setupStore 15 6 47 8 16 28
numNetworkReqs 84 40 139 21 101 114
Chrome Webpack Startup Standard Home uiStartup 866 689 1202 90 930 1000
load 738 614 926 87 807 882
domContentLoaded 732 609 919 87 802 876
domInteractive 29 16 123 23 23 89
firstPaint 116 60 312 60 129 239
backgroundConnect 28 19 65 9 32 48
firstReactRender 18 12 40 6 21 31
initialActions 1 0 5 1 1 2
loadScripts 729 606 917 86 799 874
setupStore 11 6 27 3 12 17
numNetworkReqs 31 22 97 21 25 88
Chrome Webpack Startup Power User Home uiStartup 1276 930 3010 291 1313 1839
load 745 634 1398 114 748 983
domContentLoaded 734 628 1383 114 738 977
domInteractive 40 18 227 38 36 134
firstPaint 150 64 422 83 178 373
backgroundConnect 181 134 702 89 173 286
firstReactRender 22 15 32 3 24 27
initialActions 1 0 2 1 1 1
loadScripts 731 626 1369 112 736 968
setupStore 13 4 42 6 15 21
numNetworkReqs 102 47 201 34 118 169
Firefox Browserify Startup Standard Home uiStartup 1592 1354 2462 206 1618 2041
load 1345 1157 2230 175 1377 1711
domContentLoaded 1344 1153 2230 175 1373 1710
domInteractive 65 30 214 37 87 137
firstPaint - - - - - -
backgroundConnect 58 26 320 36 57 118
firstReactRender 13 11 31 2 13 15
initialActions 1 0 6 1 1 2
loadScripts 1317 1135 2206 167 1354 1581
setupStore 18 6 168 28 14 33
numNetworkReqs 31 19 96 21 26 92
Firefox Browserify Startup Power User Home uiStartup 3074 2089 8456 1316 2993 7649
load 1844 1320 7088 1215 1628 5718
domContentLoaded 1843 1320 7088 1215 1628 5718
domInteractive 156 46 1752 193 145 364
firstPaint - - - - - -
backgroundConnect 409 105 1327 300 524 1031
firstReactRender 19 14 70 8 20 28
initialActions 2 1 3 1 2 2
loadScripts 1801 1296 7053 1210 1583 5677
setupStore 146 14 745 180 139 610
numNetworkReqs 85 30 185 36 99 173
Firefox Webpack Startup Standard Home uiStartup 1789 1416 3425 339 1773 2182
load 1510 1271 3011 308 1499 1686
domContentLoaded 1510 1266 3011 308 1499 1680
domInteractive 115 30 1441 141 133 179
firstPaint - - - - - -
backgroundConnect 67 26 258 36 72 128
firstReactRender 18 12 84 9 17 26
initialActions 1 0 3 1 2 2
loadScripts 1483 1249 2976 306 1472 1651
setupStore 27 8 161 32 32 82
numNetworkReqs 30 20 85 16 27 75
Firefox Webpack Startup Power User Home uiStartup 2807 2009 7890 637 2872 3648
load 1590 1201 6221 527 1591 2176
domContentLoaded 1590 1200 6221 528 1591 2175
domInteractive 162 47 791 155 170 582
firstPaint - - - - - -
backgroundConnect 477 115 1583 342 761 1044
firstReactRender 22 15 62 8 23 32
initialActions 2 1 7 1 2 2
loadScripts 1548 1185 6185 524 1520 2006
setupStore 140 9 656 169 127 580
numNetworkReqs 80 29 247 40 88 164

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 0 219 219
srpButtonToSrpForm 98 5 102 104
confirmSrpToPwForm 22 1 23 23
pwFormToMetricsScreen 15 1 16 16
metricsToWalletReadyScreen 16 1 16 17
doneButtonToHomeScreen 729 92 736 852
openAccountMenuToAccountListLoaded 7329 668 7873 8056
total 8552 447 8969 9025
Onboarding New Wallet createWalletToSocialScreen 219 1 219 220
srpButtonToPwForm 105 2 105 108
createPwToRecoveryScreen 9 0 9 9
skipBackupToMetricsScreen 37 1 38 39
agreeButtonToOnboardingSuccess 17 0 17 17
doneButtonToAssetList 608 85 627 727
total 993 85 1016 1109
Asset Details assetClickToPriceChart 53 16 62 78
total 53 16 62 78
Solana Asset Details assetClickToPriceChart 48 3 50 52
total 48 3 50 52
Import Srp Home loginToHomeScreen 2018 3 2022 2022
openAccountMenuAfterLogin 44 6 47 54
homeAfterImportWithNewWallet 2412 82 2424 2518
total 4478 11 4489 4489
Send Transactions openSendPageFromHome 27 11 38 43
selectTokenToSendFormLoaded 19 1 19 21
reviewTransactionToConfirmationPage 853 4 855 860
total 903 8 910 914
Swap openSwapPageFromHome 120 7 117 132
fetchAndDisplaySwapQuotes 5305 831 6253 6386
total 5433 840 6369 6545

🌐 Dapp Page Load Benchmarks

Current Commit: 1bea1ec | Date: 2/23/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±42ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 734ms (±39ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 80ms (±11ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	42ms	1.03s	1.34s	1.08s	1.34s
domContentLoaded	734ms	39ms	713ms	1.00s	761ms	1.00s
firstPaint	80ms	11ms	64ms	172ms	88ms	172ms
firstContentfulPaint	80ms	11ms	64ms	172ms	88ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 4.45 KiB (0.1%)
ui: -8.08 KiB (-0.1%)
common: 123 Bytes (0%)

Delete extra blank line before closing describe block to satisfy prettier/prettier formatting rule (Delete ⏎ at line 672:1). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

sonarqubecloud · 2026-02-25T07:43:58Z

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-02-25T07:58:53Z

Builds ready [02a3cdc]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (1394 ± 108 ms)

👆 Interaction Benchmarks
Action Metric Mean (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 275 7 276 284
total 275 7 276 284
Confirm Tx confirm_tx 6064 31 6089 6106
total 6064 31 6089 6106
Bridge User Actions bridge_load_page 195 8 201 204
bridge_load_asset_picker 199 5 204 204
bridge_search_token 698 3 700 703
total 1093 10 1100 1104

🔌 Startup Benchmarks
Build Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P 75 (ms) P 95 (ms)
Chrome Browserify Startup Standard Home uiStartup 1394 1161 1687 108 1427 1589
load 1174 979 1429 97 1206 1355
domContentLoaded 1166 970 1423 96 1198 1347
domInteractive 27 17 93 17 23 78
firstPaint 149 66 396 75 198 296
backgroundConnect 204 189 265 14 207 238
firstReactRender 18 12 36 5 19 29
initialActions 1 0 6 1 1 4
loadScripts 979 785 1223 96 1013 1146
setupStore 15 6 215 21 15 22
numNetworkReqs 31 22 97 20 22 85
Chrome Browserify Startup Power User Home uiStartup 1697 1396 2251 153 1746 2007
load 1122 1010 1598 128 1108 1513
domContentLoaded 1108 1003 1559 123 1100 1491
domInteractive 35 17 147 25 33 97
firstPaint 177 70 1454 151 222 311
backgroundConnect 284 258 354 21 297 325
firstReactRender 24 15 68 8 27 41
initialActions 1 0 6 1 1 3
loadScripts 903 810 1354 121 889 1277
setupStore 16 8 40 6 19 28
numNetworkReqs 60 39 146 24 62 128
Chrome Webpack Startup Standard Home uiStartup 873 719 1156 100 946 1054
load 740 626 1001 98 791 936
domContentLoaded 734 621 994 97 786 924
domInteractive 30 16 117 24 24 98
firstPaint 110 63 391 60 121 208
backgroundConnect 30 20 86 10 34 44
firstReactRender 20 13 39 7 23 34
initialActions 1 0 4 1 1 2
loadScripts 731 619 992 96 784 920
setupStore 12 6 47 6 14 19
numNetworkReqs 31 22 97 20 25 88
Chrome Webpack Startup Power User Home uiStartup 1200 857 1687 174 1287 1561
load 706 612 1147 109 701 982
domContentLoaded 697 607 1134 108 688 970
domInteractive 34 17 143 27 31 114
firstPaint 146 63 1144 124 176 266
backgroundConnect 166 130 353 44 164 267
firstReactRender 22 18 32 3 24 28
initialActions 1 0 2 1 1 1
loadScripts 694 605 1125 106 686 961
setupStore 12 4 47 7 13 28
numNetworkReqs 109 39 250 49 139 220
Firefox Browserify Startup Standard Home uiStartup 1644 1377 3124 244 1644 2026
load 1390 1156 2877 222 1397 1718
domContentLoaded 1388 1150 2877 223 1395 1718
domInteractive 90 35 922 94 101 153
firstPaint - - - - - -
backgroundConnect 58 27 256 28 63 114
firstReactRender 13 11 21 1 14 16
initialActions 1 0 3 1 1 2
loadScripts 1363 1133 2844 218 1371 1669
setupStore 18 7 135 21 16 46
numNetworkReqs 31 20 97 20 25 88
Firefox Browserify Startup Power User Home uiStartup 2728 2036 3766 389 2834 3529
load 1562 1239 2413 276 1645 2137
domContentLoaded 1561 1239 2412 276 1644 2137
domInteractive 120 35 627 112 111 424
firstPaint - - - - - -
backgroundConnect 305 106 1179 275 254 924
firstReactRender 18 13 62 7 18 23
initialActions 1 0 3 1 2 2
loadScripts 1528 1214 2353 267 1620 2094
setupStore 152 8 778 204 173 592
numNetworkReqs 61 33 139 30 84 119
Firefox Webpack Startup Standard Home uiStartup 1696 1356 3143 249 1720 1977
load 1423 1132 2840 221 1450 1612
domContentLoaded 1423 1131 2839 221 1449 1612
domInteractive 103 29 299 55 132 199
firstPaint - - - - - -
backgroundConnect 63 25 310 45 67 183
firstReactRender 15 12 25 3 15 21
initialActions 1 0 2 1 1 2
loadScripts 1399 1119 2819 219 1417 1586
setupStore 23 7 181 32 15 84
numNetworkReqs 31 20 94 19 27 83
Firefox Webpack Startup Power User Home uiStartup 2703 1920 3786 476 2811 3627
load 1560 1194 2459 319 1733 2226
domContentLoaded 1559 1194 2459 319 1733 2225
domInteractive 132 31 762 161 104 540
firstPaint - - - - - -
backgroundConnect 291 102 1033 249 238 896
firstReactRender 20 15 31 4 22 28
initialActions 2 0 3 1 2 2
loadScripts 1522 1178 2434 304 1685 2179
setupStore 163 8 1212 239 148 684
numNetworkReqs 60 31 146 35 85 140

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 1 220 220
srpButtonToSrpForm 94 6 97 104
confirmSrpToPwForm 21 1 21 22
pwFormToMetricsScreen 15 0 15 15
metricsToWalletReadyScreen 15 0 15 15
doneButtonToHomeScreen 749 166 800 1039
openAccountMenuToAccountListLoaded 7340 473 7831 7866
total 8453 437 8823 8828
Onboarding New Wallet createWalletToSocialScreen 217 1 217 218
srpButtonToPwForm 104 2 105 105
createPwToRecoveryScreen 8 0 8 9
skipBackupToMetricsScreen 34 1 35 35
agreeButtonToOnboardingSuccess 16 1 16 17
doneButtonToAssetList 654 127 709 815
total 1036 131 1084 1209
Asset Details assetClickToPriceChart 61 20 83 85
total 61 20 83 85
Solana Asset Details assetClickToPriceChart 54 7 57 66
total 54 7 57 66
Import Srp Home loginToHomeScreen 1948 81 2028 2048
openAccountMenuAfterLogin 40 2 41 43
homeAfterImportWithNewWallet 2288 153 2401 2460
total 4280 209 4467 4473
Send Transactions openSendPageFromHome 27 10 38 39
selectTokenToSendFormLoaded 19 1 19 20
reviewTransactionToConfirmationPage 859 4 861 863
total 917 4 918 922
Swap openSwapPageFromHome 132 3 135 135
fetchAndDisplaySwapQuotes 5648 840 6375 6383
total 5776 834 6496 6504

🌐 Dapp Page Load Benchmarks

Current Commit: 02a3cdc | Date: 2/25/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 971ms (±35ms) 🟢 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 673ms (±33ms) 🟢 | historical mean value: 725ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 74ms (±8ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	971ms	35ms	950ms	1.23s	986ms	1.23s
domContentLoaded	673ms	33ms	656ms	922ms	681ms	922ms
firstPaint	74ms	8ms	60ms	140ms	84ms	140ms
firstContentfulPaint	74ms	8ms	60ms	140ms	84ms	140ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -258.31 KiB (-5.95%)
ui: 1.18 KiB (0.01%)
common: 189.65 KiB (1.7%)

VGR-GIT requested a review from a team as a code owner February 18, 2026 13:24

VGR-GIT temporarily deployed to pr-comment February 18, 2026 13:24 — with GitHub Actions Inactive

metamaskbot added team-rewards Rewards team INVALID-PR-TEMPLATE PR's body doesn't match template labels Feb 18, 2026

github-actions bot added the size-XL label Feb 18, 2026

cursor bot reviewed Feb 18, 2026

View reviewed changes

app/scripts/controllers/rewards/rewards-controller.ts Show resolved Hide resolved

ui/components/app/rewards/RewardsPointsBalance.tsx Show resolved Hide resolved

VGR-GIT temporarily deployed to pr-comment February 18, 2026 13:43 — with GitHub Actions Inactive

cursor bot reviewed Feb 18, 2026

View reviewed changes

app/scripts/controllers/rewards/rewards-controller.test.ts Show resolved Hide resolved

VGR-GIT temporarily deployed to pr-comment February 18, 2026 14:07 — with GitHub Actions Inactive

cursor bot reviewed Feb 18, 2026

View reviewed changes

ui/components/app/rewards/RewardsPointsBalance.tsx Show resolved Hide resolved

app/scripts/controllers/rewards/rewards-controller.ts Show resolved Hide resolved

VGR-GIT temporarily deployed to pr-comment February 18, 2026 14:24 — with GitHub Actions Inactive

VGR-GIT temporarily deployed to pr-comment February 18, 2026 15:08 — with GitHub Actions Inactive

VGR-GIT temporarily deployed to pr-comment February 18, 2026 15:35 — with GitHub Actions Inactive

VGR-GIT added 2 commits February 23, 2026 10:02

feat(rewards): hardware wallet support

aa4e758

f

c69df6f

VGR-GIT force-pushed the rwds-feat-hardware-wallet-support branch from a440d3a to c69df6f Compare February 23, 2026 09:02

VGR-GIT temporarily deployed to pr-comment February 23, 2026 09:02 — with GitHub Actions Inactive

f

2feb193

VGR-GIT temporarily deployed to pr-comment February 23, 2026 11:58 — with GitHub Actions Inactive

VGR-GIT temporarily deployed to pr-comment February 23, 2026 12:24 — with GitHub Actions Inactive

VGR-GIT temporarily deployed to pr-comment February 23, 2026 13:15 — with GitHub Actions Inactive

cursor bot reviewed Feb 23, 2026

View reviewed changes

app/scripts/controllers/rewards/rewards-controller.ts Show resolved Hide resolved

VGR-GIT temporarily deployed to pr-comment February 23, 2026 13:33 — with GitHub Actions Inactive

cursor bot reviewed Feb 23, 2026

View reviewed changes

app/scripts/controllers/rewards/utils/isHardwareAccount.ts Show resolved Hide resolved

VGR-GIT temporarily deployed to pr-comment February 23, 2026 14:03 — with GitHub Actions Inactive

fix(rewards): remove trailing blank line in useOptIn.test.tsx

02a3cdc

Delete extra blank line before closing describe block to satisfy prettier/prettier formatting rule (Delete ⏎ at line 672:1). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

VGR-GIT temporarily deployed to pr-comment February 25, 2026 07:29 — with GitHub Actions Inactive

VGR-GIT temporarily deployed to pr-comment February 25, 2026 07:54 — with GitHub Actions Inactive

SteP-n-s approved these changes Feb 25, 2026

View reviewed changes

VGR-GIT enabled auto-merge February 25, 2026 12:13

EugeniyBykov approved these changes Feb 25, 2026

View reviewed changes

VGR-GIT added this pull request to the merge queue Feb 25, 2026

Merged via the queue into main with commit 4a97299 Feb 25, 2026
178 of 179 checks passed

VGR-GIT deleted the rwds-feat-hardware-wallet-support branch February 25, 2026 12:50

github-actions bot locked and limited conversation to collaborators Feb 25, 2026

metamaskbot added the release-13.21.0 Issue or pull request that will be included in release 13.21.0 label Feb 25, 2026

Conversation

VGR-GIT commented Feb 18, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Screenshots

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

VGR-GIT commented Feb 23, 2026

Code review

Uh oh!

metamaskbotv2 bot commented Feb 23, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

metamaskbotv2 bot commented Feb 23, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud bot commented Feb 25, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 bot commented Feb 25, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

VGR-GIT commented Feb 18, 2026 •

edited by cursor bot

Loading