fix(perps): update perps/tutorial skip button#40174
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/perps (12 files, +644 -592)
|
f9a5ef7 to
e4a8d50
Compare
ui/components/app/perps/perps-tutorial-modal/PerpsTutorialModal.tsx
Outdated
Show resolved
Hide resolved
ui/components/app/perps/perps-tutorial-modal/PerpsTutorialModal.test.tsx
Outdated
Show resolved
Hide resolved
Contributor
Builds ready [d79177b]
UI Startup Metrics (1396 ± 104 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Contributor
Builds ready [6879a5b]
UI Startup Metrics (1406 ± 87 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
6879a5b to
e984f67
Compare
Contributor
Builds ready [e984f67]
UI Startup Metrics (1445 ± 98 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
e984f67 to
b0629f1
Compare
Contributor
Builds ready [b0629f1]
⚡ Performance Benchmarks (1361 ± 106 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
358f995 to
0a7499f
Compare
|
Contributor
Builds ready [0a7499f]
⚡ Performance Benchmarks (1496 ± 128 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
gambinish
approved these changes
Feb 24, 2026
0a7499f to
b09b22f
Compare
Contributor
Builds ready [b09b22f]
⚡ Performance Benchmarks (1431 ± 116 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
gambinish
approved these changes
Feb 25, 2026
aganglada
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Refactors the Perps tutorial modal to align with the mobile implementation pattern and improves the Skip button styling.
Reason for change:
Solution:
Changelog
CHANGELOG entry: Refactors the Perps tutorial modal to align with the mobile implementation pattern
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
PerpsTutorialSkip.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
UI refactor consolidating tutorial navigation into the modal and adjusting button styling; main risk is minor UX/regression in step progression/closing, mitigated by added tests.
Overview
Refactors the Perps tutorial modal so navigation is controlled centrally:
ProgressIndicatorand a new sharedTutorialFooternow live inPerpsTutorialModal, with step components reduced to content-only.Updates the Skip action to be a proper
Button(Tertiary) withtext-defaultstyling, hides Skip on the last step, and changes the primary CTA to "Let’s Go" on the final step while continuing to advance steps usingTUTORIAL_STEPS_ORDER.Adds new unit tests for
PerpsTutorialModalandTutorialFooter, and trims step tests to remove per-step button/dispatch assertions now handled by the modal.Written by Cursor Bugbot for commit b09b22f. This will update automatically on new commits. Configure here.