fix(rewards): reward flag not used to render discover menu item#40023
Merged
fix(rewards): reward flag not used to render discover menu item#40023
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (2 files, +25 -34)
|
sophieqgu
approved these changes
Feb 12, 2026
Contributor
Builds ready [c4572fb]
UI Startup Metrics (1414 ± 101 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
jbblanc
approved these changes
Feb 12, 2026
NidhiKJha
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The discover menu button was conditionally being rendered based on the rewards feature flag. This should always be rendered now, regardless of whether rewards is flagged on or off.
Changelog
CHANGELOG entry: discover menu button always rendered
Screenshots/Recordings
After
Note
Low Risk
Small UI-logic change that only affects visibility of a menu item and removes a feature-flag check; no auth, data writes, or security-sensitive logic touched.
Overview
The
Discovermenu entry is now always rendered, removing its dependency on the rewards feature flag.This updates both the popover
GlobalMenuand the draweruseGlobalMenuSectionshook by deleting theselectRewardsEnabledselector usage and unconditionalizing theDiscoveritem while keeping the existing portfolio URL + MetaMetrics tracking behavior.Written by Cursor Bugbot for commit c4572fb. This will update automatically on new commits. Configure here.