fix: access token not persisted after token refresh by lwin-kyaw · Pull Request #40013 · MetaMask/metamask-extension

lwin-kyaw · 2026-02-12T12:33:23Z

Description

This PR fixes the accessToken not being persisted across lock/unlock cycles issue in the seedless onboarding flow and upgrades @metamask/seedless-onboarding-controller from v7.1.0 to v8.0.0.

Problem:
Previously, the OAuthService was reading the accessToken directly from SeedlessOnboardingController state via SeedlessOnboardingController:getState. The access token was not persisted in the controller state, causing it to be lost after a lock/unlock cycle. Additionally, when the token expired, there was no mechanism to automatically refresh it before making API calls (e.g., marketing opt-in).

Solution:

Updated to @metamask/seedless-onboarding-controller v8.0.0 which exposes a new SeedlessOnboardingController:getAccessToken action that handles token retrieval and automatic refresh when expired.
Replaced direct state access (SeedlessOnboardingController:getState → accessToken) with the new SeedlessOnboardingController:getAccessToken action in OAuthService.
Improved error handling in BaseLoginHandler by introducing createErrorFromNetworkRequest utility to provide more descriptive error messages (including status codes and response body) for token-related network failures (auth token, refresh, revoke, renew).
Added new OAuthErrorMessages enum entries for granular error categorization.
Removed the unused NO_AUTH_CODE_FOUND_ERROR enum value and updated the welcome page error handling accordingly.
Added E2E tests to verify token refresh behavior and access token validity after lock/unlock cycles.

Changelog

CHANGELOG entry: Fixed access token not persisting across lock/unlock cycles for seedless onboarding users

Related issues

Fixes: #39566
Relates to: #40011

Manual testing steps

Enable seedless onboarding feature flag and start a dev build (yarn start)
Go through the seedless onboarding flow using social login (Google)
After onboarding completes, lock the wallet
Unlock the wallet with your password
Navigate to Settings → Privacy & Security
Verify that the marketing consent settings load correctly (this confirms the access token was refreshed and used successfully)
Verify no errors appear in the console related to "No access token found"

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches seedless onboarding OAuth token retrieval/refresh paths and bumps a core controller dependency, which could affect authentication and downstream API calls if integration mismatches. Changes are mitigated by added unit/E2E coverage around failure cases and lock/unlock refresh flows.

Overview
Fixes seedless onboarding marketing-consent calls failing after lock/unlock by switching OAuthService to fetch tokens via the new SeedlessOnboardingController:getAccessToken action (delegated through the OAuth service messenger/types) instead of reading accessToken from controller state.

Improves OAuth/Auth-server failure visibility by adding createErrorFromNetworkRequest and expanding OAuthErrorMessages, then wiring these into BaseLoginHandler (token/refresh/revoke/renew) and updating unit tests accordingly; also removes the unused NO_AUTH_CODE_FOUND_ERROR handling in the onboarding welcome UI.

Upgrades @metamask/seedless-onboarding-controller to ^8.0.0 and adds/updates E2E mocking + a new E2E spec to validate token refresh behavior and access-token validity across lock/unlock cycles.

^{Written by Cursor Bugbot for commit 5db5ced. This will update automatically on new commits. Configure here.}

…persisted

github-actions · 2026-02-12T12:33:34Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-02-12T12:35:55Z

✨ Files requiring CODEOWNER review ✨

🔐 @MetaMask/web3auth (1 files, +1 -4)

📁 ui/
- 📁 pages/
  - 📁 onboarding-flow/
    - 📁 welcome/
      - 📄 welcome.tsx +1 -4

socket-security · 2026-02-12T12:38:06Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@metamask/seedless-onboarding-controller@7.1.0 ⏵ 8.0.0			⁺¹	^-2

View full report

test/e2e/helpers.js

shared/modules/error.ts

test/e2e/tests/seedless-onboarding/refresh-auth-tokens.spec.ts

metamaskbotv2 · 2026-02-12T13:10:19Z

Builds ready [c66ef43]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
lavamoat build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

UI Startup Metrics (1341 ± 90 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1341	1169	1574	90	1380	1523
			load	1150	986	1329	81	1193	1303
			domContentLoaded	1143	979	1324	82	1188	1298
			domInteractive	25	15	79	16	22	73
			firstPaint	145	66	1114	116	191	241
			backgroundConnect	234	217	279	12	236	260
			firstReactRender	17	10	184	17	17	25
			initialActions	1	0	7	1	1	4
			loadScripts	923	761	1110	82	970	1075
			setupStore	11	6	34	4	13	16
			numNetworkReqs	23	15	99	21	15	84
	Browserify	Power User Home	uiStartup	1868	1371	10785	954	1825	2322
			load	1150	1027	1652	152	1149	1604
			domContentLoaded	1134	1018	1621	146	1138	1560
			domInteractive	37	18	163	29	32	121
			firstPaint	159	72	426	73	203	288
			backgroundConnect	390	280	5072	493	335	486
			firstReactRender	22	15	109	10	23	34
			initialActions	1	0	5	1	1	2
			loadScripts	896	779	1389	139	894	1281
			setupStore	15	6	42	6	17	24
			numNetworkReqs	121	48	260	45	143	203
	Webpack	Standard Home	uiStartup	832	695	1074	89	880	1017
			load	718	616	937	83	761	876
			domContentLoaded	713	612	931	82	757	869
			domInteractive	26	16	93	20	22	84
			firstPaint	100	60	310	48	104	211
			backgroundConnect	28	17	103	12	30	43
			firstReactRender	15	10	50	6	17	24
			initialActions	1	0	4	1	1	2
			loadScripts	710	610	929	81	755	865
			setupStore	12	6	48	6	12	24
			numNetworkReqs	23	15	99	22	15	84
	Webpack	Power User Home	uiStartup	1196	869	2381	215	1272	1607
			load	700	592	1596	147	688	1052
			domContentLoaded	691	587	1588	146	677	1037
			domInteractive	38	18	223	39	30	151
			firstPaint	152	60	1046	121	185	303
			backgroundConnect	171	143	352	45	166	297
			firstReactRender	21	16	30	3	22	27
			initialActions	1	0	3	1	1	1
			loadScripts	688	585	1582	145	675	1029
			setupStore	11	4	51	6	12	17
			numNetworkReqs	125	45	291	54	148	261
Firefox	Browserify	Standard Home	uiStartup	1530	1322	2316	188	1571	1939
			load	1320	1138	1820	140	1381	1613
			domContentLoaded	1319	1138	1819	140	1380	1612
			domInteractive	63	32	268	38	87	130
			firstPaint	-	-	-	-	-	-
			backgroundConnect	54	29	235	30	52	104
			firstReactRender	11	9	18	1	12	14
			initialActions	1	0	2	0	1	2
			loadScripts	1295	1115	1735	135	1354	1586
			setupStore	12	6	57	10	13	38
			numNetworkReqs	24	13	100	22	17	84
	Browserify	Power User Home	uiStartup	2818	2103	4041	378	3038	3567
			load	1608	1285	2587	242	1659	2109
			domContentLoaded	1608	1285	2587	242	1659	2109
			domInteractive	138	38	750	124	125	396
			firstPaint	-	-	-	-	-	-
			backgroundConnect	333	117	1115	250	415	917
			firstReactRender	19	14	75	6	19	23
			initialActions	2	0	6	1	2	2
			loadScripts	1561	1265	2551	227	1601	2022
			setupStore	139	10	760	193	117	627
			numNetworkReqs	76	36	150	31	96	135
	Webpack	Standard Home	uiStartup	1613	1364	2325	145	1674	1836
			load	1383	1192	1765	103	1439	1530
			domContentLoaded	1383	1186	1765	103	1437	1530
			domInteractive	85	27	186	40	123	142
			firstPaint	-	-	-	-	-	-
			backgroundConnect	58	26	230	35	58	125
			firstReactRender	16	11	61	8	15	24
			initialActions	1	0	3	1	2	2
			loadScripts	1355	1177	1677	96	1413	1497
			setupStore	19	6	178	27	14	54
			numNetworkReqs	24	13	92	20	17	79
	Webpack	Power User Home	uiStartup	2716	1822	3997	472	2893	3641
			load	1514	1251	2428	253	1624	1973
			domContentLoaded	1513	1251	2428	253	1623	1973
			domInteractive	141	29	736	157	122	549
			firstPaint	-	-	-	-	-	-
			backgroundConnect	295	76	1020	213	321	838
			firstReactRender	22	15	64	6	24	30
			initialActions	1	0	3	1	2	2
			loadScripts	1477	1229	2404	246	1587	1931
			setupStore	158	8	812	206	151	639
			numNetworkReqs	74	37	168	34	92	136

📊 Page Load Benchmark Results

Current Commit: c66ef43 | Date: 2/12/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±72ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 737ms (±68ms) 🟢 | historical mean value: 728ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±11ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	72ms	1.01s	1.34s	1.30s	1.34s
domContentLoaded	737ms	68ms	699ms	1.00s	958ms	1.00s
firstPaint	78ms	11ms	64ms	172ms	92ms	172ms
firstContentfulPaint	78ms	11ms	64ms	172ms	92ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 300.74 KiB (7.5%)
ui: 928 Bytes (0.01%)
common: 10.28 KiB (0.09%)

lwin-kyaw · 2026-02-12T13:54:44Z

@metamaskbot update-policies

test/e2e/tests/seedless-onboarding/refresh-auth-tokens.spec.ts

metamaskbot · 2026-02-12T14:08:56Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

👀 lavamoat/browserify/beta/policy.json changes differ from main/policy.json policy changes
👀 lavamoat/browserify/experimental/policy.json changes differ from main/policy.json policy changes
👀 lavamoat/browserify/flask/policy.json changes differ from main/policy.json policy changes
👀 lavamoat/webpack/mv2/beta/policy.json changes differ from mv2/main/policy.json policy changes
👀 lavamoat/webpack/mv2/experimental/policy.json changes differ from mv2/main/policy.json policy changes
👀 lavamoat/webpack/mv2/flask/policy.json changes differ from mv2/main/policy.json policy changes
✅ lavamoat/webpack/mv3/beta/policy.json changes match mv3/main/policy.json policy changes
✅ lavamoat/webpack/mv3/experimental/policy.json changes match mv3/main/policy.json policy changes
✅ lavamoat/webpack/mv3/flask/policy.json changes match mv3/main/policy.json policy changes

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

shared/modules/error.ts

test/e2e/helpers/seedless-onboarding/mocks.ts

…into fix/access-token-not-persisted

metamaskbotv2 · 2026-02-12T15:06:40Z

Builds ready [14b32a8]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

UI Startup Metrics (1378 ± 107 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1378	1194	1840	107	1429	1567
			load	1185	995	1532	96	1235	1345
			domContentLoaded	1178	991	1516	94	1230	1338
			domInteractive	28	16	120	21	23	79
			firstPaint	166	68	1206	128	213	291
			backgroundConnect	241	222	305	13	245	265
			firstReactRender	17	11	39	5	19	29
			initialActions	1	0	9	1	1	3
			loadScripts	954	767	1278	94	1003	1114
			setupStore	13	6	32	5	14	25
			numNetworkReqs	23	15	90	20	15	81
	Browserify	Power User Home	uiStartup	1716	1394	2944	198	1791	1977
			load	1149	1034	2336	191	1124	1655
			domContentLoaded	1133	1025	2257	180	1114	1581
			domInteractive	35	18	164	26	34	101
			firstPaint	187	71	1582	167	222	407
			backgroundConnect	318	283	539	29	322	356
			firstReactRender	22	15	51	5	23	34
			initialActions	1	0	3	1	1	1
			loadScripts	893	782	1862	169	871	1332
			setupStore	15	6	42	6	18	26
			numNetworkReqs	118	48	259	45	142	202
	Webpack	Standard Home	uiStartup	850	704	1167	101	932	1016
			load	739	605	1001	99	825	898
			domContentLoaded	733	601	995	98	819	891
			domInteractive	27	16	97	19	24	82
			firstPaint	115	64	642	71	133	206
			backgroundConnect	26	16	61	9	31	41
			firstReactRender	15	10	34	5	18	23
			initialActions	1	0	5	1	1	2
			loadScripts	730	599	986	97	810	889
			setupStore	12	6	41	5	13	20
			numNetworkReqs	23	15	91	20	15	81
	Webpack	Power User Home	uiStartup	1215	837	1929	161	1306	1467
			load	711	627	1110	112	701	1028
			domContentLoaded	702	622	1101	112	688	1020
			domInteractive	36	18	147	28	33	107
			firstPaint	131	63	519	82	138	282
			backgroundConnect	165	130	338	44	162	262
			firstReactRender	22	17	32	3	23	27
			initialActions	1	0	4	1	1	1
			loadScripts	699	620	1091	110	686	1010
			setupStore	11	4	42	5	13	17
			numNetworkReqs	119	44	280	55	147	248
Firefox	Browserify	Standard Home	uiStartup	1627	1399	2237	169	1697	1998
			load	1396	1211	1859	132	1470	1651
			domContentLoaded	1395	1211	1859	132	1469	1651
			domInteractive	87	34	343	48	116	151
			firstPaint	-	-	-	-	-	-
			backgroundConnect	59	29	147	24	65	118
			firstReactRender	13	10	24	2	13	17
			initialActions	1	0	3	1	2	2
			loadScripts	1369	1185	1804	126	1442	1601
			setupStore	17	7	190	24	14	61
			numNetworkReqs	24	12	91	20	17	85
	Browserify	Power User Home	uiStartup	2720	2124	4627	393	2823	3484
			load	1545	1284	2464	251	1571	2150
			domContentLoaded	1545	1283	2458	251	1571	2149
			domInteractive	134	34	742	138	119	412
			firstPaint	-	-	-	-	-	-
			backgroundConnect	283	124	968	236	256	894
			firstReactRender	21	15	76	13	21	62
			initialActions	2	0	3	1	2	2
			loadScripts	1510	1256	2406	244	1534	2093
			setupStore	145	7	780	203	168	685
			numNetworkReqs	66	39	135	33	89	129
	Webpack	Standard Home	uiStartup	1655	1332	2325	135	1701	1879
			load	1428	1228	1731	91	1478	1591
			domContentLoaded	1427	1228	1731	90	1478	1590
			domInteractive	100	30	234	48	132	158
			firstPaint	-	-	-	-	-	-
			backgroundConnect	58	25	166	30	61	123
			firstReactRender	14	11	21	2	15	19
			initialActions	1	0	3	1	2	2
			loadScripts	1398	1208	1697	88	1451	1545
			setupStore	17	6	160	23	13	50
			numNetworkReqs	23	13	91	18	18	77
	Webpack	Power User Home	uiStartup	2853	1945	8802	923	2913	4107
			load	1689	1272	7423	804	1708	2368
			domContentLoaded	1689	1271	7423	804	1708	2368
			domInteractive	156	34	823	180	119	589
			firstPaint	-	-	-	-	-	-
			backgroundConnect	303	79	1334	253	276	920
			firstReactRender	22	15	71	6	24	29
			initialActions	2	0	3	1	2	3
			loadScripts	1645	1255	7380	796	1667	2256
			setupStore	183	8	784	222	276	676
			numNetworkReqs	66	38	144	30	91	122

📊 Page Load Benchmark Results

Current Commit: 14b32a8 | Date: 2/12/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±39ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 727ms (±36ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±12ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	39ms	1.02s	1.33s	1.06s	1.33s
domContentLoaded	727ms	36ms	703ms	991ms	746ms	991ms
firstPaint	79ms	12ms	64ms	192ms	84ms	192ms
firstContentfulPaint	79ms	12ms	64ms	192ms	84ms	192ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 300.74 KiB (7.5%)
ui: 928 Bytes (0.01%)
common: 10.28 KiB (0.09%)

metamaskbotv2 · 2026-02-12T15:46:35Z

Builds ready [5db5ced]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- content-script: 0
- offscreen: 0

UI Startup Metrics (1407 ± 105 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1407	1217	1885	105	1478	1547
			load	1205	1005	1626	95	1267	1334
			domContentLoaded	1198	1001	1595	94	1261	1327
			domInteractive	27	16	127	20	24	76
			firstPaint	213	67	1412	274	207	1121
			backgroundConnect	243	218	343	18	247	276
			firstReactRender	17	10	166	15	18	23
			initialActions	1	0	7	1	1	3
			loadScripts	971	780	1366	94	1030	1103
			setupStore	12	6	26	4	13	18
			numNetworkReqs	23	15	84	20	15	82
	Browserify	Power User Home	uiStartup	1967	1377	6270	848	1829	3904
			load	1144	1002	2230	195	1127	1598
			domContentLoaded	1124	995	2105	180	1118	1508
			domInteractive	40	18	566	59	34	99
			firstPaint	229	68	2129	232	250	335
			backgroundConnect	472	276	3958	595	335	1414
			firstReactRender	22	15	49	5	24	31
			initialActions	1	0	3	0	1	1
			loadScripts	897	768	1823	171	897	1273
			setupStore	15	7	38	6	16	30
			numNetworkReqs	116	44	254	45	140	222
	Webpack	Standard Home	uiStartup	884	711	1320	114	955	1092
			load	765	631	1235	107	844	919
			domContentLoaded	759	626	1227	107	839	912
			domInteractive	29	19	99	18	26	82
			firstPaint	122	65	447	65	149	234
			backgroundConnect	28	20	75	9	32	44
			firstReactRender	15	10	30	4	18	23
			initialActions	1	0	4	1	1	2
			loadScripts	756	624	1225	106	836	908
			setupStore	13	5	34	5	13	26
			numNetworkReqs	23	15	98	20	15	79
	Webpack	Power User Home	uiStartup	1207	917	1870	177	1304	1447
			load	715	629	1149	111	702	1011
			domContentLoaded	705	623	1135	111	692	1002
			domInteractive	35	18	207	28	34	97
			firstPaint	141	63	537	98	148	385
			backgroundConnect	157	132	351	38	156	230
			firstReactRender	22	17	32	3	24	27
			initialActions	1	0	3	1	1	1
			loadScripts	702	621	1128	109	690	993
			setupStore	12	4	44	5	13	17
			numNetworkReqs	116	45	273	49	145	182
Firefox	Browserify	Standard Home	uiStartup	1594	1368	2342	178	1621	1928
			load	1379	1197	2119	146	1419	1648
			domContentLoaded	1379	1197	2113	145	1418	1648
			domInteractive	74	32	267	46	97	152
			firstPaint	-	-	-	-	-	-
			backgroundConnect	57	34	194	27	55	105
			firstReactRender	12	10	22	2	13	14
			initialActions	1	0	3	1	1	2
			loadScripts	1352	1174	2090	140	1396	1620
			setupStore	15	6	118	16	13	31
			numNetworkReqs	24	14	98	21	17	86
	Browserify	Power User Home	uiStartup	2763	2177	4042	403	2909	3603
			load	1552	1316	2397	225	1607	2044
			domContentLoaded	1552	1316	2397	225	1606	2044
			domInteractive	140	35	654	125	136	427
			firstPaint	-	-	-	-	-	-
			backgroundConnect	301	105	1296	250	304	936
			firstReactRender	21	15	94	13	20	28
			initialActions	2	0	3	1	2	2
			loadScripts	1508	1296	2335	208	1534	1998
			setupStore	168	8	785	209	216	625
			numNetworkReqs	73	37	193	34	91	138
	Webpack	Standard Home	uiStartup	1681	1418	3192	202	1705	1970
			load	1451	1225	3007	187	1485	1666
			domContentLoaded	1450	1220	3002	186	1485	1666
			domInteractive	119	29	1614	158	133	207
			firstPaint	-	-	-	-	-	-
			backgroundConnect	60	29	263	37	61	138
			firstReactRender	15	11	25	2	15	19
			initialActions	1	0	3	1	2	2
			loadScripts	1423	1208	2985	185	1456	1594
			setupStore	18	6	178	32	13	54
			numNetworkReqs	23	13	95	19	17	75
	Webpack	Power User Home	uiStartup	2733	1978	4228	441	2800	3680
			load	1528	1277	2658	275	1668	2090
			domContentLoaded	1527	1273	2658	275	1668	2090
			domInteractive	145	31	1304	179	115	537
			firstPaint	-	-	-	-	-	-
			backgroundConnect	349	118	1465	298	400	1039
			firstReactRender	24	16	70	9	25	32
			initialActions	2	1	6	1	2	3
			loadScripts	1489	1243	2634	258	1629	2004
			setupStore	200	9	783	243	340	730
			numNetworkReqs	70	36	156	32	100	125

📊 Page Load Benchmark Results

Current Commit: 5db5ced | Date: 2/12/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±37ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 722ms (±35ms) 🟢 | historical mean value: 720ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±11ms) 🟢 | historical mean value: 76ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	37ms	1.01s	1.31s	1.07s	1.31s
domContentLoaded	722ms	35ms	699ms	986ms	751ms	986ms
firstPaint	75ms	11ms	56ms	164ms	84ms	164ms
firstContentfulPaint	75ms	11ms	56ms	164ms	84ms	164ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 301.45 KiB (7.52%)
ui: -183.42 KiB (-2.21%)
common: 195.67 KiB (1.8%)

chaitanyapotti

lgtm

lwin-kyaw added 4 commits February 2, 2026 18:39

fix: refresh access token if expired

683b138

test: added new e2e tests for the token refersh

7685cde

Merge remote-tracking branch 'origin/main' into fix/access-token-not-…

fc88f9e

…persisted

chore: update error handling in OAuthService

c66ef43

lwin-kyaw requested review from a team as code owners February 12, 2026 12:33

lwin-kyaw temporarily deployed to pr-comment February 12, 2026 12:33 — with GitHub Actions Inactive

metamaskbot added the team-onboarding Onboarding team label Feb 12, 2026

github-actions bot added the size-L label Feb 12, 2026

lwin-kyaw changed the title ~~Fix/access token not persisted~~ fix: access token not persisted after token refresh Feb 12, 2026

cursor bot reviewed Feb 12, 2026

View reviewed changes

test/e2e/helpers.js Outdated Show resolved Hide resolved

shared/modules/error.ts Outdated Show resolved Hide resolved

test/e2e/tests/seedless-onboarding/refresh-auth-tokens.spec.ts Outdated Show resolved Hide resolved

lwin-kyaw temporarily deployed to pr-comment February 12, 2026 13:05 — with GitHub Actions Inactive

chore: removed debug logs

9616820

lwin-kyaw temporarily deployed to pr-comment February 12, 2026 13:51 — with GitHub Actions Inactive

cursor bot reviewed Feb 12, 2026

View reviewed changes

test/e2e/tests/seedless-onboarding/refresh-auth-tokens.spec.ts Show resolved Hide resolved

Update LavaMoat policies

9a77469

metamaskbot temporarily deployed to pr-comment February 12, 2026 14:09 — with GitHub Actions Inactive

cursor bot reviewed Feb 12, 2026

View reviewed changes

shared/modules/error.ts Show resolved Hide resolved

test/e2e/helpers/seedless-onboarding/mocks.ts Show resolved Hide resolved

lwin-kyaw added 2 commits February 12, 2026 22:26

fix: fixed tests

6f49cfd

Merge remote-tracking branch 'origin/fix/access-token-not-persisted' …

14b32a8

…into fix/access-token-not-persisted

lwin-kyaw removed request for a team February 12, 2026 14:27

lwin-kyaw temporarily deployed to pr-comment February 12, 2026 14:27 — with GitHub Actions Inactive

lwin-kyaw temporarily deployed to pr-comment February 12, 2026 15:02 — with GitHub Actions Inactive

fix: updated refresh token e2e

5db5ced

lwin-kyaw temporarily deployed to pr-comment February 12, 2026 15:11 — with GitHub Actions Inactive

lwin-kyaw temporarily deployed to pr-comment February 12, 2026 15:41 — with GitHub Actions Inactive

chaitanyapotti approved these changes Feb 13, 2026

View reviewed changes

chaitanyapotti enabled auto-merge February 13, 2026 06:35

tuna1207 approved these changes Feb 13, 2026

View reviewed changes

chaitanyapotti added this pull request to the merge queue Feb 13, 2026

Merged via the queue into main with commit 65f8e66 Feb 13, 2026
176 checks passed

chaitanyapotti deleted the fix/access-token-not-persisted branch February 13, 2026 09:08

github-actions bot locked and limited conversation to collaborators Feb 13, 2026

metamaskbot added the release-13.20.0 Issue or pull request that will be included in release 13.20.0 label Feb 13, 2026

Conversation

lwin-kyaw commented Feb 12, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Feb 12, 2026

Uh oh!

metamaskbotv2 bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

socket-security bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metamaskbotv2 bot commented Feb 12, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

lwin-kyaw commented Feb 12, 2026

Uh oh!

Uh oh!

metamaskbot commented Feb 12, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

metamaskbotv2 bot commented Feb 12, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Feb 12, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

chaitanyapotti left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lwin-kyaw commented Feb 12, 2026 •

edited by cursor bot

Loading

metamaskbotv2 bot commented Feb 12, 2026 •

edited

Loading

socket-security bot commented Feb 12, 2026 •

edited

Loading