Skip to content

fix: Use ZENDESK_URLS constant for speed up/cancel link#40001

Merged
georgewrmarshall merged 1 commit intomainfrom
speed-up-transaction-link-fix
Feb 12, 2026
Merged

fix: Use ZENDESK_URLS constant for speed up/cancel link#40001
georgewrmarshall merged 1 commit intomainfrom
speed-up-transaction-link-fix

Conversation

@georgewrmarshall
Copy link
Copy Markdown
Contributor

@georgewrmarshall georgewrmarshall commented Feb 11, 2026

Description

Replace hardcoded support URL with ZENDESK_URLS.SPEEDUP_CANCEL constant in the cancel/speed up popover component to improve maintainability. This addresses feedback from PR #39964 where it was suggested to use the centralized constant instead of the hardcoded URL.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes: Follow-up to #39964 (comment)

Manual testing steps

  1. Go to a transaction that can be sped up or cancelled
  2. Click on the "Speed up" or "Cancel" action
  3. In the cancel/speed up popover, verify the "Learn more" link points to the correct support article
  4. Click the link and verify it opens the correct Zendesk article about speeding up or cancelling transactions

Screenshots/Recordings

Before

Hardcoded URL: https://community.metamask.io/t/how-to-speed-up-or-cancel-transactions-on-metamask/3296

After

Using constant: ZENDESK_URLS.SPEEDUP_CANCEL

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Single-string UI change that only affects the destination of a help link, with no impact to transaction logic or data handling.

Overview
The cancel/speed-up transaction popover now links to the support article via the shared ZENDESK_URLS.SPEEDUP_CANCEL constant instead of an inline hardcoded URL, improving maintainability and consistency with other UI links.

Written by Cursor Bugbot for commit 070c5a9. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall self-assigned this Feb 11, 2026
@georgewrmarshall georgewrmarshall force-pushed the speed-up-transaction-link-fix branch from 62542ad to 070c5a9 Compare February 12, 2026 00:21
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Feb 12, 2026
@georgewrmarshall georgewrmarshall marked this pull request as ready for review February 12, 2026 00:23
<TextButton asChild className="inline">
<a
href="https://support.metamask.io/manage-crypto/transactions/how-to-speed-up-or-cancel-a-pending-transaction"
href={ZENDESK_URLS.SPEEDUP_CANCEL}
Copy link
Copy Markdown
Contributor Author

@georgewrmarshall georgewrmarshall Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Feb 12, 2026

Builds ready [070c5a9]
UI Startup Metrics (1369 ± 94 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1369118317169414231507
load1188101014308312341322
domContentLoaded1181100214258312271315
domInteractive2716108192480
firstPaint177661402174207279
backgroundConnect23722133916239263
firstReactRender15103341621
initialActions301481513
loadScripts95578111528310001095
setupStore1264051518
numNetworkReqs231588201582
BrowserifyPower User HomeuiStartup17881412235819218702169
load11941058185017711721687
domContentLoaded11771048180817111551656
domInteractive38192173437107
firstPaint210741815288233323
backgroundConnect33127845730341384
firstReactRender23155562435
initialActions102111
loadScripts92679715211619081377
setupStore1795481931
numNetworkReqs1184925544141203
WebpackStandard HomeuiStartup8407041140969081025
load72362192384786877
domContentLoaded71761891983782869
domInteractive261696182377
firstPaint1176136859156215
backgroundConnect26186082941
firstReactRender16107581825
initialActions103112
loadScripts71461591182780867
setupStore1263551321
numNetworkReqs231588201582
WebpackPower User HomeuiStartup1251886186615713271518
load7226241439121713990
domContentLoaded7136171432120701982
domInteractive37182113136124
firstPaint1336840275142312
backgroundConnect16813531541169270
firstReactRender23173542531
initialActions104111
loadScripts7106151424118700972
setupStore1254951318
numNetworkReqs1154726651144217
FirefoxBrowserifyStandard HomeuiStartup15941390225715716071922
load13751205186011714061587
domContentLoaded13741201186011814061587
domInteractive863624851124175
firstPaint------
backgroundConnect55281411954105
firstReactRender1291811314
initialActions102122
loadScripts13481179182711313801554
setupStore177189251442
numNetworkReqs241289201782
BrowserifyPower User HomeuiStartup27372139416733128563455
load15661218228821716492101
domContentLoaded15651214228621716482101
domInteractive12529753127114395
firstPaint------
backgroundConnect26198994211232865
firstReactRender20166982024
initialActions203122
loadScripts15291195223920916052073
setupStore1349710192116640
numNetworkReqs65351353191124
WebpackStandard HomeuiStartup15941333196813016541821
load13841209165610014401559
domContentLoaded13831209165610014391555
domInteractive872923147130150
firstPaint------
backgroundConnect5425159235695
firstReactRender14112521419
initialActions102012
loadScripts1357119015939514181523
setupStore156174231233
numNetworkReqs231286171762
WebpackPower User HomeuiStartup27452083393042028343642
load15801285234528017182276
domContentLoaded15791285234528017172276
domInteractive13832835155118572
firstPaint------
backgroundConnect3031141327273290933
firstReactRender22166782332
initialActions216123
loadScripts15401262230527316562234
setupStore1627796205210662
numNetworkReqs653617534102123
📊 Page Load Benchmark Results

Current Commit: 070c5a9 | Date: 2/12/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 981ms (±45ms) 🟢 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 679ms (±40ms) 🟢 | historical mean value: 733ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±11ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 981ms 45ms 948ms 1.33s 1.03s 1.33s
domContentLoaded 679ms 40ms 657ms 999ms 698ms 999ms
firstPaint 75ms 11ms 64ms 172ms 84ms 172ms
firstContentfulPaint 75ms 11ms 64ms 172ms 84ms 172ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 15 Bytes (0%)
  • common: 20 Bytes (0%)

@georgewrmarshall georgewrmarshall added this pull request to the merge queue Feb 12, 2026
Merged via the queue into main with commit bae7140 Feb 12, 2026
178 of 179 checks passed
@georgewrmarshall georgewrmarshall deleted the speed-up-transaction-link-fix branch February 12, 2026 19:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2026
@metamaskbot metamaskbot added the release-13.19.0 Issue or pull request that will be included in release 13.19.0 label Feb 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.19.0 Issue or pull request that will be included in release 13.19.0 size-XS team-design-system All issues relating to design system in Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants