feat: implement Merkl claim status toasts and localization#39979
Merged
PatrykLucka merged 8 commits intomainfrom Feb 13, 2026
Merged
feat: implement Merkl claim status toasts and localization#39979PatrykLucka merged 8 commits intomainfrom
PatrykLucka merged 8 commits intomainfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (1 files, +1 -2)
🔒 @MetaMask/extension-security-team (1 files, +4 -0)
|
2c0b41d to
0eada11
Compare
ui/components/app/assets/merkl-rewards/hooks/useMerklClaimStatus.ts
Outdated
Show resolved
Hide resolved
0eada11 to
9420a09
Compare
10e2c34 to
c239c5e
Compare
Contributor
Builds ready [58e9fd3]
UI Startup Metrics (1333 ± 96 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Gudahtt
reviewed
Feb 11, 2026
Contributor
Builds ready [10cb57e]
UI Startup Metrics (1406 ± 106 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
nickewansmith
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds custom toast notifications for the mUSD Merkl rewards claiming flow. When a user initiates a Merkl claim transaction, the toast tracks the transaction lifecycle: in-progress (with spinner) → success/failed (auto-hides after 5s).
Also fixes a pre-existing bug in
home.component.jswhere the "network added" notification would reappear after navigating away and back —onAutoHidewas calling the rawsetEditedNetwork()action creator (no-op) instead of the dispatchedclearEditedNetwork()prop.Changes:
useMerklClaimStatushook — monitors Redux transactions for Merkl Distributor address, detects pending → confirmed/failed/dropped transitions, and exposestoastState+dismissToastMerklClaimToastcomponent inToastMaster— renders loading spinner (in-progress), checkmark (success), or error icon (failed) using@metamask/design-system-reacticonshome.component.jsonAutoHidenow callsclearEditedNetwork()(dispatched) instead ofsetEditedNetwork()(undispatched import)Note: This has been tested together with the full
claim-musdbranch changes from PR #39901 (Merkl rewards functionality — still WIP), but this PR is independent and can be merged first.Changelog
CHANGELOG entry: Added toast notifications for mUSD reward claim transaction status (in-progress, success, failed); fixed a bug where the "network added" home notification would reappear after navigation
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MUSD-303
Manual testing steps
claim-musdbranch (PR feat: add Merkl rewards functionality and localization #39901) on top of this branchScreenshots/Recordings
Before
After
custom-toast-musd-claim-extension.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Adds new UI toast behavior driven by transaction state transitions; low blast radius but mistakes could cause noisy/incorrect user notifications or missed claim feedback.
Overview
Adds mUSD Merkl rewards claim status toasts that watch Merkl distributor transactions and show in-progress (spinner) then success/failed completion messages (auto-hiding after 5s).
Introduces a new
useMerklClaimStatushook (with tests) to detect pending→confirmed/failed/dropped transitions and prevent duplicate completion toasts, wires it intoToastMaster, and adds new i18n strings.Fixes
home.component.jsnotification auto-hide to call the dispatchedclearEditedNetwork()instead of an undispatchedsetEditedNetwork()action creator.Written by Cursor Bugbot for commit 10cb57e. This will update automatically on new commits. Configure here.