Perps/poc controller integration limit order#39972
Merged
gambinish merged 2 commits intoperps/poc-controller-integrationfrom Feb 11, 2026
Merged
Perps/poc controller integration limit order#39972gambinish merged 2 commits intoperps/poc-controller-integrationfrom
gambinish merged 2 commits intoperps/poc-controller-integrationfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
37d8173
into
perps/poc-controller-integration
24 of 27 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Touches order placement/calc flows and adds controller-backed cancel actions; main risk is incorrect filtering/validation leading to missing orders or blocked/incorrect submissions, but changes are UI-scoped and covered with new component/tests.
Overview
Adds limit-order UX to perps order entry by introducing a
LimitPriceInput(direction-aware bid/ask/mid and +/- presets, formatting/validation) and wiring it throughOrderEntry/usePerpsOrderFormso calculations and submissions use the limit price when provided.Extends open-orders surfaces to show only resting user limit orders (filtering out TP/SL and reduce-only/trigger orders) and adds cancellation controls: per-order cancel buttons on
OrderCardplus a “Cancel All Orders” action in the perps tab, both callinggetPerpsController().cancelOrder/cancelOrders. The market detail page also subscribes to top-of-book data for presets, disables submit when limit price is invalid, and returns immediately after placing limit orders (no position-pending wait).Written by Cursor Bugbot for commit b48ff28. This will update automatically on new commits. Configure here.