Skip to content

Perps/poc controller integration limit order#39972

Merged
gambinish merged 2 commits intoperps/poc-controller-integrationfrom
perps/poc-controller-integration--limit-order
Feb 11, 2026
Merged

Perps/poc controller integration limit order#39972
gambinish merged 2 commits intoperps/poc-controller-integrationfrom
perps/poc-controller-integration--limit-order

Conversation

@gambinish
Copy link
Copy Markdown
Member

@gambinish gambinish commented Feb 11, 2026

Description

Open in GitHub Codespaces

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches order placement/calc flows and adds controller-backed cancel actions; main risk is incorrect filtering/validation leading to missing orders or blocked/incorrect submissions, but changes are UI-scoped and covered with new component/tests.

Overview
Adds limit-order UX to perps order entry by introducing a LimitPriceInput (direction-aware bid/ask/mid and +/- presets, formatting/validation) and wiring it through OrderEntry/usePerpsOrderForm so calculations and submissions use the limit price when provided.

Extends open-orders surfaces to show only resting user limit orders (filtering out TP/SL and reduce-only/trigger orders) and adds cancellation controls: per-order cancel buttons on OrderCard plus a “Cancel All Orders” action in the perps tab, both calling getPerpsController().cancelOrder/cancelOrders. The market detail page also subscribes to top-of-book data for presets, disables submit when limit price is invalid, and returns immediately after placing limit orders (no position-pending wait).

Written by Cursor Bugbot for commit b48ff28. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-perps Perps team label Feb 11, 2026
@gambinish gambinish marked this pull request as ready for review February 11, 2026 00:19
@gambinish gambinish requested a review from a team as a code owner February 11, 2026 00:19
@gambinish gambinish merged commit 37d8173 into perps/poc-controller-integration Feb 11, 2026
24 of 27 checks passed
@gambinish gambinish deleted the perps/poc-controller-integration--limit-order branch February 11, 2026 00:19
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants