feat: upgrade subscription controller for error surface by tuna1207 · Pull Request #39938 · MetaMask/metamask-extension

tuna1207 · 2026-02-10T09:43:57Z

Description

When a shield subscription crypto approval fails in the background (e.g. submitShieldSubscriptionCryptoApproval throws), the error was previously only logged and not surfaced to the user. This PR adds end-to-end error propagation so the user sees the failure on the Shield Plan and Transaction Shield settings pages.

New app state property (shieldSubscriptionError) in AppStateController — a transient (persist: false) error object { message: string; code?: string } that is set when a subscription API call fails in the background.
Background error capture — SubscriptionService now sets shieldSubscriptionError via the messenger when submitShieldSubscriptionCryptoApproval fails, using the cause message from SubscriptionServiceError when available.
UI error display — Both the Shield Plan page and the Transaction Shield settings tab read shieldSubscriptionError from Redux state and include it in their existing ApiErrorHandler component. For the known payerAddressAlreadyUsed error, a user-friendly i18n message is shown. The error is cleared when the user navigates away from either page.
ApiErrorHandler enhancement — Added an optional message prop so callers can override the default error body text.

Changelog

CHANGELOG entry: Added error display on Shield Plan and Transaction Shield pages when a subscription payment fails in the background

Related issues

Fixes:

Manual testing steps

Subscribe to Shield using a crypto payment method with an address that is already linked to another customer account.
The background submitShieldSubscriptionCryptoApproval call will fail with a payerAddressAlreadyUsed error.
Transaction Shield page should show payer address already used error.
Navigate away from the page and return — verify the error is cleared and normal content is shown (unless the error is re-triggered).

Screenshots/Recordings

Before

After

Screen.Recording.2026-02-10.at.16.33.25.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches cross-layer wiring (background controller state, messenger actions, and UI error handling), so regressions could suppress Shield flows or spam error UI, but it does not change auth or transaction execution logic.

Overview
Surfaces Transaction Shield subscription failures that happen in the background by introducing a transient AppStateController.shieldSubscriptionError and wiring it through the messenger so SubscriptionService can set/clear it when submitShieldSubscriptionCryptoApproval fails.

Updates Shield UI flows (ShieldPlan and Transaction Shield settings) to consume this error via a new useSubscriptionError hook and display a friendlier i18n message for the known “payer address already used” case, using an enhanced ApiErrorHandler that now accepts an optional override message.

Adds the new Shield error constant/type, background action (setShieldSubscriptionError), selector, and associated unit/e2e snapshot updates to validate the new state field and error propagation.

^{Written by Cursor Bugbot for commit d1ad263. This will update automatically on new commits. Configure here.}

metamaskbotv2 · 2026-02-10T09:46:38Z

✨ Files requiring CODEOWNER review ✨

🕵️ @MetaMask/extension-privacy-reviewers (1 files, +1 -0)

📁 test/
- 📁 e2e/
  - 📁 tests/
    - 📁 settings/
      - 📄 state-logs.json +1 -0

🧪 @MetaMask/qa (1 files, +1 -0)

📁 test/
- 📁 e2e/
  - 📁 tests/
    - 📁 settings/
      - 📄 state-logs.json +1 -0

🔐 @MetaMask/web3auth (3 files, +81 -4)

📁 ui/
- 📁 hooks/
  - 📁 subscription/
    - 📄 useSubscription.ts +66 -2
- 📁 pages/
  - 📁 settings/
    - 📁 transaction-shield-tab/
      - 📄 transaction-shield.tsx +7 -1
  - 📁 shield-plan/
    - 📄 shield-plan.tsx +8 -1

This reverts commit 2f762f5.

…error

ui/pages/settings/transaction-shield-tab/transaction-shield.tsx

ui/pages/shield-plan/shield-plan.tsx

metamaskbotv2 · 2026-02-11T09:12:16Z

Builds ready [0855118]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

UI Startup Metrics (1309 ± 96 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1309	1135	1653	96	1340	1480
			load	1121	934	1421	88	1160	1283
			domContentLoaded	1114	929	1406	87	1155	1274
			domInteractive	27	14	131	21	23	81
			firstPaint	193	60	1150	195	199	338
			backgroundConnect	215	199	261	13	219	247
			firstReactRender	15	10	32	3	16	21
			initialActions	1	0	10	1	1	2
			loadScripts	914	738	1173	85	953	1070
			setupStore	12	6	162	15	13	17
			numNetworkReqs	23	15	98	22	15	86
	Browserify	Power User Home	uiStartup	2547	1420	7268	1245	2636	5208
			load	1232	1050	1879	151	1265	1582
			domContentLoaded	1212	1041	1871	143	1234	1534
			domInteractive	38	20	220	33	34	101
			firstPaint	217	69	1707	201	256	357
			backgroundConnect	788	297	5036	930	593	2764
			firstReactRender	23	15	58	6	26	33
			initialActions	1	0	4	1	1	1
			loadScripts	968	810	1616	140	996	1305
			setupStore	16	7	80	10	17	31
			numNetworkReqs	109	30	246	44	132	207
	Webpack	Standard Home	uiStartup	800	667	1068	84	846	948
			load	695	597	977	81	754	836
			domContentLoaded	690	594	968	80	747	827
			domInteractive	25	16	93	18	22	76
			firstPaint	113	61	389	67	134	246
			backgroundConnect	26	17	113	11	30	40
			firstReactRender	14	10	30	4	16	19
			initialActions	1	0	2	1	1	1
			loadScripts	687	592	956	79	745	824
			setupStore	11	6	30	4	11	21
			numNetworkReqs	23	15	93	21	15	83
	Webpack	Power User Home	uiStartup	1242	822	1891	183	1334	1636
			load	736	629	1120	111	742	1029
			domContentLoaded	725	621	1115	112	727	1022
			domInteractive	40	17	206	37	36	126
			firstPaint	144	76	457	73	166	281
			backgroundConnect	159	130	373	39	163	240
			firstReactRender	22	17	37	3	23	27
			initialActions	1	0	2	1	1	1
			loadScripts	722	619	1106	110	725	1012
			setupStore	11	4	26	5	14	20
			numNetworkReqs	130	46	271	47	155	215
Firefox	Browserify	Standard Home	uiStartup	1549	1336	2513	168	1571	1864
			load	1336	1148	1792	115	1373	1556
			domContentLoaded	1334	1145	1792	115	1373	1556
			domInteractive	74	32	226	40	96	140
			firstPaint	-	-	-	-	-	-
			backgroundConnect	55	28	315	30	53	71
			firstReactRender	11	9	18	1	12	14
			initialActions	1	0	6	1	1	2
			loadScripts	1310	1129	1693	110	1349	1529
			setupStore	14	6	214	22	11	30
			numNetworkReqs	24	12	89	20	17	85
	Browserify	Power User Home	uiStartup	2794	2146	3991	352	2918	3454
			load	1578	1361	2467	207	1637	1988
			domContentLoaded	1577	1361	2467	207	1637	1988
			domInteractive	142	35	506	108	146	395
			firstPaint	-	-	-	-	-	-
			backgroundConnect	339	122	1346	261	396	915
			firstReactRender	19	15	48	4	19	23
			initialActions	2	0	3	1	2	3
			loadScripts	1536	1333	2294	187	1585	1944
			setupStore	146	8	780	201	120	644
			numNetworkReqs	80	38	161	34	113	130
	Webpack	Standard Home	uiStartup	1593	1350	2410	175	1635	1879
			load	1376	1173	2198	136	1435	1571
			domContentLoaded	1375	1168	2198	136	1434	1571
			domInteractive	91	29	230	43	129	165
			firstPaint	-	-	-	-	-	-
			backgroundConnect	56	26	361	42	57	129
			firstReactRender	14	11	55	6	14	19
			initialActions	1	0	3	1	1	2
			loadScripts	1347	1161	2172	130	1405	1516
			setupStore	13	6	85	13	11	38
			numNetworkReqs	23	12	98	19	17	73
	Webpack	Power User Home	uiStartup	2665	2009	6747	528	2810	3290
			load	1543	1261	5311	438	1532	2019
			domContentLoaded	1543	1260	5311	438	1532	2018
			domInteractive	149	31	783	149	130	480
			firstPaint	-	-	-	-	-	-
			backgroundConnect	326	128	941	211	360	828
			firstReactRender	20	15	34	4	22	27
			initialActions	2	1	3	1	2	2
			loadScripts	1500	1235	5268	431	1507	1950
			setupStore	158	13	758	195	176	650
			numNetworkReqs	81	36	225	44	86	183

📊 Page Load Benchmark Results

Current Commit: 0855118 | Date: 2/11/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±64ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 733ms (±61ms) 🟢 | historical mean value: 721ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±11ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	64ms	1.02s	1.34s	1.26s	1.34s
domContentLoaded	733ms	61ms	706ms	1.02s	935ms	1.02s
firstPaint	78ms	11ms	64ms	164ms	88ms	164ms
firstContentfulPaint	78ms	11ms	64ms	164ms	88ms	164ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 749 Bytes (0.02%)
ui: 1.15 KiB (0.01%)
common: 518 Bytes (0%)

ui/hooks/subscription/useSubscription.ts

app/scripts/services/subscription/subscription-service.ts

metamaskbotv2 · 2026-02-11T09:56:05Z

Builds ready [8d82ba3]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

UI Startup Metrics (1404 ± 106 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1404	1208	1853	106	1455	1589
			load	1197	1010	1554	88	1236	1355
			domContentLoaded	1191	997	1548	88	1224	1349
			domInteractive	27	15	122	18	23	75
			firstPaint	188	66	1294	199	215	336
			backgroundConnect	244	226	326	16	245	276
			firstReactRender	18	10	152	17	17	22
			initialActions	1	0	5	1	1	2
			loadScripts	961	774	1314	89	1003	1123
			setupStore	12	7	31	4	14	20
			numNetworkReqs	23	15	89	20	15	82
	Browserify	Power User Home	uiStartup	2009	1392	9427	1304	1821	2432
			load	1140	1013	1650	135	1145	1516
			domContentLoaded	1123	1007	1602	131	1123	1489
			domInteractive	33	18	193	23	34	82
			firstPaint	168	74	401	75	226	295
			backgroundConnect	524	283	7042	1002	333	663
			firstReactRender	21	14	41	5	23	32
			initialActions	1	0	3	1	1	2
			loadScripts	890	778	1322	125	886	1244
			setupStore	14	6	37	5	16	21
			numNetworkReqs	103	53	231	43	132	201
	Webpack	Standard Home	uiStartup	809	674	1163	102	902	973
			load	705	599	972	92	782	866
			domContentLoaded	699	595	959	91	777	860
			domInteractive	25	16	83	17	22	72
			firstPaint	110	59	401	62	131	209
			backgroundConnect	25	16	80	9	27	41
			firstReactRender	13	9	26	4	16	22
			initialActions	1	0	3	1	1	2
			loadScripts	697	593	951	90	775	855
			setupStore	11	6	39	5	12	18
			numNetworkReqs	23	15	96	21	15	83
	Webpack	Power User Home	uiStartup	1302	955	2428	229	1376	1730
			load	739	629	1592	146	734	1063
			domContentLoaded	729	622	1582	146	720	1054
			domInteractive	40	19	221	34	37	108
			firstPaint	151	62	547	95	168	346
			backgroundConnect	190	152	376	44	188	299
			firstReactRender	24	18	64	6	26	32
			initialActions	1	0	2	0	1	1
			loadScripts	726	620	1572	144	718	1045
			setupStore	12	5	39	5	14	18
			numNetworkReqs	129	45	275	51	151	212
Firefox	Browserify	Standard Home	uiStartup	1509	1312	2201	169	1540	1887
			load	1298	1135	1811	134	1347	1565
			domContentLoaded	1297	1132	1805	134	1345	1564
			domInteractive	62	32	217	38	80	134
			firstPaint	-	-	-	-	-	-
			backgroundConnect	53	28	128	17	56	86
			firstReactRender	12	9	21	2	12	17
			initialActions	1	0	2	1	1	2
			loadScripts	1273	1115	1782	129	1321	1504
			setupStore	13	6	129	16	12	30
			numNetworkReqs	24	12	93	21	16	87
	Browserify	Power User Home	uiStartup	2631	2046	3880	325	2738	3305
			load	1505	1256	2421	234	1559	2026
			domContentLoaded	1504	1256	2420	234	1559	2025
			domInteractive	127	35	581	119	120	399
			firstPaint	-	-	-	-	-	-
			backgroundConnect	263	99	965	213	262	861
			firstReactRender	19	14	69	10	17	22
			initialActions	1	0	3	1	2	2
			loadScripts	1469	1233	2396	224	1507	1958
			setupStore	173	7	798	213	227	637
			numNetworkReqs	72	37	139	31	100	129
	Webpack	Standard Home	uiStartup	1590	1367	2087	139	1649	1868
			load	1375	1172	1749	105	1443	1541
			domContentLoaded	1374	1171	1749	105	1442	1541
			domInteractive	86	28	251	45	119	165
			firstPaint	-	-	-	-	-	-
			backgroundConnect	56	25	162	27	58	112
			firstReactRender	15	11	78	8	14	18
			initialActions	1	0	3	1	2	2
			loadScripts	1346	1156	1673	103	1422	1512
			setupStore	14	6	165	17	13	29
			numNetworkReqs	24	13	93	20	20	80
	Webpack	Power User Home	uiStartup	2952	2051	9739	1052	2946	3782
			load	1773	1324	8345	950	1748	2454
			domContentLoaded	1772	1318	8345	950	1747	2453
			domInteractive	156	34	1491	198	136	569
			firstPaint	-	-	-	-	-	-
			backgroundConnect	303	117	1263	228	303	913
			firstReactRender	24	16	77	8	26	33
			initialActions	2	1	4	1	2	3
			loadScripts	1729	1299	8315	949	1687	2422
			setupStore	203	9	840	236	337	731
			numNetworkReqs	69	34	215	37	91	132

📊 Page Load Benchmark Results

Current Commit: 8d82ba3 | Date: 2/11/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±38ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 723ms (±35ms) 🟢 | historical mean value: 721ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±11ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	38ms	1.01s	1.32s	1.07s	1.32s
domContentLoaded	723ms	35ms	702ms	993ms	746ms	993ms
firstPaint	77ms	11ms	60ms	152ms	92ms	152ms
firstContentfulPaint	77ms	11ms	60ms	152ms	92ms	152ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 749 Bytes (0.02%)
ui: 1.12 KiB (0.01%)
common: 518 Bytes (0%)

metamaskbotv2 · 2026-02-11T10:48:26Z

Builds ready [1738700]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

UI Startup Metrics (1341 ± 95 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1341	1127	1639	95	1386	1505
			load	1159	987	1377	87	1211	1317
			domContentLoaded	1153	982	1371	86	1205	1311
			domInteractive	27	15	95	21	23	92
			firstPaint	197	61	1342	198	211	319
			backgroundConnect	229	208	286	15	236	258
			firstReactRender	15	10	36	4	17	21
			initialActions	1	0	5	1	1	2
			loadScripts	938	760	1133	85	987	1087
			setupStore	12	6	31	5	14	22
			numNetworkReqs	23	15	89	21	15	85
	Browserify	Power User Home	uiStartup	3449	1527	10395	2380	4327	9977
			load	1264	1054	1875	161	1320	1592
			domContentLoaded	1244	1043	1851	154	1288	1581
			domInteractive	38	19	221	36	34	123
			firstPaint	237	79	1246	163	280	436
			backgroundConnect	1682	299	8729	2119	2492	7804
			firstReactRender	24	16	52	7	26	37
			initialActions	1	0	5	1	1	2
			loadScripts	1003	822	1591	150	1032	1333
			setupStore	15	6	58	8	17	32
			numNetworkReqs	115	52	224	37	140	183
	Webpack	Standard Home	uiStartup	838	684	1148	104	904	1011
			load	724	607	962	95	790	909
			domContentLoaded	719	602	956	94	784	900
			domInteractive	26	16	94	19	24	77
			firstPaint	103	61	230	44	124	208
			backgroundConnect	26	18	55	8	28	48
			firstReactRender	15	10	26	4	18	22
			initialActions	1	0	4	1	1	2
			loadScripts	716	600	952	93	781	894
			setupStore	12	6	32	4	13	19
			numNetworkReqs	23	15	92	21	15	83
	Webpack	Power User Home	uiStartup	1277	951	2349	242	1341	1732
			load	738	634	1404	110	742	959
			domContentLoaded	727	626	1391	111	731	954
			domInteractive	38	18	192	27	38	117
			firstPaint	158	66	730	100	196	351
			backgroundConnect	158	130	353	38	159	219
			firstReactRender	22	16	46	5	23	29
			initialActions	1	0	4	1	1	1
			loadScripts	724	624	1381	109	729	945
			setupStore	13	4	53	6	15	21
			numNetworkReqs	140	61	272	40	161	210
Firefox	Browserify	Standard Home	uiStartup	1590	1364	2353	180	1614	1970
			load	1373	1173	2107	144	1401	1602
			domContentLoaded	1372	1173	2101	144	1400	1601
			domInteractive	85	34	237	47	118	151
			firstPaint	-	-	-	-	-	-
			backgroundConnect	57	28	203	24	56	89
			firstReactRender	12	10	23	2	13	15
			initialActions	1	0	2	0	1	2
			loadScripts	1349	1148	2080	142	1373	1570
			setupStore	15	6	173	20	12	38
			numNetworkReqs	24	13	93	21	16	84
	Browserify	Power User Home	uiStartup	2815	2035	8106	808	2893	3314
			load	1620	1281	6255	695	1632	1869
			domContentLoaded	1620	1281	6255	695	1632	1869
			domInteractive	168	55	725	121	201	404
			firstPaint	-	-	-	-	-	-
			backgroundConnect	443	104	1354	305	599	1032
			firstReactRender	17	14	61	6	18	22
			initialActions	2	1	3	1	2	2
			loadScripts	1575	1259	6194	689	1598	1782
			setupStore	130	13	638	137	180	420
			numNetworkReqs	93	44	171	29	114	149
	Webpack	Standard Home	uiStartup	1527	1293	2059	134	1574	1813
			load	1324	1147	1649	96	1371	1473
			domContentLoaded	1324	1147	1649	96	1370	1473
			domInteractive	81	28	305	45	110	134
			firstPaint	-	-	-	-	-	-
			backgroundConnect	50	22	126	22	54	90
			firstReactRender	15	10	56	8	14	22
			initialActions	1	0	3	1	1	2
			loadScripts	1299	1133	1596	93	1354	1442
			setupStore	18	5	160	29	12	59
			numNetworkReqs	24	12	86	19	17	79
	Webpack	Power User Home	uiStartup	3025	2118	8635	1045	3027	4259
			load	1787	1298	7035	984	1662	3103
			domContentLoaded	1787	1298	7035	984	1661	3103
			domInteractive	191	51	1772	217	192	526
			firstPaint	-	-	-	-	-	-
			backgroundConnect	522	124	1530	361	792	1198
			firstReactRender	21	14	84	9	23	30
			initialActions	2	1	3	1	2	2
			loadScripts	1725	1274	6972	979	1566	3036
			setupStore	162	15	908	194	182	613
			numNetworkReqs	91	38	222	41	95	203

📊 Page Load Benchmark Results

Current Commit: 1738700 | Date: 2/11/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±48ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 736ms (±44ms) 🟢 | historical mean value: 721ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±13ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	48ms	1.02s	1.45s	1.09s	1.45s
domContentLoaded	736ms	44ms	710ms	1.10s	768ms	1.10s
firstPaint	79ms	13ms	64ms	196ms	92ms	196ms
firstContentfulPaint	79ms	13ms	64ms	196ms	92ms	196ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.07 KiB (0.03%)
ui: 661 Bytes (0.01%)
common: 451 Bytes (0%)

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

ui/hooks/subscription/useSubscription.ts

metamaskbotv2 · 2026-02-12T02:55:17Z

Builds ready [65df2e9]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

UI Startup Metrics (1397 ± 108 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1397	1178	1769	108	1455	1583
			load	1199	996	1508	100	1260	1362
			domContentLoaded	1192	992	1502	99	1243	1354
			domInteractive	27	17	92	17	24	75
			firstPaint	147	66	382	80	202	334
			backgroundConnect	245	224	410	22	246	278
			firstReactRender	18	10	36	6	19	30
			initialActions	1	0	7	1	1	3
			loadScripts	964	767	1239	96	1009	1126
			setupStore	13	6	45	6	15	24
			numNetworkReqs	22	15	85	20	15	81
	Browserify	Power User Home	uiStartup	1702	1330	2382	181	1758	2050
			load	1161	1042	1906	186	1129	1703
			domContentLoaded	1143	1021	1821	176	1116	1609
			domInteractive	35	19	217	31	33	105
			firstPaint	186	68	1754	180	223	369
			backgroundConnect	319	278	406	24	330	358
			firstReactRender	22	14	66	6	23	30
			initialActions	1	0	4	1	1	2
			loadScripts	903	780	1566	171	879	1383
			setupStore	15	5	55	7	16	26
			numNetworkReqs	111	43	259	48	138	212
	Webpack	Standard Home	uiStartup	833	670	1226	105	918	993
			load	729	593	977	104	828	896
			domContentLoaded	723	588	971	103	822	884
			domInteractive	26	15	130	20	22	80
			firstPaint	106	59	367	56	127	207
			backgroundConnect	25	16	58	8	28	40
			firstReactRender	13	10	24	4	15	21
			initialActions	1	0	3	1	1	2
			loadScripts	721	586	964	102	820	882
			setupStore	11	7	33	4	11	18
			numNetworkReqs	23	15	92	21	15	84
	Webpack	Power User Home	uiStartup	1216	881	1595	141	1295	1455
			load	720	632	1110	110	703	1027
			domContentLoaded	710	625	1104	110	691	1017
			domInteractive	38	19	195	33	37	118
			firstPaint	142	65	1032	114	148	310
			backgroundConnect	164	131	305	38	168	245
			firstReactRender	22	17	34	4	24	29
			initialActions	1	0	2	0	1	1
			loadScripts	707	623	1096	108	689	1007
			setupStore	13	4	46	5	14	20
			numNetworkReqs	113	45	263	50	145	237
Firefox	Browserify	Standard Home	uiStartup	1543	1333	2137	156	1576	1875
			load	1329	1159	1823	119	1373	1565
			domContentLoaded	1328	1153	1822	120	1367	1565
			domInteractive	72	32	261	44	94	144
			firstPaint	-	-	-	-	-	-
			backgroundConnect	55	28	223	25	53	93
			firstReactRender	12	9	18	1	12	14
			initialActions	1	0	3	1	1	2
			loadScripts	1303	1136	1709	111	1347	1518
			setupStore	15	6	173	23	12	36
			numNetworkReqs	24	14	97	20	17	80
	Browserify	Power User Home	uiStartup	2766	2053	4426	432	2840	3668
			load	1546	1291	2392	237	1623	2041
			domContentLoaded	1546	1291	2387	237	1621	2040
			domInteractive	117	34	665	101	117	302
			firstPaint	-	-	-	-	-	-
			backgroundConnect	327	114	1041	255	394	914
			firstReactRender	21	14	136	15	20	29
			initialActions	2	0	3	1	2	2
			loadScripts	1505	1271	2337	224	1559	1996
			setupStore	142	8	744	203	114	650
			numNetworkReqs	66	36	144	29	87	124
	Webpack	Standard Home	uiStartup	1537	1318	2076	150	1589	1839
			load	1340	1135	1864	113	1395	1539
			domContentLoaded	1339	1131	1864	114	1395	1538
			domInteractive	81	25	238	43	118	137
			firstPaint	-	-	-	-	-	-
			backgroundConnect	54	21	187	34	55	124
			firstReactRender	13	10	23	2	13	18
			initialActions	1	0	2	0	1	2
			loadScripts	1311	1124	1727	106	1371	1500
			setupStore	14	6	146	19	12	45
			numNetworkReqs	23	13	91	18	17	75
	Webpack	Power User Home	uiStartup	2816	1948	8573	887	2835	3723
			load	1607	1291	6393	567	1695	2338
			domContentLoaded	1606	1291	6393	567	1694	2337
			domInteractive	139	31	785	160	111	525
			firstPaint	-	-	-	-	-	-
			backgroundConnect	386	125	5071	553	328	928
			firstReactRender	22	16	55	5	24	30
			initialActions	2	1	6	1	2	3
			loadScripts	1563	1213	6360	562	1635	2312
			setupStore	143	7	783	197	127	632
			numNetworkReqs	65	36	145	31	96	120

📊 Page Load Benchmark Results

Current Commit: 65df2e9 | Date: 2/12/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±41ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 723ms (±38ms) 🟢 | historical mean value: 730ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±13ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	41ms	1.01s	1.34s	1.07s	1.34s
domContentLoaded	723ms	38ms	700ms	1.01s	741ms	1.01s
firstPaint	78ms	13ms	64ms	176ms	88ms	176ms
firstContentfulPaint	78ms	13ms	64ms	176ms	88ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 299.03 KiB (7.46%)
ui: 1.71 KiB (0.02%)
common: 2.39 KiB (0.02%)

…error

metamaskbotv2 · 2026-02-12T04:44:53Z

Builds ready [d1ad263]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

UI Startup Metrics (1397 ± 103 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1397	1177	1647	103	1460	1592
			load	1204	1009	1427	94	1264	1369
			domContentLoaded	1197	1003	1420	94	1258	1365
			domInteractive	28	15	102	20	24	84
			firstPaint	156	66	346	65	207	257
			backgroundConnect	240	222	293	12	243	269
			firstReactRender	17	9	33	5	19	27
			initialActions	1	0	7	1	1	4
			loadScripts	971	784	1197	93	1031	1135
			setupStore	13	6	47	7	15	28
			numNetworkReqs	23	15	90	21	15	83
	Browserify	Power User Home	uiStartup	2192	1501	10239	1410	2114	3879
			load	1225	1071	1948	175	1242	1655
			domContentLoaded	1206	1060	1836	163	1221	1624
			domInteractive	38	18	178	30	37	112
			firstPaint	208	76	1857	247	247	343
			backgroundConnect	503	289	3945	662	353	1843
			firstReactRender	23	15	48	6	25	36
			initialActions	1	0	4	1	1	1
			loadScripts	960	822	1542	158	975	1369
			setupStore	16	6	53	8	17	33
			numNetworkReqs	113	38	247	45	140	192
	Webpack	Standard Home	uiStartup	838	678	1140	109	911	1053
			load	729	600	1064	103	805	906
			domContentLoaded	724	596	1055	102	799	900
			domInteractive	26	16	101	20	22	87
			firstPaint	114	62	999	102	123	201
			backgroundConnect	25	16	64	9	28	41
			firstReactRender	13	10	25	4	15	20
			initialActions	1	0	4	1	1	2
			loadScripts	721	594	1053	101	791	898
			setupStore	12	6	47	7	12	26
			numNetworkReqs	23	15	88	20	15	84
	Webpack	Power User Home	uiStartup	1299	885	2851	261	1371	1624
			load	755	647	1517	137	738	1067
			domContentLoaded	744	641	1510	137	728	1059
			domInteractive	41	19	219	35	38	126
			firstPaint	151	69	519	86	168	333
			backgroundConnect	187	140	891	95	175	334
			firstReactRender	23	17	37	4	25	28
			initialActions	1	0	3	1	1	1
			loadScripts	741	639	1497	135	727	1050
			setupStore	13	5	38	5	15	20
			numNetworkReqs	134	48	275	48	156	219
Firefox	Browserify	Standard Home	uiStartup	1490	1300	2126	172	1520	1896
			load	1286	1131	1717	128	1325	1576
			domContentLoaded	1285	1127	1717	129	1322	1576
			domInteractive	60	31	211	34	80	132
			firstPaint	-	-	-	-	-	-
			backgroundConnect	50	25	205	25	50	99
			firstReactRender	11	9	20	2	12	15
			initialActions	1	0	2	0	1	2
			loadScripts	1263	1110	1654	123	1302	1547
			setupStore	12	6	168	17	10	27
			numNetworkReqs	23	12	87	20	17	84
	Browserify	Power User Home	uiStartup	2745	2083	4076	366	2907	3530
			load	1564	1277	2287	256	1623	2200
			domContentLoaded	1564	1275	2287	257	1623	2200
			domInteractive	139	32	741	138	128	464
			firstPaint	-	-	-	-	-	-
			backgroundConnect	342	116	1114	277	391	906
			firstReactRender	19	14	132	13	18	27
			initialActions	2	0	3	1	2	2
			loadScripts	1520	1252	2264	246	1541	2136
			setupStore	119	7	728	164	123	530
			numNetworkReqs	74	36	156	32	97	126
	Webpack	Standard Home	uiStartup	1525	1279	1940	138	1579	1815
			load	1329	1089	1746	108	1392	1506
			domContentLoaded	1329	1088	1746	108	1392	1506
			domInteractive	80	28	188	42	128	142
			firstPaint	-	-	-	-	-	-
			backgroundConnect	54	22	149	29	61	124
			firstReactRender	13	10	48	4	13	18
			initialActions	1	0	2	0	1	2
			loadScripts	1302	1077	1637	100	1369	1461
			setupStore	12	6	52	10	12	31
			numNetworkReqs	24	12	95	21	16	82
	Webpack	Power User Home	uiStartup	2738	1906	7451	635	2872	3731
			load	1597	1226	5630	509	1686	2319
			domContentLoaded	1597	1226	5630	509	1686	2319
			domInteractive	156	33	755	170	139	605
			firstPaint	-	-	-	-	-	-
			backgroundConnect	291	118	997	216	317	851
			firstReactRender	20	16	30	4	23	28
			initialActions	2	1	3	1	2	2
			loadScripts	1557	1207	5602	496	1648	2227
			setupStore	148	8	858	200	174	592
			numNetworkReqs	71	35	182	35	97	132

📊 Page Load Benchmark Results

Current Commit: d1ad263 | Date: 2/12/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±40ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 718ms (±37ms) 🟢 | historical mean value: 730ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±10ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	40ms	997ms	1.31s	1.05s	1.31s
domContentLoaded	718ms	37ms	690ms	985ms	741ms	985ms
firstPaint	76ms	10ms	60ms	156ms	84ms	156ms
firstContentfulPaint	76ms	10ms	60ms	156ms	84ms	156ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 749 Bytes (0.02%)
ui: 946 Bytes (0.01%)
common: 518 Bytes (0%)

ui/hooks/subscription/useSubscription.ts

LeVinhGithub

lgtm QA

tuna1207 added 3 commits February 10, 2026 16:36

feat: add shield subscription error app state

f9cef2a

feat: handle display shield subscription error

c0c730f

feat: upgrade subscription controller for error surface

2f762f5

tuna1207 temporarily deployed to pr-comment February 10, 2026 09:44 — with GitHub Actions Inactive

metamaskbot added the team-onboarding Onboarding team label Feb 10, 2026

tuna1207 added area-shield team-shield Shield team and removed team-onboarding Onboarding team labels Feb 10, 2026

github-actions bot added the size-M label Feb 10, 2026

tuna1207 added 2 commits February 11, 2026 15:34

Revert "feat: upgrade subscription controller for error surface"

df36938

This reverts commit 2f762f5.

Merge branch 'main' into feat/subscription-handle-payer-address-used-…

0855118

…error

tuna1207 had a problem deploying to pr-comment February 11, 2026 08:36 — with GitHub Actions Error

tuna1207 marked this pull request as ready for review February 11, 2026 08:36

tuna1207 requested review from a team as code owners February 11, 2026 08:36

tuna1207 temporarily deployed to pr-comment February 11, 2026 08:36 — with GitHub Actions Inactive

cursor bot reviewed Feb 11, 2026

View reviewed changes

ui/pages/settings/transaction-shield-tab/transaction-shield.tsx Outdated Show resolved Hide resolved

ui/pages/shield-plan/shield-plan.tsx Outdated Show resolved Hide resolved

feat: update api error message

b8c4cd7

tuna1207 temporarily deployed to pr-comment February 11, 2026 09:07 — with GitHub Actions Inactive

feat: refactor useSubscriptionError

8d82ba3

tuna1207 temporarily deployed to pr-comment February 11, 2026 09:18 — with GitHub Actions Inactive

cursor bot reviewed Feb 11, 2026

View reviewed changes

ui/hooks/subscription/useSubscription.ts Outdated Show resolved Hide resolved

app/scripts/services/subscription/subscription-service.ts Show resolved Hide resolved

tuna1207 temporarily deployed to pr-comment February 11, 2026 09:51 — with GitHub Actions Inactive

fix: update test data

b27a15e

tuna1207 temporarily deployed to pr-comment February 11, 2026 09:56 — with GitHub Actions Inactive

tuna1207 temporarily deployed to pr-comment February 11, 2026 10:44 — with GitHub Actions Inactive

fix: test data

e9dd6b9

tuna1207 temporarily deployed to pr-comment February 12, 2026 02:20 — with GitHub Actions Inactive

fix: test data

65df2e9

tuna1207 temporarily deployed to pr-comment February 12, 2026 02:23 — with GitHub Actions Inactive

cursor bot reviewed Feb 12, 2026

View reviewed changes

ui/hooks/subscription/useSubscription.ts Show resolved Hide resolved

tuna1207 temporarily deployed to pr-comment February 12, 2026 02:50 — with GitHub Actions Inactive

Merge branch 'main' into feat/subscription-handle-payer-address-used-…

0b9ceca

…error

tuna1207 temporarily deployed to pr-comment February 12, 2026 03:48 — with GitHub Actions Inactive

fix: test data

d1ad263

tuna1207 temporarily deployed to pr-comment February 12, 2026 04:11 — with GitHub Actions Inactive

tuna1207 temporarily deployed to pr-comment February 12, 2026 04:40 — with GitHub Actions Inactive

tuna1207 requested review from chaitanyapotti, lionellbriones and lwin-kyaw February 12, 2026 04:51

lionellbriones approved these changes Feb 12, 2026

View reviewed changes

chaitanyapotti reviewed Feb 12, 2026

View reviewed changes

ui/hooks/subscription/useSubscription.ts Show resolved Hide resolved

chaitanyapotti approved these changes Feb 12, 2026

View reviewed changes

chaitanyapotti enabled auto-merge February 12, 2026 06:40

LeVinhGithub approved these changes Feb 12, 2026

View reviewed changes

chaitanyapotti added this pull request to the merge queue Feb 12, 2026

Merged via the queue into main with commit b605dc3 Feb 12, 2026
180 checks passed

chaitanyapotti deleted the feat/subscription-handle-payer-address-used-error branch February 12, 2026 08:29

github-actions bot locked and limited conversation to collaborators Feb 12, 2026

metamaskbot added the release-13.19.0 Issue or pull request that will be included in release 13.19.0 label Feb 12, 2026

chaitanyapotti removed the request for review from a team February 12, 2026 08:49

Conversation

tuna1207 commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbotv2 bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

Uh oh!

Uh oh!

metamaskbotv2 bot commented Feb 11, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

metamaskbotv2 bot commented Feb 11, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Feb 11, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

metamaskbotv2 bot commented Feb 12, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Feb 12, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

LeVinhGithub left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tuna1207 commented Feb 10, 2026 •

edited

Loading

metamaskbotv2 bot commented Feb 10, 2026 •

edited

Loading