Skip to content

fix: Remove "Dapp suggested" speed for speed label if gas settled more than 1B#39934

Merged
OGPoyraz merged 6 commits intomainfrom
ogp/remove--dapp-suggestion-high-from-gas-speed
Feb 19, 2026
Merged

fix: Remove "Dapp suggested" speed for speed label if gas settled more than 1B#39934
OGPoyraz merged 6 commits intomainfrom
ogp/remove--dapp-suggestion-high-from-gas-speed

Conversation

@OGPoyraz
Copy link
Copy Markdown
Member

@OGPoyraz OGPoyraz commented Feb 10, 2026

Description

Open in GitHub Codespaces

If you initiate a transaction from wallet and set gas value more than 1 billion it settles gas speed as dapp suggested.

This PR removes that logic.

Changelog

CHANGELOG entry: Remove unintended "Dapp suggested" label from gas speed labels

Related issues

Fixes: #39933

Manual testing steps

  1. Start send
  2. Set gas more than 1 billion
  3. See it changes to "Dapp suggested"

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Small, localized change to gas fee label/estimate selection state with corresponding test updates; it doesn’t alter signing or transaction submission logic.

Overview
Removes a heuristic in useGasFeeInputs that calculated the max transaction fee and, when it exceeded a threshold, forced estimateUsed to dappSuggestedHigh; the hook now consistently derives estimateUsed from transaction.userFeeLevel for EIP-1559 transactions.

Cleans up related unit tests by deleting the gas-details-item case that expected the warning/label behavior for high dapp-suggested fees, and updates the Jest console baseline to reflect the reduced warnings.

Written by Cursor Bugbot for commit 178405b. This will update automatically on new commits. Configure here.

@OGPoyraz OGPoyraz requested a review from a team as a code owner February 10, 2026 08:03
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Feb 10, 2026
@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Feb 10, 2026

✨ Files requiring CODEOWNER review ✨

@MetaMask/confirmations (2 files, +0 -53)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 components/
          • 📁 gas-details-item/
            • 📄 gas-details-item.test.js +0 -36
        • 📁 hooks/
          • 📄 useGasFeeInputs.js +0 -17

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Feb 10, 2026

Builds ready [6e77edb]
UI Startup Metrics (1349 ± 100 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup13491159170410014011514
load116798614709412181328
domContentLoaded116198214419312131318
domInteractive2716102202384
firstPaint151671136117201231
backgroundConnect23621827613238267
firstReactRender1593541622
initialActions105113
loadScripts9407671214919921091
setupStore1272941318
numNetworkReqs231592201582
BrowserifyPower User HomeuiStartup16931381230815617481940
load1112995177516410981582
domContentLoaded1092984172915710781557
domInteractive3317139213478
firstPaint216671618182237398
backgroundConnect31426640330328370
firstReactRender21144152235
initialActions102111
loadScripts86676814581488431302
setupStore1473551623
numNetworkReqs1135026947135204
WebpackStandard HomeuiStartup824674111692899963
load70860094486773870
domContentLoaded70359693486767863
domInteractive251696182272
firstPaint1076137056123195
backgroundConnect25175082643
firstReactRender14103251722
initialActions105112
loadScripts70059592785765861
setupStore1153041219
numNetworkReqs231593211582
WebpackPower User HomeuiStartup1181979171916312631559
load6695901130109658972
domContentLoaded6605861118108645959
domInteractive37163384431140
firstPaint1296059290134276
backgroundConnect17514036952168314
firstReactRender22173232328
initialActions104111
loadScripts6585841112106643949
setupStore1243451319
numNetworkReqs1194927551142226
FirefoxBrowserifyStandard HomeuiStartup15351324215717415811893
load13191131192214013751602
domContentLoaded13181131191614013751602
domInteractive65323284585135
firstPaint------
backgroundConnect5530144176182
firstReactRender1292721214
initialActions102012
loadScripts12941108189513813511578
setupStore156128191253
numNetworkReqs241396221786
BrowserifyPower User HomeuiStartup27392026367639028383601
load15841302230828416442263
domContentLoaded15841302230828416442263
domInteractive13133839131123478
firstPaint------
backgroundConnect2871241014229280906
firstReactRender20147692028
initialActions213122
loadScripts15471281228327516042201
setupStore1768811231215707
numNetworkReqs65361473088124
WebpackStandard HomeuiStartup15251281213815515651839
load13241156173410813691532
domContentLoaded13231156173410813691532
domInteractive782721339102134
firstPaint------
backgroundConnect55232343365121
firstReactRender14105051418
initialActions102012
loadScripts12971098163410013471497
setupStore13661121148
numNetworkReqs241488201783
WebpackPower User HomeuiStartup26561820426044827713697
load15671293281631316932239
domContentLoaded15661293281531316932238
domInteractive161311380209128690
firstPaint------
backgroundConnect268561352240244908
firstReactRender24168292631
initialActions217123
loadScripts15261210279030516592161
setupStore14211824184164573
numNetworkReqs66351403197126
📊 Page Load Benchmark Results

Current Commit: 6e77edb | Date: 2/10/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±38ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 738ms (±36ms) 🟢 | historical mean value: 717ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±10ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 38ms 1.02s 1.31s 1.09s 1.31s
domContentLoaded 738ms 36ms 705ms 987ms 769ms 987ms
firstPaint 79ms 10ms 60ms 164ms 88ms 164ms
firstContentfulPaint 79ms 10ms 60ms 164ms 88ms 164ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: -776 Bytes (-0.01%)
  • common: 20 Bytes (0%)

@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Feb 11, 2026

Builds ready [f76c5b9]
UI Startup Metrics (1332 ± 88 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1332116615818813811499
load114698813388211921296
domContentLoaded114198413308111861289
domInteractive2516111182270
firstPaint155661203129199311
backgroundConnect23521540124236265
firstReactRender1593951722
initialActions103112
loadScripts9207601113829681072
setupStore1263351319
numNetworkReqs231590201583
BrowserifyPower User HomeuiStartup3398153011077203844786980
load13291148175012213811596
domContentLoaded13111133171911713631559
domInteractive3619226263771
firstPaint239921270143293394
backgroundConnect12123098461147517193339
firstReactRender23153842631
initialActions1010112
loadScripts1054888143411210901308
setupStore1463151721
numNetworkReqs934015823107130
WebpackStandard HomeuiStartup819679107793873976
load71260494591758893
domContentLoaded70760093890753887
domInteractive2715232272273
firstPaint1116239661129219
backgroundConnect26187792743
firstReactRender14102941723
initialActions105112
loadScripts70459993089750885
setupStore1263651220
numNetworkReqs231594211584
WebpackPower User HomeuiStartup1314905316839013632155
load74263214591377201057
domContentLoaded73162614461377061050
domInteractive39202073338122
firstPaint190791072163214456
backgroundConnect2141311581229160416
firstReactRender20153332228
initialActions102111
loadScripts72962414331347051047
setupStore1256371320
numNetworkReqs1486227939162226
FirefoxBrowserifyStandard HomeuiStartup15531364224916915791934
load13411166202013613781616
domContentLoaded13391166201213613731615
domInteractive76322974798140
firstPaint------
backgroundConnect5632124156086
firstReactRender1291811213
initialActions103012
loadScripts13151144199913413531586
setupStore187199341333
numNetworkReqs241389211686
BrowserifyPower User HomeuiStartup29052184383434931193494
load15691290210818316491981
domContentLoaded15691290210818316491980
domInteractive17152687133203469
firstPaint------
backgroundConnect47312413293186791148
firstReactRender18152931823
initialActions103122
loadScripts15281270207017516171929
setupStore15617912198178643
numNetworkReqs904219633104166
WebpackStandard HomeuiStartup15841330238615916441851
load13591160161210314241536
domContentLoaded13591160161210314241536
domInteractive872923244129152
firstPaint------
backgroundConnect56231712963129
firstReactRender13102631421
initialActions102112
loadScripts1330114715719713911504
setupStore236679711159
numNetworkReqs241389201880
WebpackPower User HomeuiStartup28722025461043931143563
load16261306329730717172095
domContentLoaded16261305329730717172095
domInteractive16250746132188392
firstPaint------
backgroundConnect47312914183017221000
firstReactRender23178482534
initialActions217123
loadScripts15831268325030616522074
setupStore13016622151132529
numNetworkReqs90282273698162
📊 Page Load Benchmark Results

Current Commit: f76c5b9 | Date: 2/11/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±40ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 734ms (±38ms) 🟢 | historical mean value: 721ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±9ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 40ms 1.02s 1.35s 1.09s 1.35s
domContentLoaded 734ms 38ms 712ms 1.02s 764ms 1.02s
firstPaint 78ms 9ms 64ms 144ms 84ms 144ms
firstContentfulPaint 78ms 9ms 64ms 144ms 84ms 144ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: -776 Bytes (-0.01%)
  • common: 20 Bytes (0%)

@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Feb 11, 2026

Builds ready [a6680b7]
UI Startup Metrics (1355 ± 88 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1355117316018813821539
load1167101314058412031328
domContentLoaded115998914028511951302
domInteractive261692192273
firstPaint150651247129202233
backgroundConnect23721730817242271
firstReactRender15103441721
initialActions107113
loadScripts9397711172849771081
setupStore1373551522
numNetworkReqs231586201582
BrowserifyPower User HomeuiStartup253213547651129329345105
load12041031177914112431481
domContentLoaded11891020173113812311456
domInteractive3319180243458
firstPaint1826741281251304
backgroundConnect77328951538786982382
firstReactRender22154352531
initialActions104111
loadScripts95077914911349861235
setupStore1565281729
numNetworkReqs1105225042133190
WebpackStandard HomeuiStartup85168612571239501060
load7406151177121821935
domContentLoaded7346101168121816928
domInteractive261689182377
firstPaint1096065972119191
backgroundConnect25186682838
firstReactRender14103351723
initialActions103112
loadScripts7326081166120808926
setupStore1263751224
numNetworkReqs231597211584
WebpackPower User HomeuiStartup1336878302937513602226
load76563414701417601094
domContentLoaded75162614571407411064
domInteractive43201853241111
firstPaint169731115121194323
backgroundConnect2031361118165162430
firstReactRender22183742432
initialActions103111
loadScripts74862414481387391054
setupStore1253051423
numNetworkReqs1476328338162202
FirefoxBrowserifyStandard HomeuiStartup15151313213216415411885
load12951136165110813341502
domContentLoaded12931136165110813331502
domInteractive63312884584143
firstPaint------
backgroundConnect56282322657108
firstReactRender1191711213
initialActions102012
loadScripts12711111161210613111478
setupStore186172291271
numNetworkReqs231291201780
BrowserifyPower User HomeuiStartup28242038805062429423529
load16121290625251316432132
domContentLoaded16111290625151316422132
domInteractive15235720131156402
firstPaint------
backgroundConnect3251111172241378895
firstReactRender20146982128
initialActions217122
loadScripts15741264622050915902079
setupStore1648797201182640
numNetworkReqs833718235109151
WebpackStandard HomeuiStartup15841367206015316341998
load13691163168210614181573
domContentLoaded13681163168210614171569
domInteractive882922346124159
firstPaint------
backgroundConnect62233414962135
firstReactRender15107071419
initialActions102012
loadScripts1335114616429713921513
setupStore156212271132
numNetworkReqs231292191876
WebpackPower User HomeuiStartup28552040948683129033752
load16501307694066716372415
domContentLoaded16501301694066716372414
domInteractive15245755142145513
firstPaint------
backgroundConnect3716115103134031083
firstReactRender22156472430
initialActions203122
loadScripts16131281690866215812382
setupStore15910778178198530
numNetworkReqs79372153892157
📊 Page Load Benchmark Results

Current Commit: a6680b7 | Date: 2/11/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±98ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 729ms (±96ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 82ms (±76ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 98ms 1.01s 1.98s 1.08s 1.98s
domContentLoaded 729ms 96ms 703ms 1.65s 754ms 1.65s
firstPaint 82ms 76ms 56ms 832ms 88ms 832ms
firstContentfulPaint 82ms 76ms 56ms 832ms 88ms 832ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: -776 Bytes (-0.01%)
  • common: 20 Bytes (0%)

@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Feb 16, 2026

Builds ready [178405b]
UI Startup Metrics (1406 ± 102 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup14061215164010214581612
load1207102114139412611370
domContentLoaded1200101714049412561355
domInteractive281688182580
firstPaint158711368139210245
backgroundConnect25423238819257278
firstReactRender16103141824
initialActions107113
loadScripts96378311569310121116
setupStore137114111522
numNetworkReqs221590201579
BrowserifyPower User HomeuiStartup2070147410958132819542468
load12571099227420212561758
domContentLoaded12411088226119512371701
domInteractive37181813034105
firstPaint263761810251290411
backgroundConnect4983088346907368581
firstReactRender23164872435
initialActions109112
loadScripts97482018941859571451
setupStore1686271727
numNetworkReqs1154726445140202
WebpackStandard HomeuiStartup82266412261269221053
load7175931143124817937
domContentLoaded7115881135123809930
domInteractive2615101182374
firstPaint1205960572155229
backgroundConnect24155982642
firstReactRender14102131720
initialActions103112
loadScripts7085861133123803923
setupStore1164961117
numNetworkReqs231599221587
WebpackPower User HomeuiStartup12551018227922213301734
load73763212531207291033
domContentLoaded72762512461187161020
domInteractive38181703135126
firstPaint148681046119163306
backgroundConnect16713142652167285
firstReactRender23173332429
initialActions101011
loadScripts72462312371167141009
setupStore1242841518
numNetworkReqs1274527250150241
FirefoxBrowserifyStandard HomeuiStartup15231326209416315651902
load13191139177313413591616
domContentLoaded13181134177313513591615
domInteractive68323644591142
firstPaint------
backgroundConnect5628268295398
firstReactRender1291511213
initialActions102012
loadScripts12931118169712813321577
setupStore156173211432
numNetworkReqs241294211785
BrowserifyPower User HomeuiStartup26442004387433127823226
load15331266228221816052009
domContentLoaded15331266228221816042009
domInteractive13737718130123513
firstPaint------
backgroundConnect2851041408233313784
firstReactRender18146561822
initialActions103122
loadScripts14841236225320015291922
setupStore1748718217255652
numNetworkReqs77371763499143
WebpackStandard HomeuiStartup16051352194911616741810
load1392117217309914541536
domContentLoaded1392117217309914541536
domInteractive892823345130153
firstPaint------
backgroundConnect54221512459101
firstReactRender14102531424
initialActions102012
loadScripts1369115917099814271516
setupStore146166181139
numNetworkReqs231293181874
WebpackPower User HomeuiStartup290922471022183530663733
load16781366856074016332302
domContentLoaded16771366856074016332302
domInteractive15447825168135653
firstPaint------
backgroundConnect3441241354257393862
firstReactRender24177892631
initialActions213123
loadScripts16311347852473215782206
setupStore16210773199173648
numNetworkReqs79402124286182
📊 Page Load Benchmark Results

Current Commit: 178405b | Date: 2/16/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 966ms (±40ms) 🟢 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 678ms (±36ms) 🟢 | historical mean value: 736ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±11ms) 🟢 | historical mean value: 85ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 966ms 40ms 938ms 1.24s 986ms 1.24s
domContentLoaded 678ms 36ms 653ms 936ms 697ms 936ms
firstPaint 76ms 11ms 60ms 164ms 84ms 164ms
firstContentfulPaint 76ms 11ms 60ms 164ms 84ms 164ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: -771 Bytes (-0.01%)
  • common: 20 Bytes (0%)

@OGPoyraz OGPoyraz added this pull request to the merge queue Feb 19, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 19, 2026
@OGPoyraz OGPoyraz added this pull request to the merge queue Feb 19, 2026
Merged via the queue into main with commit 43421ee Feb 19, 2026
177 checks passed
@OGPoyraz OGPoyraz deleted the ogp/remove--dapp-suggestion-high-from-gas-speed branch February 19, 2026 09:54
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2026
@metamaskbot metamaskbot added the release-13.20.0 Issue or pull request that will be included in release 13.20.0 label Feb 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.20.0 Issue or pull request that will be included in release 13.20.0 size-S team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Setting gas more than 1 billion makes speed as "dapp suggested"

4 participants