Conversation
Contributor
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (2 files, +0 -53)
|
pedronfigueiredo
previously approved these changes
Feb 10, 2026
Contributor
Builds ready [6e77edb]
UI Startup Metrics (1349 ± 100 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Contributor
Builds ready [f76c5b9]
UI Startup Metrics (1332 ± 88 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Contributor
Builds ready [a6680b7]
UI Startup Metrics (1355 ± 88 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Contributor
Builds ready [178405b]
UI Startup Metrics (1406 ± 102 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
pedronfigueiredo
approved these changes
Feb 18, 2026
dan437
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If you initiate a transaction from wallet and set gas value more than 1 billion it settles gas speed as dapp suggested.
This PR removes that logic.
Changelog
CHANGELOG entry: Remove unintended "Dapp suggested" label from gas speed labels
Related issues
Fixes: #39933
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Small, localized change to gas fee label/estimate selection state with corresponding test updates; it doesn’t alter signing or transaction submission logic.
Overview
Removes a heuristic in
useGasFeeInputsthat calculated the max transaction fee and, when it exceeded a threshold, forcedestimateUsedtodappSuggestedHigh; the hook now consistently derivesestimateUsedfromtransaction.userFeeLevelfor EIP-1559 transactions.Cleans up related unit tests by deleting the
gas-details-itemcase that expected the warning/label behavior for high dapp-suggested fees, and updates the Jest console baseline to reflect the reduced warnings.Written by Cursor Bugbot for commit 178405b. This will update automatically on new commits. Configure here.