Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
Contributor
✨ Files requiring CODEOWNER review ✨📜 @MetaMask/policy-reviewers (21 files, +517 -0)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. |
Contributor
Author
|
@SocketSecurity ignore npm/@tanstack/query-core@4.43.0 |
Contributor
Builds ready [c918c90]
UI Startup Metrics (1348 ± 88 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Author
|
@SocketSecurity ignore npm/@tanstack/react-query@4.43.0 |
Contributor
Builds ready [9989db7]
UI Startup Metrics (1362 ± 95 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [8105eae]
UI Startup Metrics (1458 ± 115 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [0328f07]
UI Startup Metrics (1356 ± 99 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [cd42d5b]
UI Startup Metrics (1365 ± 98 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [e987bca]
UI Startup Metrics (1398 ± 122 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
NidhiKJha
previously approved these changes
Feb 19, 2026
Contributor
Builds ready [2aacd8d]
UI Startup Metrics (1485 ± 136 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
MajorLift
previously requested changes
Feb 19, 2026
Contributor
There was a problem hiding this comment.
These overrides need to be applied across all build policies i.e. {browserify,webpack/mv2,webpack/mv3}X{beta,experimental,flask,main}. The recommendation to use webpack/mv3/main was just for testing -- sorry for the confusion.
Testing whether "addEventListener": false works is more critical for this PR compared to the @tanstack/query-core case, because it can leak window references when called from UI.
cc @naugtur:
- Made this a blocking review due to
policy-reviewersCO approval requirement being dismissed by accounts CO approval above. - Can confirm that this time the dependency is only called in UI. It's actually a subject of some discussion where this package should live, but in this PR it's being set up and called exclusively from React in
ui/(relevantshared/imports are types only).
| }, | ||
| "@tanstack/react-query>@tanstack/query-core": { | ||
| "globals": { | ||
| "document": false |
Contributor
There was a problem hiding this comment.
Suggested change
| "document": false | |
| "addEventListener": false, | |
| "document": false |
| }, | ||
| "@tanstack/react-query>use-sync-external-store": { | ||
| "globals": { | ||
| "__REACT_DEVTOOLS_GLOBAL_HOOK__": false |
Contributor
There was a problem hiding this comment.
Suggested change
| "__REACT_DEVTOOLS_GLOBAL_HOOK__": false | |
| "__REACT_DEVTOOLS_GLOBAL_HOOK__": false, | |
| "document": false, | |
| "document.createElement": true |
Contributor
Author
There was a problem hiding this comment.
Updated the policy-overrides @MajorLift @naugtur
Contributor
|
@metamaskbot update-policies |
hjetpoluru
previously approved these changes
Feb 19, 2026
NidhiKJha
previously approved these changes
Feb 19, 2026
Collaborator
|
No policy changes |
Contributor
Builds ready [37ddddc]
UI Startup Metrics (1346 ± 113 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [5a5b193]
UI Startup Metrics (1382 ± 103 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This reverts commit 5a5b193.
javiergarciavera
approved these changes
Feb 19, 2026
naugtur
reviewed
Feb 19, 2026
| "@tanstack/react-query>@tanstack/query-core": { | ||
| "globals": { | ||
| "addEventListener": false, | ||
| "document": false |
Contributor
There was a problem hiding this comment.
I recall previous PRs had the document visibility API field explicitly added here. It's probably unnecessary for an extension UI, but leaving a note for consistency.
naugtur
approved these changes
Feb 19, 2026
Contributor
naugtur
left a comment
There was a problem hiding this comment.
approving on behalf of @MetaMask/policy-reviewers
Contributor
Builds ready [69e6bf2]
UI Startup Metrics (1378 ± 103 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
hjetpoluru
approved these changes
Feb 19, 2026
vinnyhoward
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces a new Activity List component powered by a React Query hook to display historical EVM transaction history from the accounts v4 API. Updates list items to align with the new data source.
Context
The previous activity list was built on the accounts v1 API and did not have modern data-fetching patterns. This update improves data handling and enables smooth infinite scrolling.
Changelog
CHANGELOG entry: feat: activity view with infinite scroll
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Touches core Activity UI and introduces new background-driven, paginated network fetching (React Query + Accounts v4), which can affect transaction visibility/ordering and performance across networks. Most risk is mitigated by added mocks/tests, but regressions are possible in list merging/deduping and modal mapping.
Overview
Introduces Activity tab v2 by swapping the old activity view for a new
activity-v2list that virtualizes rendering, supports infinite scroll, and merges Accounts v4 API EVM history with local pending/submitted transactions and non-EVM transactions, including details modal support via a legacy-adapter.Adds a shared API client and React Query
querieslayer forGET /v4/multiaccount/transactions(bearer-token aware, locale-aware), wiresQueryClientProviderinto the app, Storybook, and test render helpers, and updates selectors/utilities (EVM address selection, enabled-network CAIP IDs, local tx filtering, market-rate lookup) plus extensive unit/e2e/integration test and mock updates. Also expands LavaMoat policies to allow the new@tanstack/react-querydependency and adds small formatter/unit helpers used by the new UI.Written by Cursor Bugbot for commit 69e6bf2. This will update automatically on new commits. Configure here.