feat: init the new assets controller package under FF by salimtb · Pull Request #39917 · MetaMask/metamask-extension

salimtb · 2026-02-09T14:53:12Z

Description

init the new assets controller package under a feature flag

Changelog

CHANGELOG entry: init the new assets controller under a feature flag

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches core controller initialization wiring and introduces new privileged messenger/action/event delegations plus new LavaMoat allowances; while feature-flagged, misconfiguration could impact startup or asset data fetching/auth token usage.

Overview
Introduces a new AssetsControllerInit that constructs @metamask/assets-controller with a cached createApiPlatformClient, token-detection preference wiring, and an isEnabled gate driven by the assetsUnifyState remote feature flag/version.

Wires the controller into modular controller initialization and the controller messenger registry, and conditionally initializes/exposes AssetsController from metamask-controller.js only when the flag is enabled. Adds new messenger plumbing + unit tests for both init/messenger behavior, updates controller type/state unions, and expands LavaMoat policies plus package.json/yarn.lock to include @metamask/assets-controller (and updated @metamask/core-backend deps such as @tanstack/query-core).

^{Written by Cursor Bugbot for commit 0ee26f6. This will update automatically on new commits. Configure here.}

salimtb · 2026-02-09T14:53:20Z

@metamaskbot update-policies

github-actions · 2026-02-09T14:53:24Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2026-02-09T14:54:12Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@metamask/assets-controller@1.0.0
	@metamask/core-backend@5.1.0

View full report

socket-security · 2026-02-09T14:54:14Z

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

@metamask/assets-controller@1.0.0
@tanstack/query-core@5.90.20
@metamask/core-backend@5.1.0

View full report

metamaskbotv2 · 2026-02-09T14:55:47Z

✨ Files requiring CODEOWNER review ✨

📜 @MetaMask/policy-reviewers (20 files, +708 -0)

📁 lavamoat/
- 📁 browserify/
  - 📁 beta/
    - 📄 policy.json +111 -0
  - 📁 experimental/
    - 📄 policy.json +111 -0
  - 📁 flask/
    - 📄 policy.json +111 -0
  - 📁 main/
    - 📄 policy.json +111 -0
    - 📄 policy-override.json +7 -0
- 📁 build-system/
  - 📄 policy-override.json +7 -0
  - 📄 policy.json +7 -0
- 📁 webpack/
  - 📁 build/
    - 📄 policy-override.json +7 -0
    - 📄 policy.json +7 -0
  - 📁 mv2/
    - 📁 beta/
      - 📄 policy-override.json +7 -0
      - 📄 policy.json +45 -0
    - 📁 experimental/
      - 📄 policy-override.json +7 -0
      - 📄 policy.json +45 -0
    - 📁 flask/
      - 📄 policy-override.json +7 -0
      - 📄 policy.json +45 -0
    - 📁 main/
      - 📄 policy-override.json +7 -0
      - 📄 policy.json +45 -0
  - 📁 mv3/
    - 📁 beta/
      - 📄 policy-override.json +7 -0
    - 📁 experimental/
      - 📄 policy-override.json +7 -0
    - 📁 flask/
      - 📄 policy-override.json +7 -0

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

metamaskbot · 2026-02-09T15:04:34Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

👀 lavamoat/browserify/beta/policy.json changes differ from main/policy.json policy changes
👀 lavamoat/browserify/experimental/policy.json changes differ from main/policy.json policy changes
👀 lavamoat/browserify/flask/policy.json changes differ from main/policy.json policy changes
👀 lavamoat/webpack/mv2/beta/policy.json changes differ from mv2/main/policy.json policy changes
👀 lavamoat/webpack/mv2/experimental/policy.json changes differ from mv2/main/policy.json policy changes
👀 lavamoat/webpack/mv2/flask/policy.json changes differ from mv2/main/policy.json policy changes
✅ lavamoat/webpack/mv3/beta/policy.json changes match mv3/main/policy.json policy changes
✅ lavamoat/webpack/mv3/experimental/policy.json changes match mv3/main/policy.json policy changes
✅ lavamoat/webpack/mv3/flask/policy.json changes match mv3/main/policy.json policy changes

app/scripts/controller-init/messengers/assets/assets-controller-messenger.ts

salimtb · 2026-02-09T17:11:11Z

@metamaskbot update-policies

metamaskbot · 2026-02-09T17:18:35Z

Policy update failed. You can review the logs or retry the policy update here

salimtb · 2026-02-09T17:20:24Z

@metamaskbot update-policies

metamaskbot · 2026-02-09T17:37:07Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

👀 lavamoat/browserify/beta/policy.json changes differ from main/policy.json policy changes
👀 lavamoat/browserify/experimental/policy.json changes differ from main/policy.json policy changes
👀 lavamoat/browserify/flask/policy.json changes differ from main/policy.json policy changes
👀 lavamoat/webpack/mv2/beta/policy.json changes differ from mv2/main/policy.json policy changes
👀 lavamoat/webpack/mv2/experimental/policy.json changes differ from mv2/main/policy.json policy changes
👀 lavamoat/webpack/mv2/flask/policy.json changes differ from mv2/main/policy.json policy changes
✅ lavamoat/webpack/mv3/beta/policy.json changes match mv3/main/policy.json policy changes
✅ lavamoat/webpack/mv3/experimental/policy.json changes match mv3/main/policy.json policy changes
✅ lavamoat/webpack/mv3/flask/policy.json changes match mv3/main/policy.json policy changes

metamaskbotv2 · 2026-02-09T18:30:06Z

Builds ready [9b130a6]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
lavamoat build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

UI Startup Metrics (1348 ± 102 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1348	1173	1795	102	1404	1501
			load	1170	989	1499	92	1218	1316
			domContentLoaded	1164	985	1490	91	1214	1308
			domInteractive	27	16	123	19	23	70
			firstPaint	134	64	426	71	191	244
			backgroundConnect	235	213	283	12	243	258
			firstReactRender	15	10	69	6	16	19
			initialActions	3	0	174	17	1	3
			loadScripts	943	769	1249	90	991	1101
			setupStore	12	7	25	4	16	22
			numNetworkReqs	22	14	90	21	15	83
	Browserify	Power User Home	uiStartup	2571	1408	10329	1914	2276	4892
			load	1208	1010	1970	159	1245	1530
			domContentLoaded	1189	1001	1892	153	1233	1500
			domInteractive	35	19	264	37	30	60
			firstPaint	207	73	1290	141	256	354
			backgroundConnect	959	287	8490	1701	426	2957
			firstReactRender	23	15	45	5	24	33
			initialActions	1	0	3	1	1	2
			loadScripts	951	765	1653	148	995	1252
			setupStore	15	6	48	8	17	35
			numNetworkReqs	113	50	256	40	136	178
	Webpack	Standard Home	uiStartup	847	687	1149	97	930	983
			load	740	616	1074	98	815	897
			domContentLoaded	735	612	1070	98	806	892
			domInteractive	26	16	94	18	23	77
			firstPaint	111	62	353	58	137	223
			backgroundConnect	25	17	48	7	28	38
			firstReactRender	14	9	44	5	16	22
			initialActions	1	0	5	1	1	2
			loadScripts	732	610	1068	97	799	885
			setupStore	11	6	32	5	12	21
			numNetworkReqs	23	14	100	23	15	87
	Webpack	Power User Home	uiStartup	1259	934	2791	310	1291	1891
			load	724	623	1258	122	717	1038
			domContentLoaded	714	617	1250	122	708	1025
			domInteractive	38	18	223	34	35	109
			firstPaint	144	65	506	82	169	304
			backgroundConnect	169	131	630	72	163	289
			firstReactRender	21	16	37	3	23	27
			initialActions	1	0	3	1	1	1
			loadScripts	711	615	1241	120	706	1014
			setupStore	12	5	41	5	15	18
			numNetworkReqs	133	47	279	47	158	211
Firefox	Browserify	Standard Home	uiStartup	1560	1360	2368	172	1606	1914
			load	1345	1175	1759	126	1406	1635
			domContentLoaded	1344	1169	1758	126	1406	1635
			domInteractive	72	34	235	42	96	142
			firstPaint	-	-	-	-	-	-
			backgroundConnect	56	28	186	22	59	97
			firstReactRender	12	9	17	1	12	13
			initialActions	1	0	2	0	1	2
			loadScripts	1320	1159	1724	122	1381	1586
			setupStore	16	6	181	24	14	41
			numNetworkReqs	23	12	97	22	16	84
	Browserify	Power User Home	uiStartup	2798	2074	7719	637	2919	3559
			load	1582	1268	6380	558	1576	2060
			domContentLoaded	1582	1268	6380	558	1573	2059
			domInteractive	164	34	1557	189	149	431
			firstPaint	-	-	-	-	-	-
			backgroundConnect	386	109	1322	311	528	967
			firstReactRender	17	14	35	3	18	22
			initialActions	1	0	3	1	2	2
			loadScripts	1539	1234	6340	553	1540	1993
			setupStore	120	7	760	167	132	546
			numNetworkReqs	83	38	166	34	108	147
	Webpack	Standard Home	uiStartup	1586	1340	3340	242	1595	2024
			load	1374	1176	3113	198	1408	1540
			domContentLoaded	1373	1176	3113	198	1404	1540
			domInteractive	101	31	1924	189	122	146
			firstPaint	-	-	-	-	-	-
			backgroundConnect	54	27	270	37	52	125
			firstReactRender	14	11	25	2	14	18
			initialActions	1	0	4	1	2	2
			loadScripts	1348	1163	3099	197	1379	1504
			setupStore	21	7	219	40	12	65
			numNetworkReqs	23	11	86	20	16	80
	Webpack	Power User Home	uiStartup	2873	2076	8579	703	3020	3567
			load	1614	1309	6825	563	1675	1997
			domContentLoaded	1614	1304	6825	563	1675	1996
			domInteractive	158	33	772	146	160	473
			firstPaint	-	-	-	-	-	-
			backgroundConnect	432	117	1451	335	513	1224
			firstReactRender	23	15	73	10	25	32
			initialActions	2	1	7	1	2	3
			loadScripts	1570	1283	6778	560	1620	1969
			setupStore	179	11	880	202	271	632
			numNetworkReqs	82	37	219	37	100	148

📊 Page Load Benchmark Results

Current Commit: 9b130a6 | Date: 2/9/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±53ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 731ms (±51ms) 🟢 | historical mean value: 717ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±11ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	53ms	1.01s	1.35s	1.09s	1.35s
domContentLoaded	731ms	51ms	702ms	1.03s	756ms	1.03s
firstPaint	78ms	11ms	60ms	172ms	84ms	172ms
firstContentfulPaint	78ms	11ms	60ms	172ms	84ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 296.99 KiB (7.41%)
ui: 179 Bytes (0%)
common: 170 Bytes (0%)

metamaskbotv2 · 2026-02-11T10:54:44Z

Builds ready [bc34b60]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
lavamoat build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

UI Startup Metrics (1415 ± 114 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1415	1186	1881	114	1475	1586
			load	1219	1002	1619	100	1280	1376
			domContentLoaded	1213	998	1611	99	1274	1358
			domInteractive	28	16	134	20	24	85
			firstPaint	169	70	1345	137	213	263
			backgroundConnect	251	227	462	26	256	285
			firstReactRender	16	11	36	4	18	26
			initialActions	1	0	9	1	1	3
			loadScripts	978	772	1348	97	1038	1131
			setupStore	14	7	197	19	14	19
			numNetworkReqs	22	14	87	21	15	83
	Browserify	Power User Home	uiStartup	3310	1629	10874	1898	4029	6542
			load	1224	1071	1738	117	1252	1484
			domContentLoaded	1208	1047	1728	113	1243	1445
			domInteractive	33	19	166	20	34	60
			firstPaint	194	80	316	75	258	295
			backgroundConnect	1104	298	4916	996	1535	3200
			firstReactRender	23	15	50	7	24	37
			initialActions	1	0	3	1	1	2
			loadScripts	968	814	1444	105	994	1208
			setupStore	13	5	39	7	15	23
			numNetworkReqs	90	44	161	25	110	127
	Webpack	Standard Home	uiStartup	836	694	1124	93	882	1003
			load	720	609	920	89	778	897
			domContentLoaded	714	603	915	89	773	890
			domInteractive	26	16	112	19	23	77
			firstPaint	114	60	842	90	120	238
			backgroundConnect	26	18	52	8	30	41
			firstReactRender	14	10	33	4	17	22
			initialActions	1	0	4	1	1	2
			loadScripts	712	601	913	88	771	885
			setupStore	12	5	37	6	12	26
			numNetworkReqs	22	14	100	22	15	84
	Webpack	Power User Home	uiStartup	1334	948	2267	251	1401	1907
			load	779	671	1230	111	795	1057
			domContentLoaded	767	656	1214	111	780	1048
			domInteractive	41	20	208	31	38	104
			firstPaint	181	75	1233	138	222	339
			backgroundConnect	178	137	621	68	171	302
			firstReactRender	22	17	35	3	23	28
			initialActions	1	0	2	1	1	2
			loadScripts	764	654	1205	109	778	1036
			setupStore	14	5	44	8	17	22
			numNetworkReqs	143	65	259	37	160	206
Firefox	Browserify	Standard Home	uiStartup	1533	1329	2217	168	1554	1911
			load	1332	1124	1930	137	1378	1600
			domContentLoaded	1330	1123	1929	138	1376	1600
			domInteractive	72	33	198	38	96	137
			firstPaint	-	-	-	-	-	-
			backgroundConnect	55	29	166	22	57	91
			firstReactRender	12	9	26	2	12	14
			initialActions	1	0	3	1	1	2
			loadScripts	1307	1108	1899	134	1352	1564
			setupStore	14	6	172	19	13	33
			numNetworkReqs	23	12	101	22	16	87
	Browserify	Power User Home	uiStartup	2782	2094	3629	371	3019	3505
			load	1530	1267	2538	215	1597	1964
			domContentLoaded	1530	1267	2538	215	1597	1959
			domInteractive	178	53	1180	161	201	424
			firstPaint	-	-	-	-	-	-
			backgroundConnect	413	125	1220	251	572	896
			firstReactRender	19	14	66	8	18	28
			initialActions	2	0	3	1	2	2
			loadScripts	1482	1245	2508	207	1525	1911
			setupStore	159	15	751	173	251	467
			numNetworkReqs	95	49	204	32	109	160
	Webpack	Standard Home	uiStartup	1629	1403	2155	148	1661	1936
			load	1405	1223	1783	100	1454	1581
			domContentLoaded	1404	1223	1783	100	1454	1581
			domInteractive	93	30	237	49	130	166
			firstPaint	-	-	-	-	-	-
			backgroundConnect	59	23	213	33	63	131
			firstReactRender	14	11	27	3	14	20
			initialActions	1	0	3	0	1	2
			loadScripts	1377	1175	1671	94	1431	1550
			setupStore	19	6	216	30	13	63
			numNetworkReqs	23	12	92	20	17	79
	Webpack	Power User Home	uiStartup	2900	2234	8267	785	3025	3679
			load	1652	1255	6753	722	1619	2208
			domContentLoaded	1652	1255	6753	721	1619	2207
			domInteractive	188	51	845	177	173	665
			firstPaint	-	-	-	-	-	-
			backgroundConnect	531	111	1417	305	736	1055
			firstReactRender	22	15	67	8	24	29
			initialActions	2	1	7	1	2	3
			loadScripts	1606	1238	6712	720	1558	2140
			setupStore	129	16	700	140	127	415
			numNetworkReqs	95	40	229	46	91	210

📊 Page Load Benchmark Results

Current Commit: bc34b60 | Date: 2/11/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±42ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 727ms (±39ms) 🟢 | historical mean value: 721ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±14ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	42ms	1.02s	1.39s	1.07s	1.39s
domContentLoaded	727ms	39ms	704ms	1.05s	755ms	1.05s
firstPaint	77ms	14ms	60ms	196ms	88ms	196ms
firstContentfulPaint	77ms	14ms	60ms	196ms	88ms	196ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 296.67 KiB (7.4%)
ui: 7.5 KiB (0.09%)
common: 2.31 KiB (0.02%)

naugtur

Approving policy and verrides on behalf of @MetaMask/policy-reviewers

salimtb · 2026-02-11T14:06:56Z

lavamoat/browserify/beta/policy.json

        "nanoid": true
      }
    },
+    "@metamask/assets-controller": {


we're introducing a new package here

salimtb · 2026-02-11T14:07:16Z

lavamoat/browserify/beta/policy.json

        "@metamask/snaps-utils>validate-npm-package-name": true
      }
    },
+    "@metamask/assets-controller>@metamask/snaps-utils": {


snaps-utils version has changed

salimtb · 2026-02-11T14:07:36Z

lavamoat/browserify/beta/policy.json

        "browserify>browser-resolve": true
      }
    },
+    "@metamask/core-backend>@tanstack/query-core": {


we use tanstack query on the new package

salimtb · 2026-02-11T14:07:51Z

lavamoat/browserify/beta/policy.json

        "define": true
      }
    },
+    "@metamask/assets-controller>bignumber.js": {


we use bignumber js on the new package

salimtb · 2026-02-11T14:16:11Z

LavaMoat policy.json differences (beta / flask / experimental vs main)

TL;DR: The differences between variant policy.json files (e.g. lavamoat/browserify/beta/policy.json vs lavamoat/browserify/main/policy.json) are not introduced by this PR. They come from how LavaMoat generates policy per build variant. This PR only adds overrides in policy-override.json.

What this PR changes

policy-override.json only: added/updated the override for @metamask/core-backend>@tanstack/query-core with:
- document: false
- document.visibilityState: true
- addEventListener: false
Those overrides are applied in the same way in every variant’s override file (browserify, webpack mv2/mv3, main/beta/flask/experimental).

Why variant policy.json files differ

policy.json is generated by LavaMoat per build variant (main, beta, flask, experimental).
Each variant has its own build and scan, so the generated policy content and structure can differ (different packages, different globals).
That’s expected and pre-existing; it’s not caused by this PR.
This PR does not edit the generated policy.json files; it only edits policy-override.json.

Summary

Item	This PR
policy-override.json	✅ Updated (override for query-core)
policy.json (main vs beta/flask/experimental)	❌ Not changed; existing per-variant differences remain

So when the bot says “policy.json changes differ from main,” that refers to the existing difference between each variant’s generated policy and main’s, not to new inconsistencies introduced here.

Kriys94

I have few small changes in mind but I will tackle them in another PR

hjetpoluru

Hi @salimtb, could you address the comments from the CursorBot and it could break some other tests.

test/e2e/fixtures/onboarding-fixture.json

test/e2e/tests/metrics/state-snapshots/errors-before-init-opt-in-ui-state.json

naugtur

re-approving the same policy diff on behalf of @MetaMask/policy-reviewers

metamaskbotv2 · 2026-02-11T15:34:02Z

Builds ready [0ee26f6]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
lavamoat build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

UI Startup Metrics (1382 ± 92 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1382	1173	1650	92	1449	1515
			load	1199	1001	1410	87	1261	1339
			domContentLoaded	1191	993	1402	88	1256	1335
			domInteractive	27	16	95	18	23	79
			firstPaint	146	65	1108	118	193	228
			backgroundConnect	242	217	401	23	247	275
			firstReactRender	16	10	45	5	18	26
			initialActions	1	0	5	1	1	3
			loadScripts	964	773	1169	86	1028	1091
			setupStore	14	6	164	16	15	25
			numNetworkReqs	23	15	90	20	15	80
	Browserify	Power User Home	uiStartup	2322	1463	10073	1290	2249	4789
			load	1246	1090	2198	184	1283	1677
			domContentLoaded	1228	1075	2187	180	1276	1631
			domInteractive	40	20	177	29	39	113
			firstPaint	217	73	1597	171	279	362
			backgroundConnect	647	291	7670	1018	371	2542
			firstReactRender	23	16	66	7	25	34
			initialActions	1	0	4	1	1	1
			loadScripts	976	830	1926	174	1016	1352
			setupStore	17	7	60	8	18	31
			numNetworkReqs	119	48	238	45	147	214
	Webpack	Standard Home	uiStartup	806	685	1034	82	857	957
			load	701	602	878	79	758	852
			domContentLoaded	695	598	873	78	753	840
			domInteractive	25	15	89	18	22	78
			firstPaint	112	59	379	60	145	202
			backgroundConnect	25	18	54	6	28	39
			firstReactRender	14	10	25	4	17	20
			initialActions	1	0	3	1	1	2
			loadScripts	693	596	870	77	751	837
			setupStore	11	6	38	5	11	20
			numNetworkReqs	23	15	98	21	15	82
	Webpack	Power User Home	uiStartup	1208	868	2353	197	1269	1541
			load	702	587	1126	105	705	976
			domContentLoaded	691	579	1120	105	693	965
			domInteractive	35	19	165	27	33	108
			firstPaint	142	63	344	69	188	273
			backgroundConnect	167	139	384	41	162	217
			firstReactRender	22	16	47	5	23	31
			initialActions	1	0	5	1	1	1
			loadScripts	688	578	1113	103	691	953
			setupStore	11	4	22	4	13	18
			numNetworkReqs	135	53	284	48	158	200
Firefox	Browserify	Standard Home	uiStartup	1587	1367	2328	212	1622	2050
			load	1367	1172	2100	178	1402	1661
			domContentLoaded	1365	1166	2093	178	1397	1661
			domInteractive	72	34	306	52	86	172
			firstPaint	-	-	-	-	-	-
			backgroundConnect	55	28	173	23	57	96
			firstReactRender	12	10	23	2	13	15
			initialActions	1	0	2	0	1	2
			loadScripts	1342	1148	2068	174	1378	1619
			setupStore	13	6	60	9	13	29
			numNetworkReqs	24	14	94	21	17	87
	Browserify	Power User Home	uiStartup	2649	2078	4284	356	2732	3374
			load	1501	1188	2324	211	1554	2013
			domContentLoaded	1501	1187	2324	211	1554	2013
			domInteractive	131	35	564	108	126	410
			firstPaint	-	-	-	-	-	-
			backgroundConnect	341	104	1087	285	409	954
			firstReactRender	18	14	64	8	17	22
			initialActions	1	0	7	1	2	2
			loadScripts	1465	1159	2294	206	1526	1957
			setupStore	140	8	787	197	136	676
			numNetworkReqs	76	39	148	32	101	134
	Webpack	Standard Home	uiStartup	1637	1311	2263	148	1687	1938
			load	1410	1191	1712	112	1461	1636
			domContentLoaded	1409	1191	1712	112	1456	1636
			domInteractive	82	28	231	44	117	158
			firstPaint	-	-	-	-	-	-
			backgroundConnect	55	22	157	28	60	134
			firstReactRender	15	11	53	5	15	21
			initialActions	1	0	3	1	2	2
			loadScripts	1381	1173	1657	105	1434	1567
			setupStore	15	6	82	14	13	46
			numNetworkReqs	24	13	86	19	18	78
	Webpack	Power User Home	uiStartup	2664	1971	4276	419	2852	3447
			load	1509	1211	3128	290	1558	2098
			domContentLoaded	1508	1210	3128	290	1558	2097
			domInteractive	141	30	823	144	125	455
			firstPaint	-	-	-	-	-	-
			backgroundConnect	302	112	1406	247	349	880
			firstReactRender	21	15	59	7	23	32
			initialActions	2	0	7	1	2	3
			loadScripts	1459	1164	3099	260	1525	1858
			setupStore	167	8	797	218	195	706
			numNetworkReqs	77	39	216	35	99	138

📊 Page Load Benchmark Results

Current Commit: 0ee26f6 | Date: 2/11/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±77ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 738ms (±75ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	77ms	1.00s	1.32s	1.30s	1.32s
domContentLoaded	738ms	75ms	695ms	1.01s	971ms	1.01s
firstPaint	77ms	12ms	60ms	184ms	84ms	184ms
firstContentfulPaint	77ms	12ms	60ms	184ms	84ms	184ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 297.66 KiB (7.43%)
ui: 7.53 KiB (0.09%)
common: 3.55 KiB (0.03%)

salimtb temporarily deployed to pr-comment February 9, 2026 14:53 — with GitHub Actions Inactive

metamaskbot added the team-assets label Feb 9, 2026

github-actions bot added the size-L label Feb 9, 2026

metamaskbot temporarily deployed to pr-comment February 9, 2026 15:04 — with GitHub Actions Inactive

metamaskbot had a problem deploying to pr-comment February 9, 2026 15:18 — with GitHub Actions Failure

metamaskbot had a problem deploying to pr-comment February 9, 2026 15:19 — with GitHub Actions Failure

salimtb temporarily deployed to pr-comment February 9, 2026 15:48 — with GitHub Actions Inactive

salimtb had a problem deploying to pr-comment February 9, 2026 16:02 — with GitHub Actions Failure

salimtb had a problem deploying to pr-comment February 9, 2026 16:03 — with GitHub Actions Failure

salimtb temporarily deployed to pr-comment February 9, 2026 16:05 — with GitHub Actions Inactive

salimtb had a problem deploying to pr-comment February 9, 2026 16:20 — with GitHub Actions Failure

Kriys94 reviewed Feb 9, 2026

View reviewed changes

app/scripts/controller-init/messengers/assets/assets-controller-messenger.ts Outdated Show resolved Hide resolved

Kriys94 reviewed Feb 9, 2026

View reviewed changes

app/scripts/controller-init/messengers/assets/assets-controller-messenger.ts Outdated Show resolved Hide resolved

salimtb temporarily deployed to pr-comment February 9, 2026 17:20 — with GitHub Actions Inactive

metamaskbot temporarily deployed to pr-comment February 9, 2026 17:37 — with GitHub Actions Inactive

salimtb temporarily deployed to pr-comment February 9, 2026 17:41 — with GitHub Actions Inactive

salimtb temporarily deployed to pr-comment February 9, 2026 17:55 — with GitHub Actions Inactive

salimtb temporarily deployed to pr-comment February 9, 2026 18:25 — with GitHub Actions Inactive

metamaskbot temporarily deployed to pr-comment February 11, 2026 10:50 — with GitHub Actions Inactive

salimtb requested a review from naugtur February 11, 2026 13:16

naugtur previously approved these changes Feb 11, 2026

View reviewed changes

salimtb commented Feb 11, 2026

View reviewed changes

Kriys94 previously approved these changes Feb 11, 2026

View reviewed changes

hjetpoluru reviewed Feb 11, 2026

View reviewed changes

test/e2e/fixtures/onboarding-fixture.json Outdated Show resolved Hide resolved

test/e2e/tests/metrics/state-snapshots/errors-before-init-opt-in-ui-state.json Outdated Show resolved Hide resolved

fix: fix PR comments

fb22122

salimtb dismissed stale reviews from Kriys94 and naugtur via fb22122 February 11, 2026 14:45

salimtb had a problem deploying to pr-comment February 11, 2026 14:46 — with GitHub Actions Error

fix: fix PR comments

0ee26f6

salimtb temporarily deployed to pr-comment February 11, 2026 14:48 — with GitHub Actions Inactive

salimtb requested review from Kriys94 and naugtur February 11, 2026 15:23

naugtur approved these changes Feb 11, 2026

View reviewed changes

salimtb temporarily deployed to pr-comment February 11, 2026 15:29 — with GitHub Actions Inactive

salimtb enabled auto-merge February 11, 2026 15:56

Kriys94 approved these changes Feb 11, 2026

View reviewed changes

salimtb added this pull request to the merge queue Feb 11, 2026

Merged via the queue into main with commit c1e8825 Feb 11, 2026
176 checks passed

salimtb deleted the feat/init-new-assets-controller-package branch February 11, 2026 16:30

github-actions bot locked and limited conversation to collaborators Feb 11, 2026

metamaskbot added the release-13.19.0 Issue or pull request that will be included in release 13.19.0 label Feb 11, 2026

Conversation

salimtb commented Feb 9, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

salimtb commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

socket-security bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbotv2 bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Feb 9, 2026

Uh oh!

Uh oh!

Uh oh!

salimtb commented Feb 9, 2026

Uh oh!

metamaskbot commented Feb 9, 2026

Uh oh!

salimtb commented Feb 9, 2026

Uh oh!

metamaskbot commented Feb 9, 2026

Uh oh!

metamaskbotv2 bot commented Feb 9, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Feb 11, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

naugtur left a comment

Choose a reason for hiding this comment

Uh oh!

salimtb Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

salimtb Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

salimtb Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

salimtb Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

salimtb commented Feb 11, 2026

LavaMoat policy.json differences (beta / flask / experimental vs main)

What this PR changes

Why variant policy.json files differ

Summary

Uh oh!

Kriys94 left a comment

Choose a reason for hiding this comment

Uh oh!

hjetpoluru left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

naugtur left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbotv2 bot commented Feb 11, 2026

salimtb commented Feb 9, 2026 •

edited by cursor bot

Loading

socket-security bot commented Feb 9, 2026 •

edited

Loading

socket-security bot commented Feb 9, 2026 •

edited

Loading

metamaskbotv2 bot commented Feb 9, 2026 •

edited

Loading