chore: normalize no-data states in token list#39912
Merged
Conversation
ui/components/multichain/token-list-item/price/percentage-change/percentage-change.tsx
Show resolved
Hide resolved
Contributor
Builds ready [a6cdd87]
UI Startup Metrics (1415 ± 92 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ui/components/app/assets/token-cell/cells/token-cell-secondary-display.tsx
Outdated
Show resolved
Hide resolved
Contributor
Builds ready [4b9f0c6]
UI Startup Metrics (1354 ± 101 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ui/components/multichain/token-list-item/price/percentage-change/percentage-change.tsx
Show resolved
Hide resolved
Contributor
Builds ready [bdedc9f]
UI Startup Metrics (1353 ± 89 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Contributor
Builds ready [e6d0506]
UI Startup Metrics (1378 ± 108 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Contributor
Builds ready [c96feac]
UI Startup Metrics (1542 ± 151 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
sahar-fehri
approved these changes
Feb 10, 2026
Prithpal-Sooriya
approved these changes
Feb 10, 2026
Unik0rnMaggie
approved these changes
Feb 11, 2026
NidhiKJha
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When we don’t have pricing data, we currently show “No conversion rate available”, which is overly verbose and makes the UI feel unpolished. We have changed it to show dashes like on Mobile/Trending
Changelog
CHANGELOG entry: standardize display of unavailable data in tokens list
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-2565
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Primarily UI text/placeholder and test updates with no changes to pricing logic or state management; minor risk is missed expectations in downstream tests or translations due to removed i18n keys.
Overview
Standardizes token list no pricing data states by replacing the verbose "No conversion rate available" message with a compact em dash ("—") placeholder.
This removes the
noConversionRateAvailablei18n string across locales and updates token list UI/tests (includingTokenCellSecondaryDisplayandPercentageChange) plus e2e selectors/snapshots to expect the new placeholders. Unused legacy componentsTokenInputandUserPreferencedTokenInput(and their tests/stories) are deleted and related baseline entries are cleaned up.Written by Cursor Bugbot for commit c96feac. This will update automatically on new commits. Configure here.