Skip to content

chore: normalize no-data states in token list#39912

Merged
juanmigdr merged 8 commits intomainfrom
chore/normalize-no-conversion-rate-format-token-list
Feb 11, 2026
Merged

chore: normalize no-data states in token list#39912
juanmigdr merged 8 commits intomainfrom
chore/normalize-no-conversion-rate-format-token-list

Conversation

@juanmigdr
Copy link
Copy Markdown
Member

@juanmigdr juanmigdr commented Feb 9, 2026

Description

When we don’t have pricing data, we currently show “No conversion rate available”, which is overly verbose and makes the UI feel unpolished. We have changed it to show dashes like on Mobile/Trending

Open in GitHub Codespaces

Changelog

CHANGELOG entry: standardize display of unavailable data in tokens list

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-2565

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Primarily UI text/placeholder and test updates with no changes to pricing logic or state management; minor risk is missed expectations in downstream tests or translations due to removed i18n keys.

Overview
Standardizes token list no pricing data states by replacing the verbose "No conversion rate available" message with a compact em dash ("—") placeholder.

This removes the noConversionRateAvailable i18n string across locales and updates token list UI/tests (including TokenCellSecondaryDisplay and PercentageChange) plus e2e selectors/snapshots to expect the new placeholders. Unused legacy components TokenInput and UserPreferencedTokenInput (and their tests/stories) are deleted and related baseline entries are cleaned up.

Written by Cursor Bugbot for commit c96feac. This will update automatically on new commits. Configure here.

@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Feb 9, 2026

Builds ready [a6cdd87]
UI Startup Metrics (1415 ± 92 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1415123517509214691549
load1211101014459112771337
domContentLoaded1204100514409212701330
domInteractive281698192382
firstPaint1556736165202286
backgroundConnect24121829917242278
firstReactRender17113941925
initialActions105113
loadScripts98076611789510481106
setupStore1263151422
numNetworkReqs221584201581
BrowserifyPower User HomeuiStartup286615209581181638327386
load12611066173015713471573
domContentLoaded12441045172315713151567
domInteractive41173234634114
firstPaint1927755097254352
backgroundConnect11062897519156415793029
firstReactRender24174972638
initialActions109112
loadScripts1000820145114610601301
setupStore16785102029
numNetworkReqs1084920835128177
WebpackStandard HomeuiStartup8246601027908691000
load69259594082748845
domContentLoaded68759193381738840
domInteractive251686172276
firstPaint1005922644114191
backgroundConnect3717168273791
firstReactRender15103151727
initialActions105112
loadScripts68459093180736834
setupStore1153751221
numNetworkReqs2315100211584
WebpackPower User HomeuiStartup1276871272530813171869
load74062313801327461062
domContentLoaded72861413731337241048
domInteractive39181542935124
firstPaint166721058129190303
backgroundConnect188130890123157373
firstReactRender21173332327
initialActions101011
loadScripts72561213651317211039
setupStore1243151419
numNetworkReqs1446025239161217
FirefoxBrowserifyStandard HomeuiStartup17181399247520818542069
load14351173198115615541658
domContentLoaded14341173198115715531657
domInteractive75331874097140
firstPaint------
backgroundConnect832823351108197
firstReactRender13111811315
initialActions103022
loadScripts13861148184913214561608
setupStore2142763813114
numNetworkReqs241298211884
BrowserifyPower User HomeuiStartup285720967911100228993791
load16471187618385515742054
domContentLoaded16461187618385515742054
domInteractive14134691105152336
firstPaint------
backgroundConnect3681171353288416938
firstReactRender17143231722
initialActions102122
loadScripts16021143614885415232018
setupStore1658858189237641
numNetworkReqs904218032109161
WebpackStandard HomeuiStartup15431328190213816431804
load1330113515959913931480
domContentLoaded1330113515959913921480
domInteractive70261443695131
firstPaint------
backgroundConnect64191543782135
firstReactRender13102421419
initialActions102012
loadScripts1294112114928613591448
setupStore134116141142
numNetworkReqs231379171869
WebpackPower User HomeuiStartup26571886480746028793449
load14951236377929315921880
domContentLoaded14951236377829215921880
domInteractive149311379169144456
firstPaint------
backgroundConnect42611314203255651113
firstReactRender20154252228
initialActions2111123
loadScripts14491216373828415101774
setupStore1339785179127600
numNetworkReqs844120434101153
📊 Page Load Benchmark Results

Current Commit: a6cdd87 | Date: 2/9/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±38ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 731ms (±36ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±12ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 38ms 1.02s 1.33s 1.08s 1.33s
domContentLoaded 731ms 36ms 706ms 996ms 755ms 996ms
firstPaint 78ms 12ms 60ms 184ms 84ms 184ms
firstContentfulPaint 78ms 12ms 60ms 184ms 84ms 184ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 513 Bytes (0.01%)
  • common: 530 Bytes (0%)

@juanmigdr juanmigdr requested a review from a team as a code owner February 9, 2026 15:34
@juanmigdr juanmigdr enabled auto-merge February 9, 2026 15:37
@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Feb 9, 2026

Builds ready [4b9f0c6]
UI Startup Metrics (1354 ± 101 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup13541166165410114141523
load117197814159312311313
domContentLoaded116597314109312251308
domInteractive271594172470
firstPaint1486733268204249
backgroundConnect23621831215237267
firstReactRender17104562028
initialActions1010213
loadScripts94475511879210031087
setupStore1274051519
numNetworkReqs231590201582
BrowserifyPower User HomeuiStartup2866151210615202838938019
load12191044177915512521607
domContentLoaded12011028176414912331582
domInteractive37202083333107
firstPaint207711201171250407
backgroundConnect1066286818916555972802
firstReactRender24155772633
initialActions101011
loadScripts96480114941409941322
setupStore1373151523
numNetworkReqs1164625542146182
WebpackStandard HomeuiStartup791649104091841978
load68958494083736840
domContentLoaded68558093483731833
domInteractive251597182273
firstPaint1025721241124178
backgroundConnect25177092738
firstReactRender1393641520
initialActions103112
loadScripts68257893282729829
setupStore1052941019
numNetworkReqs231588201583
WebpackPower User HomeuiStartup1194840240326512481724
load7025891116105703924
domContentLoaded6925841105106694915
domInteractive3517188263292
firstPaint15460929102183279
backgroundConnect16813937344163269
firstReactRender21163432327
initialActions102111
loadScripts6895821098105692909
setupStore1142031215
numNetworkReqs1364528341157206
FirefoxBrowserifyStandard HomeuiStartup15681393214815915981902
load13461194175511913881597
domContentLoaded13451194174811913881592
domInteractive803623947111146
firstPaint------
backgroundConnect59311922558112
firstReactRender12101921315
initialActions102122
loadScripts13181171172611213551533
setupStore176145231362
numNetworkReqs241298221786
BrowserifyPower User HomeuiStartup27892136403735830293373
load15101281218316115751828
domContentLoaded15101281218316115751828
domInteractive15441662117164429
firstPaint------
backgroundConnect45211717023196561054
firstReactRender18154942024
initialActions103122
loadScripts14701258207115515041791
setupStore13014773162140530
numNetworkReqs1083722442134178
WebpackStandard HomeuiStartup16231389209514216601904
load1391120717219314411537
domContentLoaded1390120717149314401537
domInteractive952823847130168
firstPaint------
backgroundConnect60272473362105
firstReactRender1610118111520
initialActions102122
loadScripts1364118716999114161508
setupStore186166281360
numNetworkReqs231288191880
WebpackPower User HomeuiStartup28062101859272629913476
load16031224728565816142274
domContentLoaded16021224728465816142274
domInteractive209441439235257657
firstPaint------
backgroundConnect40911813743055531038
firstReactRender21157392231
initialActions204122
loadScripts15581204714964915402243
setupStore14414724163163490
numNetworkReqs873721836106149
📊 Page Load Benchmark Results

Current Commit: 4b9f0c6 | Date: 2/9/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±61ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 721ms (±58ms) 🟢 | historical mean value: 719ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±12ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 61ms 1.00s 1.30s 1.24s 1.30s
domContentLoaded 721ms 58ms 694ms 991ms 917ms 991ms
firstPaint 75ms 12ms 56ms 180ms 84ms 180ms
firstContentfulPaint 75ms 12ms 56ms 180ms 84ms 180ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -68.56 KiB (-1.69%)
  • ui: 514 Bytes (0.01%)
  • common: 4.48 KiB (0.04%)

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Feb 10, 2026

Builds ready [bdedc9f]
UI Startup Metrics (1353 ± 89 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1353115915908913941526
load116298413818312131312
domContentLoaded115797813738312071304
domInteractive261696182374
firstPaint159651190126208276
backgroundConnect23421434717237263
firstReactRender1582731620
initialActions106113
loadScripts9387571150829821086
setupStore1162841319
numNetworkReqs231589201582
BrowserifyPower User HomeuiStartup17361419254214617742027
load11611041221816111411530
domContentLoaded11451035210915311251501
domInteractive3719230333464
firstPaint185712124208228286
backgroundConnect32329543421331361
firstReactRender21154852328
initialActions102111
loadScripts90279217781448831232
setupStore1564761724
numNetworkReqs1114726039139168
WebpackStandard HomeuiStartup83667611231048861050
load71660494586778872
domContentLoaded71159992985773868
domInteractive261689182378
firstPaint1066024649128218
backgroundConnect2618115112838
firstReactRender15103651721
initialActions104112
loadScripts70859791884771864
setupStore1173341218
numNetworkReqs231598211584
WebpackPower User HomeuiStartup1194877170815212821495
load7006151152107691989
domContentLoaded6916081147106681983
domInteractive35171703131116
firstPaint1306542766140275
backgroundConnect16712933150168291
firstReactRender22163332428
initialActions104111
loadScripts6886061139104679975
setupStore1254551318
numNetworkReqs1194627051145254
FirefoxBrowserifyStandard HomeuiStartup15401307234419715681967
load13261132214616613621620
domContentLoaded13251126214616613591615
domInteractive79309139786188
firstPaint------
backgroundConnect5326152195683
firstReactRender1292321213
initialActions102112
loadScripts13021108212416213431566
setupStore156154221336
numNetworkReqs241293211786
BrowserifyPower User HomeuiStartup27202033401041528633497
load15411277244923315452105
domContentLoaded15401277244923315442105
domInteractive12735739137112459
firstPaint------
backgroundConnect278115942233269890
firstReactRender18152731924
initialActions203122
loadScripts14981218242922614852066
setupStore1408784207118736
numNetworkReqs66381523384133
WebpackStandard HomeuiStartup15361252198712915971747
load1332114215779613971488
domContentLoaded1332114215769613961488
domInteractive772431051106146
firstPaint------
backgroundConnect5021159225588
firstReactRender14115161420
initialActions2045412
loadScripts1308112815509213751442
setupStore1166991125
numNetworkReqs231283181871
WebpackPower User HomeuiStartup27432085428443228053616
load15821243290531017842175
domContentLoaded15821243290531017842174
domInteractive142321031182116569
firstPaint------
backgroundConnect282121941200271835
firstReactRender22166772429
initialActions207122
loadScripts15281227278428116862131
setupStore20871220279301797
numNetworkReqs64371413296123
📊 Page Load Benchmark Results

Current Commit: bdedc9f | Date: 2/10/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±38ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 724ms (±35ms) 🟢 | historical mean value: 717ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±11ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 38ms 1.02s 1.31s 1.06s 1.31s
domContentLoaded 724ms 35ms 705ms 986ms 740ms 986ms
firstPaint 77ms 11ms 60ms 168ms 88ms 168ms
firstContentfulPaint 77ms 11ms 60ms 168ms 88ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: -285 Bytes (0%)
  • common: -47 Bytes (0%)

@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Feb 10, 2026

Builds ready [e6d0506]
UI Startup Metrics (1378 ± 108 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup13781209187510814361543
load1189101215929212531335
domContentLoaded1182100715879312391329
domInteractive2515130202073
firstPaint171661267165219319
backgroundConnect23921650730241265
firstReactRender16104151625
initialActions1011112
loadScripts96278213579210151105
setupStore1264561423
numNetworkReqs231589201583
BrowserifyPower User HomeuiStartup17101408231016817762066
load11391022167814011311532
domContentLoaded11231011164813511121500
domInteractive3318207253262
firstPaint1666548878222286
backgroundConnect31728446528330359
firstReactRender22155272338
initialActions107112
loadScripts88476414011308711267
setupStore1676781825
numNetworkReqs1114825742134183
WebpackStandard HomeuiStartup7816371130108852993
load67857196398757864
domContentLoaded67256695597752859
domInteractive2415117201975
firstPaint1205759274150205
backgroundConnect241591112639
firstReactRender1493451724
initialActions105112
loadScripts67056495396744857
setupStore1253961224
numNetworkReqs231594211586
WebpackPower User HomeuiStartup1234946217819113181648
load71662214581376981049
domContentLoaded70761414521386871044
domInteractive39182584232123
firstPaint1396554292148341
backgroundConnect16613232946162276
firstReactRender22174952428
initialActions107111
loadScripts70461214431366861037
setupStore1253851317
numNetworkReqs1214827852147237
FirefoxBrowserifyStandard HomeuiStartup15231314222420715332077
load13141124196617413461677
domContentLoaded13121123196217413461676
domInteractive66311863886148
firstPaint------
backgroundConnect5532149186088
firstReactRender1281821216
initialActions106122
loadScripts12891098194117113191648
setupStore146200211234
numNetworkReqs241296211683
BrowserifyPower User HomeuiStartup27232067367232228243482
load15471291247820716061952
domContentLoaded15461291247720716051952
domInteractive12734599122122458
firstPaint------
backgroundConnect3001201212258304903
firstReactRender20157591926
initialActions203122
loadScripts14991223242520115261887
setupStore1318771195107625
numNetworkReqs66361333197125
WebpackStandard HomeuiStartup15721360201513216221837
load13521168161810114191539
domContentLoaded13521168161710114191538
domInteractive832921643115144
firstPaint------
backgroundConnect57271702961118
firstReactRender15114951519
initialActions103122
loadScripts1325115015939713871509
setupStore176138221256
numNetworkReqs241394201781
WebpackPower User HomeuiStartup28242092823380929113757
load16491246689173216812321
domContentLoaded16491246689073216812320
domInteractive13831824179107694
firstPaint------
backgroundConnect2931231190229275886
firstReactRender22153342429
initialActions203123
loadScripts15981177685672416452243
setupStore2079802254305773
numNetworkReqs64351553287121
📊 Page Load Benchmark Results

Current Commit: e6d0506 | Date: 2/10/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±41ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 723ms (±38ms) 🟢 | historical mean value: 717ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±10ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 41ms 1.00s 1.34s 1.08s 1.34s
domContentLoaded 723ms 38ms 695ms 1.01s 753ms 1.01s
firstPaint 78ms 10ms 60ms 152ms 84ms 152ms
firstContentfulPaint 78ms 10ms 60ms 152ms 84ms 152ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: -285 Bytes (0%)
  • common: -47 Bytes (0%)

@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Feb 10, 2026

Builds ready [c96feac]
UI Startup Metrics (1542 ± 151 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup15421312225715116131744
load13291105204513614031511
domContentLoaded13221095203513513951503
domInteractive3017116222687
firstPaint197691574221226288
backgroundConnect26323042625273302
firstReactRender199276261822
initialActions105113
loadScripts1079849177313211541255
setupStore1372741419
numNetworkReqs221585191578
BrowserifyPower User HomeuiStartup3179149411033186139756360
load12741100189913913101575
domContentLoaded12561074179412912901539
domInteractive37201722933100
firstPaint233811804237264323
backgroundConnect11073037416126313103570
firstReactRender25186472840
initialActions104112
loadScripts1006840153512510401286
setupStore1565981826
numNetworkReqs903716226108137
WebpackStandard HomeuiStartup8426881165103919986
load723615109290778875
domContentLoaded718610108689774871
domInteractive271589192479
firstPaint1076036651120188
backgroundConnect26189092938
firstReactRender14103851723
initialActions102112
loadScripts715608108488773866
setupStore1253141320
numNetworkReqs231599211582
WebpackPower User HomeuiStartup1274872247729713661947
load73362013931277281058
domContentLoaded72261513811267161029
domInteractive38182233532119
firstPaint164681079138191385
backgroundConnect178129965113156343
firstReactRender22164242327
initialActions101011
loadScripts71961313721247141017
setupStore1244261419
numNetworkReqs1424823940161202
FirefoxBrowserifyStandard HomeuiStartup15801352225619215892059
load13561148183713613951653
domContentLoaded13551148183713613951652
domInteractive833326851104171
firstPaint------
backgroundConnect60272183159109
firstReactRender12102121316
initialActions102022
loadScripts13291132180913113691599
setupStore156195261228
numNetworkReqs241392211785
BrowserifyPower User HomeuiStartup27842097445439029943386
load15061280212815815401899
domContentLoaded15051280212815815391899
domInteractive13636698119128417
firstPaint------
backgroundConnect39311213553094471106
firstReactRender2114100122027
initialActions207122
loadScripts14651253209214614921771
setupStore11814798154109481
numNetworkReqs884017431105151
WebpackStandard HomeuiStartup15711324243118415972062
load13601162220713614121561
domContentLoaded13591162220613614111561
domInteractive922826849129146
firstPaint------
backgroundConnect57203284657146
firstReactRender14115351419
initialActions103012
loadScripts13321147217913213851467
setupStore135194201129
numNetworkReqs231295181778
WebpackPower User HomeuiStartup28191892916878329313714
load15891254659659916042105
domContentLoaded15891253659659916032105
domInteractive170341342185172589
firstPaint------
backgroundConnect4936026943966521230
firstReactRender231576112456
initialActions203122
loadScripts15421233650758815242066
setupStore132131212196124559
numNetworkReqs87402223596153
📊 Page Load Benchmark Results

Current Commit: c96feac | Date: 2/10/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 991ms (±71ms) 🟢 | historical mean value: 1.03s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 693ms (±68ms) 🟢 | historical mean value: 717ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±10ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 991ms 71ms 949ms 1.27s 1.23s 1.27s
domContentLoaded 693ms 68ms 654ms 968ms 921ms 968ms
firstPaint 75ms 10ms 60ms 160ms 88ms 160ms
firstContentfulPaint 75ms 10ms 60ms 160ms 88ms 160ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: -285 Bytes (0%)
  • common: -47 Bytes (0%)

@juanmigdr juanmigdr added this pull request to the merge queue Feb 11, 2026
Merged via the queue into main with commit 6be7c23 Feb 11, 2026
331 of 333 checks passed
@juanmigdr juanmigdr deleted the chore/normalize-no-conversion-rate-format-token-list branch February 11, 2026 09:55
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2026
@metamaskbot metamaskbot added the release-13.19.0 Issue or pull request that will be included in release 13.19.0 label Feb 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.19.0 Issue or pull request that will be included in release 13.19.0 size-L team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants