fix: hide legacy network manager modal in sidepanel confirmation by ameliejyc · Pull Request #39908 · MetaMask/metamask-extension

ameliejyc · 2026-02-09T12:24:21Z

Description

When the Network Manager modal is open in the side panel view and a dapp request comes in, the confirmation screen navigates but the Network Manager modal remains visible and broken.

The useModalState.closeModals() hook only closed the NetworkListMenu but not legacy modals like NETWORK_MANAGER. This fix extends closeModals() to also close any open legacy modals, as modals should not persist on top of confirmation screens.

Changelog

CHANGELOG entry: Fixed Network Manager modal not closing when navigating to dapp confirmation screens in side panel view

Related issues

Fixes: #39880

Manual testing steps

Open MetaMask in side panel view
Open the Network Manager modal (via token list control bar)
Trigger a dapp request (e.g. connect or sign request from a dapp)
Verify the Network Manager modal closes and the confirmation screen displays correctly

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Small UI-state change that dispatches an additional MODAL_CLOSE action; low risk aside from potentially closing other legacy modals more broadly than intended.

Overview
Fixes a sidepanel navigation issue where the legacy Network Manager modal could remain visible over dapp confirmation screens.

useModalState.closeModals() now dispatches hideModal() in addition to closeNetworkMenu(), ensuring any open legacy modal is closed when the app attempts to close modal UI.

^{Written by Cursor Bugbot for commit 2d66e86. This will update automatically on new commits. Configure here.}

github-actions · 2026-02-09T12:24:30Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-02-09T12:59:01Z

Builds ready [0161a83]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

UI Startup Metrics (1414 ± 114 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1414	1229	1792	114	1479	1581
			load	1226	1009	1593	109	1291	1393
			domContentLoaded	1219	1004	1587	110	1286	1385
			domInteractive	26	15	111	19	22	75
			firstPaint	166	64	1297	174	214	239
			backgroundConnect	234	215	313	18	235	278
			firstReactRender	17	10	56	6	19	30
			initialActions	1	0	8	1	1	3
			loadScripts	999	782	1341	112	1070	1172
			setupStore	14	6	64	7	15	23
			numNetworkReqs	23	15	87	20	15	81
	Browserify	Power User Home	uiStartup	2724	1419	9975	1732	2726	6956
			load	1222	1033	2068	165	1282	1523
			domContentLoaded	1205	1021	2057	161	1255	1496
			domInteractive	35	18	171	29	33	109
			firstPaint	191	73	1591	163	246	313
			backgroundConnect	852	284	7345	1206	741	3500
			firstReactRender	23	16	53	7	25	38
			initialActions	1	0	8	1	1	2
			loadScripts	966	788	1746	151	1026	1245
			setupStore	15	6	74	10	16	33
			numNetworkReqs	88	49	173	30	103	145
	Webpack	Standard Home	uiStartup	852	672	1161	98	909	1042
			load	720	601	1081	104	797	930
			domContentLoaded	714	598	1074	103	793	922
			domInteractive	26	16	91	18	23	74
			firstPaint	111	62	369	56	132	209
			backgroundConnect	38	18	176	28	38	104
			firstReactRender	15	10	40	5	17	25
			initialActions	1	0	4	1	1	3
			loadScripts	711	596	1071	102	791	920
			setupStore	12	6	32	5	12	23
			numNetworkReqs	23	15	91	20	15	80
	Webpack	Power User Home	uiStartup	1252	903	2702	276	1284	1803
			load	742	651	1095	110	738	1061
			domContentLoaded	730	642	1086	110	727	1048
			domInteractive	38	18	129	22	38	91
			firstPaint	168	66	1054	134	192	409
			backgroundConnect	187	50	1140	145	161	386
			firstReactRender	21	17	38	4	23	29
			initialActions	1	0	2	0	1	1
			loadScripts	727	640	1077	108	725	1039
			setupStore	13	5	38	6	15	21
			numNetworkReqs	146	53	278	38	162	233
Firefox	Browserify	Standard Home	uiStartup	1604	1294	2181	210	1743	2026
			load	1356	1125	1889	181	1449	1726
			domContentLoaded	1355	1125	1889	181	1449	1726
			domInteractive	68	32	242	44	85	145
			firstPaint	-	-	-	-	-	-
			backgroundConnect	76	26	179	45	119	162
			firstReactRender	12	9	20	2	12	14
			initialActions	1	0	7	1	2	2
			loadScripts	1312	1109	1849	164	1399	1631
			setupStore	13	6	226	23	12	35
			numNetworkReqs	25	12	102	23	18	89
	Browserify	Power User Home	uiStartup	2820	2156	8312	773	2881	3409
			load	1606	1274	6740	651	1588	1867
			domContentLoaded	1605	1274	6740	652	1588	1867
			domInteractive	147	42	492	97	190	358
			firstPaint	-	-	-	-	-	-
			backgroundConnect	408	116	1271	294	591	937
			firstReactRender	18	14	63	7	18	26
			initialActions	1	0	3	1	2	2
			loadScripts	1564	1248	6704	651	1555	1830
			setupStore	145	10	828	179	167	541
			numNetworkReqs	85	33	189	33	99	151
	Webpack	Standard Home	uiStartup	1680	1383	2350	182	1759	1998
			load	1423	1158	1840	121	1492	1628
			domContentLoaded	1422	1158	1839	122	1492	1628
			domInteractive	85	29	191	42	117	162
			firstPaint	-	-	-	-	-	-
			backgroundConnect	74	29	302	50	80	158
			firstReactRender	17	11	122	12	16	23
			initialActions	2	0	41	4	2	2
			loadScripts	1383	1141	1817	112	1436	1549
			setupStore	19	6	232	34	13	41
			numNetworkReqs	23	12	86	18	18	77
	Webpack	Power User Home	uiStartup	2769	2044	8143	688	2852	3829
			load	1586	1303	6312	549	1634	2094
			domContentLoaded	1586	1303	6311	549	1634	2094
			domInteractive	167	32	1375	185	170	518
			firstPaint	-	-	-	-	-	-
			backgroundConnect	359	139	1224	242	420	850
			firstReactRender	22	16	33	4	25	30
			initialActions	2	0	8	1	2	3
			loadScripts	1541	1264	6274	541	1573	2020
			setupStore	170	11	1073	198	228	565
			numNetworkReqs	82	36	216	36	95	152

📊 Page Load Benchmark Results

Current Commit: 0161a83 | Date: 2/9/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±39ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 720ms (±37ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±11ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	39ms	1.01s	1.34s	1.05s	1.34s
domContentLoaded	720ms	37ms	700ms	1.02s	734ms	1.02s
firstPaint	75ms	11ms	60ms	176ms	80ms	176ms
firstContentfulPaint	75ms	11ms	60ms	176ms	80ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 2.04 KiB (0.02%)
common: 1.26 KiB (0.01%)

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

ui/hooks/useModalState.ts

metamaskbotv2 · 2026-02-09T16:23:47Z

Builds ready [2d66e86]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

UI Startup Metrics (1446 ± 117 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1446	1173	1799	117	1516	1627
			load	1239	1005	1531	114	1307	1412
			domContentLoaded	1232	999	1528	114	1300	1401
			domInteractive	26	17	103	18	23	77
			firstPaint	144	66	272	57	195	227
			backgroundConnect	237	218	334	17	242	260
			firstReactRender	18	11	33	5	20	28
			initialActions	1	0	7	1	1	3
			loadScripts	1011	770	1278	116	1084	1195
			setupStore	14	6	43	7	17	29
			numNetworkReqs	23	15	90	20	15	83
	Browserify	Power User Home	uiStartup	2733	1423	9351	1630	2823	5675
			load	1242	1064	1806	153	1283	1587
			domContentLoaded	1225	1053	1780	150	1258	1578
			domInteractive	36	20	131	22	36	95
			firstPaint	215	79	1738	205	250	407
			backgroundConnect	821	293	4105	961	647	3296
			firstReactRender	24	15	50	7	27	37
			initialActions	1	0	5	1	1	2
			loadScripts	982	821	1450	133	1014	1305
			setupStore	15	5	44	8	17	34
			numNetworkReqs	114	39	243	44	141	196
	Webpack	Standard Home	uiStartup	843	669	1101	96	918	996
			load	708	593	914	89	779	868
			domContentLoaded	702	589	902	88	771	855
			domInteractive	25	16	97	17	22	72
			firstPaint	107	59	320	51	133	212
			backgroundConnect	36	18	143	23	38	83
			firstReactRender	15	9	30	5	17	26
			initialActions	1	0	7	1	1	2
			loadScripts	700	587	900	87	769	853
			setupStore	12	5	43	6	12	24
			numNetworkReqs	23	15	88	20	15	80
	Webpack	Power User Home	uiStartup	1311	872	2284	298	1377	1887
			load	758	633	1463	144	764	1090
			domContentLoaded	747	625	1451	144	749	1080
			domInteractive	41	19	267	37	37	111
			firstPaint	180	68	1122	193	169	453
			backgroundConnect	184	131	591	84	180	361
			firstReactRender	22	17	39	4	24	30
			initialActions	1	0	3	1	1	1
			loadScripts	744	622	1439	142	747	1072
			setupStore	12	4	37	5	15	19
			numNetworkReqs	142	68	246	41	160	222
Firefox	Browserify	Standard Home	uiStartup	1790	1441	2524	231	1900	2284
			load	1492	1251	2085	178	1556	1893
			domContentLoaded	1491	1246	2085	178	1555	1887
			domInteractive	77	35	238	42	97	139
			firstPaint	-	-	-	-	-	-
			backgroundConnect	87	34	251	53	114	202
			firstReactRender	13	11	19	1	14	15
			initialActions	1	0	3	1	2	2
			loadScripts	1443	1229	2046	158	1498	1771
			setupStore	18	6	213	27	14	55
			numNetworkReqs	24	12	93	21	18	88
	Browserify	Power User Home	uiStartup	2750	2130	7091	641	2896	3499
			load	1543	1284	5563	531	1523	1938
			domContentLoaded	1543	1284	5563	531	1523	1938
			domInteractive	158	35	827	140	149	429
			firstPaint	-	-	-	-	-	-
			backgroundConnect	415	114	1485	323	601	1050
			firstReactRender	18	14	63	5	18	22
			initialActions	2	1	3	1	2	2
			loadScripts	1506	1256	5530	525	1481	1904
			setupStore	114	8	647	151	96	490
			numNetworkReqs	87	41	208	34	104	149
	Webpack	Standard Home	uiStartup	1618	1389	2247	181	1685	1961
			load	1385	1169	1757	113	1456	1568
			domContentLoaded	1384	1169	1757	114	1451	1567
			domInteractive	85	27	324	48	118	143
			firstPaint	-	-	-	-	-	-
			backgroundConnect	69	26	233	43	81	145
			firstReactRender	15	12	57	7	14	21
			initialActions	1	0	2	0	2	2
			loadScripts	1346	1152	1727	106	1414	1497
			setupStore	16	5	136	25	11	41
			numNetworkReqs	23	12	89	19	18	76
	Webpack	Power User Home	uiStartup	2671	2084	4082	365	2815	3386
			load	1491	1254	2311	195	1598	1827
			domContentLoaded	1490	1253	2311	195	1598	1826
			domInteractive	144	38	593	124	141	477
			firstPaint	-	-	-	-	-	-
			backgroundConnect	406	123	1879	321	486	1008
			firstReactRender	21	14	44	5	23	29
			initialActions	2	0	6	1	2	2
			loadScripts	1452	1232	2286	192	1539	1792
			setupStore	151	8	1628	215	170	509
			numNetworkReqs	82	41	196	33	105	145

📊 Page Load Benchmark Results

Current Commit: 2d66e86 | Date: 2/9/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±43ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 720ms (±41ms) 🟢 | historical mean value: 722ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±27ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	43ms	1.01s	1.38s	1.06s	1.38s
domContentLoaded	720ms	41ms	699ms	1.06s	740ms	1.06s
firstPaint	78ms	27ms	60ms	312ms	88ms	312ms
firstContentfulPaint	78ms	27ms	60ms	312ms	88ms	312ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 2.8 KiB (0.03%)
common: 1.75 KiB (0.02%)

fix: hide legacy network manager modal in sidepanel confirmation

0161a83

ameliejyc temporarily deployed to pr-comment February 9, 2026 12:24 — with GitHub Actions Inactive

metamaskbot added the team-core-extension-ux Core Extension UX team label Feb 9, 2026

github-actions bot added the size-S label Feb 9, 2026

ameliejyc temporarily deployed to pr-comment February 9, 2026 12:54 — with GitHub Actions Inactive

ameliejyc changed the title ~~fix: cp-13.18.0 hide legacy network manager modal in sidepanel confirmation~~ fix: hide legacy network manager modal in sidepanel confirmation Feb 9, 2026

chore: remove check for network manager modal

2d66e86

ameliejyc temporarily deployed to pr-comment February 9, 2026 15:42 — with GitHub Actions Inactive

github-actions bot added size-XS and removed size-S labels Feb 9, 2026

cursor bot reviewed Feb 9, 2026

View reviewed changes

ui/hooks/useModalState.ts Show resolved Hide resolved

ameliejyc temporarily deployed to pr-comment February 9, 2026 16:17 — with GitHub Actions Inactive

AndyMBridges approved these changes Feb 10, 2026

View reviewed changes

ameliejyc enabled auto-merge February 10, 2026 10:38

n3ps approved these changes Feb 10, 2026

View reviewed changes

ameliejyc added this pull request to the merge queue Feb 10, 2026

Merged via the queue into main with commit 7dad971 Feb 10, 2026
191 checks passed

ameliejyc deleted the fix-network-manager-dapp-request-broken-ui branch February 10, 2026 15:48

github-actions bot locked and limited conversation to collaborators Feb 10, 2026

metamaskbot added the release-13.19.0 Issue or pull request that will be included in release 13.19.0 label Feb 10, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: hide legacy network manager modal in sidepanel confirmation#39908

fix: hide legacy network manager modal in sidepanel confirmation#39908
ameliejyc merged 2 commits intomainfrom
fix-network-manager-dapp-request-broken-ui

ameliejyc commented Feb 9, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

metamaskbotv2 bot commented Feb 9, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

metamaskbotv2 bot commented Feb 9, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ameliejyc commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

metamaskbotv2 bot commented Feb 9, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

metamaskbotv2 bot commented Feb 9, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ameliejyc commented Feb 9, 2026 •

edited

Loading